<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220856</bug_id>
          
          <creation_ts>2021-01-22 03:05:45 -0800</creation_ts>
          <short_desc>TransformationMatrix::Recompose() and Decompose() incorrectly transpose rotation</short_desc>
          <delta_ts>2023-08-29 14:45:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Animations</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Imanol Fernandez">ifernandez</reporter>
          <assigned_to name="Matt Woodrow">mattwoodrow</assigned_to>
          <cc>cdumez</cc>
    
    <cc>dino</cc>
    
    <cc>graouts</cc>
    
    <cc>krit</cc>
    
    <cc>mrobinson</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1721544</commentid>
    <comment_count>0</comment_count>
    <who name="Imanol Fernandez">ifernandez</who>
    <bug_when>2021-01-22 03:05:45 -0800</bug_when>
    <thetext>The computation of quaternions during matrix decomposition looks like it&apos;s based off of the matrix transpose. The matrix data is actually column major order but the quaternion operations seem to assume row major order.

More info in the equivalent chromium bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=929841</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1723678</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-01-29 03:06:11 -0800</bug_when>
    <thetext>&lt;rdar://problem/73747851&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1974101</commentid>
    <comment_count>2</comment_count>
    <who name="Matt Woodrow">mattwoodrow</who>
    <bug_when>2023-08-28 18:03:58 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/17162</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1974308</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-08-29 14:45:25 -0700</bug_when>
    <thetext>Committed 267424@main (a959acf1111c): &lt;https://commits.webkit.org/267424@main&gt;

Reviewed commits have been landed. Closing PR #17162 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>