220839 2021-01-21 18:44:17 -0800 [WebAuthn] No error is visible after user enters the incorrect PIN 2021-01-22 12:04:13 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181943 1 jiewen_tan jiewen_tan bfulgham jiewen_tan webkit-bug-importer oldest_to_newest 1721452 0 jiewen_tan 2021-01-21 18:44:17 -0800 When entering an incorrect PIN for a security key, the “incorrect PIN” error message gets flashed very briefly on screen before being dismissed and replaced with the original PIN entry view. 1721453 1 jiewen_tan 2021-01-21 18:44:27 -0800 <rdar://problem/73378319> 1721454 2 418104 jiewen_tan 2021-01-21 18:48:47 -0800 Created attachment 418104 Patch 1721664 3 418104 bfulgham 2021-01-22 11:54:38 -0800 Comment on attachment 418104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418104&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:159 > + if (m_presentedPIN) You might want to add a logging message so we can debug failed PIN cases in the future. 1721666 4 418104 jiewen_tan 2021-01-22 12:00:37 -0800 Comment on attachment 418104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418104&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:159 >> + if (m_presentedPIN) > > You might want to add a logging message so we can debug failed PIN cases in the future. Good idea! Not sure if this is the good place. I think I have some logging in the caller site. 1721669 5 ews-feeder 2021-01-22 12:04:11 -0800 Committed r271754: <https://trac.webkit.org/changeset/271754> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418104. 418104 2021-01-21 18:48:47 -0800 2021-01-22 12:04:12 -0800 Patch bug-220839-20210121184846.patch text/plain 3448 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg1ODliNDMwY2RjMzAwOWRk MTk4ZDQyZWE0ZDk1Y2FiYTcwYmIxZTEuLmJmYjU1ZGU3NWI0YWVmNWI0ZGM2OGFhN2JhYWMxNmZk NzAzZGJlYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDEtMjEgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIE5vIGVycm9y IGlzIHZpc2libGUgYWZ0ZXIgdXNlciBlbnRlcnMgdGhlIGluY29ycmVjdCBQSU4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDgzOQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNzMzNzgzMTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVG8gZml4IHRoYXQsIGxldCdzIGhhdmUgYSBib29sZWFuIHRvIGlu ZGljYXRlIHRoZSBQSU4gZW50cnkgVUkgaGFzIGFscmVhZHkgYmVlbiBwcmVzZW50ZWQgd2l0aGlu IHRoaXMgc2Vzc2lvbi4KKyAgICAgICAgQW5kIHRoZW4gcmVseSBvbiB0aGUgZXJyb3IgVUkgdG8g bGV0IHVzZXJzIHJldHJ5IHRoZSBQSU4uCisKKyAgICAgICAgQ292ZXJlZCBieSBtYW51YWwgdGVz dHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvQXV0aGVu dGljYXRvclByZXNlbnRlckNvb3JkaW5hdG9yLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkF1 dGhlbnRpY2F0aW9uL0NvY29hL0F1dGhlbnRpY2F0b3JQcmVzZW50ZXJDb29yZGluYXRvci5tbToK KyAgICAgICAgKFdlYktpdDo6QXV0aGVudGljYXRvclByZXNlbnRlckNvb3JkaW5hdG9yOjpyZXF1 ZXN0UGluKToKKyAgICAgICAgKFdlYktpdDo6QXV0aGVudGljYXRvclByZXNlbnRlckNvb3JkaW5h dG9yOjpzZWxlY3RBc3NlcnRpb25SZXNwb25zZSk6CisgICAgICAgIEJlc2lkZXMgYWJvdmUsIHRo aXMgcGF0Y2ggYWxzbyBmaXhlcyBzb21lIGNyYXNoZXMuCisKIDIwMjEtMDEtMjAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVUHJvY2Vzc10gTWFyayBJT1N1 cmZhY2UgYmFja2luZyBmb3IgUmVtb3RlR3JhcGhpY3NDb250ZXh0R0wncyBkaXNwbGF5QnVmZmVy IGFzIG93bmVkIGJ5IHRoZSBXZWJQcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9BdXRoZW50aWNhdG9yUHJlc2VudGVyQ29v cmRpbmF0b3IuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0Nv Y29hL0F1dGhlbnRpY2F0b3JQcmVzZW50ZXJDb29yZGluYXRvci5oCmluZGV4IGRjYjFlYWNkNjll YjNiZGI3ZWZiZTI5MWE0YzA4M2Y0OTQ3N2NjNjcuLjI2NzE5MTMwMDNiNjNjOWZkZmFiNWZkMDcz NTY5YmZlM2ViYjI4ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1 dGhlbnRpY2F0aW9uL0NvY29hL0F1dGhlbnRpY2F0b3JQcmVzZW50ZXJDb29yZGluYXRvci5oCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0F1dGhl bnRpY2F0b3JQcmVzZW50ZXJDb29yZGluYXRvci5oCkBAIC04Nyw2ICs4Nyw5IEBAIHByaXZhdGU6 CiAgICAgSGFzaE1hcDxTdHJpbmcsIFJlZlB0cjxXZWJDb3JlOjpBdXRoZW50aWNhdG9yQXNzZXJ0 aW9uUmVzcG9uc2U+PiBtX2NyZWRlbnRpYWxzOwogCiAgICAgQ29tcGxldGlvbkhhbmRsZXI8dm9p ZChjb25zdCBTdHJpbmcmKT4gbV9waW5IYW5kbGVyOworI2lmIEhBVkUoQVNDX0FVVEhfVUkpCisg ICAgYm9vbCBtX3ByZXNlbnRlZFBJTiB7IGZhbHNlIH07CisjZW5kaWYKIH07CiAKIH0gLy8gbmFt ZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0 aGVudGljYXRpb24vQ29jb2EvQXV0aGVudGljYXRvclByZXNlbnRlckNvb3JkaW5hdG9yLm1tIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvQXV0aGVudGlj YXRvclByZXNlbnRlckNvb3JkaW5hdG9yLm1tCmluZGV4IDM2NjUwNDdlNDZmZTgzNDcwYjc0NjJl ZDIyN2ViYWRmMTcyMjJlNmQuLjhmNWVhZWMwYjk3NzBhNmVhNjVhYWE0NTE5NzYzMGJjNGYyMWJl NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9u L0NvY29hL0F1dGhlbnRpY2F0b3JQcmVzZW50ZXJDb29yZGluYXRvci5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9BdXRoZW50aWNhdG9yUHJl c2VudGVyQ29vcmRpbmF0b3IubW0KQEAgLTE1Miw3ICsxNTIsMTMgQEAgdm9pZCBBdXRoZW50aWNh dG9yUHJlc2VudGVyQ29vcmRpbmF0b3I6OnVwZGF0ZVByZXNlbnRlcihXZWJBdXRoZW50aWNhdGlv blN0YXR1cwogdm9pZCBBdXRoZW50aWNhdG9yUHJlc2VudGVyQ29vcmRpbmF0b3I6OnJlcXVlc3RQ aW4odWludDY0X3QsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoY29uc3QgU3RyaW5nJik+JiYgY29t cGxldGlvbkhhbmRsZXIpCiB7CiAjaWYgSEFWRShBU0NfQVVUSF9VSSkKKyAgICBpZiAobV9waW5I YW5kbGVyKQorICAgICAgICBtX3BpbkhhbmRsZXIoU3RyaW5nKCkpOwogICAgIG1fcGluSGFuZGxl ciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpOworCisgICAgaWYgKG1fcHJlc2VudGVkUElO KQorICAgICAgICByZXR1cm47CisgICAgbV9wcmVzZW50ZWRQSU4gPSB0cnVlOwogICAgIFttX3By ZXNlbnRlciBwcmVzZW50UElORW50cnlJbnRlcmZhY2VdOwogI2VuZGlmIC8vIEhBVkUoQVNDX0FV VEhfVUkpCiB9CkBAIC0xNjksNiArMTc1LDkgQEAgdm9pZCBBdXRoZW50aWNhdG9yUHJlc2VudGVy Q29vcmRpbmF0b3I6OnNlbGVjdEFzc2VydGlvblJlc3BvbnNlKFZlY3RvcjxSZWY8QXV0aGUKIAog ICAgICAgICBtX2NyZWRlbnRpYWxzLmNsZWFyKCk7CiAgICAgICAgIGZvciAoYXV0byYgcmVzcG9u c2UgOiByZXNwb25zZXMpIHsKKyAgICAgICAgICAgIGlmICghcmVzcG9uc2UtPm5hbWUoKSkKKyAg ICAgICAgICAgICAgICBjb250aW51ZTsKKwogICAgICAgICAgICAgUmV0YWluUHRyPE5TRGF0YT4g dXNlckhhbmRsZTsKICAgICAgICAgICAgIGlmIChyZXNwb25zZS0+dXNlckhhbmRsZSgpKQogICAg ICAgICAgICAgICAgIHVzZXJIYW5kbGUgPSBhZG9wdE5TKFtbTlNEYXRhIGFsbG9jXSBpbml0V2l0 aEJ5dGVzOnJlc3BvbnNlLT51c2VySGFuZGxlKCktPmRhdGEoKSBsZW5ndGg6cmVzcG9uc2UtPnVz ZXJIYW5kbGUoKS0+Ynl0ZUxlbmd0aCgpXSk7Cg==