220736 2021-01-19 10:18:33 -0800 REGRESSION(r271506): webkit-patch keyring integration is broken on Linux 2021-10-07 18:55:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221029 https://bugs.webkit.org/show_bug.cgi?id=231381 InRadar P2 Normal --- 220744 1 mcatanzaro mcatanzaro bugs-noreply jbedard mcatanzaro pnormand webkit-bug-importer oldest_to_newest 1720568 0 mcatanzaro 2021-01-19 10:18:33 -0800 webkit-patch is no longer able to look up my Bugzilla password from the system keyring, instead prompting me to enter my password each time. I don't know why yet... probably related to r271506, but I need to investigate more. 1720593 1 mcatanzaro 2021-01-19 11:12:09 -0800 Debug patch: diff --git a/Tools/Scripts/webkitpy/common/net/credentials.py b/Tools/Scripts/webkitpy/common/net/credentials.py index ef98ee15b3c4..c8781e5d5232 100644 --- a/Tools/Scripts/webkitpy/common/net/credentials.py +++ b/Tools/Scripts/webkitpy/common/net/credentials.py @@ -161,8 +161,8 @@ class Credentials(object): if username and not password and self._keyring and use_stored_credentials: try: password = self._keyring.get_password(self.host, username) - except: - pass + except Exception as e: + print('failed to get password from keyring: {}'.format(str(e))) if not password: password = user.prompt_password("%s password for %s: " % (self.host, username)) It prints: $ webkit-patch upload 220736 Total errors found: 0 in 1 files failed to get password from keyring: No recommended backend was available. Install a recommended 3rd party backend package; or, install the keyrings.alt package if you want to use the non-recommended backends. See https://pypi.org/project/keyring for details. bugs.webkit.org password for mcatanzaro@gnome.org: So somehow python-keyring is no longer able to use python-secretservice, which is bad. 1720594 2 mcatanzaro 2021-01-19 11:20:32 -0800 > So somehow python-keyring is no longer able to use python-secretservice, > which is bad. Er, it's called python-secretstorage. That is required for system keyring integration on Linux. Historically, our autoinstalled python-keyring has been able to use the system copy of python-secretstorage. Maybe the updated version is not? Anyway, if I revert to our previous version of python-keyring, the bug disappears. The bug also goes away if I upgrade to the latest stable version of python-keyring. I'm not sure why exactly version 18.0.1 was selected, but it seems to be a bad version. CC: Jonathan in case this particular version was selected for some important reason. 1720598 3 417891 mcatanzaro 2021-01-19 11:23:16 -0800 Created attachment 417891 Patch 1720601 4 417891 mcatanzaro 2021-01-19 11:30:23 -0800 Comment on attachment 417891 Patch OK, webkitpy EWS is red. I didn't realize we still support python2. The new version of python-keyring does not support python2. So I need to find an older version that still supports python2, is new enough for the GitHub code to work, and doesn't exhibit this secretstorage bug. Hi Jonathan, can you comment regarding why you upgraded python-keyring? I assume you needed a newer version of the library for... something? What exactly was required? Then I'm not sure what is wrong with the python3 test. ModuleNotFoundError: No module named 'monotonic' immediately after installing python-monotonic. Hm. 1720602 5 mcatanzaro 2021-01-19 11:32:21 -0800 (In reply to Michael Catanzaro from comment #2) > I'm not sure why exactly version 18.0.1 was selected This was simply the last version to support python2. 1720606 6 417893 mcatanzaro 2021-01-19 11:37:32 -0800 Created attachment 417893 Patch 1720609 7 417894 mcatanzaro 2021-01-19 11:39:19 -0800 Created attachment 417894 Patch 1720610 8 417895 mcatanzaro 2021-01-19 11:39:41 -0800 Created attachment 417895 Patch 1720611 9 mcatanzaro 2021-01-19 11:41:39 -0800 (In reply to Michael Catanzaro from comment #2) > I'm not sure why exactly version 18.0.1 was selected, but > it seems to be a bad version. It seems versions 12 is the first version that is broken. So version 11 is the last version that supports python2 and works properly on Linux. I wonder if this is new enough for Jonathan's GitHub support that landed in r271506. 1720614 10 417897 mcatanzaro 2021-01-19 11:44:29 -0800 Created attachment 417897 Patch 1720616 11 mcatanzaro 2021-01-19 11:46:38 -0800 webkitpy bot is green. Jonathan, can you please check to ensure I haven't broken your GitHub credentials work? 1720623 12 jbedard 2021-01-19 12:34:08 -0800 (In reply to Michael Catanzaro from comment #11) > webkitpy bot is green. Jonathan, can you please check to ensure I haven't > broken your GitHub credentials work? I didn't need to update the library, I assumed (erroneously, clearly), that a newer version would be better. Before we land this change, I'd like to land another change that will help some of our bots out, because otherwise changing the library version on them will require manual intervention. Is it Ok if this change waits a few hours before landing? 1720626 13 mcatanzaro 2021-01-19 12:39:03 -0800 Sure. I can't land it now anyway, since commit-queue is taking the day off, and I don't have an SVN account anymore. If you could give r+ when you're ready, that would be great. 1720630 14 jbedard 2021-01-19 12:44:52 -0800 (In reply to Michael Catanzaro from comment #13) > Sure. I can't land it now anyway, since commit-queue is taking the day off, > and I don't have an SVN account anymore. yeah, that's the other thing I'm working on right now :) > > If you could give r+ when you're ready, that would be great. 1720640 15 417897 jbedard 2021-01-19 13:00:52 -0800 Comment on attachment 417897 Patch Marking this cq- right now so no one accidentally commits it before our infrastructure is ready, in particular, we need https://bugs.webkit.org/show_bug.cgi?id=220744 first. 1720777 16 ews-feeder 2021-01-19 17:47:18 -0800 Committed r271634: <https://trac.webkit.org/changeset/271634> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417897. 1720778 17 webkit-bug-importer 2021-01-19 17:48:14 -0800 <rdar://problem/73382360> 1722867 18 pnormand 2021-01-27 01:21:15 -0800 Still borken BTW, when running webkit-patch in the Flatpak SDK runtime... 1722985 19 jbedard 2021-01-27 07:51:59 -0800 (In reply to Philippe Normand from comment #18) > Still borken BTW, when running webkit-patch in the Flatpak SDK runtime... What exactly does broken mean in this case? Seems likely it's something about keyring being unable to find some sort of key store. 1722989 20 mcatanzaro 2021-01-27 07:59:44 -0800 (In reply to Jonathan Bedard from comment #19) > What exactly does broken mean in this case? Seems likely it's something > about keyring being unable to find some sort of key store. Yup, the problem is python-keyring is totally unable to find the system keyring. It's as if it thinks the system keyring doesn't exist. I did not debug it to figure out why, since the problem I was hitting was definitely fixed in the latest version. 1722990 21 mcatanzaro 2021-01-27 08:01:02 -0800 (In reply to Michael Catanzaro from comment #1) > $ webkit-patch upload 220736 > Total errors found: 0 in 1 files > failed to get password from keyring: No recommended backend was available. > Install a recommended 3rd party backend package; or, install the > keyrings.alt package if you want to use the non-recommended backends. See > https://pypi.org/project/keyring for details. > bugs.webkit.org password for mcatanzaro@gnome.org: Looks like it's failing to discover its own backends. It's supposed to use python-secretstorage to talk to gnome-keyring via libsecret, but for whatever reason it doesn't realize python-secretstorage is installed. 1722993 22 pnormand 2021-01-27 08:05:38 -0800 I had this error: failed to get password from keyring: No recommended backend was available. Install a recommended 3rd party backend package; or, install the keyrings.alt package if you want to use the non-recommended backends. See https://pypi.org/project/keyring for details. 1722998 23 jbedard 2021-01-27 08:40:50 -0800 (In reply to Philippe Normand from comment #22) > I had this error: > > failed to get password from keyring: No recommended backend was available. > Install a recommended 3rd party backend package; or, install the > keyrings.alt package if you want to use the non-recommended backends. See > https://pypi.org/project/keyring for details. Oh, I wonder if it checks for the module instead of importing it, which would by-pass our auto-install clever-ness....or the "if sys.platform == 'linux':" is false in webkitscmpy's __init__.py 417891 2021-01-19 11:23:16 -0800 2021-01-19 11:37:30 -0800 Patch bug-220736-20210119132315.patch text/plain 1679 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmU4ZDFjNTNjZmQ0ZjgyZDA0YjNkZWRlYjYzNGIzYzc2 NzBkYjEwZS4uYmRiMzc4OTk5ZGEyYWJmYWFmMzhjNWJiOTdiZDVjNGU3N2UwZTJjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTAxLTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3MTUwNik6IHdlYmtpdC1wYXRjaCBrZXlyaW5nIGlu dGVncmF0aW9uIGlzIGJyb2tlbiBvbiBMaW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwNzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgcjI3MTUwNiB1cGRhdGVkIG91ciBweXRob24ta2V5cmluZyB0 byB2ZXJzaW9uIDE4LjAuMSwgYnV0IGZvciB3aGF0ZXZlciByZWFzb24sIGxpYnNlY3JldAorICAg ICAgICBzdXBwb3J0IHZpYSBweXRob24tc2VjcmV0c3RvcmFnZSBpcyBicm9rZW4gaW4gdGhpcyB2 ZXJzaW9uLiBUaGUgbGF0ZXN0IHN0YWJsZSB2ZXJzaW9uLAorICAgICAgICAyMS44LjAsIHdvcmtz IGZpbmUsIHNvIHVwZGF0ZSB0byB0aGlzLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMv d2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHk6CisKIDIwMjEtMDEtMTkgIEpvbmF0 aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFtHaXRIdWJdIFVzZSBn aXRodWIuY29tIGFzIHRoZSBzb3VyY2Ugb2YgdHJ1dGggZm9yIEVXUwpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkg Yi9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRf Xy5weQppbmRleCBlZjM1Y2U0YjIyMTJiZGY4MWFiNzBkYTQ4ZGQ3MDg2YWJlMDgyNzcwLi42OWRl NDQyNjlhZjRjM2Q2MjMxMzQzMzI5MDU5OGY4ZDkyODA0N2ZlIDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weQorKysg Yi9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRf Xy5weQpAQCAtNTAsNyArNTAsNyBAQCB2ZXJzaW9uID0gVmVyc2lvbigwLCA5LCAyKQogCiBBdXRv SW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdlbnRyeXBvaW50cycsIFZlcnNpb24oMCwgMywgMCkp KQogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnZmFzdGVuZXJzJywgVmVyc2lvbigwLCAx NSwgMCkpKQotQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgna2V5cmluZycsIFZlcnNpb24o MTgsIDAsIDEpKSkKK0F1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ2tleXJpbmcnLCBWZXJz aW9uKDIxLCA4LCAwKSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdtb25vdG9uaWMn LCBWZXJzaW9uKDEsIDUpKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ3htbHRvZGlj dCcsIFZlcnNpb24oMCwgMTIsIDApKSkKIAo= 417893 2021-01-19 11:37:32 -0800 2021-01-19 11:39:17 -0800 Patch bug-220736-20210119133731.patch text/plain 1419 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmU4ZDFjNTNjZmQ0ZjgyZDA0YjNkZWRlYjYzNGIzYzc2 NzBkYjEwZS4uYjE1ZDcxZDhhYzM5NWRmZGFiYjZkZjVlNTk5OWFlY2JkMWY2YjRmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIxLTAxLTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIFRlc3QgcGF0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyMDczNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgaXMgYSB0ZXN0IHBhdGNoLiBEbyBub3QgbGFuZC4KKworICAg ICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9f LnB5OgorCiAyMDIxLTAxLTE5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4K IAogICAgICAgICBbR2l0SHViXSBVc2UgZ2l0aHViLmNvbSBhcyB0aGUgc291cmNlIG9mIHRydXRo IGZvciBFV1MKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5IGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkKaW5kZXggZWYzNWNlNGIyMjEyYmRmODFhYjcw ZGE0OGRkNzA4NmFiZTA4Mjc3MC4uNjlkZTQ0MjY5YWY0YzNkNjIzMTM0MzMyOTA1OThmOGQ5Mjgw NDdmZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Vi a2l0c2NtcHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkKQEAgLTUwLDcgKzUwLDcgQEAgdmVyc2lvbiA9 IFZlcnNpb24oMCwgOSwgMikKIAogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnZW50cnlw b2ludHMnLCBWZXJzaW9uKDAsIDMsIDApKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2Uo J2Zhc3RlbmVycycsIFZlcnNpb24oMCwgMTUsIDApKSkKLUF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBh Y2thZ2UoJ2tleXJpbmcnLCBWZXJzaW9uKDE4LCAwLCAxKSkpCitBdXRvSW5zdGFsbC5yZWdpc3Rl cihQYWNrYWdlKCdrZXlyaW5nJywgVmVyc2lvbigyMSwgOCwgMCkpKQogQXV0b0luc3RhbGwucmVn aXN0ZXIoUGFja2FnZSgnbW9ub3RvbmljJywgVmVyc2lvbigxLCA1KSkpCiBBdXRvSW5zdGFsbC5y ZWdpc3RlcihQYWNrYWdlKCd4bWx0b2RpY3QnLCBWZXJzaW9uKDAsIDEyLCAwKSkpCiAK 417894 2021-01-19 11:39:19 -0800 2021-01-19 11:39:39 -0800 Patch bug-220736-20210119133918.patch text/plain 1419 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmU4ZDFjNTNjZmQ0ZjgyZDA0YjNkZWRlYjYzNGIzYzc2 NzBkYjEwZS4uYjE1ZDcxZDhhYzM5NWRmZGFiYjZkZjVlNTk5OWFlY2JkMWY2YjRmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIxLTAxLTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIFRlc3QgcGF0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyMDczNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgaXMgYSB0ZXN0IHBhdGNoLiBEbyBub3QgbGFuZC4KKworICAg ICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9f LnB5OgorCiAyMDIxLTAxLTE5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4K IAogICAgICAgICBbR2l0SHViXSBVc2UgZ2l0aHViLmNvbSBhcyB0aGUgc291cmNlIG9mIHRydXRo IGZvciBFV1MKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5IGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkKaW5kZXggZWYzNWNlNGIyMjEyYmRmODFhYjcw ZGE0OGRkNzA4NmFiZTA4Mjc3MC4uNThmZjRmNTJjYWJjNGI5N2FhNzQwYjBkMDUzMWU3MGZmODEx YmRiZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Vi a2l0c2NtcHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkKQEAgLTUwLDcgKzUwLDcgQEAgdmVyc2lvbiA9 IFZlcnNpb24oMCwgOSwgMikKIAogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnZW50cnlw b2ludHMnLCBWZXJzaW9uKDAsIDMsIDApKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2Uo J2Zhc3RlbmVycycsIFZlcnNpb24oMCwgMTUsIDApKSkKLUF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBh Y2thZ2UoJ2tleXJpbmcnLCBWZXJzaW9uKDE4LCAwLCAxKSkpCitBdXRvSW5zdGFsbC5yZWdpc3Rl cihQYWNrYWdlKCdrZXlyaW5nJywgVmVyc2lvbigxMCwgNiwgMCkpKQogQXV0b0luc3RhbGwucmVn aXN0ZXIoUGFja2FnZSgnbW9ub3RvbmljJywgVmVyc2lvbigxLCA1KSkpCiBBdXRvSW5zdGFsbC5y ZWdpc3RlcihQYWNrYWdlKCd4bWx0b2RpY3QnLCBWZXJzaW9uKDAsIDEyLCAwKSkpCiAK 417895 2021-01-19 11:39:41 -0800 2021-01-19 11:44:26 -0800 Patch bug-220736-20210119133941.patch text/plain 1419 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmU4ZDFjNTNjZmQ0ZjgyZDA0YjNkZWRlYjYzNGIzYzc2 NzBkYjEwZS4uYjE1ZDcxZDhhYzM5NWRmZGFiYjZkZjVlNTk5OWFlY2JkMWY2YjRmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIxLTAxLTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIFRlc3QgcGF0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyMDczNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgaXMgYSB0ZXN0IHBhdGNoLiBEbyBub3QgbGFuZC4KKworICAg ICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9f LnB5OgorCiAyMDIxLTAxLTE5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4K IAogICAgICAgICBbR2l0SHViXSBVc2UgZ2l0aHViLmNvbSBhcyB0aGUgc291cmNlIG9mIHRydXRo IGZvciBFV1MKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5IGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkKaW5kZXggZWYzNWNlNGIyMjEyYmRmODFhYjcw ZGE0OGRkNzA4NmFiZTA4Mjc3MC4uOGM4MDczMGM4YTM2ZDBjZmMyZTgzM2QyMGYzZWVjMDUyYjE3 MGM4NCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Vi a2l0c2NtcHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkKQEAgLTUwLDcgKzUwLDcgQEAgdmVyc2lvbiA9 IFZlcnNpb24oMCwgOSwgMikKIAogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnZW50cnlw b2ludHMnLCBWZXJzaW9uKDAsIDMsIDApKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2Uo J2Zhc3RlbmVycycsIFZlcnNpb24oMCwgMTUsIDApKSkKLUF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBh Y2thZ2UoJ2tleXJpbmcnLCBWZXJzaW9uKDE4LCAwLCAxKSkpCitBdXRvSW5zdGFsbC5yZWdpc3Rl cihQYWNrYWdlKCdrZXlyaW5nJywgVmVyc2lvbigxMSwgMSwgMCkpKQogQXV0b0luc3RhbGwucmVn aXN0ZXIoUGFja2FnZSgnbW9ub3RvbmljJywgVmVyc2lvbigxLCA1KSkpCiBBdXRvSW5zdGFsbC5y ZWdpc3RlcihQYWNrYWdlKCd4bWx0b2RpY3QnLCBWZXJzaW9uKDAsIDEyLCAwKSkpCiAK 417897 2021-01-19 11:44:29 -0800 2021-01-19 17:47:19 -0800 Patch bug-220736-20210119134428.patch text/plain 2074 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmU4ZDFjNTNjZmQ0ZjgyZDA0YjNkZWRlYjYzNGIzYzc2 NzBkYjEwZS4uZDI3MGE3OGZkNTEyM2FkYTIzNjc3M2Q5NDBhN2E4ZThmMzA2NDNkNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDIxLTAxLTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3MTUwNik6IHdlYmtpdC1wYXRjaCBrZXlyaW5nIGlu dGVncmF0aW9uIGlzIGJyb2tlbiBvbiBMaW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwNzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgcjI3MTUwNiB1cGRhdGVkIHB5dGhvbi1rZXlyaW5nIHRvIHRo ZSBsYXN0IHZlcnNpb24gdG8gc3VwcG9ydCBweXRob24yLCBidXQgdW5mb3J0dW5hdGVseQorICAg ICAgICB0aGlzIHZlcnNpb24gc2VlbXMgdG8gYmUgc29tZWhvdyBpbmNvbXBhdGlibGUgd2l0aCBw eXRob24tc2VjcmV0c3RvcmFnZSwgd2hpY2ggaXMgcmVxdWlyZWQKKyAgICAgICAgZm9yIHN5c3Rl bSBrZXlyaW5nIHN1cHBvcnQgb24gTGludXguIFRoaXMgYnVnIGlzIGZpeGVkIGluIG5ld2VyIHZl cnNpb25zIG9mIHB5dGhvbi1rZXlyaW5nCisgICAgICAgIHRoYXQgZG8gbm90IHN1cHBvcnQgcHl0 aG9uMiwgYnV0IHdlIHN0aWxsIHN1cHBvcnQgcHl0aG9uMiwgc28gd2UgY2Fubm90IHVwZ3JhZGUu IEkndmUgdGVzdGVkCisgICAgICAgIHNldmVyYWwgdmVyc2lvbnMgb2YgcHl0aG9uLWtleXJpbmcg YW5kIGZvdW5kIHRoYXQgdmVyc2lvbiAxMS4xLjAgaXMgdGhlIG1vc3QgcmVjZW50IHZlcnNpb24K KyAgICAgICAgdGhhdCBzdXBwb3J0cyBweXRob24yIGFuZCB3b3JrcyBwcm9wZXJseSBvbiBMaW51 eCwgc28gbGV0J3Mgc3RpY2sgd2l0aCB0aGF0IHVudGlsIHdlIGFyZQorICAgICAgICByZWFkeSB0 byBnaXZlIHVwIG9uIHB5dGhvbjIuCisKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weToKKwogMjAyMS0wMS0xOSAgSm9uYXRoYW4g QmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0dpdEh1Yl0gVXNlIGdpdGh1 Yi5jb20gYXMgdGhlIHNvdXJjZSBvZiB0cnV0aCBmb3IgRVdTCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weSBiL1Rv b2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5 CmluZGV4IGVmMzVjZTRiMjIxMmJkZjgxYWI3MGRhNDhkZDcwODZhYmUwODI3NzAuLjhjODA3MzBj OGEzNmQwY2ZjMmU4MzNkMjBmM2VlYzA1MmIxNzBjODQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5 CkBAIC01MCw3ICs1MCw3IEBAIHZlcnNpb24gPSBWZXJzaW9uKDAsIDksIDIpCiAKIEF1dG9JbnN0 YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ2VudHJ5cG9pbnRzJywgVmVyc2lvbigwLCAzLCAwKSkpCiBB dXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdmYXN0ZW5lcnMnLCBWZXJzaW9uKDAsIDE1LCAw KSkpCi1BdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdrZXlyaW5nJywgVmVyc2lvbigxOCwg MCwgMSkpKQorQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgna2V5cmluZycsIFZlcnNpb24o MTEsIDEsIDApKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ21vbm90b25pYycsIFZl cnNpb24oMSwgNSkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgneG1sdG9kaWN0Jywg VmVyc2lvbigwLCAxMiwgMCkpKQogCg==