220610 2021-01-13 16:50:43 -0800 REGRESSION(r271119) Check for nullness of preamble.caller 2021-01-28 12:37:51 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220216 InRadar P2 Normal --- 1 lmoura lmoura alecflett ashvayka beidson ews-watchlist jsbell webkit-bug-importer ysuzuki oldest_to_newest 1719493 0 lmoura 2021-01-13 16:50:43 -0800 REGRESSION(r271119) Check for nullness of preamble.caller 1719500 1 417586 lmoura 2021-01-13 17:18:11 -0800 Created attachment 417586 Patch 1719535 2 417586 ashvayka 2021-01-13 22:49:00 -0800 Comment on attachment 417586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417586&action=review Thank you for tracking this down! > LayoutTests/ChangeLog:8 > + r271119 changed some kinds of functions to return null when trying to What if partly revert r271119 by removing if (!function->jsExecutable()->hasCallerAndArgumentsProperties()) return JSValue::encode(jsNull()); from `caller` getter to completely align us with the other runtimes? 1719783 3 lmoura 2021-01-14 22:01:36 -0800 (In reply to Alexey Shvayka from comment #2) > > What if partly revert r271119 by removing > > if (!function->jsExecutable()->hasCallerAndArgumentsProperties()) > return JSValue::encode(jsNull()); > > from `caller` getter to completely align us with the other runtimes? I tried it and most tests work, except function-hidden-as-caller.js, caller-property.js, and tail-call-recognize.js, as they would need to be updated to reflect the previous behavior. But wouldn't it go against the spec linked in the original revision[1]? Or, as there is still an open issue[2] about in TC39 github, should we try to mimic other runtimes while it's discussed there? (although no updates in the github issue since early last year) [1] https://tc39.es/ecma262/#sec-forbidden-extensions [2] https://github.com/tc39/ecma262/issues/562 1721043 4 webkit-bug-importer 2021-01-20 16:51:12 -0800 <rdar://problem/73427042> 1723450 5 417586 ysuzuki 2021-01-28 12:22:12 -0800 Comment on attachment 417586 Patch I think this is OK. 1723453 6 417586 ysuzuki 2021-01-28 12:28:52 -0800 Comment on attachment 417586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417586&action=review >> LayoutTests/ChangeLog:8 >> + r271119 changed some kinds of functions to return null when trying to > > What if partly revert r271119 by removing > > if (!function->jsExecutable()->hasCallerAndArgumentsProperties()) > return JSValue::encode(jsNull()); > > from `caller` getter to completely align us with the other runtimes? Removing that part breaks the intent of https://trac.webkit.org/changeset/271119/webkit 1723454 7 417586 ysuzuki 2021-01-28 12:29:13 -0800 Comment on attachment 417586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417586&action=review >>> LayoutTests/ChangeLog:8 >>> + r271119 changed some kinds of functions to return null when trying to >> >> What if partly revert r271119 by removing >> >> if (!function->jsExecutable()->hasCallerAndArgumentsProperties()) >> return JSValue::encode(jsNull()); >> >> from `caller` getter to completely align us with the other runtimes? > > Removing that part breaks the intent of https://trac.webkit.org/changeset/271119/webkit Ah, no https://trac.webkit.org/changeset/230662/webkit 1723457 8 ews-feeder 2021-01-28 12:37:49 -0800 Committed r272030: <https://trac.webkit.org/changeset/272030> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417586. 417586 2021-01-13 17:18:11 -0800 2021-01-28 12:37:50 -0800 Patch bug-220610-20210113221809.patch text/plain 2951 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNDczCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODA5MDBmZDI5Nzg4MWJmMTIxZTg2 NzZlMmRiYWJkYzM5N2JlZjY0Mi4uYWE4YzAxOTFhMTI0MWZmMWEzYmRlYjcwODU3YzRiMmI3NTAw NmM1NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIxLTAxLTEzICBMYXVybyBNb3VyYSAgPGxt b3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3MTExOSkgQ2hlY2sgZm9y IG51bGxuZXNzIG9mIHByZWFtYmxlLmNhbGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwNjEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgcjI3MTExOSBjaGFuZ2VkIHNvbWUga2luZHMgb2YgZnVuY3Rp b25zIHRvIHJldHVybiBudWxsIHdoZW4gdHJ5aW5nIHRvCisgICAgICAgIGFjY2VzcyBpdHMgY2Fs bGVyIHByb3BlcnR5LgorCisgICAgICAgIFRoaXMgbWFkZSB0aGUgcHJlYW1ibGUgaGVscGVyIGZy b20gaW5kZXhlZGRiIHRlc3RzIHRvIGZhaWwgd2hlbiB1c2VkCisgICAgICAgIGluIHBsYWNlcyBs aWtlIGFycm93IGZ1bmN0aW9ucywgbGlrZSBpbgorICAgICAgICBzdG9yYWdlL2luZGV4ZWRkYi9y ZXN1bHQtcmVxdWVzdC1jeWNsZS5odG1sLgorCisgICAgICAgIFRoaXMgY29tbWl0IG1ha2VzIHBy ZWFtYmxlIGRlZmF1bHQgdG8gYW4gZW1wdHkgbmFtZSBpZiB0aGUgY2FsbGVyIGlzCisgICAgICAg IG51bGwuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL0luZGV4ZWREQi9yZXNvdXJjZXMvc2hhcmVk LmpzOgorICAgICAgICAocHJlYW1ibGUpOgorICAgICAgICAqIGltcG9ydGVkL2JsaW5rL3N0b3Jh Z2UvaW5kZXhlZGRiL3Jlc291cmNlcy9zaGFyZWQuanM6CisgICAgICAgIChwcmVhbWJsZSk6Cisg ICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL3NoYXJlZC5qczoKKyAgICAgICAg KHByZWFtYmxlKToKKwogMjAyMS0wMS0xMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNv bT4KIAogICAgICAgICBbQ29jb2FdIFN1cHBvcnQga2V5IHJvdGF0aW9uIHdpdGggSExTLWJhY2tl ZCBlbmNyeXB0ZWQgbWVkaWEgc3RyZWFtcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9JbmRleGVkREIvcmVzb3VyY2VzL3NoYXJlZC5qcyBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvSW5kZXhlZERCL3Jlc291cmNlcy9zaGFyZWQuanMKaW5kZXggZmM5YzFlODkzMDIyZWMyODI5 MGFlNDk4YjFlOTU0NzAyMjBkYmYxNS4uYzc1MmMyNmQ0OWJhZWRkZmRmZmMxNWFmODdkNjU3Y2E1 ZTFkODAyNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9JbmRleGVkREIvcmVz b3VyY2VzL3NoYXJlZC5qcworKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL0luZGV4ZWREQi9y ZXNvdXJjZXMvc2hhcmVkLmpzCkBAIC0xNDYsNyArMTQ2LDggQEAgZnVuY3Rpb24gcHJlYW1ibGUo ZXZ0KQogICAgIGlmIChldnQpCiAgICAgICAgIGV2ZW50ID0gZXZ0OwogICAgIGRlYnVnKCIiKTsK LSAgICBkZWJ1ZyhwcmVhbWJsZS5jYWxsZXIubmFtZSArICIoKToiKTsKKyAgICB2YXIgbmFtZSA9 IHByZWFtYmxlLmNhbGxlcj8ubmFtZSA/PyAnJzsKKyAgICBkZWJ1ZyhuYW1lICsgIigpOiIpOwog fQogCiAvLyBGb3IgV29ya2VycwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvYmxp bmsvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL3NoYXJlZC5qcyBiL0xheW91dFRlc3RzL2lt cG9ydGVkL2JsaW5rL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9zaGFyZWQuanMKaW5kZXgg OTQwMTBiYjZiNTAwNWU4NDUwNDJmM2VjODE3MTMyMGFjNmU5OTUzYi4uYjIwYTM2Y2M5NDgyMWQ2 YmUzODA2NzUxNGY3NWI4YTQyNzlmNjkzZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvYmxpbmsvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL3NoYXJlZC5qcworKysgYi9MYXlv dXRUZXN0cy9pbXBvcnRlZC9ibGluay9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvc2hhcmVk LmpzCkBAIC0xMzAsNyArMTMwLDggQEAgZnVuY3Rpb24gcHJlYW1ibGUoZXZ0KQogICAgIGlmIChl dnQpCiAgICAgICAgIGV2ZW50ID0gZXZ0OwogICAgIGRlYnVnKCIiKTsKLSAgICBkZWJ1ZyhwcmVh bWJsZS5jYWxsZXIubmFtZSArICIoKToiKTsKKyAgICB2YXIgbmFtZSA9IHByZWFtYmxlLmNhbGxl cj8ubmFtZSA/PyAnJzsKKyAgICBkZWJ1ZyhuYW1lICsgIigpOiIpOwogfQogCiAvLyBGb3IgV29y a2VycwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2Vz L3NoYXJlZC5qcyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9zaGFy ZWQuanMKaW5kZXggZmM5YzFlODkzMDIyZWMyODI5MGFlNDk4YjFlOTU0NzAyMjBkYmYxNS4uYzc1 MmMyNmQ0OWJhZWRkZmRmZmMxNWFmODdkNjU3Y2E1ZTFkODAyNyAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL3NoYXJlZC5qcworKysgYi9MYXlvdXRU ZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvc2hhcmVkLmpzCkBAIC0xNDYsNyArMTQ2 LDggQEAgZnVuY3Rpb24gcHJlYW1ibGUoZXZ0KQogICAgIGlmIChldnQpCiAgICAgICAgIGV2ZW50 ID0gZXZ0OwogICAgIGRlYnVnKCIiKTsKLSAgICBkZWJ1ZyhwcmVhbWJsZS5jYWxsZXIubmFtZSAr ICIoKToiKTsKKyAgICB2YXIgbmFtZSA9IHByZWFtYmxlLmNhbGxlcj8ubmFtZSA/PyAnJzsKKyAg ICBkZWJ1ZyhuYW1lICsgIigpOiIpOwogfQogCiAvLyBGb3IgV29ya2Vycwo=