<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220116</bug_id>
          
          <creation_ts>2020-12-23 05:34:00 -0800</creation_ts>
          <short_desc>[GTK] Remove WebKitWebContext:process-swap-on-cross-site-navigation-enabled and ensure PSON is always enabled with GTK 4</short_desc>
          <delta_ts>2022-10-21 07:20:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=240052</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>210100</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1716449</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-12-23 05:34:00 -0800</bug_when>
    <thetext>So we don&apos;t forget: process-swap-on-cross-site-navigation-enabled should default to TRUE in the GTK 4 API, so we are secure by default.

Alternatively: we could remove this setting and force it to TRUE. However, it would probably be useful to allow non-browser applications to disable it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1866445</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-05-04 08:06:40 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #0)
&gt; Alternatively: we could remove this setting and force it to TRUE. However,
&gt; it would probably be useful to allow non-browser applications to disable it.

Problem is PSON might become mandatory in the future. Exposing process model details in our public API has historically not worked well for us: basically all such APIs are now deprecated and broken. It&apos;s safer in the long run to just force PSON to be on.

If someone has a real good reason to disable it (e.g. small app loading only content from one security origin, want to avoid overhead of prewarming a process that will never be used) then I see the temptation to keep the setting around. But apps can break real badly if PSON is forced and they don&apos;t expect it. So I&apos;m not sure this is a good idea. More opinions welcome.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1866488</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-05-04 09:18:56 -0700</bug_when>
    <thetext>Maybe the benefit of having only one web process is worth the risk of breaking if PSON becomes forced in the future. For a small app like devhelp, you don&apos;t really want the overhead of a second prewarmed web process sitting around, when you know it will never be used.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1906222</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-10-17 12:09:54 -0700</bug_when>
    <thetext>So I tested Epiphany and found it actually creates only a single web process when opened with one web view, with no prewarmed process, so I think we should just force this on always.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1906314</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-10-17 16:51:09 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/5470</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1907301</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-10-21 07:20:27 -0700</bug_when>
    <thetext>Committed 255825@main (94be12a42fa1): &lt;https://commits.webkit.org/255825@main&gt;

Reviewed commits have been landed. Closing PR #5470 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>