219776 2020-12-11 03:37:18 -0800 [GTK][WPE] Async overflow scrolling is disabled by default due to brokenness 2020-12-11 09:51:16 -0800 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clord clord andersca cgarcia cmarcelo ews-watchlist fred.wang fujii jamesr kondapallykalyan luiz psaavedra simon.fraser thorton tonikitoo webkit-bug-importer zan oldest_to_newest 1713872 0 clord 2020-12-11 03:37:18 -0800 Sorry for the slightly vague title - Currently, AsyncOverflowScrollingEnabled is disabled in WebPreferencesInternal for Nicosia because enabling it results in broken rendering on scrolled overflow scrolling layers and their descendents. This is obviously less than ideal, scrolling is often not done on the root frame and disabling async overflow scrolling causes us to fall back to both main-thread scrolling and results in more painting and worse-feeling scrolling. The bug appears to be boundsOrigin on layers not being respected correctly. We should fix this and enable this setting - I have a patch that fixes at least the most obvious issues. I'm not certain it's a complete fix, but we need wider testing to identify further issues. In the future, it'd probably be ideal for there to be more shared code here between Mac and Linux, where Mac has a complete and likely more bug-free implementation. I think it'd be good to do some consolidation/refactoring and renaming in this code path - though this patch is quite small, it took a long time to figure out. 1713874 1 415986 clord 2020-12-11 03:42:51 -0800 Created attachment 415986 Patch 1713897 2 clord 2020-12-11 07:04:10 -0800 *** Bug 203412 has been marked as a duplicate of this bug. *** 1713922 3 416000 clord 2020-12-11 09:13:24 -0800 Created attachment 416000 Patch 1713932 4 ews-feeder 2020-12-11 09:50:35 -0800 Committed r270683: <https://trac.webkit.org/changeset/270683> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416000. 1713933 5 webkit-bug-importer 2020-12-11 09:51:16 -0800 <rdar://problem/72226809> 415986 2020-12-11 03:42:51 -0800 2020-12-11 09:13:20 -0800 Patch bug-219776-20201211114250.patch text/plain 6195 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDIwODVlNGQyMjg5NDYxZWQzNGY2ZWY3 NjczNGYyYTBlZjEzNTEzNTkuLjllMDMwOWE0OTZkOTc2YzRkNmE4YzU3NDk3OGI2NzNlMmIwMTcw MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMTItMTEgIENocmlzIExvcmQgIDxjbG9yZEBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gQXN5bmMgb3ZlcmZsb3cgc2Nyb2xsaW5n IGlzIGRpc2FibGVkIGJ5IGRlZmF1bHQgZHVlIHRvIGJyb2tlbm5lc3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTc3NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBhc3luYyBvdmVyZmxvdyBz Y3JvbGxpbmcgd2l0aCBOaWNvc2lhLgorCisgICAgICAgICogU2NyaXB0cy9QcmVmZXJlbmNlcy9X ZWJQcmVmZXJlbmNlc0ludGVybmFsLnlhbWw6CisKIDIwMjAtMTItMDEgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBsaXN0IG9mIGJsb2NrIHBvcnRz IGFjY29yZGluZyBmZXRjaCBzcGVjCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDIzYzUwM2ZkNWY2MTg3ODBkM2Q2 MmUwYWU0ZGQ5YTk4MWFiZjczYi4uNGM5OWM5MjhjZTIwZDgwZGVkMTAzNDYzNDlkNTE3YTQwNTE4 MWY1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTEyLTExICBDaHJpcyBMb3Jk ICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEFzeW5jIG92ZXJmbG93 IHNjcm9sbGluZyBpcyBkaXNhYmxlZCBieSBkZWZhdWx0IGR1ZSB0byBicm9rZW5uZXNzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk3NzYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgdG8g cmVzcGVjdCBHcmFwaGljc0xheWVyOjpib3VuZHNPcmlnaW4gd2hlbiBjYWxjdWxhdGluZworICAg ICAgICB0cmFuc2Zvcm1zLCBjb3ZlcmFnZSBhbmQgY2xpcHBpbmcgaW4gQ29vcmRpbmF0ZWRHcmFw aGljc0xheWVyLiBBbHNvLAorICAgICAgICB3aGVuIHNjcm9sbGluZyBvdmVyZmxvdyBhcmVhcywg Y2hhbmdlIHRoZSBib3VuZHNPcmlnaW4gb24gdGhlCisgICAgICAgIGNvbnRhaW5lciBsYXllciBh bmQgbm90IHRoZSBjb250ZW50cyBhcmVhLCB0byBtYXRjaCBiZWhhdmlvdXIgb24gTWFjLgorCisg ICAgICAgICogcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlT3ZlcmZsb3dTY3Jv bGxpbmdOb2RlTmljb3NpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdUcmVlT3Zl cmZsb3dTY3JvbGxpbmdOb2RlTmljb3NpYTo6cmVwb3NpdGlvblNjcm9sbGluZ0xheWVycyk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50U2VsZkFuZENoaWxk cmVuKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29v cmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVk R3JhcGhpY3NMYXllcjo6Zmx1c2hDb21wb3NpdGluZ1N0YXRlRm9yVGhpc0xheWVyT25seSk6Cisg ICAgICAgIChXZWJDb3JlOjpDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OmNvbXB1dGVUcmFuc2Zv cm1lZFZpc2libGVSZWN0KToKKwogMjAyMC0xMi0wNyAgQ2hyaXMgTG9yZCAgPGNsb3JkQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBPdmVyZmxvdy9pZnJhbWUgc2Nyb2xsaW5nIHdp dGggYXN5bmMgc2Nyb2xsaW5nIGVuYWJsZWQgc29tZXRpbWVzIGRvZXNuJ3Qgd29yawpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzSW50ZXJu YWwueWFtbCBiL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0lu dGVybmFsLnlhbWwKaW5kZXggNWYwODhkNWUyNDZkMDQ3YWM1NGM0ZGUwYzcyZjMwNmIwOWEyY2Nk ZC4uZTA1ODE4NzdhYmU3NDUyODY3M2I1MTU1NjhhYzQ1MWQ5Nzk2OGYzNyAxMDA2NDQKLS0tIGEv U291cmNlL1dURi9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzSW50ZXJuYWwueWFt bAorKysgYi9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNJbnRl cm5hbC55YW1sCkBAIC0xMTUsNyArMTE1LDcgQEAgQXN5bmNPdmVyZmxvd1Njcm9sbGluZ0VuYWJs ZWQ6CiAgICAgV2ViS2l0TGVnYWN5OgogICAgICAgZGVmYXVsdDogZmFsc2UKICAgICBXZWJLaXQ6 Ci0gICAgICAiVVNFKE5JQ09TSUEpIjogZmFsc2UKKyAgICAgICJVU0UoTklDT1NJQSkiOiB0cnVl CiAgICAgICAiUExBVEZPUk0oSU9TX0ZBTUlMWSkiOiB0cnVlCiAgICAgICBkZWZhdWx0OiBXZWJL aXQ6OmRlZmF1bHRBc3luY0ZyYW1lU2Nyb2xsaW5nRW5hYmxlZCgpCiAgICAgV2ViQ29yZToKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL25pY29zaWEvU2Nyb2xsaW5n VHJlZU92ZXJmbG93U2Nyb2xsaW5nTm9kZU5pY29zaWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlT3ZlcmZsb3dTY3JvbGxpbmdOb2RlTmlj b3NpYS5jcHAKaW5kZXggNjEwMWEwYmZlNGNmZWVlY2RlYjBhNDgzYzc5YTE1OGY5ZTQwZTVkZS4u ZWRmYTZlMmFjYTQyOWIzMmE5NWFiOWZmYTEzYTRiYjVmYzNlYWQ1ZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlT3ZlcmZsb3dT Y3JvbGxpbmdOb2RlTmljb3NpYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxp bmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlT3ZlcmZsb3dTY3JvbGxpbmdOb2RlTmljb3NpYS5jcHAK QEAgLTgwLDcgKzgwLDcgQEAgRmxvYXRQb2ludCBTY3JvbGxpbmdUcmVlT3ZlcmZsb3dTY3JvbGxp bmdOb2RlTmljb3NpYTo6YWRqdXN0ZWRTY3JvbGxQb3NpdGlvbihjb24KIAogdm9pZCBTY3JvbGxp bmdUcmVlT3ZlcmZsb3dTY3JvbGxpbmdOb2RlTmljb3NpYTo6cmVwb3NpdGlvblNjcm9sbGluZ0xh eWVycygpCiB7Ci0gICAgYXV0byogc2Nyb2xsTGF5ZXIgPSBzdGF0aWNfY2FzdDxOaWNvc2lhOjpQ bGF0Zm9ybUxheWVyKj4oc2Nyb2xsZWRDb250ZW50c0xheWVyKCkpOworICAgIGF1dG8qIHNjcm9s bExheWVyID0gc3RhdGljX2Nhc3Q8Tmljb3NpYTo6UGxhdGZvcm1MYXllcio+KHNjcm9sbENvbnRh aW5lckxheWVyKCkpOwogICAgIEFTU0VSVChzY3JvbGxMYXllcik7CiAgICAgYXV0byYgY29tcG9z aXRpb25MYXllciA9IGRvd25jYXN0PE5pY29zaWE6OkNvbXBvc2l0aW9uTGF5ZXI+KCpzY3JvbGxM YXllcik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKaW5kZXggMTJjN2IzZjJmMjBhMjA2 OTEwNzZiNjQzYzM3ZTgxZGYwOTA3NDNlZC4uMmMzM2VhMmY1YTI0OTQyNWU0ODhhNjcxMjFlNzQy ODdkZGQ2ZTBkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKQEAgLTI2Myw3ICsyNjMs OCBAQCB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRTZWxmQW5kQ2hpbGRyZW4oVGV4dHVy ZU1hcHBlclBhaW50T3B0aW9ucyYgb3B0aW9ucwogICAgIGJvb2wgc2hvdWxkQ2xpcCA9IG1fc3Rh dGUubWFza3NUb0JvdW5kcyAmJiAhbV9zdGF0ZS5wcmVzZXJ2ZXMzRDsKICAgICBpZiAoc2hvdWxk Q2xpcCkgewogICAgICAgICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCBjbGlwVHJhbnNmb3JtOwotICAg ICAgICBjbGlwVHJhbnNmb3JtLnRyYW5zbGF0ZShvcHRpb25zLm9mZnNldC53aWR0aCgpLCBvcHRp b25zLm9mZnNldC5oZWlnaHQoKSk7CisgICAgICAgIGNsaXBUcmFuc2Zvcm0udHJhbnNsYXRlKG9w dGlvbnMub2Zmc2V0LndpZHRoKCkgKyBtX3N0YXRlLmJvdW5kc09yaWdpbi54KCksCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG9wdGlvbnMub2Zmc2V0LmhlaWdodCgpICsgbV9zdGF0 ZS5ib3VuZHNPcmlnaW4ueSgpKTsKICAgICAgICAgY2xpcFRyYW5zZm9ybS5tdWx0aXBseShvcHRp b25zLnRyYW5zZm9ybSk7CiAgICAgICAgIGNsaXBUcmFuc2Zvcm0ubXVsdGlwbHkobV9sYXllclRy YW5zZm9ybXMuY29tYmluZWQpOwogICAgICAgICBvcHRpb25zLnRleHR1cmVNYXBwZXIuYmVnaW5D bGlwKGNsaXBUcmFuc2Zvcm0sIEZsb2F0Um91bmRlZFJlY3QobGF5ZXJSZWN0KCkpKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRl ZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAK aW5kZXggNmM0MmRjYjhmMjg0MTJlOWYyZGNmMTUzOTQ3ODgyMmQzMDlmZWY4MS4uZTAzZmYyNTM5 NzFiNDRmM2U4OTRlZDRlZWZjZTM4YzQ2ZTdiNzFkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhp Y3NMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKQEAgLTkxNyw2ICs5MTcs OCBAQCB2b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6Zmx1c2hDb21wb3NpdGluZ1N0YXRl Rm9yVGhpc0xheWVyT25seSgpCiAgICAgICAgICAgICAgICAgICAgIHN0YXRlLmFuY2hvclBvaW50 ID0gbV9hZGp1c3RlZEFuY2hvclBvaW50OwogICAgICAgICAgICAgICAgIGlmIChsb2NhbERlbHRh LnNpemVDaGFuZ2VkKQogICAgICAgICAgICAgICAgICAgICBzdGF0ZS5zaXplID0gbV9hZGp1c3Rl ZFNpemU7CisgICAgICAgICAgICAgICAgaWYgKGxvY2FsRGVsdGEuYm91bmRzT3JpZ2luQ2hhbmdl ZCkKKyAgICAgICAgICAgICAgICAgICAgc3RhdGUuYm91bmRzT3JpZ2luID0gYm91bmRzT3JpZ2lu KCk7CiAKICAgICAgICAgICAgICAgICBpZiAobG9jYWxEZWx0YS50cmFuc2Zvcm1DaGFuZ2VkKQog ICAgICAgICAgICAgICAgICAgICBzdGF0ZS50cmFuc2Zvcm0gPSB0cmFuc2Zvcm0oKTsKQEAgLTEz MjUsNyArMTMyNyw3IEBAIHZvaWQgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpjb21wdXRlVHJh bnNmb3JtZWRWaXNpYmxlUmVjdCgpCiAgICAgbV9sYXllclRyYW5zZm9ybS5zZXRMb2NhbFRyYW5z Zm9ybShjdXJyZW50VHJhbnNmb3JtKTsKIAogICAgIG1fbGF5ZXJUcmFuc2Zvcm0uc2V0QW5jaG9y UG9pbnQobV9hZGp1c3RlZEFuY2hvclBvaW50KTsKLSAgICBtX2xheWVyVHJhbnNmb3JtLnNldFBv c2l0aW9uKG1fYWRqdXN0ZWRQb3NpdGlvbik7CisgICAgbV9sYXllclRyYW5zZm9ybS5zZXRQb3Np dGlvbihGbG9hdFBvaW50KG1fYWRqdXN0ZWRQb3NpdGlvbi54KCkgLSBib3VuZHNPcmlnaW4oKS54 KCksIG1fYWRqdXN0ZWRQb3NpdGlvbi55KCkgLSBib3VuZHNPcmlnaW4oKS55KCkpKTsKICAgICBt X2xheWVyVHJhbnNmb3JtLnNldFNpemUobV9hZGp1c3RlZFNpemUpOwogCiAgICAgbV9sYXllclRy YW5zZm9ybS5zZXRGbGF0dGVuaW5nKCFwcmVzZXJ2ZXMzRCgpKTsK 416000 2020-12-11 09:13:24 -0800 2020-12-11 09:50:35 -0800 Patch bug-219776-20201211171323.patch text/plain 6159 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDM0ZDQwOTM2ZjBmNDVjMmE5ZGExODcx ZmY0OTc5MmUxMzM4ZDk0NWUuLmIwZWIwYWRlYTE3ZTZiZDEzNWNkMGNmNzAwMWQ2ZWFkNmZlZmU5 NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMTItMTEgIENocmlzIExvcmQgIDxjbG9yZEBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gQXN5bmMgb3ZlcmZsb3cgc2Nyb2xsaW5n IGlzIGRpc2FibGVkIGJ5IGRlZmF1bHQgZHVlIHRvIGJyb2tlbm5lc3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTc3NgorCisgICAgICAgIFJldmll d2VkIGJ5IMW9YW4gRG9iZXLFoWVrLgorCisgICAgICAgIEVuYWJsZSBhc3luYyBvdmVyZmxvdyBz Y3JvbGxpbmcgd2l0aCBOaWNvc2lhLgorCisgICAgICAgICogU2NyaXB0cy9QcmVmZXJlbmNlcy9X ZWJQcmVmZXJlbmNlc0ludGVybmFsLnlhbWw6CisKIDIwMjAtMTItMTAgIEpvaG4gV2lsYW5kZXIg IDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAgICAgUENNOiBUdXJuIGZlYXR1cmUgb24gYnkg ZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQwNjliZmYxOTIwMjZiYjYxNzAyNGIzMTY4YzZkZjAxNjE4 YjgxN2UuLmVlNjdmN2I0ZWEwN2JiN2U4OGYxOGUwYWNmNTljYjBhODQ3YmQ5OWIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyMyBAQAorMjAyMC0xMi0xMSAgQ2hyaXMgTG9yZCAgPGNsb3JkQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBBc3luYyBvdmVyZmxvdyBzY3JvbGxpbmcgaXMg ZGlzYWJsZWQgYnkgZGVmYXVsdCBkdWUgdG8gYnJva2VubmVzcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5Nzc2CisKKyAgICAgICAgUmV2aWV3ZWQg Ynkgxb1hbiBEb2JlcsWhZWsuCisKKyAgICAgICAgTWFrZSBzdXJlIHRvIHJlc3BlY3QgR3JhcGhp Y3NMYXllcjo6Ym91bmRzT3JpZ2luIHdoZW4gY2FsY3VsYXRpbmcKKyAgICAgICAgdHJhbnNmb3Jt cywgY292ZXJhZ2UgYW5kIGNsaXBwaW5nIGluIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllci4gQWxz bywKKyAgICAgICAgd2hlbiBzY3JvbGxpbmcgb3ZlcmZsb3cgYXJlYXMsIGNoYW5nZSB0aGUgYm91 bmRzT3JpZ2luIG9uIHRoZQorICAgICAgICBjb250YWluZXIgbGF5ZXIgYW5kIG5vdCB0aGUgY29u dGVudHMgYXJlYSwgdG8gbWF0Y2ggYmVoYXZpb3VyIG9uIE1hYy4KKworICAgICAgICAqIHBhZ2Uv c2Nyb2xsaW5nL25pY29zaWEvU2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsaW5nTm9kZU5pY29z aWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZU92ZXJmbG93U2Nyb2xsaW5n Tm9kZU5pY29zaWE6OnJlcG9zaXRpb25TY3JvbGxpbmdMYXllcnMpOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6VGV4dHVyZU1hcHBlckxheWVyOjpwYWludFNlbGZBbmRDaGlsZHJlbik6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhp Y3NMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6 OmZsdXNoQ29tcG9zaXRpbmdTdGF0ZUZvclRoaXNMYXllck9ubHkpOgorICAgICAgICAoV2ViQ29y ZTo6Q29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpjb21wdXRlVHJhbnNmb3JtZWRWaXNpYmxlUmVj dCk6CisKIDIwMjAtMTItMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJlbW92ZSB0ZW1wb3Jhcnkgd29ya2Fyb3VuZCBh ZGRlZCB0byBmaXggdGhlIGJ1aWxkIHdpdGggR0NDIDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNJbnRlcm5hbC55YW1sIGIvU291cmNl L1dURi9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzSW50ZXJuYWwueWFtbAppbmRl eCBhYzMwNmRhYWM4N2I2YzAwMjRmNmJmN2IyMzM5NWE1ZTZmN2QyMTRiLi5iYzI2ODAwNDUzZjQ5 ZDFmZDY2ZTRmNDJmNzdhNzFjZjM0M2Q5YjY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL1Njcmlw dHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNJbnRlcm5hbC55YW1sCisrKyBiL1NvdXJjZS9X VEYvU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0ludGVybmFsLnlhbWwKQEAgLTEx NSw3ICsxMTUsNyBAQCBBc3luY092ZXJmbG93U2Nyb2xsaW5nRW5hYmxlZDoKICAgICBXZWJLaXRM ZWdhY3k6CiAgICAgICBkZWZhdWx0OiBmYWxzZQogICAgIFdlYktpdDoKLSAgICAgICJVU0UoTklD T1NJQSkiOiBmYWxzZQorICAgICAgIlVTRShOSUNPU0lBKSI6IHRydWUKICAgICAgICJQTEFURk9S TShJT1NfRkFNSUxZKSI6IHRydWUKICAgICAgIGRlZmF1bHQ6IFdlYktpdDo6ZGVmYXVsdEFzeW5j RnJhbWVTY3JvbGxpbmdFbmFibGVkKCkKICAgICBXZWJDb3JlOgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdUcmVlT3ZlcmZsb3dTY3Jv bGxpbmdOb2RlTmljb3NpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9uaWNv c2lhL1Njcm9sbGluZ1RyZWVPdmVyZmxvd1Njcm9sbGluZ05vZGVOaWNvc2lhLmNwcAppbmRleCA2 MTAxYTBiZmU0Y2ZlZWVjZGViMGE0ODNjNzlhMTU4ZjllNDBlNWRlLi5lZGZhNmUyYWNhNDI5YjMy YTk1YWI5ZmZhMTNhNGJiNWZjM2VhZDVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9uaWNvc2lhL1Njcm9sbGluZ1RyZWVPdmVyZmxvd1Njcm9sbGluZ05vZGVOaWNv c2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9uaWNvc2lhL1Njcm9s bGluZ1RyZWVPdmVyZmxvd1Njcm9sbGluZ05vZGVOaWNvc2lhLmNwcApAQCAtODAsNyArODAsNyBA QCBGbG9hdFBvaW50IFNjcm9sbGluZ1RyZWVPdmVyZmxvd1Njcm9sbGluZ05vZGVOaWNvc2lhOjph ZGp1c3RlZFNjcm9sbFBvc2l0aW9uKGNvbgogCiB2b2lkIFNjcm9sbGluZ1RyZWVPdmVyZmxvd1Nj cm9sbGluZ05vZGVOaWNvc2lhOjpyZXBvc2l0aW9uU2Nyb2xsaW5nTGF5ZXJzKCkKIHsKLSAgICBh dXRvKiBzY3JvbGxMYXllciA9IHN0YXRpY19jYXN0PE5pY29zaWE6OlBsYXRmb3JtTGF5ZXIqPihz Y3JvbGxlZENvbnRlbnRzTGF5ZXIoKSk7CisgICAgYXV0byogc2Nyb2xsTGF5ZXIgPSBzdGF0aWNf Y2FzdDxOaWNvc2lhOjpQbGF0Zm9ybUxheWVyKj4oc2Nyb2xsQ29udGFpbmVyTGF5ZXIoKSk7CiAg ICAgQVNTRVJUKHNjcm9sbExheWVyKTsKICAgICBhdXRvJiBjb21wb3NpdGlvbkxheWVyID0gZG93 bmNhc3Q8Tmljb3NpYTo6Q29tcG9zaXRpb25MYXllcj4oKnNjcm9sbExheWVyKTsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBw ZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlckxheWVyLmNwcAppbmRleCAxMmM3YjNmMmYyMGEyMDY5MTA3NmI2NDNjMzdlODFk ZjA5MDc0M2VkLi43OGM5MmUzYmM2NWEzMjliYTRiMDM0N2JmMjIzZDFlODFhYTQ0NTdmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXht YXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcApAQCAtMjYzLDcgKzI2Myw4IEBAIHZvaWQgVGV4dHVy ZU1hcHBlckxheWVyOjpwYWludFNlbGZBbmRDaGlsZHJlbihUZXh0dXJlTWFwcGVyUGFpbnRPcHRp b25zJiBvcHRpb25zCiAgICAgYm9vbCBzaG91bGRDbGlwID0gbV9zdGF0ZS5tYXNrc1RvQm91bmRz ICYmICFtX3N0YXRlLnByZXNlcnZlczNEOwogICAgIGlmIChzaG91bGRDbGlwKSB7CiAgICAgICAg IFRyYW5zZm9ybWF0aW9uTWF0cml4IGNsaXBUcmFuc2Zvcm07Ci0gICAgICAgIGNsaXBUcmFuc2Zv cm0udHJhbnNsYXRlKG9wdGlvbnMub2Zmc2V0LndpZHRoKCksIG9wdGlvbnMub2Zmc2V0LmhlaWdo dCgpKTsKKyAgICAgICAgY2xpcFRyYW5zZm9ybS50cmFuc2xhdGUob3B0aW9ucy5vZmZzZXQud2lk dGgoKSArIG1fc3RhdGUuYm91bmRzT3JpZ2luLngoKSwKKyAgICAgICAgICAgIG9wdGlvbnMub2Zm c2V0LmhlaWdodCgpICsgbV9zdGF0ZS5ib3VuZHNPcmlnaW4ueSgpKTsKICAgICAgICAgY2xpcFRy YW5zZm9ybS5tdWx0aXBseShvcHRpb25zLnRyYW5zZm9ybSk7CiAgICAgICAgIGNsaXBUcmFuc2Zv cm0ubXVsdGlwbHkobV9sYXllclRyYW5zZm9ybXMuY29tYmluZWQpOwogICAgICAgICBvcHRpb25z LnRleHR1cmVNYXBwZXIuYmVnaW5DbGlwKGNsaXBUcmFuc2Zvcm0sIEZsb2F0Um91bmRlZFJlY3Qo bGF5ZXJSZWN0KCkpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5h dGVkR3JhcGhpY3NMYXllci5jcHAKaW5kZXggNmM0MmRjYjhmMjg0MTJlOWYyZGNmMTUzOTQ3ODgy MmQzMDlmZWY4MS4uZTAzZmYyNTM5NzFiNDRmM2U4OTRlZDRlZWZjZTM4YzQ2ZTdiNzFkNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5h dGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXll ci5jcHAKQEAgLTkxNyw2ICs5MTcsOCBAQCB2b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6 Zmx1c2hDb21wb3NpdGluZ1N0YXRlRm9yVGhpc0xheWVyT25seSgpCiAgICAgICAgICAgICAgICAg ICAgIHN0YXRlLmFuY2hvclBvaW50ID0gbV9hZGp1c3RlZEFuY2hvclBvaW50OwogICAgICAgICAg ICAgICAgIGlmIChsb2NhbERlbHRhLnNpemVDaGFuZ2VkKQogICAgICAgICAgICAgICAgICAgICBz dGF0ZS5zaXplID0gbV9hZGp1c3RlZFNpemU7CisgICAgICAgICAgICAgICAgaWYgKGxvY2FsRGVs dGEuYm91bmRzT3JpZ2luQ2hhbmdlZCkKKyAgICAgICAgICAgICAgICAgICAgc3RhdGUuYm91bmRz T3JpZ2luID0gYm91bmRzT3JpZ2luKCk7CiAKICAgICAgICAgICAgICAgICBpZiAobG9jYWxEZWx0 YS50cmFuc2Zvcm1DaGFuZ2VkKQogICAgICAgICAgICAgICAgICAgICBzdGF0ZS50cmFuc2Zvcm0g PSB0cmFuc2Zvcm0oKTsKQEAgLTEzMjUsNyArMTMyNyw3IEBAIHZvaWQgQ29vcmRpbmF0ZWRHcmFw aGljc0xheWVyOjpjb21wdXRlVHJhbnNmb3JtZWRWaXNpYmxlUmVjdCgpCiAgICAgbV9sYXllclRy YW5zZm9ybS5zZXRMb2NhbFRyYW5zZm9ybShjdXJyZW50VHJhbnNmb3JtKTsKIAogICAgIG1fbGF5 ZXJUcmFuc2Zvcm0uc2V0QW5jaG9yUG9pbnQobV9hZGp1c3RlZEFuY2hvclBvaW50KTsKLSAgICBt X2xheWVyVHJhbnNmb3JtLnNldFBvc2l0aW9uKG1fYWRqdXN0ZWRQb3NpdGlvbik7CisgICAgbV9s YXllclRyYW5zZm9ybS5zZXRQb3NpdGlvbihGbG9hdFBvaW50KG1fYWRqdXN0ZWRQb3NpdGlvbi54 KCkgLSBib3VuZHNPcmlnaW4oKS54KCksIG1fYWRqdXN0ZWRQb3NpdGlvbi55KCkgLSBib3VuZHNP cmlnaW4oKS55KCkpKTsKICAgICBtX2xheWVyVHJhbnNmb3JtLnNldFNpemUobV9hZGp1c3RlZFNp emUpOwogCiAgICAgbV9sYXllclRyYW5zZm9ybS5zZXRGbGF0dGVuaW5nKCFwcmVzZXJ2ZXMzRCgp KTsK