219623 2020-12-07 19:12:15 -0800 [GPU Process] Ensure the backend of ImageBuffer is created before getting its handle 2020-12-07 20:16:20 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219007 https://bugs.webkit.org/show_bug.cgi?id=219563 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa dino simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1712665 0 sabouhallawa 2020-12-07 19:12:15 -0800 In r270458 and in RemoteLayerBackingStore::encode(), casting the ImageBuffer and calling the overriding createImageBufferBackendHandle() of the superclass was replaced by casting the backend() and calling its createImageBufferBackendHandle() directly. This may lead to crash if the backend was not created when createImageBufferBackendHandle() is called. The createImageBufferBackendHandle() of the ImageBuffer superclass calls ensureBackendCreated() before calling its createImageBufferBackendHandle(). So we need to replace to call ImageBuffer::backend() to ImageBuffer::ensureBackendCreated(). 1712666 1 415606 sabouhallawa 2020-12-07 19:20:48 -0800 Created attachment 415606 Patch 1712673 2 ews-feeder 2020-12-07 20:15:19 -0800 Committed r270529: <https://trac.webkit.org/changeset/270529> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415606. 1712674 3 webkit-bug-importer 2020-12-07 20:16:20 -0800 <rdar://problem/72075298> 415606 2020-12-07 19:20:48 -0800 2020-12-07 20:15:19 -0800 Patch bug-219623-20201207192047.patch text/plain 6519 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzEzNDg4N2QyYjdlZjE0 YTNmOGRlYmRkYTE0MTNiNzc2YTg0YTI3Ni4uNDEwNzZhZWY5OTc5ZGM5MjYwMzcwYTk1NjA1YzNj M2E2NmQwNzg4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTEyLTA3ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g RW5zdXJlIHRoZSBiYWNrZW5kIG9mIEltYWdlQnVmZmVyIGlzIGNyZWF0ZWQgYmVmb3JlIGdldHRp bmcgaXRzIGhhbmRsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE5NjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVtb3ZlIHRoZSBJbWFnZUJ1ZmZlcjo6YmFja2VuZCgpIG1ldGhvZCBhbmQgbW92ZSBl bnN1cmVCYWNrZW5kQ3JlYXRlZCgpCisgICAgICAgIGZyb20gQ29uY3JldGVJbWFnZUJ1ZmZlciB0 byBJbWFnZUJ1ZmZlci4gQ2xpZW50cyBzaG91bGQgZW5zdXJlIHRoZSBiYWNrZW5kCisgICAgICAg IGlzIGNyZWF0ZWQgYmVmb3JlIGFjY2Vzc2luZyBpdHMgbWV0aG9kLiBlbnN1cmVCYWNrZW5kQ3Jl YXRlZCgpIGlzIG9ubHkKKyAgICAgICAgb3ZlcnJpZGRlbiBieSBSZW1vdGVJbWFnZUJ1ZmZlclBy b3h5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvQ29uY3JldGVJbWFnZUJ1ZmZlci5o OgorICAgICAgICAoV2ViQ29yZTo6Q29uY3JldGVJbWFnZUJ1ZmZlcjo6ZW5zdXJlQmFja2VuZENy ZWF0ZWQgY29uc3QpOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdl QnVmZmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6YmFja2VuZCBjb25zdCk6 IERlbGV0ZWQuCisKIDIwMjAtMTItMDcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBQYXJzZSBjb250ZW50IGFmdGVyICMgaW4gZGF0YSBVUkxz IHdpdGggSExTIG1pbWUgdHlwZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggNjYxN2YzZGY0ZGE3MWU4ZGQyMmI4MmI1 ZmFkZDlhNmYyNmUxM2ExZC4uYjMwNjRkZGVkMDQ0NGE0ZGY4Y2NlYjdmZjNkODE3ZDcwM2M2MDQ4 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAyMC0xMi0wNyAgU2FpZCBBYm91LUhhbGxh d2EgIDxzYWlkQGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVIFByb2Nlc3NdIEVuc3VyZSB0aGUg YmFja2VuZCBvZiBJbWFnZUJ1ZmZlciBpcyBjcmVhdGVkIGJlZm9yZSBnZXR0aW5nIGl0cyBoYW5k bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTYy MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIy NzA0NTggYW5kIGluIFJlbW90ZUxheWVyQmFja2luZ1N0b3JlOjplbmNvZGUoKSwgY2FzdGluZyB0 aGUgSW1hZ2VCdWZmZXIKKyAgICAgICAgYW5kIGNhbGxpbmcgdGhlIG92ZXJyaWRpbmcgY3JlYXRl SW1hZ2VCdWZmZXJCYWNrZW5kSGFuZGxlKCkgb2YgdGhlIHN1cGVyY2xhc3MKKyAgICAgICAgd2Fz IHJlcGxhY2VkIGJ5IGNhc3RpbmcgdGhlIGJhY2tlbmQgYW5kIGNhbGxpbmcgaXRzIGNyZWF0ZUlt YWdlQnVmZmVyQmFja2VuZEhhbmRsZSgpCisgICAgICAgIGRpcmVjdGx5LgorCisgICAgICAgIFRo aXMgbWF5IGxlYWQgdG8gY3Jhc2ggaWYgdGhlIGJhY2tlbmQgd2FzIG5vdCBjcmVhdGVkIHdoZW4g Y2FsbGluZyBpdHMKKyAgICAgICAgY3JlYXRlSW1hZ2VCdWZmZXJCYWNrZW5kSGFuZGxlKCkuIFRo ZSBjcmVhdGVJbWFnZUJ1ZmZlckJhY2tlbmRIYW5kbGUoKQorICAgICAgICBvZiB0aGUgSW1hZ2VC dWZmZXIgc3VwZXJjbGFzcyBjYWxscyBlbnN1cmVCYWNrZW5kQ3JlYXRlZCgpIGJlZm9yZSBjYWxs aW5nCisgICAgICAgIGNyZWF0ZUltYWdlQnVmZmVyQmFja2VuZEhhbmRsZSgpIG9mIHRoZSBiYWNr ZW5kLgorCisgICAgICAgIFNvIHdlIG5lZWQgdG8gcmVwbGFjZSB0byBjYWxsIGJhY2tlbmQoKSB0 byBlbnN1cmVCYWNrZW5kQ3JlYXRlZCgpLgorCisgICAgICAgICogU2hhcmVkL1JlbW90ZUxheWVy VHJlZS9SZW1vdGVMYXllckJhY2tpbmdTdG9yZS5tbToKKyAgICAgICAgKFdlYktpdDo6UmVtb3Rl TGF5ZXJCYWNraW5nU3RvcmU6OmVuY29kZSBjb25zdCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9H UFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQcm94eS5oOgorCiAyMDIwLTEyLTA3ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzYW5kYm94IHRl bGVtZXRyeSBmb3IgbGlrZWx5IHVudXNlZCBmZWF0dXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29uY3JldGVJbWFnZUJ1ZmZlci5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29uY3JldGVJbWFnZUJ1ZmZlci5oCmluZGV4IGQ3YjBi MWE3ZjkzZDkxMzRjOWRjZWIzZDI3OGQ5NjJlZDk2YzgyODUuLjFmMjQ1YmNlYmE3MmNlMTM3ZTkw YzYxZTU1ZjUxYTMzODFiODA2ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0NvbmNyZXRlSW1hZ2VCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9Db25jcmV0ZUltYWdlQnVmZmVyLmgKQEAgLTcxLDkgKzcxLDcgQEAgcHJv dGVjdGVkOgogICAgIH0KIAogICAgIHZvaWQgY2xlYXJCYWNrZW5kKCkgb3ZlcnJpZGUgeyBtX2Jh Y2tlbmQgPSBudWxscHRyOyB9Ci0KLSAgICBJbWFnZUJ1ZmZlckJhY2tlbmQqIGJhY2tlbmQoKSBj b25zdCBvdmVycmlkZSB7IHJldHVybiBtX2JhY2tlbmQuZ2V0KCk7IH0KLSAgICB2aXJ0dWFsIEJh Y2tlbmRUeXBlKiBlbnN1cmVCYWNrZW5kQ3JlYXRlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYmFja2Vu ZC5nZXQoKTsgfQorICAgIEltYWdlQnVmZmVyQmFja2VuZCogZW5zdXJlQmFja2VuZENyZWF0ZWQo KSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBtX2JhY2tlbmQuZ2V0KCk7IH0KIAogICAgIFJlbmRl cmluZ1Jlc291cmNlSWRlbnRpZmllciByZW5kZXJpbmdSZXNvdXJjZUlkZW50aWZpZXIoKSBjb25z dCBvdmVycmlkZSB7IHJldHVybiBtX3JlbmRlcmluZ1Jlc291cmNlSWRlbnRpZmllcjsgfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuaAppbmRleCAy NDc4ZDliNzI1NWMwMDU5N2FhNTA1YzNlYWI3MmNhYTRkMDk2NGZiLi44OGI1M2RhMzQwMjhmMWZi OGJiNGEyMWU5YTc0ODU5ZGE4ODRhMjc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ltYWdlQnVmZmVyLmgKQEAgLTY2LDcgKzY2LDcgQEAgcHVibGljOgogCiAgICAg dmlydHVhbCB2b2lkIHNldEJhY2tlbmQoc3RkOjp1bmlxdWVfcHRyPEltYWdlQnVmZmVyQmFja2Vu ZD4mJikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBjbGVhckJhY2tlbmQoKSA9IDA7Ci0gICAgdmly dHVhbCBJbWFnZUJ1ZmZlckJhY2tlbmQqIGJhY2tlbmQoKSBjb25zdCB7IHJldHVybiBudWxscHRy OyB9CisgICAgdmlydHVhbCBJbWFnZUJ1ZmZlckJhY2tlbmQqIGVuc3VyZUJhY2tlbmRDcmVhdGVk KCkgY29uc3QgPSAwOwogCiAgICAgdmlydHVhbCBSZW5kZXJpbmdNb2RlIHJlbmRlcmluZ01vZGUo KSBjb25zdCA9IDA7CiAgICAgdmlydHVhbCBib29sIGNhbk1hcEJhY2tpbmdTdG9yZSgpIGNvbnN0 ID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9S ZW1vdGVMYXllckJhY2tpbmdTdG9yZS5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxh eWVyVHJlZS9SZW1vdGVMYXllckJhY2tpbmdTdG9yZS5tbQppbmRleCAyYzFlMmZjZDUyYmE0MDRl YTk0ZDNjMDYxMjYyMTQ5MWE2ZGU4YWE1Li41OTMzOTZhMWJhODZjYmM5ZGZmOWQzYzk3N2E3NDJm Mzk3ZGNjYjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9SZW1vdGVMYXllclRy ZWUvUmVtb3RlTGF5ZXJCYWNraW5nU3RvcmUubW0KKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQv UmVtb3RlTGF5ZXJUcmVlL1JlbW90ZUxheWVyQmFja2luZ1N0b3JlLm1tCkBAIC0xMDUsMTEgKzEw NSwxMSBAQCB2b2lkIFJlbW90ZUxheWVyQmFja2luZ1N0b3JlOjplbmNvZGUoSVBDOjpFbmNvZGVy JiBlbmNvZGVyKSBjb25zdAogICAgIE9wdGlvbmFsPEltYWdlQnVmZmVyQmFja2VuZEhhbmRsZT4g aGFuZGxlOwogICAgIGlmIChtX2Zyb250QnVmZmVyLmltYWdlQnVmZmVyKSB7CiAgICAgICAgIGlm IChtX2Zyb250QnVmZmVyLmltYWdlQnVmZmVyLT5yZW5kZXJpbmdNb2RlKCkgPT0gV2ViQ29yZTo6 UmVuZGVyaW5nTW9kZTo6VW5hY2NlbGVyYXRlZCkKLSAgICAgICAgICAgIGhhbmRsZSA9IHN0YXRp Y19jYXN0PFVuYWNjZWxlcmF0ZWRJbWFnZUJ1ZmZlclNoYXJlYWJsZUJhY2tlbmQmPigqbV9mcm9u dEJ1ZmZlci5pbWFnZUJ1ZmZlci0+YmFja2VuZCgpKS5jcmVhdGVJbWFnZUJ1ZmZlckJhY2tlbmRI YW5kbGUoKTsKKyAgICAgICAgICAgIGhhbmRsZSA9IHN0YXRpY19jYXN0PFVuYWNjZWxlcmF0ZWRJ bWFnZUJ1ZmZlclNoYXJlYWJsZUJhY2tlbmQmPigqbV9mcm9udEJ1ZmZlci5pbWFnZUJ1ZmZlci0+ ZW5zdXJlQmFja2VuZENyZWF0ZWQoKSkuY3JlYXRlSW1hZ2VCdWZmZXJCYWNrZW5kSGFuZGxlKCk7 CiAgICAgICAgIGVsc2UgaWYgKG1fZnJvbnRCdWZmZXIuaW1hZ2VCdWZmZXItPmNhbk1hcEJhY2tp bmdTdG9yZSgpKQotICAgICAgICAgICAgaGFuZGxlID0gc3RhdGljX2Nhc3Q8QWNjZWxlcmF0ZWRJ bWFnZUJ1ZmZlclNoYXJlYWJsZU1hcHBlZEJhY2tlbmQmPigqbV9mcm9udEJ1ZmZlci5pbWFnZUJ1 ZmZlci0+YmFja2VuZCgpKS5jcmVhdGVJbWFnZUJ1ZmZlckJhY2tlbmRIYW5kbGUoKTsKKyAgICAg ICAgICAgIGhhbmRsZSA9IHN0YXRpY19jYXN0PEFjY2VsZXJhdGVkSW1hZ2VCdWZmZXJTaGFyZWFi bGVNYXBwZWRCYWNrZW5kJj4oKm1fZnJvbnRCdWZmZXIuaW1hZ2VCdWZmZXItPmVuc3VyZUJhY2tl bmRDcmVhdGVkKCkpLmNyZWF0ZUltYWdlQnVmZmVyQmFja2VuZEhhbmRsZSgpOwogICAgICAgICBl bHNlCi0gICAgICAgICAgICBoYW5kbGUgPSBzdGF0aWNfY2FzdDxBY2NlbGVyYXRlZEltYWdlQnVm ZmVyU2hhcmVhYmxlQmFja2VuZCY+KCptX2Zyb250QnVmZmVyLmltYWdlQnVmZmVyLT5iYWNrZW5k KCkpLmNyZWF0ZUltYWdlQnVmZmVyQmFja2VuZEhhbmRsZSgpOworICAgICAgICAgICAgaGFuZGxl ID0gc3RhdGljX2Nhc3Q8QWNjZWxlcmF0ZWRJbWFnZUJ1ZmZlclNoYXJlYWJsZUJhY2tlbmQmPigq bV9mcm9udEJ1ZmZlci5pbWFnZUJ1ZmZlci0+ZW5zdXJlQmFja2VuZENyZWF0ZWQoKSkuY3JlYXRl SW1hZ2VCdWZmZXJCYWNrZW5kSGFuZGxlKCk7CiAgICAgfQogCiAgICAgZW5jb2RlciA8PCBoYW5k bGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1Jl bW90ZUltYWdlQnVmZmVyUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3Jh cGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQcm94eS5oCmluZGV4IDAzNTYyNTFhODJlNDA0OGI5MDhl ZDgxMmViZWQ3OWZhNDVmODc0ZjguLjYwZTY0MzBiODk5MWYzYTFlZWZjZDJjZDc0ZGMyYzcwMjdm ODk5ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3Mv UmVtb3RlSW1hZ2VCdWZmZXJQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9H UFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQcm94eS5oCkBAIC0xMjcsNyArMTI3LDcgQEAg cHJvdGVjdGVkOgogICAgICAgICB9CiAgICAgfQogCi0gICAgQmFja2VuZFR5cGUqIGVuc3VyZUJh Y2tlbmRDcmVhdGVkKCkgY29uc3Qgb3ZlcnJpZGUKKyAgICBXZWJDb3JlOjpJbWFnZUJ1ZmZlckJh Y2tlbmQqIGVuc3VyZUJhY2tlbmRDcmVhdGVkKCkgY29uc3Qgb3ZlcnJpZGUKICAgICB7CiAgICAg ICAgIGlmICghbV9iYWNrZW5kICYmIG1fcmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5KQogICAg ICAgICAgICAgbV9yZW1vdGVSZW5kZXJpbmdCYWNrZW5kUHJveHktPndhaXRGb3JEaWRDcmVhdGVJ bWFnZUJ1ZmZlckJhY2tlbmQoKTsK