219395 2020-12-01 06:08:52 -0800 [JSC] Aarch64 build failure 2020-12-01 12:04:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218990 InRadar P2 Normal --- 1 lmoura chi187 chi187 ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1711018 0 lmoura 2020-12-01 06:08:52 -0800 The JSC-Only Aarch64 bot[1] is failing with the following error: ``` /usr/bin/ccache /home/buildbot/linaro/toolchain/bin/aarch64-linux-gnu-g++ --sysroot=/home/buildbot/linaro/toolchain/sysroot -DBUILDING_JSCONLY__ -DBUILDING_WITH_CMAKE=1 -DHAVE_CONFIG_H=1 -DSTATICALLY_LINKED_WITH_WTF -IDerivedSources/ForwardingHeaders -I. -I../../Source/JavaScriptCore -I../../Source/JavaScriptCore/API -I../../Source/JavaScriptCore/assembler -I../../Source/JavaScriptCore/b3 -I../../Source/JavaScriptCore/b3/air -I../../Source/JavaScriptCore/bindings -I../../Source/JavaScriptCore/builtins -I../../Source/JavaScriptCore/bytecode -I../../Source/JavaScriptCore/bytecompiler -I../../Source/JavaScriptCore/dfg -I../../Source/JavaScriptCore/disassembler -I../../Source/JavaScriptCore/disassembler/ARM64 -I../../Source/JavaScriptCore/disassembler/udis86 -I../../Source/JavaScriptCore/domjit -I../../Source/JavaScriptCore/ftl -I../../Source/JavaScriptCore/heap -I../../Source/JavaScriptCore/debugger -I../../Source/JavaScriptCore/inspector -I../../Source/JavaScriptCore/inspector/agents -I../../Source/JavaScriptCore/inspector/augmentable -I../../Source/JavaScriptCore/inspector/remote -I../../Source/JavaScriptCore/interpreter -I../../Source/JavaScriptCore/jit -I../../Source/JavaScriptCore/llint -I../../Source/JavaScriptCore/parser -I../../Source/JavaScriptCore/profiler -I../../Source/JavaScriptCore/runtime -I../../Source/JavaScriptCore/tools -I../../Source/JavaScriptCore/wasm -I../../Source/JavaScriptCore/wasm/js -I../../Source/JavaScriptCore/yarr -IDerivedSources/JavaScriptCore -IDerivedSources/JavaScriptCore/inspector -IDerivedSources/JavaScriptCore/runtime -IDerivedSources/JavaScriptCore/yarr -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-attributes -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -fPIC -std=c++1z -MD -MT Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o -MF Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o -c ../../Source/JavaScriptCore/llint/LowLevelInterpreter.cpp /tmp/ccYwnhHg.s: Assembler messages: /tmp/ccYwnhHg.s:65123: Error: operand mismatch -- `sxtb x1,x0' /tmp/ccYwnhHg.s:65123: Info: did you mean this? /tmp/ccYwnhHg.s:65123: Info: sxtb x1, w0 /tmp/ccYwnhHg.s:65123: Info: other valid variant(s): /tmp/ccYwnhHg.s:65123: Info: sxtb w1, w0 ... ``` Likely related to r270265, which added the following snippet? ``` --- a/Source/JavaScriptCore/offlineasm/arm64.rb +++ b/Source/JavaScriptCore/offlineasm/arm64.rb @@ -901,6 +901,10 @@ class Instruction emitARM64("sxtb", operands, [:word, :word]) when "sxh2i" emitARM64("sxth", operands, [:word, :word]) + when "sxb2q" + emitARM64("sxtb", operands, [:quad, :quad]) + when "sxh2q" + emitARM64("sxth", operands, [:quad, :quad]) when "nop" $asm.puts "nop" when "bieq", "bbeq" ``` [1] https://build.webkit.org/builders/JSCOnly-Linux-AArch64-Release?numbuilds=50 1711026 1 415134 chi187 2020-12-01 06:47:37 -0800 Created attachment 415134 Patch 1711027 2 chi187 2020-12-01 06:50:04 -0800 (In reply to Lauro Moura from comment #0) > The JSC-Only Aarch64 bot[1] is failing with the following error: > > ``` > /usr/bin/ccache /home/buildbot/linaro/toolchain/bin/aarch64-linux-gnu-g++ > --sysroot=/home/buildbot/linaro/toolchain/sysroot -DBUILDING_JSCONLY__ > -DBUILDING_WITH_CMAKE=1 -DHAVE_CONFIG_H=1 -DSTATICALLY_LINKED_WITH_WTF > -IDerivedSources/ForwardingHeaders -I. -I../../Source/JavaScriptCore > -I../../Source/JavaScriptCore/API -I../../Source/JavaScriptCore/assembler > -I../../Source/JavaScriptCore/b3 -I../../Source/JavaScriptCore/b3/air > -I../../Source/JavaScriptCore/bindings > -I../../Source/JavaScriptCore/builtins > -I../../Source/JavaScriptCore/bytecode > -I../../Source/JavaScriptCore/bytecompiler -I../../Source/JavaScriptCore/dfg > -I../../Source/JavaScriptCore/disassembler > -I../../Source/JavaScriptCore/disassembler/ARM64 > -I../../Source/JavaScriptCore/disassembler/udis86 > -I../../Source/JavaScriptCore/domjit -I../../Source/JavaScriptCore/ftl > -I../../Source/JavaScriptCore/heap -I../../Source/JavaScriptCore/debugger > -I../../Source/JavaScriptCore/inspector > -I../../Source/JavaScriptCore/inspector/agents > -I../../Source/JavaScriptCore/inspector/augmentable > -I../../Source/JavaScriptCore/inspector/remote > -I../../Source/JavaScriptCore/interpreter -I../../Source/JavaScriptCore/jit > -I../../Source/JavaScriptCore/llint -I../../Source/JavaScriptCore/parser > -I../../Source/JavaScriptCore/profiler -I../../Source/JavaScriptCore/runtime > -I../../Source/JavaScriptCore/tools -I../../Source/JavaScriptCore/wasm > -I../../Source/JavaScriptCore/wasm/js -I../../Source/JavaScriptCore/yarr > -IDerivedSources/JavaScriptCore -IDerivedSources/JavaScriptCore/inspector > -IDerivedSources/JavaScriptCore/runtime -IDerivedSources/JavaScriptCore/yarr > -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined > -Wno-attributes -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation > -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith > -Wmissing-format-attribute -Wformat-security -Wcast-align > -Wno-tautological-compare -fno-strict-aliasing -fno-exceptions -fno-rtti > -O3 -DNDEBUG -fPIC -std=c++1z -MD -MT > Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/ > LowLevelInterpreter.cpp.o -MF > Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/ > LowLevelInterpreter.cpp.o.d -o > Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/ > LowLevelInterpreter.cpp.o -c > ../../Source/JavaScriptCore/llint/LowLevelInterpreter.cpp > /tmp/ccYwnhHg.s: Assembler messages: > /tmp/ccYwnhHg.s:65123: Error: operand mismatch -- `sxtb x1,x0' > /tmp/ccYwnhHg.s:65123: Info: did you mean this? > /tmp/ccYwnhHg.s:65123: Info: sxtb x1, w0 > /tmp/ccYwnhHg.s:65123: Info: other valid variant(s): > /tmp/ccYwnhHg.s:65123: Info: sxtb w1, w0 > ... > ``` > > Likely related to r270265, which added the following snippet? > > ``` > --- a/Source/JavaScriptCore/offlineasm/arm64.rb > +++ b/Source/JavaScriptCore/offlineasm/arm64.rb > @@ -901,6 +901,10 @@ class Instruction > emitARM64("sxtb", operands, [:word, :word]) > when "sxh2i" > emitARM64("sxth", operands, [:word, :word]) > + when "sxb2q" > + emitARM64("sxtb", operands, [:quad, :quad]) > + when "sxh2q" > + emitARM64("sxth", operands, [:quad, :quad]) > when "nop" > $asm.puts "nop" > when "bieq", "bbeq" > ``` > > [1] > https://build.webkit.org/builders/JSCOnly-Linux-AArch64-Release?numbuilds=50 Oh, yes, the source register operand of sxt instructions should be a word 1711111 3 415134 ysuzuki 2020-12-01 11:21:08 -0800 Comment on attachment 415134 Patch r=me if EWS gets green 1711119 4 415134 ysuzuki 2020-12-01 11:57:31 -0800 Comment on attachment 415134 Patch mac-debug-wk1 EWS is getting stuck now and will not get tests soon. 1711120 5 ews-feeder 2020-12-01 12:03:20 -0800 Committed r270322: <https://trac.webkit.org/changeset/270322> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415134. 1711121 6 webkit-bug-importer 2020-12-01 12:04:18 -0800 <rdar://problem/71861265> 415134 2020-12-01 06:47:37 -0800 2020-12-01 12:03:20 -0800 Patch bug-219395-20201201174735.patch text/plain 1391 chi187 U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZDAwOWUzYWUyNWVmODdlYTJiY2Y2MzljY2YwNjM2OGJjNGE0ZDFiLi5iNDBmZjdjYzMwMTI0MjJh ZGIwN2Q4OTNlYTc0MTJmMDM3ZGExNDhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAyMC0xMi0wMSAgU2VyZ2V5IFJ1YmFub3YgIDxjaGkxODdAZ21haWwuY29t PgorCisgICAgICAgIEZpeCBBYXJjaDY0IGJ1aWxkIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTM5NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogb2ZmbGluZWFzbS9hcm02NC5yYjoKKwog MjAyMC0xMi0wMSAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb SlNDXSBNYWtlIEJ5dGVjb2RlcyBnZW5lcmF0b3IgY29tbWFuZCBhbHNvIGRlcGVuZCBvbiB3YXNt Lmpzb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FybTY0 LnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJtNjQucmIKaW5kZXggNDY1 MzJhNmRkMDdlM2Q0N2E5ZjUxNDQ3MTdmMmM5NDFiZDY5YmIxYi4uNzc3YzEwMDMxODY4NTRhYTVi YjQyNGI2MGJhZDc1ODUzMzhlMjQzNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L29mZmxpbmVhc20vYXJtNjQucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVh c20vYXJtNjQucmIKQEAgLTkwMiw5ICs5MDIsOSBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAgICAg ICB3aGVuICJzeGgyaSIKICAgICAgICAgICAgIGVtaXRBUk02NCgic3h0aCIsIG9wZXJhbmRzLCBb OndvcmQsIDp3b3JkXSkKICAgICAgICAgd2hlbiAic3hiMnEiCi0gICAgICAgICAgICBlbWl0QVJN NjQoInN4dGIiLCBvcGVyYW5kcywgWzpxdWFkLCA6cXVhZF0pCisgICAgICAgICAgICBlbWl0QVJN NjQoInN4dGIiLCBvcGVyYW5kcywgWzp3b3JkLCA6cXVhZF0pCiAgICAgICAgIHdoZW4gInN4aDJx IgotICAgICAgICAgICAgZW1pdEFSTTY0KCJzeHRoIiwgb3BlcmFuZHMsIFs6cXVhZCwgOnF1YWRd KQorICAgICAgICAgICAgZW1pdEFSTTY0KCJzeHRoIiwgb3BlcmFuZHMsIFs6d29yZCwgOnF1YWRd KQogICAgICAgICB3aGVuICJub3AiCiAgICAgICAgICAgICAkYXNtLnB1dHMgIm5vcCIKICAgICAg ICAgd2hlbiAiYmllcSIsICJiYmVxIgo=