219175 2020-11-19 12:29:54 -0800 ASSERT NOT REACHED in WebCore::DisplayList::DrawImageBuffer::apply seen with TestWebKitAPI.DisplayListTests.ReplayWithMissingResource 2020-11-19 14:12:08 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219067 InRadar P2 Normal --- 1 ryanhaddad wenson_hsieh thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1709224 0 ryanhaddad 2020-11-19 12:29:54 -0800 TestWebKitAPI.DisplayListTests.ReplayWithMissingResource SHOULD NEVER BE REACHED ./platform/graphics/displaylists/DisplayListItems.cpp(426) : void WebCore::DisplayList::DrawImageBuffer::apply(WebCore::GraphicsContext &) const 1 0x105181a69 WTFCrash 2 0x11c85190b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x120bbbf93 WebCore::DisplayList::DrawImageBuffer::apply(WebCore::GraphicsContext&) const 4 0x120bbb495 WebCore::DisplayList::ItemHandle::apply(WebCore::GraphicsContext&) 5 0x120bca34d WebCore::DisplayList::Replayer::applyItem(WebCore::DisplayList::ItemHandle) 6 0x120bbaee7 WebCore::DisplayList::Replayer::replay(WebCore::FloatRect const&, bool) 7 0x102b119db TestWebKitAPI::DisplayListTests_ReplayWithMissingResource_Test::TestBody() 8 0x1033f7de4 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 9 0x1033c65ab void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 10 0x1033c64e6 testing::Test::Run() 11 0x1033c767a testing::TestInfo::Run() 12 0x1033c8564 testing::TestCase::Run() 13 0x1033d3c18 testing::internal::UnitTestImpl::RunAllTests() 14 0x1033fcde4 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 15 0x1033d370b bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 16 0x1033d35dd testing::UnitTest::Run() 17 0x103185251 RUN_ALL_TESTS() 18 0x1031851e2 TestWebKitAPI::TestsController::run(int, char**) 19 0x103392d75 main 20 0x7fff6f0a0cc9 start 21 0x2 https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.DisplayListTests.ReplayWithMissingResource 1709225 1 ryanhaddad 2020-11-19 12:30:30 -0800 This test was added with https://trac.webkit.org/changeset/270002/webkit 1709226 2 webkit-bug-importer 2020-11-19 12:31:20 -0800 <rdar://problem/71597208> 1709227 3 wenson_hsieh 2020-11-19 12:31:48 -0800 Whoops, sorry about that! I'll have a fix up soon. 1709258 4 414615 wenson_hsieh 2020-11-19 13:27:01 -0800 Created attachment 414615 Patch 1709274 5 ews-feeder 2020-11-19 14:12:08 -0800 Committed r270051: <https://trac.webkit.org/changeset/270051> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414615. 414615 2020-11-19 13:27:01 -0800 2020-11-19 14:12:08 -0800 Patch bug-219175-20201119132701.patch text/plain 4099 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmVhZjM1MTA0NGVjYTMz NDVhNDA2YWJiMjFkNDMwNTQ5YWIwMjY5Yy4uNzZlODc1M2U0NGY2ZDZlZjY5Nzk5MDYyYzhhMjY5 MzhhYTQzNWE1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTExLTE5ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVCBOT1Qg UkVBQ0hFRCBpbiBXZWJDb3JlOjpEaXNwbGF5TGlzdDo6RHJhd0ltYWdlQnVmZmVyOjphcHBseSBz ZWVuIHdpdGggVGVzdFdlYktpdEFQSS5EaXNwbGF5TGlzdFRlc3RzLlJlcGxheVdpdGhNaXNzaW5n UmVzb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxOTE3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlJ3JlIGN1cnJlbnRseSBoaXR0aW5nIGRlYnVnIGFzc2VydGlvbnMgd2hlbiBhcHBseWluZyBu YXRpdmUgaW1hZ2UgYW5kIGltYWdlIGJ1ZmZlciBkaXNwbGF5IGxpc3QgaXRlbXMgYWZ0ZXIKKyAg ICAgICAgcjI3MDAwMiwgZHVlIHRvIHRoZSBmYWN0IHRoYXQgYGFwcGx5SW1hZ2VCdWZmZXJJdGVt YCBhbmQgYGFwcGx5TmF0aXZlSW1hZ2VJdGVtYCByZXR1cm4gYFdURjo6bnVsbG9wdGAgaW4gdGhl CisgICAgICAgIGNhc2Ugd2hlcmUgdGhlIGltYWdlIHJlc291cmNlcyBhcmUgcHJlc2VudCwgc28g d2UgcHJvY2VlZCBieSBhdHRlbXB0aW5nIHRvIGFwcGx5IHRoZSBpdGVtIHdpdGggb25seSB0aGUg Z3JhcGhpY3MKKyAgICAgICAgY29udGV4dC4KKworICAgICAgICBGaXggdGhpcyBieSBjaGVja2lu ZyB0aGUgaXRlbSB0eXBlIGFuZCBhbHdheXMgcmV0dXJuIGVhcmx5IGFmdGVyIGNhbGxpbmcgZWl0 aGVyIGBhcHBseUltYWdlQnVmZmVySXRlbWAgb3IKKyAgICAgICAgYGFwcGx5TmF0aXZlSW1hZ2VJ dGVtYC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5 TGlzdFJlcGxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXlMaXN0OjphcHBseUlt YWdlQnVmZmVySXRlbSk6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5TGlzdDo6YXBwbHlOYXRp dmVJbWFnZUl0ZW0pOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheUxpc3Q6OlJlcGxheWVyOjph cHBseUl0ZW0pOgorCiAyMDIwLTExLTE4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBw bGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBNZXRhQ29tbWFuZFN3aXRjaFRvIHRvIE1ldGFDb21t YW5kU3dpdGNoVG9JdGVtQnVmZmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RSZXBsYXllci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RSZXBsYXll ci5jcHAKaW5kZXggYjIzNGMwNWE5NDgzNTY1OGU0NzI0NjljMzE0NzM1YjBmN2ZkYTY5ZS4uY2Ex OTg0NWFhZjgwNGUxOTQ4OTlmMDljMmEwNjhiNDYzZWQ1NThmZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0UmVwbGF5 ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0 cy9EaXNwbGF5TGlzdFJlcGxheWVyLmNwcApAQCAtNDgsOCArNDgsNiBAQCBSZXBsYXllcjo6flJl cGxheWVyKCkgPSBkZWZhdWx0OwogdGVtcGxhdGU8Y2xhc3MgVD4KIGlubGluZSBzdGF0aWMgT3B0 aW9uYWw8U3RvcFJlcGxheVJlYXNvbj4gYXBwbHlJbWFnZUJ1ZmZlckl0ZW0oR3JhcGhpY3NDb250 ZXh0JiBjb250ZXh0LCBjb25zdCBJbWFnZUJ1ZmZlckhhc2hNYXAmIGltYWdlQnVmZmVycywgSXRl bUhhbmRsZSBpdGVtKQogewotICAgIGlmICghaXRlbS5pczxUPigpKQotICAgICAgICByZXR1cm4g V1RGOjpudWxsb3B0OwogICAgIGF1dG8mIGltYWdlQnVmZmVySXRlbSA9IGl0ZW0uZ2V0PFQ+KCk7 CiAgICAgaWYgKGF1dG8qIGltYWdlQnVmZmVyID0gaW1hZ2VCdWZmZXJzLmdldChpbWFnZUJ1ZmZl ckl0ZW0uaW1hZ2VCdWZmZXJJZGVudGlmaWVyKCkpKSB7CiAgICAgICAgIGltYWdlQnVmZmVySXRl bS5hcHBseShjb250ZXh0LCAqaW1hZ2VCdWZmZXIpOwpAQCAtNjEsOCArNTksNiBAQCBpbmxpbmUg c3RhdGljIE9wdGlvbmFsPFN0b3BSZXBsYXlSZWFzb24+IGFwcGx5SW1hZ2VCdWZmZXJJdGVtKEdy YXBoaWNzQ29udGV4dCYgYwogdGVtcGxhdGU8Y2xhc3MgVD4KIGlubGluZSBzdGF0aWMgT3B0aW9u YWw8U3RvcFJlcGxheVJlYXNvbj4gYXBwbHlOYXRpdmVJbWFnZUl0ZW0oR3JhcGhpY3NDb250ZXh0 JiBjb250ZXh0LCBjb25zdCBOYXRpdmVJbWFnZUhhc2hNYXAmIG5hdGl2ZUltYWdlcywgSXRlbUhh bmRsZSBpdGVtKQogewotICAgIGlmICghaXRlbS5pczxUPigpKQotICAgICAgICByZXR1cm4gV1RG OjpudWxsb3B0OwogICAgIGF1dG8mIG5hdGl2ZUltYWdlSXRlbSA9IGl0ZW0uZ2V0PFQ+KCk7CiAg ICAgaWYgKGF1dG8qIGltYWdlID0gbmF0aXZlSW1hZ2VzLmdldChuYXRpdmVJbWFnZUl0ZW0uaW1h Z2VJZGVudGlmaWVyKCkpKSB7CiAgICAgICAgIG5hdGl2ZUltYWdlSXRlbS5hcHBseShjb250ZXh0 LCAqaW1hZ2UpOwpAQCAtNzYsMTcgKzcyLDE3IEBAIE9wdGlvbmFsPFN0b3BSZXBsYXlSZWFzb24+ IFJlcGxheWVyOjphcHBseUl0ZW0oSXRlbUhhbmRsZSBpdGVtKQogICAgIGlmIChtX2RlbGVnYXRl ICYmIG1fZGVsZWdhdGUtPmFwcGx5KGl0ZW0sIG1fY29udGV4dCkpCiAgICAgICAgIHJldHVybiBX VEY6Om51bGxvcHQ7CiAKLSAgICBpZiAoYXV0byByZWFzb25Gb3JTdG9wcGluZyA9IGFwcGx5SW1h Z2VCdWZmZXJJdGVtPERyYXdJbWFnZUJ1ZmZlcj4obV9jb250ZXh0LCBtX2ltYWdlQnVmZmVycywg aXRlbSkpCi0gICAgICAgIHJldHVybiByZWFzb25Gb3JTdG9wcGluZzsKKyAgICBpZiAoaXRlbS5p czxEcmF3SW1hZ2VCdWZmZXI+KCkpCisgICAgICAgIHJldHVybiBhcHBseUltYWdlQnVmZmVySXRl bTxEcmF3SW1hZ2VCdWZmZXI+KG1fY29udGV4dCwgbV9pbWFnZUJ1ZmZlcnMsIGl0ZW0pOwogCi0g ICAgaWYgKGF1dG8gcmVhc29uRm9yU3RvcHBpbmcgPSBhcHBseUltYWdlQnVmZmVySXRlbTxDbGlw VG9JbWFnZUJ1ZmZlcj4obV9jb250ZXh0LCBtX2ltYWdlQnVmZmVycywgaXRlbSkpCi0gICAgICAg IHJldHVybiByZWFzb25Gb3JTdG9wcGluZzsKKyAgICBpZiAoaXRlbS5pczxDbGlwVG9JbWFnZUJ1 ZmZlcj4oKSkKKyAgICAgICAgcmV0dXJuIGFwcGx5SW1hZ2VCdWZmZXJJdGVtPENsaXBUb0ltYWdl QnVmZmVyPihtX2NvbnRleHQsIG1faW1hZ2VCdWZmZXJzLCBpdGVtKTsKIAotICAgIGlmIChhdXRv IHJlYXNvbkZvclN0b3BwaW5nID0gYXBwbHlOYXRpdmVJbWFnZUl0ZW08RHJhd05hdGl2ZUltYWdl PihtX2NvbnRleHQsIG1fbmF0aXZlSW1hZ2VzLCBpdGVtKSkKLSAgICAgICAgcmV0dXJuIHJlYXNv bkZvclN0b3BwaW5nOworICAgIGlmIChpdGVtLmlzPERyYXdOYXRpdmVJbWFnZT4oKSkKKyAgICAg ICAgcmV0dXJuIGFwcGx5TmF0aXZlSW1hZ2VJdGVtPERyYXdOYXRpdmVJbWFnZT4obV9jb250ZXh0 LCBtX25hdGl2ZUltYWdlcywgaXRlbSk7CiAKLSAgICBpZiAoYXV0byByZWFzb25Gb3JTdG9wcGlu ZyA9IGFwcGx5TmF0aXZlSW1hZ2VJdGVtPERyYXdQYXR0ZXJuPihtX2NvbnRleHQsIG1fbmF0aXZl SW1hZ2VzLCBpdGVtKSkKLSAgICAgICAgcmV0dXJuIHJlYXNvbkZvclN0b3BwaW5nOworICAgIGlm IChpdGVtLmlzPERyYXdQYXR0ZXJuPigpKQorICAgICAgICByZXR1cm4gYXBwbHlOYXRpdmVJbWFn ZUl0ZW08RHJhd1BhdHRlcm4+KG1fY29udGV4dCwgbV9uYXRpdmVJbWFnZXMsIGl0ZW0pOwogCiAg ICAgaXRlbS5hcHBseShtX2NvbnRleHQpOwogICAgIHJldHVybiBXVEY6Om51bGxvcHQ7Cg==