218923 2020-11-13 15:11:45 -0800 iOS: click event doesn't get dispatched when there is a click event listener on ShadowRoot 2022-07-03 16:37:23 -0700 1 1 1 Unclassified WebKit UI Events Safari 14 iPhone / iPad iOS 13 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198559 https://jsfiddle.net/to2mgsy0/ BrowserCompat, HTML5, InRadar P2 Blocker --- 148695 1 lionel.seguin rniwa cdumez hi rniwa smoley webkit-bug-importer oldest_to_newest 1707404 0 414097 lionel.seguin 2020-11-13 15:11:45 -0800 Created attachment 414097 File to launch on iOS nothing will happen by clicking on "CLICK ME" This issue is happening only on iOS. First you have to create the following DOM (the file attached is doing it): <my-custom-element onclick="alert('CUSTOM BUTTON CLICKED')"> #shadowRoot <span> "button is:" <slot></slot> </span> "Some Text" </my-custom-element> when the dom is created you can add a listener to the shadowRoot like this: ```javascript document.querySelector('my-custom-element') .shadowRoot .addEventListener('click', () => { alert('CLICK EVENT FIRED'); }); ``` now you can press the "span" and you will see no event is fired. There is no alert at all displayed. The issue is related to the listener we have on the shadowRoot. If we don't have it the first listener is working well. Another strange behaviour is if you had an other listener on the "span" like this: ```javascript document.querySelector('my-custom-element') .shadowRoot .querySelector('span') .addEventListener('click', () => { alert('SPAN CLICKED'); }); ``` Now if you press the button the probleme is fixed the 3 handlers are well called as expected. 1707496 1 lionel.seguin 2020-11-14 05:33:25 -0800 The biggest impact of this issue is when a third party script is capturing events coming from a shadow root, it impacts the initial behaviour of the custom component. 1707497 2 lionel.seguin 2020-11-14 05:49:51 -0800 Another information. Attaching any of those events to the shadowRoot will change the initial component behaviour: - mouseover - click - mousedown - mouseup - mousemove 1708071 3 smoley 2020-11-16 18:33:07 -0800 Thanks for filing. I can reproduce this with the provided test case on iOS 13.6.1 and the current iOS 14.3 beta. 1708072 4 webkit-bug-importer 2020-11-16 18:33:16 -0800 <rdar://problem/71468598> 1880408 5 rniwa 2022-07-03 02:11:52 -0700 This was a bizarre bug! It all comes down to WebPage::commitPotentialTap failing to dispatch click event because ShadowRoot doesn't have a renderer. 1880409 6 460637 rniwa 2022-07-03 02:13:32 -0700 Created attachment 460637 WIP 1880431 7 rniwa 2022-07-03 13:36:25 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2043 1880437 8 ews-feeder 2022-07-03 16:37:21 -0700 Committed 252107@main (b01e40564c21): <https://commits.webkit.org/252107@main> Reviewed commits have been landed. Closing PR #2043 and removing active labels. 414097 2020-11-13 15:11:45 -0800 2020-11-13 15:11:45 -0800 File to launch on iOS nothing will happen by clicking on "CLICK ME" safari-ios-bug.html text/html 902 lionel.seguin PGh0bWw+CiAgPGJvZHk+CiAgICA8bXktY3VzdG9tLWJ1dHRvbgogICAgICBvbmNsaWNrPSJhbGVy dCgnWU9VIFNIT1VMRCBTRUUgVEhJUycpIj4KICAgICAgQ0xJQ0sgTUUgKE5PIFRISU5HIFdJTEwg SEFQUEVOIElGIFlPVSBBUkUgVVNJTkcgU0FGQVJJIGlPUykKICAgIDwvbXktY3VzdG9tLWJ1dHRv bj4KICAgIAogICAgPHNjcmlwdD4KICAgICAgLy8gcmVnaXN0ZXIgYSB3ZWJjb21wb25lbnQKICAg ICAgY3VzdG9tRWxlbWVudHMuZGVmaW5lKCdteS1jdXN0b20tYnV0dG9uJywgY2xhc3MgZXh0ZW5k cyBIVE1MRWxlbWVudCB7CiAgICAgICAgY29uc3RydWN0b3IoKSB7CiAgICAgICAgICBzdXBlcigp OwogICAgICAgICAgY29uc3Qgc2hhZG93ID0gdGhpcy5hdHRhY2hTaGFkb3coeyBtb2RlOiAnb3Bl bicgfSk7CiAgICAgICAgICBzaGFkb3cuaW5uZXJIVE1MID0gYDxzcGFuIHN0eWxlPSJiYWNrZ3Jv dW5kLWNvbG9yOiB5ZWxsb3c7Ij5CVVRUT046IDxzbG90PkNsaWNrIGhlcmUhPC9zbG90Pjwvc3Bh bj5gCiAgICAgICAgfQogICAgICB9KTsKCiAgICAgIGNvbnN0IGN1c3RvbUVsZW1lbnQgPSBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yKCdteS1jdXN0b20tYnV0dG9uJyk7CgogICAgICAvLyBhdHRhY2gg YSBsaXN0ZW5lciB0byB0aGUgc2hhZG93Um9vdAogICAgICAvLyB0aGlzIGlzIGludHJvZHVjaW5n IHRoZSBpc3N1ZQogICAgICAvLyBpZiB5b3UgY29tbWVudCBpdCwgaXQgd2lsbCBmaXggdGhlIHBy b2JsZW0KICAgICAgY3VzdG9tRWxlbWVudC5zaGFkb3dSb290LmFkZEV2ZW50TGlzdGVuZXIoJ2Ns aWNrJywgKCkgPT4gewogICAgICAgIGFsZXJ0KCdZT1UgU0hPVUxEIFNFRSBUSElTIEFTIFdFTEwg OiknKTsKICAgICAgfSk7CiAgICA8L3NjcmlwdD4KICA8L2JvZHk+CjwvaHRtbD4= 460637 2022-07-03 02:13:32 -0700 2022-07-03 02:13:32 -0700 WIP wip218923.patch text/plain 1099 rniwa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdl SU9TLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1Mu bW0KaW5kZXggZmIxYzVmOWYwOWFlLi42ODdlNGM0OWRiNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0xMTQwLDcgKzEx NDAsOSBAQCB2b2lkIFdlYlBhZ2U6OmNvbW1pdFBvdGVudGlhbFRhcChPcHRpb25TZXQ8V2ViRXZl bnQ6Ok1vZGlmaWVyPiBtb2RpZmllcnMsIFRyYW5zYQogICAgICAgICBib29sIHRhcmdldFJlbmRl cnMgPSBtX3BvdGVudGlhbFRhcE5vZGUtPnJlbmRlcmVyKCk7CiAgICAgICAgIGlmICghdGFyZ2V0 UmVuZGVycyAmJiBpczxFbGVtZW50PihtX3BvdGVudGlhbFRhcE5vZGUpKQogICAgICAgICAgICAg dGFyZ2V0UmVuZGVycyA9IGRvd25jYXN0PEVsZW1lbnQ+KCptX3BvdGVudGlhbFRhcE5vZGUpLnJl bmRlck9yRGlzcGxheUNvbnRlbnRzU3R5bGUoKTsKLSAgICAgICAgaW52YWxpZFRhcmdldEZvclNp bmdsZUNsaWNrID0gIXRhcmdldFJlbmRlcnMgJiYgIWlzPEhUTUxBcmVhRWxlbWVudD4obV9wb3Rl bnRpYWxUYXBOb2RlKTsKKyAgICAgICAgaWYgKCF0YXJnZXRSZW5kZXJzICYmIGlzPFNoYWRvd1Jv b3Q+KG1fcG90ZW50aWFsVGFwTm9kZSkpCisgICAgICAgICAgICB0YXJnZXRSZW5kZXJzID0gZG93 bmNhc3Q8U2hhZG93Um9vdD4oKm1fcG90ZW50aWFsVGFwTm9kZSkuaG9zdCgpLT5yZW5kZXJPckRp c3BsYXlDb250ZW50c1N0eWxlKCk7CisgICAgICAgIGludmFsaWRUYXJnZXRGb3JTaW5nbGVDbGlj ayA9ICF0YXJnZXRSZW5kZXJzICYmICFpczxIVE1MQXJlYUVsZW1lbnQ+KG1fcG90ZW50aWFsVGFw Tm9kZSkgJiYgIWlzPFNoYWRvd1Jvb3Q+KG1fcG90ZW50aWFsVGFwTm9kZSk7CiAgICAgfQogICAg IGlmIChpbnZhbGlkVGFyZ2V0Rm9yU2luZ2xlQ2xpY2spIHsKICAgICAgICAgY29tbWl0UG90ZW50 aWFsVGFwRmFpbGVkKCk7Cg==