218818 2020-11-11 13:03:05 -0800 [build.webkit.org] Remove obsolete buildHorizon, eventHorizon and logHorizon properties from master_buildbot2.cfg 2021-02-08 07:37:49 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218817 InRadar P2 Normal --- 175056 1 aakash_jain aakash_jain aakash_jain dewei_zhu jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1706584 0 aakash_jain 2020-11-11 13:03:05 -0800 In latest buildbot, buildHorizon, eventHorizon and logHorizon properties are not supported anymore. We should instead use JanitorConfigurator. Reference: http://docs.buildbot.net/1.1.0/manual/installation/nine-upgrade.html#data-lifetime Attempt to use these properties result in following warnings: ConfigWarning: [0.9.0 and later] NOTE: `buildHorizon` is deprecated and ignored They are replaced by util.JanitorConfigurator ConfigWarning: [0.9.0 and later] NOTE: `eventHorizon` is deprecated and ignored They are replaced by util.JanitorConfigurator ConfigWarning: [0.9.0 and later] NOTE: `logHorizon` is deprecated and ignored They are replaced by util.JanitorConfigurator 1706588 1 aakash_jain 2020-11-11 13:10:44 -0800 This is similar to <rdar://problem/32555413>. 1706823 2 413926 aakash_jain 2020-11-12 04:42:32 -0800 Created attachment 413926 Patch 1706858 3 413926 jbedard 2020-11-12 08:45:12 -0800 Comment on attachment 413926 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413926&action=review > Tools/CISupport/build-webkit-org/master_buildbot2.cfg:-42 > -c['buildHorizon'] = 1000 What were we using these for and why are they no longer required? 1706866 4 aakash_jain 2020-11-12 08:55:14 -0800 (In reply to Jonathan Bedard from comment #3) > What were we using these for and why are they no longer required? These were required only for old buildbot. This file is for new buildbot. 1706871 5 jbedard 2020-11-12 09:06:04 -0800 (In reply to Aakash Jain from comment #4) > (In reply to Jonathan Bedard from comment #3) > > What were we using these for and why are they no longer required? > These were required only for old buildbot. This file is for new buildbot. Are they implicitly defined somewhere now? Or something we can't set? buildHorizon sounds like something we would still want to use in some capacity, no? 1706874 6 aakash_jain 2020-11-12 09:13:45 -0800 Will be configuring Janitor in https://bugs.webkit.org/show_bug.cgi?id=218817 1706889 7 ews-feeder 2020-11-12 09:44:16 -0800 Committed r269736: <https://trac.webkit.org/changeset/269736> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413926. 1706891 8 webkit-bug-importer 2020-11-12 09:46:09 -0800 <rdar://problem/71330610> 413926 2020-11-12 04:42:32 -0800 2020-11-12 09:44:16 -0800 Patch bug-218818-20201112074231.patch text/plain 1157 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2OTY5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIwLTExLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gUmVtb3ZlIG9ic29sZXRlIGJ1aWxkSG9y aXpvbiwgZXZlbnRIb3Jpem9uIGFuZCBsb2dIb3Jpem9uIHByb3BlcnRpZXMgZnJvbSBtYXN0ZXJf YnVpbGRib3QyLmNmZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE4ODE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9tYXN0ZXJfYnVpbGRib3QyLmNmZzoK KwogMjAyMC0xMS0xMSAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW2J1aWxkLndlYmtpdC5vcmddIFVwZGF0ZSBDaGVja091dFNvdXJjZSBzdGVwIGZvciBu ZXcgYnVpbGRib3QKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL21hc3Rl cl9idWlsZGJvdDIuY2ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJr aXQtb3JnL21hc3Rlcl9idWlsZGJvdDIuY2ZnCShyZXZpc2lvbiAyNjk2OTkpCisrKyBUb29scy9D SVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9tYXN0ZXJfYnVpbGRib3QyLmNmZwkod29ya2luZyBj b3B5KQpAQCAtMzksOSArMzksNiBAQCBjWydwcm9qZWN0TmFtZSddID0gIldlYktpdCIKIGNbJ3By b2plY3RVUkwnXSA9ICJodHRwczovL3dlYmtpdC5vcmciCiBjWydidWlsZGJvdFVSTCddID0gImh0 dHBzOi8vYnVpbGQud2Via2l0Lm9yZy8iCiAKLWNbJ2J1aWxkSG9yaXpvbiddID0gMTAwMAotY1sn bG9nSG9yaXpvbiddID0gNTAwCi1jWydldmVudEhvcml6b24nXSA9IDIwMAogY1snYnVpbGRDYWNo ZVNpemUnXSA9IDYwCiAKIAo=