218802 2020-11-11 06:39:29 -0800 [build.webkit.org] Update CheckOutSource step for new buildbot 2021-02-08 07:37:49 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 175056 1 aakash_jain aakash_jain jbedard webkit-bug-importer oldest_to_newest 1706441 0 aakash_jain 2020-11-11 06:39:29 -0800 We are planning to upgrade build.webkit.org to latest Buildbot. The base class (SVN) used by CheckOutSource has been moved and modified in new Buildbot. We should update the step accordingly. 1706442 1 413816 aakash_jain 2020-11-11 06:42:23 -0800 Created attachment 413816 Patch 1706476 2 413816 jbedard 2020-11-11 09:09:10 -0800 Comment on attachment 413816 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413816&action=review > Tools/CISupport/build-webkit-org/steps.py:122 > + SVN.__init__(self, **kwargs) Is there a reason we aren't using super? 1706570 3 413851 aakash_jain 2020-11-11 12:19:33 -0800 Created attachment 413851 Patch 1706573 4 aakash_jain 2020-11-11 12:20:11 -0800 (In reply to Jonathan Bedard from comment #2) > Is there a reason we aren't using super? Updated patch uses super. 1706581 5 ews-feeder 2020-11-11 12:57:08 -0800 Committed r269699: <https://trac.webkit.org/changeset/269699> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413851. 1706582 6 webkit-bug-importer 2020-11-11 12:58:21 -0800 <rdar://problem/71295484> 1706825 7 aakash_jain 2020-11-12 05:13:52 -0800 (In reply to Aakash Jain from comment #4) > (In reply to Jonathan Bedard from comment #2) > > Is there a reason we aren't using super? > Updated patch uses super. Actually unit-test (and buildbot checkconfig) on old buildbot/python fails when using super on this class (old-style class) with following error (e.g.: https://ews-build.webkit.org/#/builders/20/builds/34537). File "steps.py", line 145, in __init__ super(CheckOutSource, self).__init__(**kwargs) TypeError: super() argument 1 must be type, not classobj This is because this SVN class in old buildbot is old-style class. See: https://stackoverflow.com/questions/1713038/super-fails-with-error-typeerror-argument-1-must-be-type-not-classobj-when 1706827 8 aakash_jain 2020-11-12 05:18:35 -0800 Committed r269731: <https://trac.webkit.org/changeset/269731> 413816 2020-11-11 06:42:23 -0800 2020-11-11 12:19:31 -0800 Patch bug-218802-20201111094222.patch text/plain 2474 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2OTY4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTExLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVXBkYXRlIENoZWNrT3V0U291cmNlIHN0 ZXAgZm9yIG5ldyBidWlsZGJvdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE4ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVwcy5weToKKyAgICAg ICAgKENoZWNrT3V0U291cmNlKToKKyAgICAgICAgKENoZWNrT3V0U291cmNlLl9faW5pdF9fKToK KwogMjAyMC0xMS0xMCAgTm9hbSBSb3NlbnRoYWwgIDxub2FtQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgY2xlYW51cCBteSB3YXRjaGxpc3QgZW50cmllcy4KSW5kZXg6IFRvb2xz L0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL3N0ZXBzLnB5CShyZXZpc2lvbiAyNjk2ODEpCisr KyBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVwcy5weQkod29ya2luZyBjb3B5 KQpAQCAtMjEsNyArMjEsNyBAQAogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQg T0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCiBmcm9tIGJ1aWxkYm90LnByb2Nl c3MgaW1wb3J0IGJ1aWxkc3RlcCwgZmFjdG9yeSwgcHJvcGVydGllcwotZnJvbSBidWlsZGJvdC5z dGVwcyBpbXBvcnQgbWFzdGVyLCBzaGVsbCwgc291cmNlLCB0cmFuc2ZlciwgdHJpZ2dlcgorZnJv bSBidWlsZGJvdC5zdGVwcyBpbXBvcnQgbWFzdGVyLCBzaGVsbCwgdHJhbnNmZXIsIHRyaWdnZXIK IGZyb20gYnVpbGRib3Quc3RhdHVzLmJ1aWxkZXIgaW1wb3J0IFNVQ0NFU1MsIEZBSUxVUkUsIFdB Uk5JTkdTLCBTS0lQUEVELCBFWENFUFRJT04KIAogZnJvbSB0d2lzdGVkLmludGVybmV0IGltcG9y dCBkZWZlcgpAQCAtNDMsNiArNDMsOSBAQCBVU0VfQlVJTERCT1RfVkVSU0lPTjIgPSBvcy5nZXRl bnYoJ1VTRV9CCiBXaXRoUHJvcGVydGllcyA9IHByb3BlcnRpZXMuV2l0aFByb3BlcnRpZXMKIGlm IFVTRV9CVUlMREJPVF9WRVJTSU9OMjoKICAgICBJbnRlcnBvbGF0ZSA9IHByb3BlcnRpZXMuSW50 ZXJwb2xhdGUKKyAgICBmcm9tIGJ1aWxkYm90LnN0ZXBzLnNvdXJjZS5zdm4gaW1wb3J0IFNWTgor ZWxzZToKKyAgICBmcm9tIGJ1aWxkYm90LnN0ZXBzLnNvdXJjZSBpbXBvcnQgU1ZOCiAKIGNsYXNz IFRlc3RXaXRoRmFpbHVyZUNvdW50KHNoZWxsLlRlc3QpOgogICAgIGZhaWxlZFRlc3RzRm9ybWF0 U3RyaW5nID0gIiVkIHRlc3QlcyBmYWlsZWQiCkBAIC0xMDcsMTQgKzExMCwxNiBAQCBjbGFzcyBD b25maWd1cmVCdWlsZChidWlsZHN0ZXAuQnVpbGRTdGVwCiAgICAgICAgIHJldHVybiBkZWZlci5z dWNjZWVkKE5vbmUpCiAKIAotY2xhc3MgQ2hlY2tPdXRTb3VyY2Uoc291cmNlLlNWTik6Ci0gICAg bW9kZSA9ICJ1cGRhdGUiCi0KK2NsYXNzIENoZWNrT3V0U291cmNlKFNWTik6CiAgICAgZGVmIF9f aW5pdF9fKHNlbGYsICoqa3dhcmdzKToKLSAgICAgICAga3dhcmdzWydiYXNlVVJMJ10gPSAiaHR0 cHM6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdC8iCi0gICAgICAgIGt3YXJnc1sn ZGVmYXVsdEJyYW5jaCddID0gInRydW5rIgotICAgICAgICBrd2FyZ3NbJ21vZGUnXSA9IHNlbGYu bW9kZQotICAgICAgICBzb3VyY2UuU1ZOLl9faW5pdF9fKHNlbGYsICoqa3dhcmdzKQorICAgICAg ICBpZiBVU0VfQlVJTERCT1RfVkVSU0lPTjI6CisgICAgICAgICAgICBrd2FyZ3NbJ3JlcG91cmwn XSA9ICdodHRwczovL3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0L3RydW5rJworICAg ICAgICAgICAga3dhcmdzWydtb2RlJ10gPSAnaW5jcmVtZW50YWwnCisgICAgICAgIGVsc2U6Cisg ICAgICAgICAgICBrd2FyZ3NbJ2Jhc2VVUkwnXSA9ICJodHRwczovL3N2bi53ZWJraXQub3JnL3Jl cG9zaXRvcnkvd2Via2l0LyIKKyAgICAgICAgICAgIGt3YXJnc1snZGVmYXVsdEJyYW5jaCddID0g InRydW5rIgorICAgICAgICAgICAga3dhcmdzWydtb2RlJ10gPSAndXBkYXRlJworICAgICAgICBT Vk4uX19pbml0X18oc2VsZiwgKiprd2FyZ3MpCiAKIAogY2xhc3MgSW5zdGFsbFdpbjMyRGVwZW5k ZW5jaWVzKHNoZWxsLkNvbXBpbGUpOgo= 413851 2020-11-11 12:19:33 -0800 2020-11-11 12:57:08 -0800 Patch bug-218802-20201111151932.patch text/plain 2550 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2OTY5MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTExLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVXBkYXRlIENoZWNrT3V0U291cmNlIHN0 ZXAgZm9yIG5ldyBidWlsZGJvdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE4ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9uYXRoYW4gQmVkYXJk LgorCisgICAgICAgICogQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvc3RlcHMucHk6CisgICAg ICAgIChDaGVja091dFNvdXJjZSk6CisgICAgICAgIChDaGVja091dFNvdXJjZS5fX2luaXRfXyk6 CisKIDIwMjAtMTEtMTEgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFtidWlsZC53ZWJraXQub3JnXSBVcGRhdGUgUnVuV2ViS2l0VGVzdHMgc3RlcCBmb3Ig bmV3IGJ1aWxkYm90CkluZGV4OiBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVw cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVw cy5weQkocmV2aXNpb24gMjY5NjkyKQorKysgVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1v cmcvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTIxLDcgKzIxLDcgQEAKICMgT0YgVEhJUyBT T0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH RS4KIAogZnJvbSBidWlsZGJvdC5wcm9jZXNzIGltcG9ydCBidWlsZHN0ZXAsIGZhY3RvcnksIHBy b3BlcnRpZXMKLWZyb20gYnVpbGRib3Quc3RlcHMgaW1wb3J0IG1hc3Rlciwgc2hlbGwsIHNvdXJj ZSwgdHJhbnNmZXIsIHRyaWdnZXIKK2Zyb20gYnVpbGRib3Quc3RlcHMgaW1wb3J0IG1hc3Rlciwg c2hlbGwsIHRyYW5zZmVyLCB0cmlnZ2VyCiBmcm9tIGJ1aWxkYm90LnN0YXR1cy5idWlsZGVyIGlt cG9ydCBTVUNDRVNTLCBGQUlMVVJFLCBXQVJOSU5HUywgU0tJUFBFRCwgRVhDRVBUSU9OCiAKIGZy b20gdHdpc3RlZC5pbnRlcm5ldCBpbXBvcnQgZGVmZXIKQEAgLTQ0LDcgKzQ0LDkgQEAgV2l0aFBy b3BlcnRpZXMgPSBwcm9wZXJ0aWVzLldpdGhQcm9wZXJ0aQogaWYgVVNFX0JVSUxEQk9UX1ZFUlNJ T04yOgogICAgIEludGVycG9sYXRlID0gcHJvcGVydGllcy5JbnRlcnBvbGF0ZQogICAgIGZyb20g YnVpbGRib3QucHJvY2VzcyBpbXBvcnQgbG9nb2JzZXJ2ZXIKKyAgICBmcm9tIGJ1aWxkYm90LnN0 ZXBzLnNvdXJjZS5zdm4gaW1wb3J0IFNWTgogZWxzZToKKyAgICBmcm9tIGJ1aWxkYm90LnN0ZXBz LnNvdXJjZSBpbXBvcnQgU1ZOCiAgICAgbG9nb2JzZXJ2ZXIgPSBsYW1iZGE6IE5vbmUKICAgICBs b2dvYnNlcnZlci5MaW5lQ29uc3VtZXJMb2dPYnNlcnZlciA9IHR5cGUoJ0xpbmVDb25zdW1lckxv Z09ic2VydmVyJywgKG9iamVjdCwpLCB7fSkKIApAQCAtMTMxLDE0ICsxMzMsMTYgQEAgY2xhc3Mg Q29uZmlndXJlQnVpbGQoYnVpbGRzdGVwLkJ1aWxkU3RlcAogICAgICAgICByZXR1cm4gZGVmZXIu c3VjY2VlZChOb25lKQogCiAKLWNsYXNzIENoZWNrT3V0U291cmNlKHNvdXJjZS5TVk4pOgotICAg IG1vZGUgPSAidXBkYXRlIgotCitjbGFzcyBDaGVja091dFNvdXJjZShTVk4pOgogICAgIGRlZiBf X2luaXRfXyhzZWxmLCAqKmt3YXJncyk6Ci0gICAgICAgIGt3YXJnc1snYmFzZVVSTCddID0gImh0 dHBzOi8vc3ZuLndlYmtpdC5vcmcvcmVwb3NpdG9yeS93ZWJraXQvIgotICAgICAgICBrd2FyZ3Nb J2RlZmF1bHRCcmFuY2gnXSA9ICJ0cnVuayIKLSAgICAgICAga3dhcmdzWydtb2RlJ10gPSBzZWxm Lm1vZGUKLSAgICAgICAgc291cmNlLlNWTi5fX2luaXRfXyhzZWxmLCAqKmt3YXJncykKKyAgICAg ICAgaWYgVVNFX0JVSUxEQk9UX1ZFUlNJT04yOgorICAgICAgICAgICAga3dhcmdzWydyZXBvdXJs J10gPSAnaHR0cHM6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdC90cnVuaycKKyAg ICAgICAgICAgIGt3YXJnc1snbW9kZSddID0gJ2luY3JlbWVudGFsJworICAgICAgICBlbHNlOgor ICAgICAgICAgICAga3dhcmdzWydiYXNlVVJMJ10gPSAiaHR0cHM6Ly9zdm4ud2Via2l0Lm9yZy9y ZXBvc2l0b3J5L3dlYmtpdC8iCisgICAgICAgICAgICBrd2FyZ3NbJ2RlZmF1bHRCcmFuY2gnXSA9 ICJ0cnVuayIKKyAgICAgICAgICAgIGt3YXJnc1snbW9kZSddID0gJ3VwZGF0ZScKKyAgICAgICAg c3VwZXIoQ2hlY2tPdXRTb3VyY2UsIHNlbGYpLl9faW5pdF9fKCoqa3dhcmdzKQogCiAKIGNsYXNz IEluc3RhbGxXaW4zMkRlcGVuZGVuY2llcyhzaGVsbC5Db21waWxlKToK