218594 2020-11-04 16:47:57 -0800 [iOS] Remove redundant rule for shared-preference.read-write 2020-11-05 09:36:53 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham pvollan webkit-bug-importer oldest_to_newest 1704665 0 bfulgham 2020-11-04 16:47:57 -0800 We have long had a rule to allow shared preferences to be read and written if a particular sandbox extension was granted. However, we do not issue this extension, so the rule is unnecessary. We should remove it to reduce confusion, and make the sandbox smaller (and quicker to compile). 1704666 1 bfulgham 2020-11-04 16:50:23 -0800 <rdar://problem/66581796> 1704667 2 413225 bfulgham 2020-11-04 16:50:57 -0800 Created attachment 413225 Patch 1704686 3 413225 pvollan 2020-11-04 17:29:38 -0800 Comment on attachment 413225 Patch R=me. 1704905 4 ews-feeder 2020-11-05 09:36:52 -0800 Committed r269443: <https://trac.webkit.org/changeset/269443> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413225. 413225 2020-11-04 16:50:57 -0800 2020-11-05 09:36:53 -0800 Patch bug-218594-20201104165056.patch text/plain 3780 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzODhiOWMzYTJhZGE3MTk4 MDJhOTEyN2Y1YTYwNWE1OWY5OGEwODIuLjhjNWQ3NjU1YWI3YTE1NjkyYTdmOTA2NmMxZGQ0NjIy NjljMjNjYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMTEtMDQgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVtb3ZlIHJlZHVu ZGFudCBydWxlIGZvciBzaGFyZWQtcHJlZmVyZW5jZS5yZWFkLXdyaXRlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTg1OTQKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzY2NTgxNzk2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlIGhhdmUgbG9uZyBoYWQgYSBydWxlIHRvIGFsbG93IHNoYXJlZCBwcmVm ZXJlbmNlcyB0byBiZSByZWFkIGFuZCB3cml0dGVuIGlmIGEKKyAgICAgICAgcGFydGljdWxhciBz YW5kYm94IGV4dGVuc2lvbiB3YXMgZ3JhbnRlZCB0byB0aGUgcHJvY2Vzcy4gSG93ZXZlciwgd2Ug ZG8gbm90IGlzc3VlCisgICAgICAgIHRoaXMgZXh0ZW5zaW9uIHRvIGFueSBXZWJLaXQgcHJvY2Vz cywgc28gdGhlIHJ1bGUgaXMgdW5uZWNlc3NhcnkuCisKKyAgICAgICAgV2Ugc2hvdWxkIHJlbW92 ZSBpdCB0byByZWR1Y2UgY29uZnVzaW9uLCBhbmQgbWFrZSB0aGUgc2FuZGJveCBzbWFsbGVyIChh bmQgcXVpY2tlcgorICAgICAgICB0byBjb21waWxlKS4KKworICAgICAgICAqIFJlc291cmNlcy9T YW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiOgorICAgICAgICAqIFJl c291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5z YjoKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2Vi S2l0LldlYkNvbnRlbnQuc2I6CisKIDIwMjAtMTEtMDMgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hh bUBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSByZW1vdmUgc3lzY3RsLm9pZGZtdC4gYWNj ZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMv aW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2Fu ZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQVS5zYgppbmRleCA2ZTk5Y2Y2MThm NjIzNTRkOWUyMzc0ODA3NDdmMDFjMjliNDc1NGFlLi5kMzA0Y2Q2M2ZhZmRmZGRjMmYwMGIyMzll MGI1ZDdiMzJlZmQ3NmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5k Ym94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiCisrKyBiL1NvdXJjZS9XZWJL aXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5HUFUuc2IK QEAgLTU0MCw4ICs1NDAsNiBAQAogICAgICAgICAgICAoZXh0ZW5zaW9uICJjb20uYXBwbGUuc2Vj dXJpdHkuZXhjZXB0aW9uLm1hbmFnZWQtcHJlZmVyZW5jZS5yZWFkLW9ubHkiKSkKICAgICAoYWxs b3cgdXNlci1wcmVmZXJlbmNlLXJlYWQKICAgICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFwcGxl LnNlY3VyaXR5LmV4Y2VwdGlvbi5zaGFyZWQtcHJlZmVyZW5jZS5yZWFkLW9ubHkiKSkKLSAgICAo YWxsb3cgdXNlci1wcmVmZXJlbmNlLXJlYWQgdXNlci1wcmVmZXJlbmNlLXdyaXRlCi0gICAgICAg ICAgIChleHRlbnNpb24gImNvbS5hcHBsZS5zZWN1cml0eS5leGNlcHRpb24uc2hhcmVkLXByZWZl cmVuY2UucmVhZC13cml0ZSIpKQogCiAgICAgKGFsbG93IGZpbGUtaXNzdWUtZXh0ZW5zaW9uCiAg ICAgICAgICAgKHJlcXVpcmUtYWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNl cy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYiBiL1Nv dXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5OZXR3b3JraW5nLnNiCmluZGV4IDY3ZWFjNjM5MDAwOWNmOGE3MDMzYmIyOTJlZjlhZjMwMWQw ZTA5Y2EuLmUzMWUyZTUxM2NmYTRkNzBhOGE0MjI4N2Q0NDlkNTRkMTE0ZGU3YmMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxl LldlYktpdC5OZXR3b3JraW5nLnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRi b3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCkBAIC0zODMsOCAr MzgzLDYgQEAKICAgICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFwcGxlLnNlY3VyaXR5LmV4Y2Vw dGlvbi5tYW5hZ2VkLXByZWZlcmVuY2UucmVhZC1vbmx5IikpCiAgICAgKGFsbG93IHVzZXItcHJl ZmVyZW5jZS1yZWFkCiAgICAgICAgICAgIChleHRlbnNpb24gImNvbS5hcHBsZS5zZWN1cml0eS5l eGNlcHRpb24uc2hhcmVkLXByZWZlcmVuY2UucmVhZC1vbmx5IikpCi0gICAgKGFsbG93IHVzZXIt cHJlZmVyZW5jZS1yZWFkIHVzZXItcHJlZmVyZW5jZS13cml0ZQotICAgICAgICAgICAoZXh0ZW5z aW9uICJjb20uYXBwbGUuc2VjdXJpdHkuZXhjZXB0aW9uLnNoYXJlZC1wcmVmZXJlbmNlLnJlYWQt d3JpdGUiKSkKICAgICAoYWxsb3cgc3lzY3RsLXJlYWQKICAgICAgICAgICAgKGV4dGVuc2lvbiAi Y29tLmFwcGxlLnNlY3VyaXR5LmV4Y2VwdGlvbi5zeXNjdGwucmVhZC1vbmx5IikpCiAgICAgKGFs bG93IHN5c2N0bC1yZWFkIHN5c2N0bC13cml0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9S ZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQu c2IgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBs ZS5XZWJLaXQuV2ViQ29udGVudC5zYgppbmRleCA5YjQzOGJjYmNjM2NmM2YxMzdkZTI4NTg0MmU4 ZDFkOGU3N2M3OTE4Li5iN2VkMjY5ZmJiMjdlMjYzNzM4OWRiYmQwYTdlY2VkYzI1MWRmZDE2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2Nv bS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgorKysgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNl cy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgpAQCAt NTc5LDggKzU3OSw2IEBACiAgICAgICAgICAgIChleHRlbnNpb24gImNvbS5hcHBsZS5zZWN1cml0 eS5leGNlcHRpb24ubWFuYWdlZC1wcmVmZXJlbmNlLnJlYWQtb25seSIpKQogICAgIChhbGxvdyB1 c2VyLXByZWZlcmVuY2UtcmVhZAogICAgICAgICAgICAoZXh0ZW5zaW9uICJjb20uYXBwbGUuc2Vj dXJpdHkuZXhjZXB0aW9uLnNoYXJlZC1wcmVmZXJlbmNlLnJlYWQtb25seSIpKQotICAgIChhbGxv dyB1c2VyLXByZWZlcmVuY2UtcmVhZCB1c2VyLXByZWZlcmVuY2Utd3JpdGUKLSAgICAgICAgICAg KGV4dGVuc2lvbiAiY29tLmFwcGxlLnNlY3VyaXR5LmV4Y2VwdGlvbi5zaGFyZWQtcHJlZmVyZW5j ZS5yZWFkLXdyaXRlIikpCiAKICAgICAoYWxsb3cgZmlsZS1pc3N1ZS1leHRlbnNpb24KICAgICAg ICAgICAocmVxdWlyZS1hbGwK