218253 2020-10-27 11:59:36 -0700 REGRESSION (r268897): [macOS WK1] inspector/cpu-profiler/threads.html is a flaky failure 2020-11-03 10:11:49 -0800 1 1 1 Unclassified WebKit Web Inspector Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218051 https://bugs.webkit.org/show_bug.cgi?id=217724 InRadar P2 Normal --- 1 ryanhaddad cdumez bburg cdumez darin ggaren hi inspector-bugzilla-changes joepeck nvasilyev webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1702013 0 ryanhaddad 2020-10-27 11:59:36 -0700 inspector/cpu-profiler/threads.html has become a flaky failure on macOS WK1 bots --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/inspector/cpu-profiler/threads-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/inspector/cpu-profiler/threads-actual.txt @@ -13,10 +13,16 @@ PASS: Event should have threads. PASS: Every thread has between 0 and 100 usage. PASS: Event should have 1 main thread. -PASS: Event should have 2 worker threads. +FAIL: Event should have 2 worker threads. + Expected: 2 + Actual: 7 PASS: Event should have other worker threads. -PASS: Worker 1 usage should be greater than zero. -PASS: Worker 2 usage should be greater than zero. +FAIL: Worker 1 usage should be greater than zero. + Expected: greater than 0 + Actual: 0 +FAIL: Worker 2 usage should be greater than zero. + Expected: greater than 0 + Actual: 0 PASS: Total usage should be greater than or equal to the sum of both worker threads. CPUProfiler.trackingComplete https://results.webkit.org/?suite=layout-tests&test=inspector%2Fcpu-profiler%2Fthreads.html 1702015 1 ryanhaddad 2020-10-27 12:00:10 -0700 It looks like this started after https://trac.webkit.org/changeset/268897/webkit landed 1702016 2 webkit-bug-importer 2020-10-27 12:00:36 -0700 <rdar://problem/70732755> 1702542 3 ryanhaddad 2020-10-28 16:11:02 -0700 I have not yet been able to reproduce this locally by running this test alone in iterations. 1703568 4 412936 cdumez 2020-11-02 10:01:46 -0800 Created attachment 412936 Patch 1703577 5 412936 ggaren 2020-11-02 10:19:48 -0800 Comment on attachment 412936 Patch r=me I kinda wish there were a thread.type for worker (and perhaps a distinct thread.type for ServiceWorker). 1703609 6 ews-feeder 2020-11-02 11:13:16 -0800 Committed r269257: <https://trac.webkit.org/changeset/269257> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412936. 1704054 7 412936 joepeck 2020-11-03 10:09:46 -0800 Comment on attachment 412936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412936&action=review > LayoutTests/ChangeLog:10 > + Check the thread name to identify the 2 worker threads. This is needed so that worklet thread are > + not identified as worker threads after r268897. Should we be identifying Worklet threads and have inspector tests for that? 1704055 8 cdumez 2020-11-03 10:11:49 -0800 (In reply to Joseph Pecoraro from comment #7) > Comment on attachment 412936 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412936&action=review > > > LayoutTests/ChangeLog:10 > > + Check the thread name to identify the 2 worker threads. This is needed so that worklet thread are > > + not identified as worker threads after r268897. > > Should we be identifying Worklet threads and have inspector tests for that? Probably? Web Inspector support for AudioWorklet is still mostly missing: https://bugs.webkit.org/show_bug.cgi?id=217724 412936 2020-11-02 10:01:46 -0800 2020-11-02 11:13:16 -0800 Patch bug-218253-20201102100145.patch text/plain 1669 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MjQ5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDU2MjQ1ZGM4MjE2ODA0NGU0ZTZl ZjFmOTQ0OTRhMTQ0Y2Q3Yzg0My4uYTNhOGE1NTRkYjU1OTM1Zjk1MDFhYTkxYmMwZmE5MjEyZjJi ZTZjYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTExLTAyICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI2ODg5Nyk6IFttYWNPUyBX SzFdIGluc3BlY3Rvci9jcHUtcHJvZmlsZXIvdGhyZWFkcy5odG1sIGlzIGEgZmxha3kgZmFpbHVy ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4MjUz CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDczMjc1NT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayB0aGUgdGhyZWFkIG5hbWUgdG8gaWRl bnRpZnkgdGhlIDIgd29ya2VyIHRocmVhZHMuIFRoaXMgaXMgbmVlZGVkIHNvIHRoYXQgd29ya2xl dCB0aHJlYWQgYXJlCisgICAgICAgIG5vdCBpZGVudGlmaWVkIGFzIHdvcmtlciB0aHJlYWRzIGFm dGVyIHIyNjg4OTcuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvY3B1LXByb2ZpbGVyL3RocmVhZHMu aHRtbDoKKwogMjAyMC0xMS0wMiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dMSUJdIFJFR1JFU1NJT04ocjI2OTE0NCkgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3Nzb20tdmlldy9zY3JvbGxJbnRvVmlldy1zY3JvbGxNYXJn aW4uaHRtbCBpcyBmYWlsaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY3B1 LXByb2ZpbGVyL3RocmVhZHMuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jcHUtcHJvZmls ZXIvdGhyZWFkcy5odG1sCmluZGV4IDM2NWQwNzQwZWY2ZDhhZDFhOWE5ZGMyYTI4OGEzN2Q4NDVk YjBkMzUuLjM2MzUwN2IwZjA0ZmExM2ZkZWE0ODAwMDNkMmY4MmM5YTMxMWU3NTkgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jcHUtcHJvZmlsZXIvdGhyZWFkcy5odG1sCisrKyBi L0xheW91dFRlc3RzL2luc3BlY3Rvci9jcHUtcHJvZmlsZXIvdGhyZWFkcy5odG1sCkBAIC0zNiw3 ICszNiw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgICAgIGZvciAobGV0IHRocmVh ZCBvZiB0aHJlYWRzKSB7CiAgICAgICAgICAgICAgICAgICAgIGlmICh0aHJlYWQudHlwZSA9PT0g Im1haW4iKQogICAgICAgICAgICAgICAgICAgICAgICAgbWFpbi5wdXNoKHRocmVhZCk7Ci0gICAg ICAgICAgICAgICAgICAgIGVsc2UgaWYgKHRocmVhZC50YXJnZXRJZCkKKyAgICAgICAgICAgICAg ICAgICAgZWxzZSBpZiAodGhyZWFkLnRhcmdldElkICYmIHRocmVhZC5uYW1lID09ICJXZWJDb3Jl OiBXb3JrZXIiKQogICAgICAgICAgICAgICAgICAgICAgICAgd29ya2Vycy5wdXNoKHRocmVhZCk7 CiAgICAgICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgICAgIG90aGVy cy5wdXNoKHRocmVhZCk7Cg==