218235 2020-10-27 08:21:08 -0700 AudioContext.suspend() should not reject promise when audio session is interrupted 2020-10-27 08:27:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 217606 1 cdumez cdumez eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1701877 0 cdumez 2020-10-27 08:21:08 -0700 AudioContext.suspend() should not reject promise when audio session is interrupted. Being "interrupted" is an internal WebKit concept and rejecting the promise here is confusing to Web developers. 1701878 1 412423 cdumez 2020-10-27 08:24:54 -0700 Created attachment 412423 Patch 1701879 2 412423 cdumez 2020-10-27 08:26:09 -0700 Comment on attachment 412423 Patch Clearing flags on attachment: 412423 Committed r269039: <https://trac.webkit.org/changeset/269039> 1701880 3 cdumez 2020-10-27 08:26:11 -0700 All reviewed patches have been landed. Closing bug. 1701881 4 webkit-bug-importer 2020-10-27 08:27:18 -0700 <rdar://problem/70722668> 412423 2020-10-27 08:24:54 -0700 2020-10-27 08:26:09 -0700 Patch bug-218235-20201027082454.patch text/plain 6960 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2YyMjc0NDI3YzAyZjA3 OTllOGVlNjJmMGEwMGI3N2RkYmVjODZkZC4uNjQ5MzM1NTdmODRkMzBkMmY3ZmI2NzQ4YjIyZjA1 OWU2ZGFiYjQ5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIwLTEwLTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXVkaW9Db250ZXh0LnN1c3Bl bmQoKSBzaG91bGQgbm90IHJlamVjdCBwcm9taXNlIHdoZW4gYXVkaW8gc2Vzc2lvbiBpcyBpbnRl cnJ1cHRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE4MjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQXVk aW9Db250ZXh0LnN1c3BlbmQoKSBzaG91bGQgbm90IHJlamVjdCBwcm9taXNlIHdoZW4gYXVkaW8g c2Vzc2lvbiBpcyBpbnRlcnJ1cHRlZC4gQmVpbmcKKyAgICAgICAgImludGVycnVwdGVkIiBpcyBh biBpbnRlcm5hbCBXZWJLaXQgY29uY2VwdCBhbmQgcmVqZWN0aW5nIHRoZSBwcm9taXNlIGhlcmUg aXMgY29uZnVzaW5nCisgICAgICAgIHRvIFdlYiBkZXZlbG9wZXJzLgorCisgICAgICAgIFdlIG5v dyBubyBsb25nZXIgdGhyb3cgd2hlbiBBdWRpb0NvbnRleHQuc3VzcGVuZCgpIGlzIGNhbGxlZCB3 aGlsZSBpbnRlcnJ1cHRlZC4gSW5zdGVhZCwKKyAgICAgICAgd2Ugc2V0IHRoZSAnd2FzU3VzcGVu ZGVkQnlKYXZhc2NyaXB0JyBmbGFnIGFuZCByZWdpc3RlciBhIHN0YXRlIGNoYW5nZSBsaXN0ZW5l ciB0byByZXNvbHZlCisgICAgICAgIHRoZSBwcm9taXNlIHdoZW4gdGhlIHN0YXRlIGNoYW5nZXMg dG8gInN1c3BlbmRlZCIuCisKKyAgICAgICAgV2hlbiB0aGUgaW50ZXJydXB0aW9uIGVuZHMsIEF1 ZGlvQ29udGV4dDo6bWF5UmVzdW1lUGxheWJhY2soKSBnZXRzIGNhbGxlZCB3aXRoCisgICAgICAg IHNob3VsZFJlc3VtZT1mYWxzZSwgY2F1c2luZyB1cyB0byB1cGRhdGUgdGhlIHN0YXRlIGZyb20g ImludGVycnVwdGVkIiB0byAic3VzcGVuZGVkIiwKKyAgICAgICAgd2hpY2ggcmVzb2x2ZXMgdGhl IHN1c3BlbmQgcHJvbWlzZS4KKworICAgICAgICBUZXN0OiB3ZWJhdWRpby9zdXNwZW5kLWNvbnRl eHQtd2hpbGUtaW50ZXJydXB0ZWQuaHRtbAorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9B dWRpb0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0OjpzdXNwZW5k UmVuZGVyaW5nKToKKwogMjAyMC0xMC0yNyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5j b20+CiAKICAgICAgICAgQXNzZXJ0IGluIEJveFRyZWU6OmxheW91dEJveEZvclJlbmRlcmVyKCkg dW5kZXIgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbENvcm5lclN0eWxlKCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcAppbmRleCAxYTM4NjI0 YWRjY2QyZjdkODdhMmZlNDhmZmE2YmZjMDhjYzk0ZTVkLi4yNWUyZjI5YWUwZTNhMjU0MjZhM2Q0 M2NkNzY4MjYzMjkxZGRlOTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJh dWRpby9BdWRpb0NvbnRleHQuY3BwCkBAIC0yMDksNyArMjA5LDcgQEAgdm9pZCBBdWRpb0NvbnRl eHQ6OnN1c3BlbmRSZW5kZXJpbmcoRE9NUHJvbWlzZURlZmVycmVkPHZvaWQ+JiYgcHJvbWlzZSkK ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmIChpc1N0b3BwZWQoKSB8fCBzdGF0ZSgp ID09IFN0YXRlOjpDbG9zZWQgfHwgc3RhdGUoKSA9PSBTdGF0ZTo6SW50ZXJydXB0ZWQgfHwgIWRl c3RpbmF0aW9uTm9kZSgpKSB7CisgICAgaWYgKGlzU3RvcHBlZCgpIHx8IHN0YXRlKCkgPT0gU3Rh dGU6OkNsb3NlZCB8fCAhZGVzdGluYXRpb25Ob2RlKCkpIHsKICAgICAgICAgcHJvbWlzZS5yZWpl Y3QoRXhjZXB0aW9uIHsgSW52YWxpZFN0YXRlRXJyb3IsICJDb250ZXh0IGlzIGNsb3NlZCJfcyB9 KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0YTIwNmViNmI0OGE1N2NlOTg1MThm M2UwYjlhYTk4NmQ2YjYxNTgyLi4yMGUxY2NiMDQxZjlmMDUwNTVkMDMxNmMwNjJlMjdkYzU3ZWJh MWM4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMTAtMjcgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBdWRpb0NvbnRleHQuc3VzcGVuZCgpIHNob3VsZCBu b3QgcmVqZWN0IHByb21pc2Ugd2hlbiBhdWRpbyBzZXNzaW9uIGlzIGludGVycnVwdGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgyMzUKKworICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBBZGQgbGF5b3V0IHRlc3Qg Y292ZXJhZ2UuCisKKyAgICAgICAgKiB3ZWJhdWRpby9zdXNwZW5kLWNvbnRleHQtd2hpbGUtaW50 ZXJydXB0ZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiB3ZWJhdWRpby9zdXNwZW5k LWNvbnRleHQtd2hpbGUtaW50ZXJydXB0ZWQuaHRtbDogQWRkZWQuCisKIDIwMjAtMTAtMjcgIFph bGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW5uZWVkZWQg d2hpdGVzcGFjZSBiZXR3ZWVuIGNvbnRlbnQgYW5kIDxicj4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3dlYmF1ZGlvL3N1c3BlbmQtY29udGV4dC13aGlsZS1pbnRlcnJ1cHRlZC1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9zdXNwZW5kLWNvbnRleHQtd2hpbGUtaW50ZXJydXB0 ZWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk2YmU3Y2EyZDMzOWQ5NDZiOWQ1MmNkNDNiMjUz MDBiYmQwM2E4OTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9zdXNw ZW5kLWNvbnRleHQtd2hpbGUtaW50ZXJydXB0ZWQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjUg QEAKK1Rlc3RzIHRoYXQgbWVkaWEgc2Vzc2lvbiBpbnRlcnJ1cHRpb24gZG9lcyBub3QgY2F1c2Ug QXVkaW9Db250ZXh0LnN1c3BlbmQoKSB0byB0aHJvdworCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCisKKworUEFTUyBEaWQgc3RhcnQgcmVuZGVyaW5nCitpbnRlcm5hbHMuYmVnaW5NZWRpYVNl c3Npb25JbnRlcnJ1cHRpb24oJ2VudGVyaW5nYmFja2dyb3VuZCcpCitQQVNTIERpZCBiZWdpbiBp bnRlcnJ1cHRpb24KK1BBU1MgY29udGV4dC5zdGF0ZSBpcyAiaW50ZXJydXB0ZWQiCitQQVNTIGNv bnRleHQuc3RhdGUgaXMgImludGVycnVwdGVkIgorUEFTUyBkaWRSZXNvbHZlU3VzcGVuZFByb21p c2UgaXMgZmFsc2UKK1BBU1MgY29udGV4dC5zdGF0ZSBpcyAiaW50ZXJydXB0ZWQiCitQQVNTIGRp ZFJlc29sdmVTdXNwZW5kUHJvbWlzZSBpcyBmYWxzZQoraW50ZXJuYWxzLmVuZE1lZGlhU2Vzc2lv bkludGVycnVwdGlvbignbWF5cmVzdW1lcGxheWluZycpCitQQVNTIGNvbnRleHQuc3VzcGVuZCgp IHByb21pc2Ugd2FzIHJlc29sdmVkCitQQVNTIERpZCBlbmQgaW50ZXJydXB0aW9uCitQQVNTIGNv bnRleHQuc3RhdGUgaXMgInN1c3BlbmRlZCIKK1BBU1MgZGlkUmVzb2x2ZVN1c3BlbmRQcm9taXNl IGlzIHRydWUKK1BBU1MgY29udGV4dC5zdGF0ZSBpcyAic3VzcGVuZGVkIgorUEFTUyByZXN1bWUo KSBwcm9taXNlIHdhcyByZXNvbHZlZAorUEFTUyBjb250ZXh0LnN0YXRlIGlzICJydW5uaW5nIgor UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL3N1c3BlbmQtY29udGV4dC13aGlsZS1pbnRlcnJ1 cHRlZC5odG1sIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vc3VzcGVuZC1jb250ZXh0LXdoaWxlLWlu dGVycnVwdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDY3ZDVjNDM5ODViNmU0MDQ0NTA0MzAwYzdiZjEw MmY0NDA0ZjE5YwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL3N1c3Bl bmQtY29udGV4dC13aGlsZS1pbnRlcnJ1cHRlZC5odG1sCkBAIC0wLDAgKzEsNzQgQEAKKzwhRE9D VFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMt dGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIHRoYXQgbWVk aWEgc2Vzc2lvbiBpbnRlcnJ1cHRpb24gZG9lcyBub3QgY2F1c2UgQXVkaW9Db250ZXh0LnN1c3Bl bmQoKSB0byB0aHJvdyIpOworanNUZXN0SXNBc3luYyA9IHRydWU7CisKK2xldCBkaWRSZXNvbHZl U3VzcGVuZFByb21pc2UgPSBmYWxzZTsKKworZnVuY3Rpb24gZGlkRW5kSW50ZXJydXB0aW9uKCkK K3sKKyAgICB0ZXN0UGFzc2VkKCJEaWQgZW5kIGludGVycnVwdGlvbiIpOworICAgIGNvbnRleHQu b25zdGF0ZWNoYW5nZSA9IG51bGw7CisgICAgLy8gSW50ZXJydXB0aW9uIGhhcyBlbmRlZCBidXQg dGhlIHNjcmlwdCBoYXMgY2FsbGVkIHN1c3BlbmQoKSBzbyB3ZSBzaG91bGQgbW92ZSB0byAic3Vz cGVuZGVkIgorICAgIC8vIHN0YXRlLgorICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiY29udGV4 dC5zdGF0ZSIsICJzdXNwZW5kZWQiKTsKKyAgICBzaG91bGRCZVRydWUoImRpZFJlc29sdmVTdXNw ZW5kUHJvbWlzZSIpOworCisgICAgc2V0VGltZW91dCgoKSA9PiB7CisgICAgICAgIHNob3VsZEJl RXF1YWxUb1N0cmluZygiY29udGV4dC5zdGF0ZSIsICJzdXNwZW5kZWQiKTsKKworICAgICAgICBj b250ZXh0LnJlc3VtZSgpLnRoZW4oKCkgPT4geworICAgICAgICAgICAgdGVzdFBhc3NlZCgicmVz dW1lKCkgcHJvbWlzZSB3YXMgcmVzb2x2ZWQiKTsKKyAgICAgICAgICAgIHNob3VsZEJlRXF1YWxU b1N0cmluZygiY29udGV4dC5zdGF0ZSIsICJydW5uaW5nIik7CisgICAgICAgICAgICBmaW5pc2hK U1Rlc3QoKTsKKyAgICAgICAgfSwgKGUpID0+IHsKKyAgICAgICAgICAgIHRlc3RGYWlsZWQoImNv bnRleHQucmVzdW1lKCkgY2FsbCBhZnRlciB1bmludGVycnVwdGVkIHRocmV3IGFuIHVuZXhwZWN0 ZWQgZXhjZXB0aW9uOiAiICsgZSk7CisgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICAg ICAgfSk7CisgICAgfSwgMTApOworfQorCitmdW5jdGlvbiBkaWRCZWdpbkludGVycnVwdGlvbigp Cit7CisgICAgdGVzdFBhc3NlZCgiRGlkIGJlZ2luIGludGVycnVwdGlvbiIpOworICAgIGNvbnRl eHQub25zdGF0ZWNoYW5nZSA9IG51bGw7CisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJjb250 ZXh0LnN0YXRlIiwgImludGVycnVwdGVkIik7CisgICAgY29udGV4dC5zdXNwZW5kKCkudGhlbigo KSA9PiB7CisgICAgICAgIHRlc3RQYXNzZWQoImNvbnRleHQuc3VzcGVuZCgpIHByb21pc2Ugd2Fz IHJlc29sdmVkIik7CisgICAgICAgIGRpZFJlc29sdmVTdXNwZW5kUHJvbWlzZSA9IHRydWU7Cisg ICAgfSwgKGUpID0+IHsKKyAgICAgICAgdGVzdEZhaWxlZCgiY29udGV4dC5zdXNwZW5kKCkgY2Fs bCB3aGlsZSBpbnRlcnJ1cHRlZCB0aHJldyBhbiB1bmV4cGVjdGVkIGV4Y2VwdGlvbjogIiArIGUp OworICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICB9KTsKKworICAgIHNob3VsZEJlRXF1YWxU b1N0cmluZygiY29udGV4dC5zdGF0ZSIsICJpbnRlcnJ1cHRlZCIpOworICAgIHNob3VsZEJlRmFs c2UoImRpZFJlc29sdmVTdXNwZW5kUHJvbWlzZSIpOworICAgIHNldFRpbWVvdXQoKCkgPT4gewor ICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImNvbnRleHQuc3RhdGUiLCAiaW50ZXJydXB0 ZWQiKTsKKyAgICAgICAgc2hvdWxkQmVGYWxzZSgiZGlkUmVzb2x2ZVN1c3BlbmRQcm9taXNlIik7 CisKKyAgICAgICAgY29udGV4dC5vbnN0YXRlY2hhbmdlID0gZGlkRW5kSW50ZXJydXB0aW9uOwor ICAgICAgICBpZiAod2luZG93LmludGVybmFscykKKyAgICAgICAgICAgIGV2YWxBbmRMb2coImlu dGVybmFscy5lbmRNZWRpYVNlc3Npb25JbnRlcnJ1cHRpb24oJ21heXJlc3VtZXBsYXlpbmcnKSIp OworICAgIH0sIDEwKTsKK30KKworZnVuY3Rpb24gZGlkU3RhcnRSZW5kZXJpbmcoKQoreworICAg IHRlc3RQYXNzZWQoIkRpZCBzdGFydCByZW5kZXJpbmciKTsKKyAgICBjb250ZXh0Lm9uc3RhdGVj aGFuZ2UgPSBkaWRCZWdpbkludGVycnVwdGlvbjsKKyAgICBpZiAod2luZG93LmludGVybmFscykK KyAgICAgICAgZXZhbEFuZExvZygiaW50ZXJuYWxzLmJlZ2luTWVkaWFTZXNzaW9uSW50ZXJydXB0 aW9uKCdlbnRlcmluZ2JhY2tncm91bmQnKSIpOworfQorCitsZXQgY29udGV4dCA9IG5ldyBBdWRp b0NvbnRleHQ7Cit2YXIgc291cmNlID0gY29udGV4dC5jcmVhdGVDb25zdGFudFNvdXJjZSgpOwor c291cmNlLmNvbm5lY3QoY29udGV4dC5kZXN0aW5hdGlvbik7CisKK2NvbnRleHQub25zdGF0ZWNo YW5nZSA9IGRpZFN0YXJ0UmVuZGVyaW5nOworc291cmNlLnN0YXJ0KCk7Cis8L3NjcmlwdD4KKzwv aHRtbD4K