218221 2020-10-26 20:59:30 -0700 [GStreamer][WebRTC] Support for VP9 Profile 2 (10-bit color) encoding 2022-07-15 04:39:16 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217673 InRadar P2 Normal --- 222795 235885 1 clopez philn bugs-noreply eric.carlson philn pnormand vjaquez webkit-bug-importer youennf oldest_to_newest 1701746 0 clopez 2020-10-26 20:59:30 -0700 On r268971 support for VP9 Profile 2 (10-bit color) was added, but the feature is not working still for the GTK or WPE ports. The layout test webrtc/vp9-profile2.html added on r268971 fails with: --- /home/igalia/clopez/webkit/webkit-flatpak/layout-test-results/webrtc/vp9-profile2-expected.txt +++ /home/igalia/clopez/webkit/webkit-flatpak/layout-test-results/webrtc/vp9-profile2-actual.txt @@ -1,10 +1,4 @@ -PASS VP9 profile 2 in getCapabilities -PASS Verify VP9 activation -PASS Setting video exchange -PASS Ensuring connection state is connected -PASS Track is enabled, video should not be black -PASS Track is disabled, video should be black -PASS Track is enabled, video should not be black 2 +FAIL VP9 profile 2 in getCapabilities assert_equals: expected 1 but got 0 1701753 1 clopez 2020-10-26 21:40:30 -0700 Updated expectations in r269021 1746035 2 pnormand 2021-04-01 08:19:03 -0700 I had a look at this one, a few notes: - the libvpx shipped in the SDK doesn't support high bit depth pixel formats, but that's easy to fix (--enable-vp9-highbitdepth configure option) - the gst 1.18 vp9dec still chokes after fixing libvpx - gst 1.19 vp9dec works better thanks to the vp9parse element autoplugged in decodebin3 - the test still fails, here's the diff: --- /app/webkit/WebKitBuild/Release/layout-test-results/webrtc/vp9-profile2-expected.txt +++ /app/webkit/WebKitBuild/Release/layout-test-results/webrtc/vp9-profile2-actual.txt @@ -4,7 +4,7 @@ PASS Verify VP9 activation PASS Setting video exchange PASS Ensuring connection state is connected -PASS Track is enabled, video should not be black -PASS Track is disabled, video should be black -PASS Track is enabled, video should not be black 2 +FAIL Track is enabled, video should not be black promise_test: Unhandled rejection with value: object "IndexSizeError: The index is not in the allowed range." +FAIL Track is disabled, video should be black promise_test: Unhandled rejection with value: object "IndexSizeError: The index is not in the allowed range." +FAIL Track is enabled, video should not be black 2 promise_test: Unhandled rejection with value: object "IndexSizeError: The index is not in the allowed range." I suspect the decoded video dimensions are not correctly propagated from the player to the media element. 1883649 3 philn 2022-07-14 09:51:28 -0700 Re-purposing to GstWebRTC. Patch incoming. 1883663 4 pnormand 2022-07-14 10:29:11 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2414 1884013 5 ews-feeder 2022-07-15 04:38:15 -0700 Committed 252497@main (d3c0cebbf427): <https://commits.webkit.org/252497@main> Reviewed commits have been landed. Closing PR #2414 and removing active labels. 1884014 6 webkit-bug-importer 2022-07-15 04:39:16 -0700 <rdar://problem/97068026>