218210 2020-10-26 15:13:01 -0700 Improve exception messages when AudioContext.suspend() / resume() promises are rejected 2020-10-26 17:38:37 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212611 217606 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble philipj sam sergio webkit-bug-importer oldest_to_newest 1701653 0 cdumez 2020-10-26 15:13:01 -0700 Improve exception messages when AudioContext.suspend() / resume() promises are rejected. 1701655 1 412359 cdumez 2020-10-26 15:14:59 -0700 Created attachment 412359 Patch 1701659 2 412359 ggaren 2020-10-26 15:50:30 -0700 Comment on attachment 412359 Patch r=me 1701667 3 412359 cdumez 2020-10-26 16:09:21 -0700 Comment on attachment 412359 Patch Clearing flags on attachment: 412359 Committed r268999: <https://trac.webkit.org/changeset/268999> 1701668 4 cdumez 2020-10-26 16:09:23 -0700 All reviewed patches have been landed. Closing bug. 1701669 5 webkit-bug-importer 2020-10-26 16:10:17 -0700 <rdar://problem/70699860> 1701702 6 412359 darin 2020-10-26 17:38:37 -0700 Comment on attachment 412359 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412359&action=review > LayoutTests/webaudio/construct-node-with-closed-context-expected.txt:45 > +PASS context.resume() rejected promise with InvalidStateError: Context is closed. > PASS context.close() rejected promise with InvalidStateError: The object is in an invalid state.. Why do some of our error messages end with periods, and others not? 412359 2020-10-26 15:14:59 -0700 2020-10-26 16:09:21 -0700 Patch bug-218210-20201026151458.patch text/plain 5569 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4OTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDBmMzk4N2U3ZWIzZTc2 MTg4MDE3OTAyMTg2ODI4OGRhZjlhOTE3YS4uNGFmNmM1NThiNWI3ZTY5YWQzOGNmNjc2YmJmN2Fh Nzk0ZjgyMDZlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wcm92ZSBleGNlcHRpb24g bWVzc2FnZXMgd2hlbiBBdWRpb0NvbnRleHQuc3VzcGVuZCgpIC8gcmVzdW1lKCkgcHJvbWlzZXMg YXJlIHJlamVjdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTgyMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbXByb3ZlIGV4Y2VwdGlvbiBtZXNzYWdlcyB3aGVuIEF1ZGlvQ29udGV4dC5zdXNwZW5k KCkgLyByZXN1bWUoKSBwcm9taXNlcyBhcmUgcmVqZWN0ZWQuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCByZWJhc2VsaW5lZCBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMvd2Vi YXVkaW8vQXVkaW9Db250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ29udGV4dDo6 c3VzcGVuZFJlbmRlcmluZyk6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0NvbnRleHQ6OnJlc3Vt ZVJlbmRlcmluZyk6CisKIDIwMjAtMTAtMjYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBVc2UgdGVybSAibW9kZXJuIGxpbmUg bGF5b3V0IiBpbiBSZW5kZXJCbG9ja0Zsb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcAppbmRleCAxNzYzOGNlYzVmNjNlODgxNDFkMjA3MDU2 YTYzM2YyZWI2NGFkNDA4Li4xYTM4NjI0YWRjY2QyZjdkODdhMmZlNDhmZmE2YmZjMDhjYzk0ZTVk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4 dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQu Y3BwCkBAIC0yMDQsMTMgKzIwNCwxMyBAQCBEZWZhdWx0QXVkaW9EZXN0aW5hdGlvbk5vZGUqIEF1 ZGlvQ29udGV4dDo6ZGVzdGluYXRpb24oKQogCiB2b2lkIEF1ZGlvQ29udGV4dDo6c3VzcGVuZFJl bmRlcmluZyhET01Qcm9taXNlRGVmZXJyZWQ8dm9pZD4mJiBwcm9taXNlKQogewotICAgIGlmIChp c09mZmxpbmVDb250ZXh0KCkgfHwgaXNTdG9wcGVkKCkpIHsKLSAgICAgICAgcHJvbWlzZS5yZWpl Y3QoSW52YWxpZFN0YXRlRXJyb3IpOworICAgIGlmIChpc09mZmxpbmVDb250ZXh0KCkpIHsKKyAg ICAgICAgcHJvbWlzZS5yZWplY3QoRXhjZXB0aW9uIHsgSW52YWxpZFN0YXRlRXJyb3IsICJDYW5u b3QgY2FsbCBzdXNwZW5kKCkgb24gYW4gT2ZmbGluZUF1ZGlvQ29udGV4dCJfcyB9KTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmIChzdGF0ZSgpID09IFN0YXRlOjpDbG9zZWQgfHwg c3RhdGUoKSA9PSBTdGF0ZTo6SW50ZXJydXB0ZWQgfHwgIWRlc3RpbmF0aW9uTm9kZSgpKSB7Ci0g ICAgICAgIHByb21pc2UucmVqZWN0KCk7CisgICAgaWYgKGlzU3RvcHBlZCgpIHx8IHN0YXRlKCkg PT0gU3RhdGU6OkNsb3NlZCB8fCBzdGF0ZSgpID09IFN0YXRlOjpJbnRlcnJ1cHRlZCB8fCAhZGVz dGluYXRpb25Ob2RlKCkpIHsKKyAgICAgICAgcHJvbWlzZS5yZWplY3QoRXhjZXB0aW9uIHsgSW52 YWxpZFN0YXRlRXJyb3IsICJDb250ZXh0IGlzIGNsb3NlZCJfcyB9KTsKICAgICAgICAgcmV0dXJu OwogICAgIH0KIApAQCAtMjI5LDEzICsyMjksMTMgQEAgdm9pZCBBdWRpb0NvbnRleHQ6OnN1c3Bl bmRSZW5kZXJpbmcoRE9NUHJvbWlzZURlZmVycmVkPHZvaWQ+JiYgcHJvbWlzZSkKIAogdm9pZCBB dWRpb0NvbnRleHQ6OnJlc3VtZVJlbmRlcmluZyhET01Qcm9taXNlRGVmZXJyZWQ8dm9pZD4mJiBw cm9taXNlKQogewotICAgIGlmIChpc09mZmxpbmVDb250ZXh0KCkgfHwgaXNTdG9wcGVkKCkpIHsK LSAgICAgICAgcHJvbWlzZS5yZWplY3QoSW52YWxpZFN0YXRlRXJyb3IpOworICAgIGlmIChpc09m ZmxpbmVDb250ZXh0KCkpIHsKKyAgICAgICAgcHJvbWlzZS5yZWplY3QoRXhjZXB0aW9uIHsgSW52 YWxpZFN0YXRlRXJyb3IsICJDYW5ub3QgY2FsbCByZXN1bWUoKSBvbiBhbiBPZmZsaW5lQXVkaW9D b250ZXh0Il9zIH0pOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgaWYgKHN0YXRlKCkg PT0gU3RhdGU6OkNsb3NlZCB8fCAhZGVzdGluYXRpb25Ob2RlKCkpIHsKLSAgICAgICAgcHJvbWlz ZS5yZWplY3QoKTsKKyAgICBpZiAoaXNTdG9wcGVkKCkgfHwgc3RhdGUoKSA9PSBTdGF0ZTo6Q2xv c2VkIHx8ICFkZXN0aW5hdGlvbk5vZGUoKSkgeworICAgICAgICBwcm9taXNlLnJlamVjdChFeGNl cHRpb24geyBJbnZhbGlkU3RhdGVFcnJvciwgIkNvbnRleHQgaXMgY2xvc2VkIl9zIH0pOwogICAg ICAgICByZXR1cm47CiAgICAgfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWM3Yjc4NzZmZDg0MGYzMjE3ZTA4NDhhNDhh Yzk5N2YzNDU0YzhmNC4uZDUyYTllOWNjMGRmZjcyMWM5ODdlNzA2YTVjNTA1NGIzZWNkYzMxNSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTI2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CisKKyAgICAgICAgSW1wcm92ZSBleGNlcHRpb24gbWVzc2FnZXMgd2hlbiBBdWRp b0NvbnRleHQuc3VzcGVuZCgpIC8gcmVzdW1lKCkgcHJvbWlzZXMgYXJlIHJlamVjdGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgyMTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYmF1ZGlvL2F1 ZGlvY29udGV4dC1zdGF0ZS5odG1sOgorICAgICAgICBTdG9wIGV4cGVjdGluZyB0aGF0IHRoZSBy ZXN1bWUoKSBwcm9taXNlIGlzIHJlamVjdGVkIHdpdGhvdXQgYW55IGV4Y2VwdGlvbi4KKyAgICAg ICAgVGhpcyBpcyBub3Qgc3RhbmRhcmQgYmVoYXZpb3IgYW5kIGRvZXMgbm90IG1hdGNoIHRoZSBi ZWhhdmlvciBvZiBvdGhlcgorICAgICAgICBicm93c2VycyBlaXRoZXIuCisKKyAgICAgICAgKiB3 ZWJhdWRpby9jb25zdHJ1Y3Qtbm9kZS13aXRoLWNsb3NlZC1jb250ZXh0LWV4cGVjdGVkLnR4dDoK KyAgICAgICAgUmViYXNlbGluZSB0ZXN0IG5vdyB0aGF0IGV4Y2VwdGlvbiBtZXNzYWdlcyBoYXZl IGJlZW4gaW1wcm92ZWQuCisKIDIwMjAtMTAtMjYgIERpZWdvIFBpbm8gR2FyY2lhICA8ZHBpbm9A aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLiBV cGRhdGUgZXhwZWN0YXRpb25zIGFmdGVyIHIyNjg5NzMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy93ZWJhdWRpby9hdWRpb2NvbnRleHQtc3RhdGUuaHRtbCBiL0xheW91dFRlc3RzL3dlYmF1ZGlv L2F1ZGlvY29udGV4dC1zdGF0ZS5odG1sCmluZGV4IDhiMmFjMzkzZDg3NzUyYTVmOTY5NDg4NWFh NDQ5MjExYTVkNjZmMzkuLmQzOTU2ZmJlNjE0NzdkNjcwOGUzY2MyY2I4NTIwODdhNWQwNjViYzQg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvY29udGV4dC1zdGF0ZS5odG1s CisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvY29udGV4dC1zdGF0ZS5odG1sCkBAIC05 Myw4ICs5Myw2IEBAIGZ1bmN0aW9uIHJlc3VtZVN1Y2NlZWRlZEluY29ycmVjdGx5KCkgewogCiBm dW5jdGlvbiByZXN1bWVGYWlsZWRDb3JyZWN0bHkodmFsdWUpIHsKICAgICB0ZXN0UGFzc2VkKCdj b250ZXh0LnJlc3VtZSgpIHByb21pc2UgcmVqZWN0ZWQgKGNvcnJlY3RseSknKTsKLSAgICBpZiAo dHlwZW9mIHZhbHVlICE9ICd1bmRlZmluZWQnKQotICAgICAgICB0ZXN0RmFpbGVkKCdObyB2YWx1 ZSBzaG91bGQgYmUgcGFzc2VkIHRvIHRoZSBjb250ZXh0LnJlc3VtZSgpIHByb21pc2UgcmVqZWN0 ZWQgY2FsbGJhY2snKTsKICAgICBzaG91bGRCZSgnY29udGV4dC5zdGF0ZScsICciY2xvc2VkIicp OwogCiAgICAgZGVidWcoJ0NhbGxpbmcgY29udGV4dC5zdXNwZW5kKCkgKHNob3VsZCBmYWlsKScp OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vY29uc3RydWN0LW5vZGUtd2l0aC1j bG9zZWQtY29udGV4dC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9jb25zdHJ1 Y3Qtbm9kZS13aXRoLWNsb3NlZC1jb250ZXh0LWV4cGVjdGVkLnR4dAppbmRleCA0MjY1MjY5YjJh ODFkYTkxOThhNDZmMmYyODcyZTU3YmYwYjZjZDc1Li45ZWJlZDU0MWE1YjAxY2RjZTFlMjQwNmE4 MzBlZmUzYmFhNTk2MGU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9jb25zdHJ1 Y3Qtbm9kZS13aXRoLWNsb3NlZC1jb250ZXh0LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy93ZWJhdWRpby9jb25zdHJ1Y3Qtbm9kZS13aXRoLWNsb3NlZC1jb250ZXh0LWV4cGVjdGVkLnR4 dApAQCAtNDAsOCArNDAsOCBAQCBQQVNTIGNvbnRleHQuY3JlYXRlUGVyaW9kaWNXYXZlKFsxLCAy XSwgWzEsIDJdKSBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KIFBBU1MgY29udGV4dC5jcmVhdGVT dGVyZW9QYW5uZXIoKSBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KIFBBU1MgY29udGV4dC5jcmVh dGVXYXZlU2hhcGVyKCkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCiBQQVNTIGNvbnRleHQuY3Jl YXRlU2NyaXB0UHJvY2Vzc29yKCkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCi1QQVNTIGNvbnRl eHQuc3VzcGVuZCgpIHJlamVjdGVkIHByb21pc2UgIHdpdGggSW52YWxpZFN0YXRlRXJyb3I6IFRo ZSBvYmplY3QgaXMgaW4gYW4gaW52YWxpZCBzdGF0ZS4uCi1QQVNTIGNvbnRleHQucmVzdW1lKCkg cmVqZWN0ZWQgcHJvbWlzZSAgd2l0aCBJbnZhbGlkU3RhdGVFcnJvcjogVGhlIG9iamVjdCBpcyBp biBhbiBpbnZhbGlkIHN0YXRlLi4KK1BBU1MgY29udGV4dC5zdXNwZW5kKCkgcmVqZWN0ZWQgcHJv bWlzZSAgd2l0aCBJbnZhbGlkU3RhdGVFcnJvcjogQ29udGV4dCBpcyBjbG9zZWQuCitQQVNTIGNv bnRleHQucmVzdW1lKCkgcmVqZWN0ZWQgcHJvbWlzZSAgd2l0aCBJbnZhbGlkU3RhdGVFcnJvcjog Q29udGV4dCBpcyBjbG9zZWQuCiBQQVNTIGNvbnRleHQuY2xvc2UoKSByZWplY3RlZCBwcm9taXNl ICB3aXRoIEludmFsaWRTdGF0ZUVycm9yOiBUaGUgb2JqZWN0IGlzIGluIGFuIGludmFsaWQgc3Rh dGUuLgogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCg==