218078 2020-10-22 06:43:10 -0700 Web Audio continues to play when navigating off the web page via an iframe 2020-10-26 08:28:14 -0700 1 1 1 Unclassified WebKit Web Audio Safari 14 Mac macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 212611 1 adam552 cdumez ap cdumez eric.carlson ews-watchlist glenn jer.noble philipj sergio smoley webkit-bug-importer oldest_to_newest 1700621 0 adam552 2020-10-22 06:43:10 -0700 Overview: I have a web page playing Web Audio. This page contains an iframe. The iframe redirects the browser to another url on the same domain when the redirect button in it is clicked. The browser loads the new web page, but web audio continues to play for the previous page. Steps to Reproduce: I have built an example at https://github.com/AdamXA/phaser3-webaudio-bug which requires an npm install and npm start to run the example. 1) View the page, see the canvas being rendered and hear the background music playing via Web Audio. 2) Click the white 'Click here' text in the top left of the canvas to be redirected to another web page. Actual Results: Web Audio from the original page continues to play even though we are on a new page. If there is web audio on the new page, audio from both of those pages will play web audio simultaneously. Additional Builds and Platforms: iOS and macOS Safari 14.0 and earlier Additional Information: For some extra context behind this bug see: https://github.com/photonstorm/phaser/issues/5370 1700660 1 cdumez 2020-10-22 08:57:48 -0700 Here is what I did: 1. Downloaded test project from GitHub 2. Went to the project folder 3. Did `npm install` 4. Did `npm start` It loaded http://localhost:8080 in Safari and I see the canvas but NO sound. I don't see any errors in the JS console. 1700662 2 cdumez 2020-10-22 09:00:01 -0700 $ npm start > phaser3-project-template@1.1.0 start /Users/chris/Downloads/phaser3-webaudio-bug-master > webpack-dev-server --config webpack/base.js --open ℹ ｢wds｣: Project is running at http://localhost:8080/ ℹ ｢wds｣: webpack output is served from / ℹ ｢wds｣: Content not from webpack is served from /Users/chris/Downloads/phaser3-webaudio-bug-master ℹ ｢wdm｣: wait until bundle finished: / Browserslist: caniuse-lite is outdated. Please run next command `npm update` ℹ ｢wdm｣: Hash: 4ced28bccb3452da59eb Version: webpack 4.41.2 Time: 4986ms Built at: 10/22/2020 8:54:54 AM Asset Size Chunks Chunk Names c4903988d61e23e74f8dffcb10aca802.mp3 833 KiB [emitted] efbfcf3c2043e8a0694698780cb966f9.png 5.25 KiB [emitted] index.html 300 bytes [emitted] main.js 17.1 MiB main [emitted] main Entrypoint main = main.js [0] multi (webpack)-dev-server/client?http://localhost:8080 ./src 40 bytes {main} [built] [./node_modules/ansi-html/index.js] 4.16 KiB {main} [built] [./node_modules/phaser/dist/phaser.js] 5.99 MiB {main} [built] [./node_modules/strip-ansi/index.js] 161 bytes {main} [built] [./node_modules/webpack-dev-server/client/index.js?http://localhost:8080] (webpack)-dev-server/client?http://localhost:8080 4.29 KiB {main} [built] [./node_modules/webpack-dev-server/client/overlay.js] (webpack)-dev-server/client/overlay.js 3.51 KiB {main} [built] [./node_modules/webpack-dev-server/client/socket.js] (webpack)-dev-server/client/socket.js 1.53 KiB {main} [built] [./node_modules/webpack-dev-server/client/utils/createSocketUrl.js] (webpack)-dev-server/client/utils/createSocketUrl.js 2.89 KiB {main} [built] [./node_modules/webpack-dev-server/client/utils/log.js] (webpack)-dev-server/client/utils/log.js 964 bytes {main} [built] [./node_modules/webpack-dev-server/client/utils/reloadApp.js] (webpack)-dev-server/client/utils/reloadApp.js 1.59 KiB {main} [built] [./node_modules/webpack-dev-server/client/utils/sendMessage.js] (webpack)-dev-server/client/utils/sendMessage.js 402 bytes {main} [built] [./node_modules/webpack/hot sync ^\.\/log$] (webpack)/hot sync nonrecursive ^\.\/log$ 170 bytes {main} [built] [./src/assets/oedipus_wizball_highscore.mp3] 82 bytes {main} [built] [./src/assets/wizball.png] 82 bytes {main} [built] [./src/index.js] 626 bytes {main} [built] + 21 hidden modules Child html-webpack-plugin for "index.html": 1 asset Entrypoint undefined = index.html [./node_modules/html-webpack-plugin/lib/loader.js!./index.html] 448 bytes {0} [built] [./node_modules/lodash/lodash.js] 528 KiB {0} [built] [./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 472 bytes {0} [built] [./node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 497 bytes {0} [built] ℹ ｢wdm｣: Compiled successfully. 1700665 3 adam552 2020-10-22 09:04:44 -0700 (In reply to Chris Dumez from comment #1) > Here is what I did: > 1. Downloaded test project from GitHub > 2. Went to the project folder > 3. Did `npm install` > 4. Did `npm start` > > It loaded http://localhost:8080 in Safari and I see the canvas but NO sound. > I don't see any errors in the JS console. I've updated the example now, I had that occur to me in Chrome but not in Safari. Now it should start playing audio after clicking on the image in the canvas. Once audio is playing try clicking the Click here text. 1700667 4 cdumez 2020-10-22 09:07:45 -0700 (In reply to adam552 from comment #3) > (In reply to Chris Dumez from comment #1) > > Here is what I did: > > 1. Downloaded test project from GitHub > > 2. Went to the project folder > > 3. Did `npm install` > > 4. Did `npm start` > > > > It loaded http://localhost:8080 in Safari and I see the canvas but NO sound. > > I don't see any errors in the JS console. > > I've updated the example now, I had that occur to me in Chrome but not in > Safari. Now it should start playing audio after clicking on the image in the > canvas. Once audio is playing try clicking the Click here text. Ok, I can reproduce now, thanks. Will investigate. 1700749 5 412117 cdumez 2020-10-22 11:11:43 -0700 Created attachment 412117 Patch 1700823 6 webkit-bug-importer 2020-10-22 13:58:24 -0700 <rdar://problem/70588177> 1700852 7 ews-feeder 2020-10-22 14:56:29 -0700 Committed r268893: <https://trac.webkit.org/changeset/268893> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412117. 1701063 8 412117 ap 2020-10-23 10:40:49 -0700 Comment on attachment 412117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412117&action=review > Source/WebCore/Modules/webaudio/AudioContext.cpp:413 > + m_mediaSession->beginInterruption(PlatformMediaSession::PlaybackSuspended); > + document()->updateIsPlayingMedia(); These calls cannot cause JS execution, can they? Concerned about potentially running JS in page cache. 1701463 9 cdumez 2020-10-26 08:28:14 -0700 (In reply to Alexey Proskuryakov from comment #8) > Comment on attachment 412117 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412117&action=review > > > Source/WebCore/Modules/webaudio/AudioContext.cpp:413 > > + m_mediaSession->beginInterruption(PlatformMediaSession::PlaybackSuspended); > > + document()->updateIsPlayingMedia(); > > These calls cannot cause JS execution, can they? Concerned about potentially > running JS in page cache. Via code inspection, this code does not seems to run any script. 412117 2020-10-22 11:11:43 -0700 2020-10-22 14:56:30 -0700 Patch bug-218078-20201022111142.patch text/plain 5034 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4ODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzdlMTEyMWU1ZjI3NGEw Yzc5M2Y2MDUyZGJhZGI2NTMyZTYzNDRkOC4uOTMzMzcwMDg1OGIwZTBkNDY1OTIyMWE4ZDBlZWIz ZGYzMjQ4OTFlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQwIEBACisyMDIwLTEwLTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1ZGlvIGNvbnRpbnVl cyB0byBwbGF5IHdoZW4gbmF2aWdhdGluZyBvZmYgdGhlIHdlYiBwYWdlIHZpYSBhbiBpZnJhbWUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODA3OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwYWdl IHdhcyBzdXNwZW5kaW5nIHBsYXliYWNrIHdoZW4gY2xpY2tpbmcgdGhlIGxpbmsgYW5kIHRoZW4g cmVzdW1pbmcgcGxheWJhY2sgaW4gdGhlIHBhZ2VoaWRlCisgICAgICAgIGV2ZW50IGhhbmRsZXIu IFRoZSBpc3N1ZSBpcyB0aGF0IHRoZSBBdWRpb0NvbnRleHQncyBzdGF0ZSBnZXRzIHVwZGF0ZWQg YXN5bmNocm9ub3VzbHkgd2hlbiB0aGUKKyAgICAgICAgcGFnZSBzdXNwZW5kcyBvciByZXN1bWUg cmVuZGVyaW5nLCBhcyBwZXIgc3BlY2lmaWNhdGlvbi4gV2hlbiBlbnRlcmluZyB0aGUgYmFjay9m b3J3YXJkIGNhY2hlLAorICAgICAgICBBdWRpb0NvbnRleHQ6OnN1c3BlbmQoKSB3b3VsZCBiZSBj YWxsZWQgYnV0IHdvdWxkIGRvIG5vdGhpbmcgYmVjYXVzZSB0aGUgc3RhdGUgd2FzICJzdXNwZW5k ZWQiLAorICAgICAgICBkZXNwaXRlIHRoZSBzY3JpcHQgaGF2aW5nIGp1c3QgY2FsbGVkICJyZXN1 bWUoKSIuIFRvIGFkZHJlc3MgdGhlIGlzc3VlLCBBdWRpb0NvbnRleHQ6OnN1c3BlbmQoKQorICAg ICAgICBub3cgZWFybHkgcmV0dXJucyBvbmx5IGlmIHRoZSBjb250ZXh0IGlzIGNsb3NlZCBvciBi YXNlZCBvbiB0aGUgbV93YXNTdXNwZW5kZWRCeVNjcmlwdCBmbGFnCisgICAgICAgIHdoZW4gZ2V0 cyB1cGRhdGVkIHN5bmNocm9ub3VzbHkgd2hlbiB0aGUgc2NyaXB0IGNhbGxzIHN1c3BlbmQoKSAv IHJlc3VtZSgpLiBTaW1pbGFybHksCisgICAgICAgIEF1ZGlvQ29udGV4dDo6cmVzdW1lKCkgY2hl Y2tzIHRob3NlIHNhbWUgZmxhZ3Mgbm93LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBp bXBhY3RzIGF1ZGlvIHJlbmRlcmluZyBvbiBzcGVha2VycyBidXQgaXMgbm90IHdlYi1vYnNlcnZh YmxlLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0OjpyZXN1bWVSZW5kZXJpbmcpOgorICAgICAgICBD aGVjayBpZiB0aGUgTWVkaWFTZXNzaW9uIGlzIGludGVycnVwdGVkIGJlZm9yZSBhc3luY2hyb25v dXNseSBzZXR0aW5nIHRoZSBBdWRpb0NvbnRleHQncyBzdGF0ZQorICAgICAgICB0byAicnVubmlu ZyIuIFRoaXMgaXMgaW1wb3J0YW50IGJlY2F1c2UgdGhlIHN0YXRlIGdldHMgdXBkYXRlZCBhc3lu Y2hyb25vdXNseSBidXQgdGhlIE1lZGlhU2Vzc2lvbgorICAgICAgICBjYW4gYmUgaW50ZXJydXB0 ZWQgc3luY2hyb25vdXNseSB3aGVuIEF1ZGlvQ29udGV4dDo6c3VzcGVuZCgpIGdldHMgY2FsbGVk LCB3aGljaCB3b3VsZCBoYXZlIHNldAorICAgICAgICB0aGUgQXVkaW9Db250ZXh0J3Mgc3RhdGUg dG8gImludGVycnVwdGVkIi4gV2UgZG9uJ3Qgd2FudCB0byBpbmNvcnJlY3RseSBjaGFuZ2UgdGhl IHN0YXRlIGZyb20KKyAgICAgICAgImludGVycnVwdGVkIiB0byAicnVubmluZyIgaW4gdGhpcyBj YXNlLiBOb3RlIHRoYXQgQXVkaW9Db250ZXh0OjpzdXNwZW5kUmVuZGVyaW5nKCkgYWxyZWFkeSBk b2VzCisgICAgICAgIHRoZSBzYW1lIHRoaW5nLgorCisgICAgICAgIChXZWJDb3JlOjpBdWRpb0Nv bnRleHQ6OnN1c3BlbmQpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0OjpyZXN1bWUp OgorICAgICAgICBPbmx5IGVhcmx5IHJldHVybiBpZiB0aGUgQXVkaW9Db250ZXh0IGlzIGNsb3Nl ZCBvciBpZiB0aGUgbV93YXNTdXNwZW5kZWRCeVNjcmlwdCBmbGFnIGlzIHNldC4gVGhlCisgICAg ICAgIG1fd2FzU3VzcGVuZGVkQnlTY3JpcHQgZ2V0cyB1cGRhdGVkIHN5bmNocm9ub3VzbHkgd2hl biBzdXNwZW5kUmVuZGVyaW5nKCkgLyByZXN1bWVSZW5kZXJpbmcoKSBnZXQKKyAgICAgICAgY2Fs bGVkLCB1bmxpa2UgdGhlIEF1ZGlvQ29udGV4dCdzIHN0YXRlIHdoaWNoIGdldHMgdXBkYXRlZCBh c3luY2hyb25vdXNseS4KKworICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0OjpzdXNwZW5k UGxheWJhY2spOgorICAgICAgICBTdG9wIGVhcmx5IHJldHVybmluZyBpZiB0aGUgc3RhdGUgaXMg InN1c3BlbmRlZCIuIFRoaXMgd2FzIHdyb25nIHNpbmNlIHRoZSBzdGF0ZSBnZXRzIHVwZGF0ZWQK KyAgICAgICAgYXN5bmNocm9ub3VzbHkuCisKIDIwMjAtMTAtMjIgIEFkaXR5YSBLZWVydGhpICA8 YWtlZXJ0aGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFByZXZlbnQgcHJlc2VudGF0aW9u IG9mIGlucHV0IHBlcmlwaGVyYWxzIHdoZW4gZm9jdXNpbmcgZm9ybSBjb250cm9scyB3aXRoIGEg dmFsaWRhdGlvbiBtZXNzYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L0F1ZGlvQ29udGV4dC5jcHAKaW5kZXggNTUwZjFkMWViMDliYTA2YTBiMmEzYzI1OWVjNzhiYjcz ZGY1ZWY5Zi4uMTc2MzhjZWM1ZjYzZTg4MTQxZDIwNzA1NmE2MzNmMmViNjRhZDQwOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcApAQCAt MjQ4LDcgKzI0OCwxMSBAQCB2b2lkIEF1ZGlvQ29udGV4dDo6cmVzdW1lUmVuZGVyaW5nKERPTVBy b21pc2VEZWZlcnJlZDx2b2lkPiYmIHByb21pc2UpCiAgICAgbGF6eUluaXRpYWxpemUoKTsKIAog ICAgIGRlc3RpbmF0aW9uTm9kZSgpLT5yZXN1bWUoW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtl UmVmKCp0aGlzKV0gewotICAgICAgICBzZXRTdGF0ZShTdGF0ZTo6UnVubmluZyk7CisgICAgICAg IC8vIFNpbmNlIHdlIHVwZGF0ZSB0aGUgc3RhdGUgYXN5bmNocm9ub3VzbHksIHdlIG1heSBoYXZl IGJlZW4gaW50ZXJydXB0ZWQgYWZ0ZXIgdGhlCisgICAgICAgIC8vIGNhbGwgdG8gcmVzdW1lKCkg YW5kIGJlZm9yZSB0aGlzIGxhbWJkYSBydW5zLiBJbiB0aGlzIGNhc2UsIHdlIGRvbid0IHdhbnQg dG8KKyAgICAgICAgLy8gcmVzZXQgdGhlIHN0YXRlIHRvIHJ1bm5pbmcuCisgICAgICAgIGJvb2wg aW50ZXJydXB0ZWQgPSBtX21lZGlhU2Vzc2lvbi0+c3RhdGUoKSA9PSBQbGF0Zm9ybU1lZGlhU2Vz c2lvbjo6SW50ZXJydXB0ZWQ7CisgICAgICAgIHNldFN0YXRlKGludGVycnVwdGVkID8gU3RhdGU6 OkludGVycnVwdGVkIDogU3RhdGU6OlJ1bm5pbmcpOwogICAgIH0pOwogfQogCkBAIC00MDIsMTgg KzQwNiwyMCBAQCB2b2lkIEF1ZGlvQ29udGV4dDo6dmlzaWJpbGl0eVN0YXRlQ2hhbmdlZCgpCiAK IHZvaWQgQXVkaW9Db250ZXh0OjpzdXNwZW5kKFJlYXNvbkZvclN1c3BlbnNpb24pCiB7Ci0gICAg aWYgKHN0YXRlKCkgPT0gU3RhdGU6OlJ1bm5pbmcpIHsKLSAgICAgICAgbV9tZWRpYVNlc3Npb24t PmJlZ2luSW50ZXJydXB0aW9uKFBsYXRmb3JtTWVkaWFTZXNzaW9uOjpQbGF5YmFja1N1c3BlbmRl ZCk7Ci0gICAgICAgIGRvY3VtZW50KCktPnVwZGF0ZUlzUGxheWluZ01lZGlhKCk7Ci0gICAgfQor ICAgIGlmIChpc0Nsb3NlZCgpIHx8IG1fd2FzU3VzcGVuZGVkQnlTY3JpcHQpCisgICAgICAgIHJl dHVybjsKKworICAgIG1fbWVkaWFTZXNzaW9uLT5iZWdpbkludGVycnVwdGlvbihQbGF0Zm9ybU1l ZGlhU2Vzc2lvbjo6UGxheWJhY2tTdXNwZW5kZWQpOworICAgIGRvY3VtZW50KCktPnVwZGF0ZUlz UGxheWluZ01lZGlhKCk7CiB9CiAKIHZvaWQgQXVkaW9Db250ZXh0OjpyZXN1bWUoKQogewotICAg IGlmIChzdGF0ZSgpID09IFN0YXRlOjpJbnRlcnJ1cHRlZCkgewotICAgICAgICBtX21lZGlhU2Vz c2lvbi0+ZW5kSW50ZXJydXB0aW9uKFBsYXRmb3JtTWVkaWFTZXNzaW9uOjpNYXlSZXN1bWVQbGF5 aW5nKTsKLSAgICAgICAgZG9jdW1lbnQoKS0+dXBkYXRlSXNQbGF5aW5nTWVkaWEoKTsKLSAgICB9 CisgICAgaWYgKGlzQ2xvc2VkKCkgfHwgbV93YXNTdXNwZW5kZWRCeVNjcmlwdCkKKyAgICAgICAg cmV0dXJuOworCisgICAgbV9tZWRpYVNlc3Npb24tPmVuZEludGVycnVwdGlvbihQbGF0Zm9ybU1l ZGlhU2Vzc2lvbjo6TWF5UmVzdW1lUGxheWluZyk7CisgICAgZG9jdW1lbnQoKS0+dXBkYXRlSXNQ bGF5aW5nTWVkaWEoKTsKIH0KIAogdm9pZCBBdWRpb0NvbnRleHQ6OnN1c3BlbmRQbGF5YmFjaygp CkBAIC00MjEsMTIgKzQyNyw2IEBAIHZvaWQgQXVkaW9Db250ZXh0OjpzdXNwZW5kUGxheWJhY2so KQogICAgIGlmICghZGVzdGluYXRpb25Ob2RlKCkgfHwgc3RhdGUoKSA9PSBTdGF0ZTo6Q2xvc2Vk KQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoc3RhdGUoKSA9PSBTdGF0ZTo6U3VzcGVuZGVk KSB7Ci0gICAgICAgIGlmIChtX21lZGlhU2Vzc2lvbi0+c3RhdGUoKSA9PSBQbGF0Zm9ybU1lZGlh U2Vzc2lvbjo6SW50ZXJydXB0ZWQpCi0gICAgICAgICAgICBzZXRTdGF0ZShTdGF0ZTo6SW50ZXJy dXB0ZWQpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCiAgICAgbGF6eUluaXRpYWxpemUoKTsK IAogICAgIGRlc3RpbmF0aW9uTm9kZSgpLT5zdXNwZW5kKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0g bWFrZVJlZigqdGhpcyldIHsK