217972 2020-10-20 10:42:09 -0700 Make report-non-inclusive-language ignore autoinstalled directories and certain file types 2021-05-17 10:01:35 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215156 https://bugs.webkit.org/show_bug.cgi?id=217993 https://bugs.webkit.org/show_bug.cgi?id=224979 InRadar P2 Normal --- 213092 1 aakash_jain aakash_jain aakash_jain bdakin darin jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1699833 0 aakash_jain 2020-10-20 10:42:09 -0700 Make report-non-inclusive-language ignore following directories and files: 1) 'autoinstalled': The source code of packages inside autoinstalled directories (e.g.: Scripts/libraries/autoinstalled) are not part of our repository and is not controlled by us. So report-non-inclusive-language shouldn't count them. Currently the count is really skewed because of counting such autoinstalled directories. 2) Files ending with .swp: usually these are files created for files opened in other tabs). 3) Files ending with .log: usually these are not part of source code, and are simply logs. For e.g.: twistd.log while running buildbot instance locally. 1699837 1 411887 aakash_jain 2020-10-20 10:47:41 -0700 Created attachment 411887 Patch 1699856 2 aakash_jain 2020-10-20 11:30:02 -0700 It should also ignore files ending in .pyc 1699857 3 411892 aakash_jain 2020-10-20 11:31:13 -0700 Created attachment 411892 Patch 1699858 4 411887 bdakin 2020-10-20 11:32:00 -0700 Comment on attachment 411887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411887&action=review > Tools/Scripts/report-non-inclusive-language:47 > +IGNORE_FILES_ENDING_WITH = ('.order', '.xcuserstate', '.swp', '.log') I saw your comment about adding .pyc here, but R+ for now anyway. This is great! 1699871 5 ews-feeder 2020-10-20 12:13:27 -0700 Committed r268752: <https://trac.webkit.org/changeset/268752> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411892. 1699873 6 webkit-bug-importer 2020-10-20 12:14:20 -0700 <rdar://problem/70496351> 1699886 7 411892 darin 2020-10-20 13:04:38 -0700 Comment on attachment 411892 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411892&action=review > Tools/Scripts/report-non-inclusive-language:61 > + if any(directory in prefix for directory in IGNORE_DIRECTORIES): This is IGNORE_DIRECTORIES or IGNORE_DIRECTORIES_CONTAINING? It looks like we are using substring matching for directory names, but we want to know if this is exactly a directory name. Ideally this should not match "notautoinstalled". I’d like a more correct implementation to be future-looking although for now none of those three strings seems like a problem. I believe that some others at Apple have been using this script, so it’s good if it works well even outside WebKit, which is why it’s good to be careful about such things. 1699893 8 aakash_jain 2020-10-20 13:14:43 -0700 (In reply to Darin Adler from comment #7) > It looks like we are using substring matching for directory names, but we want to know if this is exactly a directory name. Ideally this should not match "notautoinstalled". Good point. Should we do the exact match for the directories. That seems like the right thing to do. Proposed patch would be something like: - if any(directory in prefix for directory in IGNORE_DIRECTORIES): + if any(directory==prefix for directory in IGNORE_DIRECTORIES): 1699895 9 aakash_jain 2020-10-20 13:18:07 -0700 (In reply to Aakash Jain from comment #8) > (In reply to Darin Adler from comment #7) > > It looks like we are using substring matching for directory names, but we want to know if this is exactly a directory name. Ideally this should not match "notautoinstalled". > Good point. Should we do the exact match for the directories. That seems > like the right thing to do. Proposed patch would be something like: > > - if any(directory in prefix for directory in IGNORE_DIRECTORIES): > + if any(directory==prefix for directory in IGNORE_DIRECTORIES): Ignore my above comment, just noticed that prefix contains the complete path. 1699899 10 aakash_jain 2020-10-20 13:24:36 -0700 Reopening to attach minor follow-up patch. 1699900 11 411908 aakash_jain 2020-10-20 13:25:58 -0700 Created attachment 411908 Patch 1699913 12 411908 darin 2020-10-20 14:07:37 -0700 Comment on attachment 411908 Patch For now, this is OK. 1699915 13 darin 2020-10-20 14:08:42 -0700 (In reply to Aakash Jain from comment #8) > (In reply to Darin Adler from comment #7) > > It looks like we are using substring matching for directory names, but we want to know if this is exactly a directory name. Ideally this should not match "notautoinstalled". > Good point. Should we do the exact match for the directories. That seems > like the right thing to do. Proposed patch would be something like: > > - if any(directory in prefix for directory in IGNORE_DIRECTORIES): > + if any(directory==prefix for directory in IGNORE_DIRECTORIES): Maybe: if any(directory.endsWith("/" + prefix) for directory in IGNORE_DIRECTORIES): Would that work? 1699939 14 ews-feeder 2020-10-20 15:01:10 -0700 Committed r268763: <https://trac.webkit.org/changeset/268763> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411908. 1699969 15 aakash_jain 2020-10-20 15:39:07 -0700 (In reply to Darin Adler from comment #13) > Maybe: > > if any(directory.endsWith("/" + prefix) for directory in > IGNORE_DIRECTORIES): > > Would that work? That doesn't seem to work. Uploaded patch in https://bugs.webkit.org/show_bug.cgi?id=217993 which seems to work fine. 411887 2020-10-20 10:47:41 -0700 2020-10-20 11:32:00 -0700 Patch bug-217972-20201020134740.patch text/plain 2699 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2ODc0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTEwLTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBNYWtlIHJlcG9ydC1ub24taW5jbHVzaXZlLWxhbmd1YWdlIGlnbm9yZSBh dXRvaW5zdGFsbGVkIGRpcmVjdG9yaWVzIGFuZCBsb2cgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzk3MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9yZXBvcnQtbm9uLWluY2x1 c2l2ZS1sYW5ndWFnZTogc3RhcnRzd2l0aCBhbmQgZW5kc3dpdGggYWxzbyB0YWtlcyBhIHR1cGxl IG9mIHN1ZmZpeGVzIHRvCisgICAgICAgIGxvb2sgZm9yLCByZWZlcmVuY2U6IGh0dHBzOi8vZG9j cy5weXRob24ub3JnLzMvbGlicmFyeS9zdGR0eXBlcy5odG1sI3N0ci5lbmRzd2l0aAorCiAyMDIw LTEwLTIwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgogCiAgICAg ICAgIFRlc3RPcHRpb25zR2VuZXJhdGVkS2V5cy5oOjMwOjUyOiB3YXJuaW5nOiBiYWNrc2xhc2gt bmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogVG9vbHMvU2NyaXB0cy9yZXBvcnQtbm9uLWlu Y2x1c2l2ZS1sYW5ndWFnZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3JlcG9ydC1ub24t aW5jbHVzaXZlLWxhbmd1YWdlCShyZXZpc2lvbiAyNjg3NDcpCisrKyBUb29scy9TY3JpcHRzL3Jl cG9ydC1ub24taW5jbHVzaXZlLWxhbmd1YWdlCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw4ICszMyw2 IEBAIGltcG9ydCBhcmdwYXJzZSwgb3MsIHJlCiAjICAgQ2xldmVyIGRlZmF1bHQgZm9yIHVzZSBv biBXZWJLaXQgc291cmNlIHRyZWUgaW5zdGVhZCBvZiBjdXJyZW50IGRpcmVjdG9yeSBieSBkZWZh dWx0LgogIyAgIFJlcG9ydCB0aGlyZCBwYXJ0eSBzb3VyY2VzIHNlcGFyYXRlbHkgZnJvbSBXZWJL aXQgcHJvamVjdCBmaWxlcy4KICMgICBTa2lwIGtub3duIGV4YW1wbGVzIG9uIGFuIGV4Y2VwdGlv biBsaXN0IHRoYXQgd2UgZG9uJ3QgaW50ZW5kIHRvIGZpeC4KLSMgICBSZXBsYWNlIHNwZWNpYWwg Y2FzZXMgZm9yIENoYW5nZUxvZywgIi5vcmRlciIsICIueGN1c2Vyc3RhdGUiLCAiLmdpdCIsICIu c3ZuIgotIyAgIGZpbGVzIHdpdGggc29tZXRoaW5nIHNtYXJ0ZXIuCiAKICMgSGFyZC1jb2RlZCBm b3Igbm93LCBjb3VsZCByZWFkIHRoZXNlIG91dCBvZiBhIGZpbGUgaW5zdGVhZC4KICMgVGVybSwg dGhlbiB0aGUgcmVndWxhciBleHByZXNzaW9uIGZvciB0aGF0IHRlcm0uCkBAIC00NCw2ICs0Miwx MCBAQCBub25JbmNsdXNpdmVUZXJtcyA9IFsKICAgICBbICJzbGF2ZSIsICJzbGF2ZSIgXQogXQog CitJR05PUkVfRElSRUNUT1JJRVMgPSBbJy5zdm4nLCAnLmdpdCcsICdhdXRvaW5zdGFsbGVkJ10K K0lHTk9SRV9GSUxFU19TVEFSVElOR19XSVRIID0gKCdDaGFuZ2VMb2cnKQorSUdOT1JFX0ZJTEVT X0VORElOR19XSVRIID0gKCcub3JkZXInLCAnLnhjdXNlcnN0YXRlJywgJy5zd3AnLCAnLmxvZycp CisKIHBhcnNlciA9IGFyZ3BhcnNlLkFyZ3VtZW50UGFyc2VyKGRlc2NyaXB0aW9uPSdSZXBvcnQg Y291bnRzIGFuZCBsb2NhdGlvbnMgb2Ygbm9uLWluY2x1c2l2ZSB0ZXJtcy4nKQogcGFyc2VyLmFk ZF9hcmd1bWVudCgnLS12ZXJib3NlJywgJy12JywgYWN0aW9uPSdzdG9yZV90cnVlJyk7CiBhcmdz ID0gcGFyc2VyLnBhcnNlX2FyZ3MoKQpAQCAtNTYsMTYgKzU4LDEyIEBAIGZvciB0ZXJtIGluIG5v bkluY2x1c2l2ZVRlcm1zOgogcm9vdCA9IG9zLmdldGN3ZCgpCiBmb3Igc3Vicm9vdCwgZGlyZWN0 b3JpZXMsIGZpbGVzIGluIG9zLndhbGsocm9vdCk6CiAgICAgcHJlZml4ID0gc3Vicm9vdFtsZW4o cm9vdCkgKyAxOl0KLSAgICBpZiAiLnN2biIgaW4gcHJlZml4OgotICAgICAgICBjb250aW51ZQot ICAgIGlmICIuZ2l0IiBpbiBwcmVmaXg6CisgICAgaWYgYW55KGRpcmVjdG9yeSBpbiBwcmVmaXgg Zm9yIGRpcmVjdG9yeSBpbiBJR05PUkVfRElSRUNUT1JJRVMpOgogICAgICAgICBjb250aW51ZQog ICAgIGZvciBmaWxlIGluIGZpbGVzOgotICAgICAgICBpZiBmaWxlLnN0YXJ0c3dpdGgoIkNoYW5n ZUxvZyIpOgotICAgICAgICAgICAgY29udGludWUKLSAgICAgICAgaWYgZmlsZS5lbmRzd2l0aCgi Lm9yZGVyIik6CisgICAgICAgIGlmIGZpbGUuc3RhcnRzd2l0aChJR05PUkVfRklMRVNfU1RBUlRJ TkdfV0lUSCk6CiAgICAgICAgICAgICBjb250aW51ZQotICAgICAgICBpZiBmaWxlLmVuZHN3aXRo KCIueGN1c2Vyc3RhdGUiKToKKyAgICAgICAgaWYgZmlsZS5lbmRzd2l0aChJR05PUkVfRklMRVNf RU5ESU5HX1dJVEgpOgogICAgICAgICAgICAgY29udGludWUKICAgICAgICAgaGFuZGxlID0gb3Bl bihvcy5wYXRoLmpvaW4oc3Vicm9vdCwgZmlsZSksICJyIikKICAgICAgICAgZm9yIGxpbmUgaW4g aGFuZGxlLnJlYWRsaW5lcygpOgo= 411892 2020-10-20 11:31:13 -0700 2020-10-20 13:26:42 -0700 Patch bug-217972-20201020143112.patch text/plain 2711 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2ODc1MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTEwLTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBNYWtlIHJlcG9ydC1ub24taW5jbHVzaXZlLWxhbmd1YWdlIGlnbm9yZSBh dXRvaW5zdGFsbGVkIGRpcmVjdG9yaWVzIGFuZCBjZXJ0YWluIGZpbGUgdHlwZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzk3MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9yZXBvcnQt bm9uLWluY2x1c2l2ZS1sYW5ndWFnZTogc3RhcnRzd2l0aCBhbmQgZW5kc3dpdGggYWxzbyB0YWtl cyBhIHR1cGxlIG9mIHN1ZmZpeGVzIHRvCisgICAgICAgIGxvb2sgZm9yLCByZWZlcmVuY2U6IGh0 dHBzOi8vZG9jcy5weXRob24ub3JnLzMvbGlicmFyeS9zdGR0eXBlcy5odG1sI3N0ci5lbmRzd2l0 aAorCiAyMDIwLTEwLTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAog ICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVXNlIGJ1aWxkZXIgdGFncyBpbnN0ZWFkIG9mIGNh dGVnb3J5IGZvciBsYXRlc3QgYnVpbGRib3QKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcmVwb3J0LW5v bi1pbmNsdXNpdmUtbGFuZ3VhZ2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9yZXBvcnQt bm9uLWluY2x1c2l2ZS1sYW5ndWFnZQkocmV2aXNpb24gMjY4NzUwKQorKysgVG9vbHMvU2NyaXB0 cy9yZXBvcnQtbm9uLWluY2x1c2l2ZS1sYW5ndWFnZQkod29ya2luZyBjb3B5KQpAQCAtMzMsOCAr MzMsNiBAQCBpbXBvcnQgYXJncGFyc2UsIG9zLCByZQogIyAgIENsZXZlciBkZWZhdWx0IGZvciB1 c2Ugb24gV2ViS2l0IHNvdXJjZSB0cmVlIGluc3RlYWQgb2YgY3VycmVudCBkaXJlY3RvcnkgYnkg ZGVmYXVsdC4KICMgICBSZXBvcnQgdGhpcmQgcGFydHkgc291cmNlcyBzZXBhcmF0ZWx5IGZyb20g V2ViS2l0IHByb2plY3QgZmlsZXMuCiAjICAgU2tpcCBrbm93biBleGFtcGxlcyBvbiBhbiBleGNl cHRpb24gbGlzdCB0aGF0IHdlIGRvbid0IGludGVuZCB0byBmaXguCi0jICAgUmVwbGFjZSBzcGVj aWFsIGNhc2VzIGZvciBDaGFuZ2VMb2csICIub3JkZXIiLCAiLnhjdXNlcnN0YXRlIiwgIi5naXQi LCAiLnN2biIKLSMgICBmaWxlcyB3aXRoIHNvbWV0aGluZyBzbWFydGVyLgogCiAjIEhhcmQtY29k ZWQgZm9yIG5vdywgY291bGQgcmVhZCB0aGVzZSBvdXQgb2YgYSBmaWxlIGluc3RlYWQuCiAjIFRl cm0sIHRoZW4gdGhlIHJlZ3VsYXIgZXhwcmVzc2lvbiBmb3IgdGhhdCB0ZXJtLgpAQCAtNDQsNiAr NDIsMTAgQEAgbm9uSW5jbHVzaXZlVGVybXMgPSBbCiAgICAgWyAic2xhdmUiLCAic2xhdmUiIF0K IF0KIAorSUdOT1JFX0RJUkVDVE9SSUVTID0gWycuc3ZuJywgJy5naXQnLCAnYXV0b2luc3RhbGxl ZCddCitJR05PUkVfRklMRVNfU1RBUlRJTkdfV0lUSCA9ICgnQ2hhbmdlTG9nJykKK0lHTk9SRV9G SUxFU19FTkRJTkdfV0lUSCA9ICgnLmxvZycsICcub3JkZXInLCAnLnB5YycsICcuc3dwJywgJy54 Y3VzZXJzdGF0ZScpCisKIHBhcnNlciA9IGFyZ3BhcnNlLkFyZ3VtZW50UGFyc2VyKGRlc2NyaXB0 aW9uPSdSZXBvcnQgY291bnRzIGFuZCBsb2NhdGlvbnMgb2Ygbm9uLWluY2x1c2l2ZSB0ZXJtcy4n KQogcGFyc2VyLmFkZF9hcmd1bWVudCgnLS12ZXJib3NlJywgJy12JywgYWN0aW9uPSdzdG9yZV90 cnVlJyk7CiBhcmdzID0gcGFyc2VyLnBhcnNlX2FyZ3MoKQpAQCAtNTYsMTYgKzU4LDEyIEBAIGZv ciB0ZXJtIGluIG5vbkluY2x1c2l2ZVRlcm1zOgogcm9vdCA9IG9zLmdldGN3ZCgpCiBmb3Igc3Vi cm9vdCwgZGlyZWN0b3JpZXMsIGZpbGVzIGluIG9zLndhbGsocm9vdCk6CiAgICAgcHJlZml4ID0g c3Vicm9vdFtsZW4ocm9vdCkgKyAxOl0KLSAgICBpZiAiLnN2biIgaW4gcHJlZml4OgotICAgICAg ICBjb250aW51ZQotICAgIGlmICIuZ2l0IiBpbiBwcmVmaXg6CisgICAgaWYgYW55KGRpcmVjdG9y eSBpbiBwcmVmaXggZm9yIGRpcmVjdG9yeSBpbiBJR05PUkVfRElSRUNUT1JJRVMpOgogICAgICAg ICBjb250aW51ZQogICAgIGZvciBmaWxlIGluIGZpbGVzOgotICAgICAgICBpZiBmaWxlLnN0YXJ0 c3dpdGgoIkNoYW5nZUxvZyIpOgotICAgICAgICAgICAgY29udGludWUKLSAgICAgICAgaWYgZmls ZS5lbmRzd2l0aCgiLm9yZGVyIik6CisgICAgICAgIGlmIGZpbGUuc3RhcnRzd2l0aChJR05PUkVf RklMRVNfU1RBUlRJTkdfV0lUSCk6CiAgICAgICAgICAgICBjb250aW51ZQotICAgICAgICBpZiBm aWxlLmVuZHN3aXRoKCIueGN1c2Vyc3RhdGUiKToKKyAgICAgICAgaWYgZmlsZS5lbmRzd2l0aChJ R05PUkVfRklMRVNfRU5ESU5HX1dJVEgpOgogICAgICAgICAgICAgY29udGludWUKICAgICAgICAg aGFuZGxlID0gb3Blbihvcy5wYXRoLmpvaW4oc3Vicm9vdCwgZmlsZSksICJyIikKICAgICAgICAg Zm9yIGxpbmUgaW4gaGFuZGxlLnJlYWRsaW5lcygpOgo= 411908 2020-10-20 13:25:58 -0700 2020-10-20 15:01:10 -0700 Patch bug-217972-20201020162557.patch text/plain 1685 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2ODc1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIwLTEwLTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBNYWtlIHJlcG9ydC1ub24taW5jbHVzaXZlLWxhbmd1YWdlIGlnbm9yZSBh dXRvaW5zdGFsbGVkIGRpcmVjdG9yaWVzIGFuZCBjZXJ0YWluIGZpbGUgdHlwZXMgKGZvbGxvdy11 cCBmaXgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTc5NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvcmVwb3J0LW5vbi1pbmNsdXNpdmUtbGFuZ3VhZ2U6IFJlbmFtZSBJR05PUkVfRElS RUNUT1JJRVMgdG8gSUdOT1JFX0RJUkVDVE9SSUVTX0NPTlRBSU5JTkcuCisKIDIwMjAtMTAtMjAg IEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgcmVw b3J0LW5vbi1pbmNsdXNpdmUtbGFuZ3VhZ2UgaWdub3JlIGF1dG9pbnN0YWxsZWQgZGlyZWN0b3Jp ZXMgYW5kIGNlcnRhaW4gZmlsZSB0eXBlcwpJbmRleDogVG9vbHMvU2NyaXB0cy9yZXBvcnQtbm9u LWluY2x1c2l2ZS1sYW5ndWFnZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3JlcG9ydC1u b24taW5jbHVzaXZlLWxhbmd1YWdlCShyZXZpc2lvbiAyNjg3NTcpCisrKyBUb29scy9TY3JpcHRz L3JlcG9ydC1ub24taW5jbHVzaXZlLWxhbmd1YWdlCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0 Miw3IEBAIG5vbkluY2x1c2l2ZVRlcm1zID0gWwogICAgIFsgInNsYXZlIiwgInNsYXZlIiBdCiBd CiAKLUlHTk9SRV9ESVJFQ1RPUklFUyA9IFsnLnN2bicsICcuZ2l0JywgJ2F1dG9pbnN0YWxsZWQn XQorSUdOT1JFX0RJUkVDVE9SSUVTX0NPTlRBSU5JTkcgPSBbJy5zdm4nLCAnLmdpdCcsICdhdXRv aW5zdGFsbGVkJ10KIElHTk9SRV9GSUxFU19TVEFSVElOR19XSVRIID0gKCdDaGFuZ2VMb2cnKQog SUdOT1JFX0ZJTEVTX0VORElOR19XSVRIID0gKCcubG9nJywgJy5vcmRlcicsICcucHljJywgJy5z d3AnLCAnLnhjdXNlcnN0YXRlJykKIApAQCAtNTgsNyArNTgsNyBAQCBmb3IgdGVybSBpbiBub25J bmNsdXNpdmVUZXJtczoKIHJvb3QgPSBvcy5nZXRjd2QoKQogZm9yIHN1YnJvb3QsIGRpcmVjdG9y aWVzLCBmaWxlcyBpbiBvcy53YWxrKHJvb3QpOgogICAgIHByZWZpeCA9IHN1YnJvb3RbbGVuKHJv b3QpICsgMTpdCi0gICAgaWYgYW55KGRpcmVjdG9yeSBpbiBwcmVmaXggZm9yIGRpcmVjdG9yeSBp biBJR05PUkVfRElSRUNUT1JJRVMpOgorICAgIGlmIGFueShkaXJlY3RvcnkgaW4gcHJlZml4IGZv ciBkaXJlY3RvcnkgaW4gSUdOT1JFX0RJUkVDVE9SSUVTX0NPTlRBSU5JTkcpOgogICAgICAgICBj b250aW51ZQogICAgIGZvciBmaWxlIGluIGZpbGVzOgogICAgICAgICBpZiBmaWxlLnN0YXJ0c3dp dGgoSUdOT1JFX0ZJTEVTX1NUQVJUSU5HX1dJVEgpOgo=