217950 2020-10-20 06:05:58 -0700 WebDriver: handle key events with non-ASCII unicode code point 2020-10-22 02:42:29 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 166679 217951 1 cgarcia webkit-unassigned aperez bburg clopez webkit-bug-importer oldest_to_newest 1699690 0 cgarcia 2020-10-20 06:05:58 -0700 We are assuming that key events are limited to ASCII, but they contain a unicode code point. This makes several tests to fail: imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\xe0-] imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\u0416-] imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\u2603-] imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\uf6c2-] 1699691 1 411858 cgarcia 2020-10-20 06:09:20 -0700 Created attachment 411858 Patch I've remove the test expectations, but those tests are still failing due to https://github.com/web-platform-tests/wpt/pull/26183 1699744 2 webkit-bug-importer 2020-10-20 08:57:52 -0700 <rdar://problem/70487022> 1700587 3 cgarcia 2020-10-22 02:42:29 -0700 Committed r268858: <https://trac.webkit.org/changeset/268858> 411858 2020-10-20 06:09:20 -0700 2020-10-20 06:20:45 -0700 Patch wd-key-unicode.diff text/plain 5975 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTBiYThlNTA0YmQxLi4wMzg3MTY3N2M3MGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjMgQEAKKzIwMjAtMTAtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFdlYkRyaXZlcjogaGFuZGxlIGtleSBldmVudHMgd2l0aCBub24t QVNDSUkgdW5pY29kZSBjb2RlIHBvaW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTc5NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZSBhcmUgYXNzdW1pbmcgdGhhdCBrZXkgZXZlbnRzIGFyZSBsaW1p dGVkIHRvIEFTQ0lJLCBidXQgdGhleSBjb250YWluIGEgdW5pY29kZSBjb2RlIHBvaW50LgorCisg ICAgICAgIEZpeGVzOiBpbXBvcnRlZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL3BlcmZvcm1fYWN0aW9u cy9rZXlfZXZlbnRzLnB5Ojp0ZXN0X3ByaW50YWJsZV9rZXlfc2VuZHNfY29ycmVjdF9ldmVudHNb XHhlMC1dCisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL3BlcmZv cm1fYWN0aW9ucy9rZXlfZXZlbnRzLnB5Ojp0ZXN0X3ByaW50YWJsZV9rZXlfc2VuZHNfY29ycmVj dF9ldmVudHNbXHUwNDE2LV0KKyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWJkcml2ZXIv dGVzdHMvcGVyZm9ybV9hY3Rpb25zL2tleV9ldmVudHMucHk6OnRlc3RfcHJpbnRhYmxlX2tleV9z ZW5kc19jb3JyZWN0X2V2ZW50c1tcdTI2MDMtXQorICAgICAgICAgICAgICAgaW1wb3J0ZWQvdzNj L3dlYmRyaXZlci90ZXN0cy9wZXJmb3JtX2FjdGlvbnMva2V5X2V2ZW50cy5weTo6dGVzdF9wcmlu dGFibGVfa2V5X3NlbmRzX2NvcnJlY3RfZXZlbnRzW1x1ZjZjMi1dCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQXV0b21hdGlvbi9TaW11bGF0ZWRJbnB1dERpc3BhdGNoZXIuaDogVXNlIFVDaGFyMzIg aW5zdGVhZCBvZiBjaGFyIGZvciBDaGFyS2V5LgorICAgICAgICAqIFVJUHJvY2Vzcy9BdXRvbWF0 aW9uL2d0ay9XZWJBdXRvbWF0aW9uU2Vzc2lvbkd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YkF1dG9tYXRpb25TZXNzaW9uOjpwbGF0Zm9ybVNpbXVsYXRlS2V5Ym9hcmRJbnRlcmFjdGlvbik6 IEhhbmRsZSBDaGFya2V5IGFzIGEgdW5pY29kZSBjb2RlIHBvaW50LgorICAgICAgICAqIFVJUHJv Y2Vzcy9BdXRvbWF0aW9uL3dwZS9XZWJBdXRvbWF0aW9uU2Vzc2lvbldQRS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYkF1dG9tYXRpb25TZXNzaW9uOjpwbGF0Zm9ybVNpbXVsYXRlS2V5Ym9hcmRJ bnRlcmFjdGlvbik6IERpdHRvLgorCiAyMDIwLTEwLTIwICBTYW0gV2VpbmlnICA8d2VpbmlnQGFw cGxlLmNvbT4KIAogICAgICAgICBUd2VhayBXZWJQcmVmZXJlbmNlcyoueWFtbCAiZXhwb3NlZCIg a2V5IHRvIG9ubHkgaW5kaWNhdGUgdGhhdCB0aGUga2V5IHNob3VsZCBub3QgYmUgY2hhbmdlYWJs ZSBieSB0aGUgZnJvbnRlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1 dG9tYXRpb24vU2ltdWxhdGVkSW5wdXREaXNwYXRjaGVyLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BdXRvbWF0aW9uL1NpbXVsYXRlZElucHV0RGlzcGF0Y2hlci5oCmluZGV4IDg2ZmQ0Nzhm YzRjOS4uMmVmMDRmYTBjMTE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B dXRvbWF0aW9uL1NpbXVsYXRlZElucHV0RGlzcGF0Y2hlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0F1dG9tYXRpb24vU2ltdWxhdGVkSW5wdXREaXNwYXRjaGVyLmgKQEAgLTU3LDcg KzU3LDcgQEAgY2xhc3MgV2ViUGFnZVByb3h5OwogdXNpbmcgS2V5Ym9hcmRJbnRlcmFjdGlvbiA9 IEluc3BlY3Rvcjo6UHJvdG9jb2w6OkF1dG9tYXRpb246OktleWJvYXJkSW50ZXJhY3Rpb25UeXBl OwogdXNpbmcgVmlydHVhbEtleSA9IEluc3BlY3Rvcjo6UHJvdG9jb2w6OkF1dG9tYXRpb246OlZp cnR1YWxLZXk7CiB1c2luZyBWaXJ0dWFsS2V5TWFwID0gSGFzaE1hcDxWaXJ0dWFsS2V5LCBWaXJ0 dWFsS2V5LCBXVEY6OkludEhhc2g8VmlydHVhbEtleT4sIFdURjo6U3Ryb25nRW51bUhhc2hUcmFp dHM8VmlydHVhbEtleT4+OwotdXNpbmcgQ2hhcktleSA9IGNoYXI7IC8vIEZvciBXZWJEcml2ZXIs IHRoaXMgb25seSBuZWVkcyB0byBzdXBwb3J0IEFTQ0lJIGNoYXJhY3RlcnMgb24gMTAyLWtleSBr ZXlib2FyZC4KK3VzaW5nIENoYXJLZXkgPSBVQ2hhcjMyOwogdXNpbmcgTW91c2VCdXR0b24gPSBJ bnNwZWN0b3I6OlByb3RvY29sOjpBdXRvbWF0aW9uOjpNb3VzZUJ1dHRvbjsKIHVzaW5nIE1vdXNl SW50ZXJhY3Rpb24gPSBJbnNwZWN0b3I6OlByb3RvY29sOjpBdXRvbWF0aW9uOjpNb3VzZUludGVy YWN0aW9uOwogdXNpbmcgTW91c2VNb3ZlT3JpZ2luID0gSW5zcGVjdG9yOjpQcm90b2NvbDo6QXV0 b21hdGlvbjo6TW91c2VNb3ZlT3JpZ2luOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQXV0b21hdGlvbi9ndGsvV2ViQXV0b21hdGlvblNlc3Npb25HdGsuY3BwIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9ndGsvV2ViQXV0b21hdGlvblNlc3Npb25HdGsu Y3BwCmluZGV4IGE2MWQ3N2VlYWFlOC4uMzE4YjhhMmY0YTZmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL2d0ay9XZWJBdXRvbWF0aW9uU2Vzc2lvbkd0ay5j cHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9ndGsvV2ViQXV0b21h dGlvblNlc3Npb25HdGsuY3BwCkBAIC0yOTIsNyArMjkyLDcgQEAgdm9pZCBXZWJBdXRvbWF0aW9u U2Vzc2lvbjo6cGxhdGZvcm1TaW11bGF0ZUtleWJvYXJkSW50ZXJhY3Rpb24oV2ViUGFnZVByb3h5 JiBwYWcKICAgICAgICAgICAgIGtleUNvZGUgPSBrZXlDb2RlRm9yVmlydHVhbEtleSh2aXJ0dWFs S2V5KTsKICAgICAgICAgfSwKICAgICAgICAgWyZdIChDaGFyS2V5IGNoYXJLZXkpIHsKLSAgICAg ICAgICAgIGtleUNvZGUgPSBnZGtfdW5pY29kZV90b19rZXl2YWwoZ191dGY4X2dldF9jaGFyKCZj aGFyS2V5KSk7CisgICAgICAgICAgICBrZXlDb2RlID0gZ2RrX3VuaWNvZGVfdG9fa2V5dmFsKGNo YXJLZXkpOwogICAgICAgICB9CiAgICAgKTsKICAgICB1bnNpZ25lZCBtb2RpZmllcnMgPSBtb2Rp ZmllcnNGb3JLZXlDb2RlKGtleUNvZGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQXV0b21hdGlvbi93cGUvV2ViQXV0b21hdGlvblNlc3Npb25XUEUuY3BwIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi93cGUvV2ViQXV0b21hdGlvblNlc3Npb25XUEUu Y3BwCmluZGV4IGNhZGJkZDNkNmI5My4uMjFiOWFkNzUzMTE4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL3dwZS9XZWJBdXRvbWF0aW9uU2Vzc2lvbldQRS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi93cGUvV2ViQXV0b21h dGlvblNlc3Npb25XUEUuY3BwCkBAIC0zMzMsNyArMzMzLDcgQEAgdm9pZCBXZWJBdXRvbWF0aW9u U2Vzc2lvbjo6cGxhdGZvcm1TaW11bGF0ZUtleWJvYXJkSW50ZXJhY3Rpb24oV2ViUGFnZVByb3h5 JiBwYWcKICAgICAgICAgICAgIGtleUNvZGUgPSBrZXlDb2RlRm9yVmlydHVhbEtleSh2aXJ0dWFs S2V5KTsKICAgICAgICAgfSwKICAgICAgICAgWyZdIChDaGFyS2V5IGNoYXJLZXkpIHsKLSAgICAg ICAgICAgIGtleUNvZGUgPSB3cGVfdW5pY29kZV90b19rZXlfY29kZShnX3V0ZjhfZ2V0X2NoYXIo JmNoYXJLZXkpKTsKKyAgICAgICAgICAgIGtleUNvZGUgPSB3cGVfdW5pY29kZV90b19rZXlfY29k ZShjaGFyS2V5KTsKICAgICAgICAgfQogICAgICk7CiAgICAgdWludDMyX3QgbW9kaWZpZXJzID0g bW9kaWZpZXJzRm9yS2V5Q29kZShrZXlDb2RlKTsKZGlmZiAtLWdpdCBhL1dlYkRyaXZlclRlc3Rz L0NoYW5nZUxvZyBiL1dlYkRyaXZlclRlc3RzL0NoYW5nZUxvZwppbmRleCA4NmYwYTgyYWFlNjku LjYyOTMzZjdmMDAwZSAxMDA2NDQKLS0tIGEvV2ViRHJpdmVyVGVzdHMvQ2hhbmdlTG9nCisrKyBi L1dlYkRyaXZlclRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTEwLTIwICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJE cml2ZXI6IGhhbmRsZSBrZXkgZXZlbnRzIHdpdGggbm9uLUFTQ0lJIHVuaWNvZGUgY29kZSBwb2lu dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3OTUw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3Zl IGV4cGVjdGF0aW9ucyBmb3IgdGVzdHMgdGhhdCBhcmUgbm93IHBhc3NpbmcuCisKKyAgICAgICAg KiBUZXN0RXhwZWN0YXRpb25zLmpzb246CisKIDIwMjAtMTAtMjAgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFdlYkRyaXZlcjogc3RhcnQgYSBo dHRwcyBzZXJ2ZXIgdG9vIGZvciB0ZXN0cwpkaWZmIC0tZ2l0IGEvV2ViRHJpdmVyVGVzdHMvVGVz dEV4cGVjdGF0aW9ucy5qc29uIGIvV2ViRHJpdmVyVGVzdHMvVGVzdEV4cGVjdGF0aW9ucy5qc29u CmluZGV4IGIzZjViNGNiMjc0MS4uZTAxM2Q1YWJkNGM3IDEwMDY0NAotLS0gYS9XZWJEcml2ZXJU ZXN0cy9UZXN0RXhwZWN0YXRpb25zLmpzb24KKysrIGIvV2ViRHJpdmVyVGVzdHMvVGVzdEV4cGVj dGF0aW9ucy5qc29uCkBAIC0yNTIsMTggKzI1Miw2IEBACiAgICAgICAgICAgICAidGVzdF9tb2Rp Zmllcl9rZXlfc2VuZHNfY29ycmVjdF9ldmVudHNbXFx1ZTA1My1SX01FVEFdIjogewogICAgICAg ICAgICAgICAgICJleHBlY3RlZCI6IHsiYWxsIjogeyJzdGF0dXMiOiBbIkZBSUwiXSwgImJ1ZyI6 ICJ3ZWJraXQub3JnL2IvMTg0OTY3In19CiAgICAgICAgICAgICB9LAotICAgICAgICAgICAgInRl c3RfcHJpbnRhYmxlX2tleV9zZW5kc19jb3JyZWN0X2V2ZW50c1tcXHhlMC1dIjogewotICAgICAg ICAgICAgICAgICJleHBlY3RlZCI6IHsiYWxsIjogeyJzdGF0dXMiOiBbIkZBSUwiXSwgImJ1ZyI6 ICJ3ZWJraXQub3JnL2IvMTg0OTY3In19Ci0gICAgICAgICAgICB9LAotICAgICAgICAgICAgInRl c3RfcHJpbnRhYmxlX2tleV9zZW5kc19jb3JyZWN0X2V2ZW50c1tcXHUwNDE2LV0iOiB7Ci0gICAg ICAgICAgICAgICAgImV4cGVjdGVkIjogeyJhbGwiOiB7InN0YXR1cyI6IFsiRkFJTCJdLCAiYnVn IjogIndlYmtpdC5vcmcvYi8xODQ5NjcifX0KLSAgICAgICAgICAgIH0sCi0gICAgICAgICAgICAi dGVzdF9wcmludGFibGVfa2V5X3NlbmRzX2NvcnJlY3RfZXZlbnRzW1xcdTI2MDMtXSI6IHsKLSAg ICAgICAgICAgICAgICAiZXhwZWN0ZWQiOiB7ImFsbCI6IHsic3RhdHVzIjogWyJGQUlMIl0sICJi dWciOiAid2Via2l0Lm9yZy9iLzE4NDk2NyJ9fQotICAgICAgICAgICAgfSwKLSAgICAgICAgICAg ICJ0ZXN0X3ByaW50YWJsZV9rZXlfc2VuZHNfY29ycmVjdF9ldmVudHNbXFx1ZjZjMi1dIjogewot ICAgICAgICAgICAgICAgICJleHBlY3RlZCI6IHsiYWxsIjogeyJzdGF0dXMiOiBbIkZBSUwiXSwg ImJ1ZyI6ICJ3ZWJraXQub3JnL2IvMTg0OTY3In19Ci0gICAgICAgICAgICB9LAogICAgICAgICAg ICAgInRlc3Rfc3BlY2lhbF9rZXlfc2VuZHNfa2V5ZG93bltNRVRBLWV4cGVjdGVkMzBdIjogewog ICAgICAgICAgICAgICAgICJleHBlY3RlZCI6IHsiYWxsIjogeyJzdGF0dXMiOiBbIkZBSUwiXSwg ImJ1ZyI6ICJ3ZWJraXQub3JnL2IvMTg0OTY3In19CiAgICAgICAgICAgICB9LAo=