217825 2020-10-16 07:25:00 -0700 [JHBuild] Update libwpe and wpebackend-fdo and add libmanette to minimal moduleset 2020-10-21 19:31:10 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217493 https://bugs.webkit.org/show_bug.cgi?id=218068 P2 Normal --- 1 clopez clopez agomez aperez bugs-noreply cgarcia clopez ews-watchlist ltilve mcatanzaro pnormand svillar oldest_to_newest 1698582 0 clopez 2020-10-16 07:25:00 -0700 libmanette 0.2.4 is required for enabling gamepad support, which defaults to on since r268389 for developer builds the version shipped by ubuntu-20.04 is not enough (0.2.3), so we should include this on the minimal moduleset which is used to generate the bundle products on the packaging bots. See: https://build.webkit.org/builders/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 meanwhile at this, seize to also update the libwpe and wpebackend-fdo libraries 1698583 1 411573 clopez 2020-10-16 07:28:03 -0700 Created attachment 411573 Patch 1698585 2 411573 aperez 2020-10-16 07:37:55 -0700 Comment on attachment 411573 Patch Whoops, I completely forgot about the JHBuild moduleset when doing the bit to enable the gamepad support for development builds. Thanks for this! View in context: https://bugs.webkit.org/attachment.cgi?id=411573&action=review > Tools/jhbuild/jhbuild-minimal.modules:102 > + <!-- libmanette >= 0.2.4 required for GamePad support --> Any reason to not use libmanette 0.2.5? 1698608 3 clopez 2020-10-16 08:26:26 -0700 (In reply to Adrian Perez from comment #2) > Comment on attachment 411573 [details] > Patch > > Whoops, I completely forgot about the JHBuild moduleset when doing the bit > to enable the gamepad support for development builds. Thanks for this! > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411573&action=review > > > Tools/jhbuild/jhbuild-minimal.modules:102 > > + <!-- libmanette >= 0.2.4 required for GamePad support --> > > Any reason to not use libmanette 0.2.5? Yes. The purpose of the minimal moduleset is to only build the libraries if the system one is not new enough. That is why the libraries listed there include a <pkg-config> entry. That tells jhbuild to first search for that library on the system and if the version shipped by the system is equal or newer than the version listed on the module, then it skips building that library. This way is possible to only build the library if is really needed. If i list a version newer than the minimum required then the above trick won't work and it may end building the library when the one shipped by the system was enough. This minimal moduleset is just used for the packaging bots and for using it you have to export an environment variable WEBKIT_JHBUILD_MODULESET=minimal See bug 213614 1698609 4 411573 clopez 2020-10-16 08:27:24 -0700 Comment on attachment 411573 Patch Clearing flags on attachment: 411573 Committed r268591: <https://trac.webkit.org/changeset/268591> 1698610 5 clopez 2020-10-16 08:27:28 -0700 All reviewed patches have been landed. Closing bug. 411573 2020-10-16 07:28:03 -0700 2020-10-16 08:27:24 -0700 Patch bug-217825-20201016162802.patch text/plain 5900 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjczOGMwZmYwZTQzNDBhNzBiZjZmMWQyNGUyMDYwN2Rj YmM1NzBiMS4uYWYyNDdmZmQ3NDMxMjE2NzhhNDZlMzVmZTE1YjNkNzE0ZGJiN2IzYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIwLTEwLTE2ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtKSEJ1aWxkXSBVcGRhdGUgbGlid3BlIGFuZCB3cGViYWNrZW5k LWZkbyBhbmQgYWRkIGxpYm1hbmV0dGUgdG8gbWluaW1hbCBtb2R1bGVzZXQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzgyNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGxpYm1hbmV0dGUgMC4yLjQgaXMg cmVxdWlyZWQgZm9yIGVuYWJsaW5nIGdhbWVwYWQgc3VwcG9ydCwgd2hpY2gKKyAgICAgICAgZGVm YXVsdHMgdG8gb24gc2luY2UgcjI2ODM4OSBmb3IgZGV2ZWxvcGVyIGJ1aWxkcy4gVGhlIHZlcnNp b24KKyAgICAgICAgc2hpcHBlZCBieSB1YnVudHUtMjAuMDQgaXMgbm90IGVub3VnaCAoMC4yLjMp LCBzbyB3ZSBzaG91bGQgaW5jbHVkZQorICAgICAgICB0aGlzIG9uIHRoZSBtaW5pbWFsIG1vZHVs ZXNldCB3aGljaCBpcyB1c2VkIHRvIGdlbmVyYXRlIHRoZSBidW5kbGUKKyAgICAgICAgcHJvZHVj dHMgb24gdGhlIHBhY2thZ2luZyBib3RzLgorCisgICAgICAgIFNlaXplIHRvIGFsc28gdXBkYXRl IHRoZSBsaWJ3cGUgYW5kIHdwZWJhY2tlbmQtZmRvIGxpYnJhcmllcy4KKworICAgICAgICAqIGd0 ay9qaGJ1aWxkLm1vZHVsZXM6CisgICAgICAgICogamhidWlsZC9qaGJ1aWxkLW1pbmltYWwubW9k dWxlczoKKyAgICAgICAgKiB3cGUvamhidWlsZC5tb2R1bGVzOgorCiAyMDIwLTEwLTE2ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIEVu c3VyZSB0aGUgdGVzdHMgYXJlIHJ1biB3aXRoIFVTL1BhY2lmaWMgdGltZSB6b25lCmRpZmYgLS1n aXQgYS9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxl cwppbmRleCA5ZmRiNmI3NWNhZWZkYmM4NTVlZTcyNDVmMjA2N2MzYTMzNGFjYmI2Li5hNmNkZTAy YzdiM2YyN2UyYWU5OWM2ZmEwZmQ5NDQ5ODA2NjRkMjE1IDEwMDY0NAotLS0gYS9Ub29scy9ndGsv amhidWlsZC5tb2R1bGVzCisrKyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKQEAgLTQ3MCw4 ICs0NzAsOSBAQAogICA8L2NtYWtlPgogCiAgIDxjbWFrZSBpZD0ibGlid3BlIj4KLSAgICA8YnJh bmNoIHJlcG89IndwZXdlYmtpdCIgbW9kdWxlPSJsaWJ3cGUtMS40LjAudGFyLnh6IiB2ZXJzaW9u PSIxLjQuMCIKLSAgICAgICAgICAgIGhhc2g9InNoYTI1NjplMmQzNDk0ZmMzM2ZlOTQ2YWQ5MTdm ZDZhM2FiZDEyNzQ2MmI5MWJiYTYyZWY4YjM1NTA3ZTkyZjhlZGU0MTg4Ii8+CisgICAgPGJyYW5j aCBtb2R1bGU9ImxpYndwZS0xLjguMC50YXIueHoiIHZlcnNpb249IjEuOC4wIgorICAgICAgICAg ICAgcmVwbz0id3Bld2Via2l0IgorICAgICAgICAgICAgaGFzaD0ic2hhMjU2OmE2ZjAwYTdkMDkx Y2JkNGRiNTdmZTdlZTNiNGMxMmM2MzUwOTIxZDY1NGVkNzk4MTI4MDBhMjZjODg4NDgxZDIiLz4K ICAgPC9jbWFrZT4KIAogICA8Y21ha2UgaWQ9IndwZWJhY2tlbmQtZmRvIj4KQEAgLTQ4MCw4ICs0 ODEsOSBAQAogICAgICAgPGRlcCBwYWNrYWdlPSJnbGliIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9 Im1lc2EiLz4KICAgICA8L2RlcGVuZGVuY2llcz4KLSAgICA8YnJhbmNoIHJlcG89IndwZXdlYmtp dCIgbW9kdWxlPSJ3cGViYWNrZW5kLWZkby0xLjQuMS50YXIueHoiIHZlcnNpb249IjEuNC4xIgot ICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjYyNDlhMGI3Y2JmYTY2MjIwNmE4ZDJmYTI0ZTJjNTc0 ZTc1YzY4MWFkMGU5MzQ2ODA5MWYxZGM2OGRkYjI5OWQiLz4KKyAgICA8YnJhbmNoIG1vZHVsZT0i d3BlYmFja2VuZC1mZG8tMS44LjAudGFyLnh6IiB2ZXJzaW9uPSIxLjguMCIKKyAgICAgICAgICAg IHJlcG89IndwZXdlYmtpdCIKKyAgICAgICAgICAgIGhhc2g9InNoYTI1Njo5NjUyYTk5Yzc1ZmUx YzZlYWIwNTg1YjYzOTVmNGUxMDRiMjQyN2U0ZDFmNDI5NjlmMWY3N2RmMjk5MjBkMjUzIi8+CiAg IDwvY21ha2U+CiAKICAgPCEtLSBEZXBlbmRlbmNpZXMgbGlzdGVkIGJlbG93IHRoaXMgcG9pbnQg YXJlIG5vdCB0aG91Z2h0IHRvIGFmZmVjdCB0ZXN0IHJlc3VsdHMsIGFuZCBhcmUgb25seQpkaWZm IC0tZ2l0IGEvVG9vbHMvamhidWlsZC9qaGJ1aWxkLW1pbmltYWwubW9kdWxlcyBiL1Rvb2xzL2po YnVpbGQvamhidWlsZC1taW5pbWFsLm1vZHVsZXMKaW5kZXggNTQ4YTBhZTZkYmI2YWNiNjg4MGQz OWFmYTBlNDA1NTBiYzY2MzM4Ni4uOTI5NTJkZWRlMzdjNWNjOWViMDQ5NDYyYmQ1ZGNjN2IzODk1 YjZhNSAxMDA2NDQKLS0tIGEvVG9vbHMvamhidWlsZC9qaGJ1aWxkLW1pbmltYWwubW9kdWxlcwor KysgYi9Ub29scy9qaGJ1aWxkL2poYnVpbGQtbWluaW1hbC5tb2R1bGVzCkBAIC03LDYgKzcsNyBA QAogICAgIDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9IndwZWJhY2tlbmQtZmRv Ii8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImxpYnNvdXAiLz4KKyAgICAgIDxkZXAgcGFja2FnZT0i bWFuZXR0ZSIvPgogICAgIDwvZGVwZW5kZW5jaWVzPgogICA8L21ldGFtb2R1bGU+CiAKQEAgLTYz LDE2ICs2NCwxOCBAQAogPCEtLSBJbiBvcmRlciB0byBlbnN1cmUgaXRzIG1pbmltYWwsIGFsbCB0 aGUgbW9kdWxlcyBzaG91bGQgaGF2ZSBhIHBrZy1jb25maWcgZGVjbGFyYXRpb24gbGluZSAtLT4K IAogICA8Y21ha2UgaWQ9ImxpYndwZSI+Ci0gICAgPGJyYW5jaCBtb2R1bGU9IldlYlBsYXRmb3Jt Rm9yRW1iZWRkZWQvbGlid3BlL3JlbGVhc2VzL2Rvd25sb2FkLzEuNi4wL2xpYndwZS0xLjYuMC50 YXIueHoiIHZlcnNpb249IjEuNi4wIgotICAgICAgICAgICAgcmVwbz0iZ2l0aHViLXRhcmJhbGwi Ci0gICAgICAgICAgICBoYXNoPSIzNTg3YzZiOGE4MDdmNGJiNzZiMjY4YmE3NGNhODJjNmIzOTVi OTAyMzVkYjQxYWQ4MjUyMjI0NDU2MTkzYzkwIi8+CisgICAgPGJyYW5jaCBtb2R1bGU9ImxpYndw ZS0xLjguMC50YXIueHoiIHZlcnNpb249IjEuOC4wIgorICAgICAgICAgICAgcmVwbz0id3Bld2Vi a2l0IgorICAgICAgICAgICAgaGFzaD0ic2hhMjU2OmE2ZjAwYTdkMDkxY2JkNGRiNTdmZTdlZTNi NGMxMmM2MzUwOTIxZDY1NGVkNzk4MTI4MDBhMjZjODg4NDgxZDIiLz4KICAgPC9jbWFrZT4KIAog ICA8Y21ha2UgaWQ9IndwZWJhY2tlbmQtZmRvIj4KICAgICA8ZGVwZW5kZW5jaWVzPgogICAgICAg PGRlcCBwYWNrYWdlPSJsaWJ3cGUiLz4KICAgICA8L2RlcGVuZGVuY2llcz4KLSAgICA8YnJhbmNo IHJlcG89ImdpdGh1Yi5jb20iIG1vZHVsZT0iSWdhbGlhL1dQRUJhY2tlbmQtZmRvLmdpdCIgY2hl Y2tvdXRkaXI9IndwZWJhY2tlbmQtZmRvIiB0YWc9IjEuMy4xLTU0LWcxZjU4ZWJkZjYzMmZkZjkw ZjY5MTk0OWQ5MGM4MzM4YThkNzA3M2M3Ii8+CisgICAgPGJyYW5jaCBtb2R1bGU9IndwZWJhY2tl bmQtZmRvLTEuOC4wLnRhci54eiIgdmVyc2lvbj0iMS44LjAiCisgICAgICAgICAgICByZXBvPSJ3 cGV3ZWJraXQiCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6OTY1MmE5OWM3NWZlMWM2ZWFiMDU4 NWI2Mzk1ZjRlMTA0YjI0MjdlNGQxZjQyOTY5ZjFmNzdkZjI5OTIwZDI1MyIvPgogICA8L2NtYWtl PgogCiAgIDwhLS0gbGlic291cCA+PSAyLjY5IHJlcXVpcmVkIGZvciBTYW1lU2l0ZSBjb29raWUg c3VwcG9ydCAtLT4KQEAgLTk2LDYgKzk5LDE2IEBACiAgICAgICAgICAgICBoYXNoPSJzaGEyNTY6 ZjhmZDBhZWI2NjI1MmRmY2M2MzhmMTRkOWJlMWUyMzYyZmRhZjJjYTg2YmRlMDQ0NGZmNGQ1Y2M5 NjFiNTYwZiIvPgogICA8L2F1dG90b29scz4KIAorICA8IS0tIGxpYm1hbmV0dGUgPj0gMC4yLjQg cmVxdWlyZWQgZm9yIEdhbWVQYWQgc3VwcG9ydCAtLT4KKyAgPG1lc29uIGlkPSJtYW5ldHRlIiBt ZXNvbmFyZ3M9Ii1EaW50cm9zcGVjdGlvbj1mYWxzZSAtRHZhcGk9ZmFsc2UiPgorICAgIDxwa2ct Y29uZmlnPm1hbmV0dGUtMC4yLnBjPC9wa2ctY29uZmlnPgorICAgIDxicmFuY2ggcmVwbz0iZnRw Lmdub21lLm9yZyIKKyAgICAgICAgICAgIG1vZHVsZT0iL3B1Yi9nbm9tZS9zb3VyY2VzL2xpYm1h bmV0dGUvMC4yL2xpYm1hbmV0dGUtMC4yLjQudGFyLnh6IgorICAgICAgICAgICAgdmVyc2lvbj0i MC4yLjQiCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6NGZlMGE0YmVkNmI0YzNhZTcyNDlkMzQx MDMxYzI3YjMyZjhkOWUwZmZiNTMzN2Q3MWNiY2VjNzE2MDM2MmNmNyIvPgorICA8L21lc29uPgor CisKICAgPCEtLSBtZXNvbiAwLjUwLjEgcmVxdWlyZWQgdG8gYnVpbGQgbGlic291cCAyLjY5IC0t PgogICA8ZGlzdHV0aWxzIGlkPSJtZXNvbiIgcHl0aG9uMz0iMSI+CiAgICAgPGJyYW5jaCByZXBv PSJnaXRodWItdGFyYmFsbCIKZGlmZiAtLWdpdCBhL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMg Yi9Ub29scy93cGUvamhidWlsZC5tb2R1bGVzCmluZGV4IDNiYzU5NWU5OTVlYzZmNWI0ZWE5OWQw NTdkOTlmOGM2MjUxOGJlMDAuLmZmYjZkNzU4MjI3NTBhMTA0NzNhZmUyOTgzZTkxODM1YjRmNTA4 MzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvd3Bl L2poYnVpbGQubW9kdWxlcwpAQCAtMTg2LDkgKzE4Niw5IEBACiAgIDwvYXV0b3Rvb2xzPgogCiAg IDxjbWFrZSBpZD0ibGlid3BlIj4KLSAgICA8YnJhbmNoIG1vZHVsZT0iV2ViUGxhdGZvcm1Gb3JF bWJlZGRlZC9saWJ3cGUvcmVsZWFzZXMvZG93bmxvYWQvMS42LjAvbGlid3BlLTEuNi4wLnRhci54 eiIgdmVyc2lvbj0iMS42LjAiCi0gICAgICAgICAgICByZXBvPSJnaXRodWItdGFyYmFsbCIKLSAg ICAgICAgICAgIGhhc2g9IjM1ODdjNmI4YTgwN2Y0YmI3NmIyNjhiYTc0Y2E4MmM2YjM5NWI5MDIz NWRiNDFhZDgyNTIyMjQ0NTYxOTNjOTAiLz4KKyAgICA8YnJhbmNoIG1vZHVsZT0ibGlid3BlLTEu OC4wLnRhci54eiIgdmVyc2lvbj0iMS44LjAiCisgICAgICAgICAgICByZXBvPSJ3cGV3ZWJraXQi CisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6YTZmMDBhN2QwOTFjYmQ0ZGI1N2ZlN2VlM2I0YzEy YzYzNTA5MjFkNjU0ZWQ3OTgxMjgwMGEyNmM4ODg0ODFkMiIvPgogICA8L2NtYWtlPgogCiAgIDxj bWFrZSBpZD0id3BlYmFja2VuZC1mZG8iPgpAQCAtMTk2LDcgKzE5Niw5IEBACiAgICAgICA8ZGVw IHBhY2thZ2U9ImxpYndwZSIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJnbGliIi8+CiAgICAgPC9k ZXBlbmRlbmNpZXM+Ci0gICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9IklnYWxp YS9XUEVCYWNrZW5kLWZkby5naXQiIGNoZWNrb3V0ZGlyPSJ3cGViYWNrZW5kLWZkbyIgdGFnPSIx LjMuMS01NC1nMWY1OGViZGY2MzJmZGY5MGY2OTE5NDlkOTBjODMzOGE4ZDcwNzNjNyIvPgorICAg IDxicmFuY2ggbW9kdWxlPSJ3cGViYWNrZW5kLWZkby0xLjguMC50YXIueHoiIHZlcnNpb249IjEu OC4wIgorICAgICAgICAgICAgcmVwbz0id3Bld2Via2l0IgorICAgICAgICAgICAgaGFzaD0ic2hh MjU2Ojk2NTJhOTljNzVmZTFjNmVhYjA1ODViNjM5NWY0ZTEwNGIyNDI3ZTRkMWY0Mjk2OWYxZjc3 ZGYyOTkyMGQyNTMiLz4KICAgPC9jbWFrZT4KIAogICA8YXV0b3Rvb2xzIGlkPSJsaWJncGctZXJy b3IiIGF1dG9nZW4tc2g9ImF1dG9yZWNvbmYiPgo=