217775 2020-10-15 12:30:30 -0700 Use std::fill_n() instead of for loops in AudioParamTimeline 2020-10-15 14:27:21 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212611 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble philipj sam sergio webkit-bug-importer oldest_to_newest 1698223 0 cdumez 2020-10-15 12:30:30 -0700 Use std::fill_n() instead of for loops in AudioParamTimeline. 1698224 1 411472 cdumez 2020-10-15 12:31:40 -0700 Created attachment 411472 Patch 1698282 2 ews-feeder 2020-10-15 14:27:01 -0700 Committed r268555: <https://trac.webkit.org/changeset/268555> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411472. 1698283 3 webkit-bug-importer 2020-10-15 14:27:21 -0700 <rdar://problem/70352124> 411472 2020-10-15 12:31:40 -0700 2020-10-15 14:27:01 -0700 Patch bug-217775-20201015123139.patch text/plain 6865 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTllNDRlMzgzYzc2NTU1 YzY0NDA4NDkyZWY3ZWRiNGMzNjRjNTY3MC4uNDczOThkYTMyNGEwYzFkMTMwYzRiYTM0OTY2ODU1 Y2YyMWQ3MjJhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTEwLTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIHN0ZDo6ZmlsbF9uKCkg aW5zdGVhZCBvZiBmb3IgbG9vcHMgaW4gQXVkaW9QYXJhbVRpbWVsaW5lCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc3NzUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ugc3RkOjpmaWxsX24oKSBpbnN0 ZWFkIG9mIGZvciBsb29wcyBpbiBBdWRpb1BhcmFtVGltZWxpbmUuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBubyBXZWIgZmFjaW5nIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIE1vZHVs ZXMvd2ViYXVkaW8vQXVkaW9QYXJhbVRpbWVsaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmZp bGxXaXRoVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9QYXJhbVRpbWVsaW5lOjp2YWx1 ZXNGb3JGcmFtZVJhbmdlKToKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvUGFyYW1UaW1lbGluZTo6 dmFsdWVzRm9yRnJhbWVSYW5nZUltcGwpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9QYXJhbVRp bWVsaW5lOjpwcm9jZXNzRXhwb25lbnRpYWxSYW1wKToKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlv UGFyYW1UaW1lbGluZTo6cHJvY2Vzc0NhbmNlbFZhbHVlcyk6CisgICAgICAgIChXZWJDb3JlOjpB dWRpb1BhcmFtVGltZWxpbmU6OnByb2Nlc3NTZXRUYXJnZXQpOgorICAgICAgICAoV2ViQ29yZTo6 QXVkaW9QYXJhbVRpbWVsaW5lOjpwcm9jZXNzU2V0VmFsdWVDdXJ2ZSk6CisKIDIwMjAtMTAtMTUg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVc2Ugc3RkOjpmaWxs X24oKSBpbnN0ZWFkIG9mIGZvciBsb29wcyBpbiBBdWRpb1BhcmFtOjpjYWxjdWxhdGVGaW5hbFZh bHVlcygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlv UGFyYW1UaW1lbGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlv UGFyYW1UaW1lbGluZS5jcHAKaW5kZXggMzdhMDVjYjAwN2EwM2Q1YmFjNmMwNjliYmQ2ZmNmYjk1 MjA0NDBhMy4uOGY3YmNlOTYwOTczZWU5NjY2MjUwMTY5NmM4ZTY3NDQ1OGIwNmYyYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1BhcmFtVGltZWxpbmUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9QYXJhbVRpbWVs aW5lLmNwcApAQCAtMzcsNiArMzcsMTQgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitzdGF0 aWMgdm9pZCBmaWxsV2l0aFZhbHVlKGZsb2F0KiB2YWx1ZXMsIGZsb2F0IHZhbHVlLCB1bnNpZ25l ZCBlbmRGcmFtZSwgdW5zaWduZWQmIHdyaXRlSW5kZXgpCit7CisgICAgaWYgKHdyaXRlSW5kZXgg PCBlbmRGcmFtZSkgeworICAgICAgICBzdGQ6OmZpbGxfbih2YWx1ZXMgKyB3cml0ZUluZGV4LCBl bmRGcmFtZSAtIHdyaXRlSW5kZXgsIHZhbHVlKTsKKyAgICAgICAgd3JpdGVJbmRleCA9IGVuZEZy YW1lOworICAgIH0KK30KKwogLy8gVGVzdCB0aGF0IGZvciBhIFNldFRhcmdldCBldmVudCwgdGhl IGN1cnJlbnQgdmFsdWUgaXMgY2xvc2UgZW5vdWdoIHRvIHRoZSB0YXJnZXQgdmFsdWUgdGhhdAog Ly8gd2UgY2FuIGNvbnNpZGVyIHRoZSBldmVudCB0byBoYXZlIGNvbnZlcmdlZCB0byB0aGUgdGFy Z2V0Lgogc3RhdGljIGJvb2wgaGFzU2V0VGFyZ2V0Q29udmVyZ2VkKGZsb2F0IHZhbHVlLCBmbG9h dCB0YXJnZXQsIFNlY29uZHMgY3VycmVudFRpbWUsIFNlY29uZHMgc3RhcnRUaW1lLCBkb3VibGUg dGltZUNvbnN0YW50KQpAQCAtMzM5LDEwICszNDcsNyBAQCBmbG9hdCBBdWRpb1BhcmFtVGltZWxp bmU6OnZhbHVlc0ZvckZyYW1lUmFuZ2Uoc2l6ZV90IHN0YXJ0RnJhbWUsIHNpemVfdCBlbmRGcmFt ZQogICAgIC8vIFdlIGNhbid0IGNvbnRlbmQgdGhlIGxvY2sgaW4gdGhlIHJlYWx0aW1lIGF1ZGlv IHRocmVhZC4KICAgICBhdXRvIGxvY2tlciA9IHRyeUhvbGRMb2NrKG1fZXZlbnRzTG9jayk7CiAg ICAgaWYgKCFsb2NrZXIpIHsKLSAgICAgICAgaWYgKHZhbHVlcykgewotICAgICAgICAgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IG51bWJlck9mVmFsdWVzOyArK2kpCi0gICAgICAgICAgICAg ICAgdmFsdWVzW2ldID0gZGVmYXVsdFZhbHVlOwotICAgICAgICB9CisgICAgICAgIHN0ZDo6Zmls bF9uKHZhbHVlcywgbnVtYmVyT2ZWYWx1ZXMsIGRlZmF1bHRWYWx1ZSk7CiAgICAgICAgIHJldHVy biBkZWZhdWx0VmFsdWU7CiAgICAgfQogCkBAIC0zNjQsOCArMzY5LDcgQEAgZmxvYXQgQXVkaW9Q YXJhbVRpbWVsaW5lOjp2YWx1ZXNGb3JGcmFtZVJhbmdlSW1wbChzaXplX3Qgc3RhcnRGcmFtZSwg c2l6ZV90IGVuZEYKIAogICAgIC8vIFJldHVybiBkZWZhdWx0IHZhbHVlIGlmIHRoZXJlIGFyZSBu byBldmVudHMgbWF0Y2hpbmcgdGhlIGRlc2lyZWQgdGltZSByYW5nZS4KICAgICBpZiAoIW1fZXZl bnRzLnNpemUoKSB8fCBlbmRGcmFtZSAqIHNhbXBsaW5nUGVyaW9kIDw9IG1fZXZlbnRzWzBdLT50 aW1lKCkudmFsdWUoKSkgewotICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbnVtYmVy T2ZWYWx1ZXM7ICsraSkKLSAgICAgICAgICAgIHZhbHVlc1tpXSA9IGRlZmF1bHRWYWx1ZTsKKyAg ICAgICAgc3RkOjpmaWxsX24odmFsdWVzLCBudW1iZXJPZlZhbHVlcywgZGVmYXVsdFZhbHVlKTsK ICAgICAgICAgcmV0dXJuIGRlZmF1bHRWYWx1ZTsKICAgICB9CiAKQEAgLTM4NSw4ICszODksNyBA QCBmbG9hdCBBdWRpb1BhcmFtVGltZWxpbmU6OnZhbHVlc0ZvckZyYW1lUmFuZ2VJbXBsKHNpemVf dCBzdGFydEZyYW1lLCBzaXplX3QgZW5kRgogCiAgICAgICAgIHVuc2lnbmVkIGZpbGxUb0ZyYW1l ID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGZpbGxUb0VuZEZyYW1lIC0gc3RhcnRGcmFtZSk7CiAg ICAgICAgIGZpbGxUb0ZyYW1lID0gc3RkOjptaW4oZmlsbFRvRnJhbWUsIG51bWJlck9mVmFsdWVz KTsKLSAgICAgICAgZm9yICg7IHdyaXRlSW5kZXggPCBmaWxsVG9GcmFtZTsgKyt3cml0ZUluZGV4 KQotICAgICAgICAgICAgdmFsdWVzW3dyaXRlSW5kZXhdID0gZGVmYXVsdFZhbHVlOworICAgICAg ICBmaWxsV2l0aFZhbHVlKHZhbHVlcywgZGVmYXVsdFZhbHVlLCBmaWxsVG9GcmFtZSwgd3JpdGVJ bmRleCk7CiAKICAgICAgICAgY3VycmVudEZyYW1lICs9IGZpbGxUb0ZyYW1lOwogICAgIH0KQEAg LTQ1OSw5ICs0NjIsNyBAQCBmbG9hdCBBdWRpb1BhcmFtVGltZWxpbmU6OnZhbHVlc0ZvckZyYW1l UmFuZ2VJbXBsKHNpemVfdCBzdGFydEZyYW1lLCBzaXplX3QgZW5kRgogCiAgICAgICAgICAgICAg ICAgLy8gU2ltcGx5IHN0YXkgYXQgYSBjb25zdGFudCB2YWx1ZS4KICAgICAgICAgICAgICAgICB2 YWx1ZSA9IGV2ZW50LT52YWx1ZSgpOwotICAgICAgICAgICAgICAgIGZvciAoOyB3cml0ZUluZGV4 IDwgZmlsbFRvRnJhbWU7ICsrd3JpdGVJbmRleCkKLSAgICAgICAgICAgICAgICAgICAgdmFsdWVz W3dyaXRlSW5kZXhdID0gdmFsdWU7Ci0KKyAgICAgICAgICAgICAgICBmaWxsV2l0aFZhbHVlKHZh bHVlcywgdmFsdWUsIGZpbGxUb0ZyYW1lLCB3cml0ZUluZGV4KTsKICAgICAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgICAgIGNhc2UgUGFyYW1FdmVudDo6Q2FuY2VsVmFsdWVzOgogICAgICAg ICAgICAgICAgIHByb2Nlc3NDYW5jZWxWYWx1ZXMoY3VycmVudFN0YXRlLCB2YWx1ZXMsIGN1cnJl bnRGcmFtZSwgdmFsdWUsIHdyaXRlSW5kZXgpOwpAQCAtNDgxLDggKzQ4Miw3IEBAIGZsb2F0IEF1 ZGlvUGFyYW1UaW1lbGluZTo6dmFsdWVzRm9yRnJhbWVSYW5nZUltcGwoc2l6ZV90IHN0YXJ0RnJh bWUsIHNpemVfdCBlbmRGCiAKICAgICAvLyBJZiB0aGVyZSdzIGFueSB0aW1lIGxlZnQgYWZ0ZXIg cHJvY2Vzc2luZyB0aGUgbGFzdCBldmVudCB0aGVuIGp1c3QgcHJvcGFnYXRlIHRoZSBsYXN0IHZh bHVlCiAgICAgLy8gdG8gdGhlIGVuZCBvZiB0aGUgdmFsdWVzIGJ1ZmZlci4KLSAgICBmb3IgKDsg d3JpdGVJbmRleCA8IG51bWJlck9mVmFsdWVzOyArK3dyaXRlSW5kZXgpCi0gICAgICAgIHZhbHVl c1t3cml0ZUluZGV4XSA9IHZhbHVlOworICAgIGZpbGxXaXRoVmFsdWUodmFsdWVzLCB2YWx1ZSwg bnVtYmVyT2ZWYWx1ZXMsIHdyaXRlSW5kZXgpOwogCiAgICAgcmV0dXJuIHZhbHVlOwogfQpAQCAt NTQ1LDggKzU0NSw3IEBAIHZvaWQgQXVkaW9QYXJhbVRpbWVsaW5lOjpwcm9jZXNzRXhwb25lbnRp YWxSYW1wKGNvbnN0IEF1dG9tYXRpb25TdGF0ZSYgY3VycmVudFN0CiAgICAgICAgIC8vIFBlciB0 aGUgc3BlY2lmaWNhdGlvbjoKICAgICAgICAgLy8gSWYgdmFsdWUxIGFuZCB2YWx1ZTIgaGF2ZSBv cHBvc2l0ZSBzaWducyBvciBpZiB2YWx1ZTEgaXMgemVybywgdGhlbiB2KHQpID0gdmFsdWUxIGZv ciBUMCA8PSB0IDwgVDEuCiAgICAgICAgIHZhbHVlID0gY3VycmVudFN0YXRlLnZhbHVlMTsKLSAg ICAgICAgZm9yICg7IHdyaXRlSW5kZXggPCBjdXJyZW50U3RhdGUuZmlsbFRvRnJhbWU7ICsrd3Jp dGVJbmRleCkKLSAgICAgICAgICAgIHZhbHVlc1t3cml0ZUluZGV4XSA9IHZhbHVlOworICAgICAg ICBmaWxsV2l0aFZhbHVlKHZhbHVlcywgdmFsdWUsIGN1cnJlbnRTdGF0ZS5maWxsVG9GcmFtZSwg d3JpdGVJbmRleCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTU5MSw4ICs1OTAsNyBA QCB2b2lkIEF1ZGlvUGFyYW1UaW1lbGluZTo6cHJvY2Vzc0NhbmNlbFZhbHVlcyhjb25zdCBBdXRv bWF0aW9uU3RhdGUmIGN1cnJlbnRTdGF0ZQogICAgICAgICB9CiAgICAgfQogCi0gICAgZm9yICg7 IHdyaXRlSW5kZXggPCBjdXJyZW50U3RhdGUuZmlsbFRvRnJhbWU7ICsrd3JpdGVJbmRleCkKLSAg ICAgICAgdmFsdWVzW3dyaXRlSW5kZXhdID0gdmFsdWU7CisgICAgZmlsbFdpdGhWYWx1ZSh2YWx1 ZXMsIHZhbHVlLCBjdXJyZW50U3RhdGUuZmlsbFRvRnJhbWUsIHdyaXRlSW5kZXgpOwogCiAgICAg Y3VycmVudEZyYW1lID0gY3VycmVudFN0YXRlLmZpbGxUb0VuZEZyYW1lOwogfQpAQCAtNjI2LDgg KzYyNCw3IEBAIHZvaWQgQXVkaW9QYXJhbVRpbWVsaW5lOjpwcm9jZXNzU2V0VGFyZ2V0KGNvbnN0 IEF1dG9tYXRpb25TdGF0ZSYgY3VycmVudFN0YXRlLCBmCiAgICAgLy8gd2l0aCB0aGUgdGFyZ2V0 IHZhbHVlLgogICAgIGlmIChoYXNTZXRUYXJnZXRDb252ZXJnZWQodmFsdWUsIHRhcmdldCwgU2Vj b25kcyB7IGN1cnJlbnRGcmFtZSAqIGN1cnJlbnRTdGF0ZS5zYW1wbGluZ1BlcmlvZCB9LCBjdXJy ZW50U3RhdGUudGltZTEsIHRpbWVDb25zdGFudCkpIHsKICAgICAgICAgY3VycmVudEZyYW1lICs9 IGN1cnJlbnRTdGF0ZS5maWxsVG9GcmFtZSAtIHdyaXRlSW5kZXg7Ci0gICAgICAgIGZvciAoOyB3 cml0ZUluZGV4IDwgY3VycmVudFN0YXRlLmZpbGxUb0ZyYW1lOyArK3dyaXRlSW5kZXgpCi0gICAg ICAgICAgICB2YWx1ZXNbd3JpdGVJbmRleF0gPSB0YXJnZXQ7CisgICAgICAgIGZpbGxXaXRoVmFs dWUodmFsdWVzLCB0YXJnZXQsIGN1cnJlbnRTdGF0ZS5maWxsVG9GcmFtZSwgd3JpdGVJbmRleCk7 CiAgICAgICAgIHZhbHVlID0gdGFyZ2V0OwogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAtNjkw LDggKzY4Nyw3IEBAIHZvaWQgQXVkaW9QYXJhbVRpbWVsaW5lOjpwcm9jZXNzU2V0VmFsdWVDdXJ2 ZShjb25zdCBBdXRvbWF0aW9uU3RhdGUmIGN1cnJlbnRTdGF0CiAgICAgaWYgKCFjdXJ2ZURhdGEg fHwgIW51bWJlck9mQ3VydmVQb2ludHMgfHwgZHVyYXRpb24gPD0gMF9zIHx8IGN1cnJlbnRTdGF0 ZS5zYW1wbGVSYXRlIDw9IDApIHsKICAgICAgICAgLy8gRXJyb3IgY29uZGl0aW9uIC0gc2ltcGx5 IHByb3BhZ2F0ZSBwcmV2aW91cyB2YWx1ZS4KICAgICAgICAgY3VycmVudEZyYW1lID0gZmlsbFRv RW5kRnJhbWU7Ci0gICAgICAgIGZvciAoOyB3cml0ZUluZGV4IDwgZmlsbFRvRnJhbWU7ICsrd3Jp dGVJbmRleCkKLSAgICAgICAgICAgIHZhbHVlc1t3cml0ZUluZGV4XSA9IHZhbHVlOworICAgICAg ICBmaWxsV2l0aFZhbHVlKHZhbHVlcywgdmFsdWUsIGZpbGxUb0ZyYW1lLCB3cml0ZUluZGV4KTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KIApAQCAtNzU4LDggKzc1NCw3IEBAIHZvaWQgQXVkaW9Q YXJhbVRpbWVsaW5lOjpwcm9jZXNzU2V0VmFsdWVDdXJ2ZShjb25zdCBBdXRvbWF0aW9uU3RhdGUm IGN1cnJlbnRTdGF0CiAgICAgLy8gb2YgdGhlIG5leHQsIHRoZW4ganVzdCBwcm9wYWdhdGUgdGhl IGxhc3QgdmFsdWUuCiAgICAgaWYgKHdyaXRlSW5kZXggPCBuZXh0RXZlbnRGaWxsVG9GcmFtZSkg ewogICAgICAgICB2YWx1ZSA9IGN1cnZlRW5kVmFsdWU7Ci0gICAgICAgIGZvciAoOyB3cml0ZUlu ZGV4IDwgbmV4dEV2ZW50RmlsbFRvRnJhbWU7ICsrd3JpdGVJbmRleCkKLSAgICAgICAgICAgIHZh bHVlc1t3cml0ZUluZGV4XSA9IHZhbHVlOworICAgICAgICBmaWxsV2l0aFZhbHVlKHZhbHVlcywg dmFsdWUsIG5leHRFdmVudEZpbGxUb0ZyYW1lLCB3cml0ZUluZGV4KTsKICAgICB9CiAKICAgICAv LyBSZS1hZGp1c3QgY3VycmVudCB0aW1lCg==