217627 2020-10-12 11:46:57 -0700 CSSStyleDeclaration includes descriptors 2020-10-26 16:47:07 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=217623 InRadar P2 Normal --- 1 gsnedders webkit-unassigned emilio esprehn+autocc ews-watchlist glenn gyuyoung.kim joepeck koivisto macpherson menard sam simon.fraser webkit-bug-importer oldest_to_newest 1696964 0 gsnedders 2020-10-12 11:46:57 -0700 e.g.: > "unicode-range" in document.body.style < true CSSStyleDeclaration should just contain properties, not descriptors. 1698445 1 gsnedders 2020-10-15 20:03:13 -0700 If you want more to fix around CSSStyleDeclaration Sam, there's more :) CSS.supports gets this right, but the IDL generation doesn't. 1698662 2 sam 2020-10-16 10:20:53 -0700 Sam, can you point me to where the difference between properties and descriptors is defined? Our current CSSProperties.json does not seem to differentiate (or I don't understand how it is), so I would need a better understanding of what to change. 1699305 3 gsnedders 2020-10-19 10:39:35 -0700 Sam, I filed https://github.com/w3c/csswg-drafts/issues/5633 about the fact that this is pretty unclear currently. A bunch of these have "skip-builder": true currently, so maybe we just want that more? 1699341 4 webkit-bug-importer 2020-10-19 11:47:16 -0700 <rdar://problem/70449709> 1699399 5 sam 2020-10-19 13:15:31 -0700 (In reply to Sam Sneddon [:gsnedders] from comment #3) > Sam, I filed https://github.com/w3c/csswg-drafts/issues/5633 about the fact > that this is pretty unclear currently. > > A bunch of these have "skip-builder": true currently, so maybe we just want > that more? There are ~40 marked with "skip-builder". If that is the set, perhaps we can rename skip-builder to be something semantic about the property rather than an action and use it, but I am not clear if that is the correct set. 1700435 6 412038 sam 2020-10-21 15:51:37 -0700 Created attachment 412038 Patch 1700437 7 sam 2020-10-21 15:52:47 -0700 Turns out there was a function on CSSProperty called isDescriptorOnly, so I'm going to use that as the guide. 1700486 8 sam 2020-10-21 17:32:13 -0700 Hm, seems at least on rest expects some descriptors sometimes. 1700522 9 sam 2020-10-21 19:23:01 -0700 The test, imported/w3c/web-platform-tests/css/cssom/cssom-fontfacerule.html, seems to indicate that when you get a CSSStyleDeclaration from a CSSFontFaceRule, it should include the descriptor "src". 1701300 10 sam 2020-10-25 09:22:19 -0700 Reseting to default assignee while we work out what the behavior here should really be. 1701680 11 gsnedders 2020-10-26 16:47:07 -0700 (In reply to Sam Weinig from comment #9) > The test, imported/w3c/web-platform-tests/css/cssom/cssom-fontfacerule.html, > seems to indicate that when you get a CSSStyleDeclaration from a > CSSFontFaceRule, it should include the descriptor "src". (In reply to Sam Weinig from comment #10) > Reseting to default assignee while we work out what the behavior here should > really be. See also: https://github.com/w3c/csswg-drafts/issues/5649 412038 2020-10-21 15:51:37 -0700 2020-10-21 17:27:37 -0700 Patch bug-217627-20201021155137.patch text/plain 5283 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2ODg0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTEwLTIxICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBDU1NTdHlsZURlY2xhcmF0aW9uIGlu Y2x1ZGVzIGRlc2NyaXB0b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTc2MjcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcwNDQ5NzA5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtXSVBdCisKKyAg ICAgICAgKiBjc3MvQ1NTUHJvcGVydGllcy5qc29uOgorICAgICAgICAqIGNzcy9DU1NQcm9wZXJ0 eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcm9wZXJ0eTo6aXNEZXNjcmlwdG9yT25seSk6 IERlbGV0ZWQuCisgICAgICAgICogY3NzL21ha2Vwcm9wLnBsOgorICAgICAgICAoYWRkUHJvcGVy dHkpOgorCiAyMDIwLTEwLTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkcmVzcyBwb3N0LWxhbmRpbmcgcmV2aWV3IGZlZWRiYWNrIGZyb20gU2FtIFdlaW5p ZyBmb3IgcjI2ODgyMC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0aWVzLmpz b24KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnRpZXMuanNvbgko cmV2aXNpb24gMjY4ODI5KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnRpZXMuanNv bgkod29ya2luZyBjb3B5KQpAQCAtMTE2LDYgKzExNiw5IEBACiAgICAgICAgICJXaGV0aGVyIHRo ZSBwcm9wZXJ0eSBuZWVkcyB0byBiZSBhcHBsaWVkIGF0IHRoZSBlbmQgb2YgaXRzIHByaW9yaXR5 IGJ1Y2tldCIsCiAgICAgICAgICJpbiBDU1MgY2FzY2FkaW5nIG9yZGVyLiIsCiAgICAgICAgICIi LAorICAgICAgICAiKiBkZXNjcmlwdG9yLW9ubHk6IiwKKyAgICAgICAgIlRoaXMgcHJvcGVydHkg aXMgb25seSBldmVyIHVzZWQgYXMgYSBkZXNjcmlwdG9yLiIsCisgICAgICAgICIiLAogICAgICAg ICAiKiByZWxhdGVkLXByb3BlcnR5OiIsCiAgICAgICAgICJJbmRpY2F0ZXMgdGhlIHByZWZpeGVk IG9yIHVucHJlZml4ZWQgdmVyc2lvbiBvZiB0aGUgc2FtZSBwcm9wZXJ0eSwiLAogICAgICAgICAi ZS5nLiAtd2Via2l0LXRleHQtb3JpZW50YXRpb24gaGFzIGEgcmVsYXRlZCBwcm9wZXJ0eSB0ZXh0 LW9yaWVudGF0aW9uIiwKQEAgLTM2MDcsNyArMzYxMCw4IEBACiAgICAgICAgIH0sCiAgICAgICAg ICJzcmMiOiB7CiAgICAgICAgICAgICAiY29kZWdlbi1wcm9wZXJ0aWVzIjogewotICAgICAgICAg ICAgICAgICJza2lwLWJ1aWxkZXIiOiB0cnVlCisgICAgICAgICAgICAgICAgInNraXAtYnVpbGRl ciI6IHRydWUsCisgICAgICAgICAgICAgICAgImRlc2NyaXB0b3Itb25seSI6IHRydWUKICAgICAg ICAgICAgIH0sCiAgICAgICAgICAgICAic3BlY2lmaWNhdGlvbiI6IHsKICAgICAgICAgICAgICAg ICAiY2F0ZWdvcnkiOiAiY3NzLWZvbnRzIiwKQEAgLTQyMDksNyArNDIxMyw4IEBACiAgICAgICAg IH0sCiAgICAgICAgICJ1bmljb2RlLXJhbmdlIjogewogICAgICAgICAgICAgImNvZGVnZW4tcHJv cGVydGllcyI6IHsKLSAgICAgICAgICAgICAgICAic2tpcC1idWlsZGVyIjogdHJ1ZQorICAgICAg ICAgICAgICAgICJza2lwLWJ1aWxkZXIiOiB0cnVlLAorICAgICAgICAgICAgICAgICJkZXNjcmlw dG9yLW9ubHkiOiB0cnVlCiAgICAgICAgICAgICB9LAogICAgICAgICAgICAgInNwZWNpZmljYXRp b24iOiB7CiAgICAgICAgICAgICAgICAgImNhdGVnb3J5IjogImNzcy1mb250cyIsCkBAIC00MjE4 LDcgKzQyMjMsOCBAQAogICAgICAgICB9LAogICAgICAgICAiZm9udC1kaXNwbGF5IjogewogICAg ICAgICAgICAgImNvZGVnZW4tcHJvcGVydGllcyI6IHsKLSAgICAgICAgICAgICAgICAic2tpcC1i dWlsZGVyIjogdHJ1ZQorICAgICAgICAgICAgICAgICJza2lwLWJ1aWxkZXIiOiB0cnVlLAorICAg ICAgICAgICAgICAgICJkZXNjcmlwdG9yLW9ubHkiOiB0cnVlCiAgICAgICAgICAgICB9LAogICAg ICAgICAgICAgInNwZWNpZmljYXRpb24iOiB7CiAgICAgICAgICAgICAgICAgImNhdGVnb3J5Ijog ImNzcy1mb250cy00IiwKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0eS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5LmNwcAkocmV2aXNp b24gMjY4ODI5KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTYxLDE4ICsxNjEsNiBAQCBDU1NQcm9wZXJ0eUlEIENTU1Byb3BlcnR5Ojpy ZXNvbHZlRGlyZWN0CiAgICAgfQogfQogCi1ib29sIENTU1Byb3BlcnR5Ojppc0Rlc2NyaXB0b3JP bmx5KENTU1Byb3BlcnR5SUQgcHJvcGVydHlJRCkKLXsKLSAgICBzd2l0Y2ggKHByb3BlcnR5SUQp IHsKLSAgICBjYXNlIENTU1Byb3BlcnR5U3JjOgotICAgIGNhc2UgQ1NTUHJvcGVydHlVbmljb2Rl UmFuZ2U6Ci0gICAgY2FzZSBDU1NQcm9wZXJ0eUZvbnREaXNwbGF5OgotICAgICAgICByZXR1cm4g dHJ1ZTsKLSAgICBkZWZhdWx0OgotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQotfQotCiBi b29sIENTU1Byb3BlcnR5Ojppc0RpcmVjdGlvbkF3YXJlUHJvcGVydHkoQ1NTUHJvcGVydHlJRCBw cm9wZXJ0eUlEKQogewogICAgIHN3aXRjaCAocHJvcGVydHlJRCkgewpJbmRleDogU291cmNlL1dl YkNvcmUvY3NzL21ha2Vwcm9wLnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9t YWtlcHJvcC5wbAkocmV2aXNpb24gMjY4ODI5KQorKysgU291cmNlL1dlYkNvcmUvY3NzL21ha2Vw cm9wLnBsCSh3b3JraW5nIGNvcHkpCkBAIC0zLDcgKzMsNyBAQAogIyAgIFRoaXMgZmlsZSBpcyBw YXJ0IG9mIHRoZSBXZWJLaXQgcHJvamVjdAogIwogIyAgIENvcHlyaWdodCAoQykgMTk5OSBXYWxk byBCYXN0aWFuIChiYXN0aWFuQGtkZS5vcmcpCi0jICAgQ29weXJpZ2h0IChDKSAyMDA3LTIwMTgg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIyAgIENvcHlyaWdodCAoQykgMjAwNy0y MDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgICBDb3B5cmlnaHQgKEMpIDIw MDggTm9raWEgQ29ycG9yYXRpb24gYW5kL29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCiAjICAgQ29w eXJpZ2h0IChDKSAyMDEwIEFuZHJhcyBCZWNzaSAoYWJlY3NpQGluZi51LXN6ZWdlZC5odSksIFVu aXZlcnNpdHkgb2YgU3plZ2VkCiAjICAgQ29weXJpZ2h0IChDKSAyMDEzIEdvb2dsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCkBAIC02Miw2ICs2Miw3IEBAIG15ICVkZWZpbmVzID0gbWFwIHsg JF8gPT4gMSB9IHNwbGl0KC8gLywKIAogbXkgQG5hbWVzOwogbXkgQGludGVybmFsUHJvcHJlcnRp ZXM7CitteSBAZGVzY3JpcHRvck9ubHlQcm9wZXJ0aWVzOwogbXkgJXJ1bnRpbWVGbGFnczsKIG15 ICVzZXR0aW5nc0ZsYWdzOwogbXkgJG51bVByZWRlZmluZWRQcm9wZXJ0aWVzID0gMjsKQEAgLTI1 Myw2ICsyNTQsOCBAQCBzdWIgYWRkUHJvcGVydHkoJCQpCiAgICAgICAgICAgICAgICAgfSBlbHNp ZiAoJGNvZGVnZW5PcHRpb25OYW1lIGVxICJpbnRlcm5hbC1vbmx5IikgewogICAgICAgICAgICAg ICAgICAgICAjIGludGVybmFsLW9ubHkgcHJvcGVydGllcyBleGlzdCB0byBtYWtlIGl0IGVhc2ll ciB0byBwYXJzZSBjb21wb3VuZCBwcm9wZXJ0aWVzIChlLmcuIGJhY2tncm91bmQtcmVwZWF0KSBh cyBpZiB0aGV5IHdlcmUgc2hvcnRoYW5kcy4KICAgICAgICAgICAgICAgICAgICAgcHVzaCBAaW50 ZXJuYWxQcm9wcmVydGllcywgJG5hbWUKKyAgICAgICAgICAgICAgICB9IGVsc2lmICgkY29kZWdl bk9wdGlvbk5hbWUgZXEgImRlc2NyaXB0b3Itb25seSIpIHsKKyAgICAgICAgICAgICAgICAgICAg cHVzaCBAZGVzY3JpcHRvck9ubHlQcm9wZXJ0aWVzLCAkbmFtZQogICAgICAgICAgICAgICAgIH0g ZWxzaWYgKCRjb2RlZ2VuT3B0aW9uTmFtZSBlcSAicnVudGltZS1mbGFnIikgewogICAgICAgICAg ICAgICAgICAgICAkcnVudGltZUZsYWdzeyRuYW1lfSA9ICRjb2RlZ2VuUHJvcGVydGllcy0+eyJy dW50aW1lLWZsYWcifTsKICAgICAgICAgICAgICAgICB9IGVsc2lmICgkY29kZWdlbk9wdGlvbk5h bWUgZXEgInNldHRpbmdzLWZsYWciKSB7CkBAIC01NDcsNiArNTUwLDIyIEBAIHByaW50IEdQRVJG IDw8ICJFT0YiOwogICAgIH0KIH0KIAorYm9vbCBDU1NQcm9wZXJ0eTo6aXNEZXNjcmlwdG9yT25s eShDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQpCit7CisgICAgc3dpdGNoIChwcm9wZXJ0eUlEKSB7 CitFT0YKKworZm9yZWFjaCBteSAkbmFtZSAoc29ydCBAZGVzY3JpcHRvck9ubHlQcm9wZXJ0aWVz KSB7CisgICAgcHJpbnQgR1BFUkYgIiAgICBjYXNlIENTU1Byb3BlcnR5SUQ6OkNTU1Byb3BlcnR5 IiAuICRuYW1lVG9JZHskbmFtZX0gLiAiOlxuIjsKK30KKworcHJpbnQgR1BFUkYgPDwgIkVPRiI7 CisgICAgICAgIHJldHVybiB0cnVlOworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVybiBmYWxz ZTsKKyAgICB9Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogSUdOT1JFX1dBUk5JTkdT X0VORApAQCAtMTM5Miw3ICsxNDExLDcgQEAgc3ViIGNzc1Byb3BlcnR5VG9JRExBdHRyaWJ1dGUo JCQkKQogCiBteSAlbmFtZXNBbmRBbGlhc2VzVG9OYW1lOwogZm9yZWFjaCBteSAkbmFtZSAoQG5h bWVzKSB7Ci0gICAgaWYgKGdyZXAgeyAkXyBlcSAkbmFtZSB9IEBpbnRlcm5hbFByb3ByZXJ0aWVz KSB7CisgICAgaWYgKGdyZXAgeyAkXyBlcSAkbmFtZSB9IChAaW50ZXJuYWxQcm9wcmVydGllcywg QGRlc2NyaXB0b3JPbmx5UHJvcGVydGllcykpIHsKICAgICAgICAgbmV4dDsKICAgICB9CiAgICAg JG5hbWVzQW5kQWxpYXNlc1RvTmFtZXskbmFtZX0gPSAkbmFtZTsK