<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>217504</bug_id>
          
          <creation_ts>2020-10-08 19:48:50 -0700</creation_ts>
          <short_desc>[GLIB] Fix tests compilation warnings with deprecated API</short_desc>
          <delta_ts>2020-10-09 08:34:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=216927</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Lauro Moura">lmoura</reporter>
          <assigned_to name="Lauro Moura">lmoura</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1696112</commentid>
    <comment_count>0</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2020-10-08 19:48:50 -0700</bug_when>
    <thetext>[GLIB] Fix tests compilation warnings with deprecated API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696113</commentid>
    <comment_count>1</comment_count>
      <attachid>410903</attachid>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2020-10-08 19:50:18 -0700</bug_when>
    <thetext>Created attachment 410903
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696137</commentid>
    <comment_count>2</comment_count>
      <attachid>410903</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2020-10-08 23:15:53 -0700</bug_when>
    <thetext>Comment on attachment 410903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410903&amp;action=review

&gt; Tools/TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:443
&gt; +        auto* websiteDataManager = webkit_web_view_get_website_data_manager(m_webView);
&gt; +        webkit_website_data_manager_set_network_proxy_settings(websiteDataManager, WEBKIT_NETWORK_PROXY_MODE_CUSTOM, settings);

It doesn&apos;t matter in this case because it&apos;s the same, but I would get the data manager from the context instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696187</commentid>
    <comment_count>3</comment_count>
      <attachid>410933</attachid>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2020-10-09 04:53:37 -0700</bug_when>
    <thetext>Created attachment 410933
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696221</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-10-09 08:33:26 -0700</bug_when>
    <thetext>Committed r268258: &lt;https://trac.webkit.org/changeset/268258&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410933.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1696222</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-10-09 08:34:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/70139759&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410903</attachid>
            <date>2020-10-08 19:50:18 -0700</date>
            <delta_ts>2020-10-09 04:53:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-217504-20201008235016.patch</filename>
            <type>text/plain</type>
            <size>1909</size>
            <attacher name="Lauro Moura">lmoura</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MjM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjU5OGY3NGEyNzdhZDgwNTZmMGIzNWQxOTljMjNlYTk5
ODBlZDI4MC4uMTIyOGRjMzg5YjY0NTAxODU4NTYwOThiODFkMThlNGJhODhlZjE1NCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDIwLTEwLTA4ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg
ICAgIFtHTElCXSBGaXggdGVzdHMgY29tcGlsYXRpb24gd2FybmluZ3Mgd2l0aCBkZXByZWNhdGVk
IEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3
NTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Vi
a2l0X3dlYl9jb250ZXh0X3NldF9uZXR3b3JrX3Byb3h5X3NldHRpbmdzKCkgaXMgZGVwcmVjYXRl
ZCBpbiBmYXZvciBvZgorICAgICAgICB3ZWJraXRfd2Vic2l0ZV9kYXRhX21hbmFnZXJfc2V0X25l
dHdvcmtfcHJveHlfc2V0dGluZ3MoKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMv
V2ViS2l0R0xpYi9UZXN0QXV0aGVudGljYXRpb24uY3BwOgorICAgICAgICAoUHJveHlBdXRoZW50
aWNhdGlvblRlc3Q6OlByb3h5QXV0aGVudGljYXRpb25UZXN0KToKKwogMjAyMC0xMC0wOCAgUnlv
c3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBNYWtlIGl0IHBvc3NpYmxl
IHRvIHNlbmQgYW4gYXJiaXRyYXJ5IElQQyBtZXNzYWdlIGZyb20gSmF2YVNjcmlwdApkaWZmIC0t
Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RBdXRoZW50aWNh
dGlvbi5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdEF1dGhl
bnRpY2F0aW9uLmNwcAppbmRleCAxNTQxZjQzMmFkNDM5ZjQzYTIyYWJmMWZkOWNjNmFmMTQ2ZmYz
NzNmLi4yMTQyMWI5NGE4MDZhOTExZTg0ODk3NzExZjdhZWFiZGI0NjliNzVhIDEwMDY0NAotLS0g
YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdEF1dGhlbnRpY2F0aW9u
LmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdEF1dGhl
bnRpY2F0aW9uLmNwcApAQCAtNDM5LDcgKzQzOSw4IEBAIHB1YmxpYzoKICAgICAgICAgZ1Byb3h5
U2VydmVyUG9ydCA9IHNvdXBfdXJpX2dldF9wb3J0KG1fcHJveHlTZXJ2ZXIuYmFzZVVSSSgpKTsK
ICAgICAgICAgR1VuaXF1ZVB0cjxjaGFyPiBwcm94eVVSSShzb3VwX3VyaV90b19zdHJpbmcobV9w
cm94eVNlcnZlci5iYXNlVVJJKCksIEZBTFNFKSk7CiAgICAgICAgIFdlYktpdE5ldHdvcmtQcm94
eVNldHRpbmdzKiBzZXR0aW5ncyA9IHdlYmtpdF9uZXR3b3JrX3Byb3h5X3NldHRpbmdzX25ldyhw
cm94eVVSSS5nZXQoKSwgbnVsbHB0cik7Ci0gICAgICAgIHdlYmtpdF93ZWJfY29udGV4dF9zZXRf
bmV0d29ya19wcm94eV9zZXR0aW5ncyhtX3dlYkNvbnRleHQuZ2V0KCksIFdFQktJVF9ORVRXT1JL
X1BST1hZX01PREVfQ1VTVE9NLCBzZXR0aW5ncyk7CisgICAgICAgIGF1dG8qIHdlYnNpdGVEYXRh
TWFuYWdlciA9IHdlYmtpdF93ZWJfdmlld19nZXRfd2Vic2l0ZV9kYXRhX21hbmFnZXIobV93ZWJW
aWV3KTsKKyAgICAgICAgd2Via2l0X3dlYnNpdGVfZGF0YV9tYW5hZ2VyX3NldF9uZXR3b3JrX3By
b3h5X3NldHRpbmdzKHdlYnNpdGVEYXRhTWFuYWdlciwgV0VCS0lUX05FVFdPUktfUFJPWFlfTU9E
RV9DVVNUT00sIHNldHRpbmdzKTsKICAgICAgICAgd2Via2l0X25ldHdvcmtfcHJveHlfc2V0dGlu
Z3NfZnJlZShzZXR0aW5ncyk7CiAgICAgfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410933</attachid>
            <date>2020-10-09 04:53:37 -0700</date>
            <delta_ts>2020-10-09 08:33:27 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-217504-20201009085336.patch</filename>
            <type>text/plain</type>
            <size>1923</size>
            <attacher name="Lauro Moura">lmoura</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MjUxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzY1ODE4YjBmYmRkMmU2Y2FmMzRmZGYyNjAyZWQxOGNh
YzE1MjAzNC4uMjUyYjRmZTZhYmU1ZWFlZTY2MTQzMTJkZjI0OWE3MjIxZWRhNTU2YiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDIwLTEwLTA5ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg
ICAgIFtHTElCXSBGaXggdGVzdHMgY29tcGlsYXRpb24gd2FybmluZ3Mgd2l0aCBkZXByZWNhdGVk
IEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3
NTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2FybG9zIEdhcmNpYSBDYW1wb3MuCisKKyAgICAg
ICAgd2Via2l0X3dlYl9jb250ZXh0X3NldF9uZXR3b3JrX3Byb3h5X3NldHRpbmdzKCkgaXMgZGVw
cmVjYXRlZCBpbiBmYXZvciBvZgorICAgICAgICB3ZWJraXRfd2Vic2l0ZV9kYXRhX21hbmFnZXJf
c2V0X25ldHdvcmtfcHJveHlfc2V0dGluZ3MoKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkv
VGVzdHMvV2ViS2l0R0xpYi9UZXN0QXV0aGVudGljYXRpb24uY3BwOgorICAgICAgICAoUHJveHlB
dXRoZW50aWNhdGlvblRlc3Q6OlByb3h5QXV0aGVudGljYXRpb25UZXN0KToKKwogMjAyMC0xMC0w
OSAgUGF1bG8gTWF0b3MgIDxwbWF0b3NAaWdhbGlhLmNvbT4KIAogICAgICAgICBBZGQgYXJtdjhs
IGFyY2ggdG8gZ2VuZXJpYyBhcm0gdW1icmVsbGEgYXJjaGl0ZWN0dXJlIHZhcmlhYmxlCmRpZmYg
LS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdEF1dGhlbnRp
Y2F0aW9uLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0QXV0
aGVudGljYXRpb24uY3BwCmluZGV4IDE1NDFmNDMyYWQ0MzlmNDNhMjJhYmYxZmQ5Y2M2YWYxNDZm
ZjM3M2YuLmRmMWNiMTIxZTFmNzM2ZWU4ZmZiOGY2YjIxYzRjZDhiNDE1YjNhNDIgMTAwNjQ0Ci0t
LSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0QXV0aGVudGljYXRp
b24uY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0QXV0
aGVudGljYXRpb24uY3BwCkBAIC00MzksNyArNDM5LDggQEAgcHVibGljOgogICAgICAgICBnUHJv
eHlTZXJ2ZXJQb3J0ID0gc291cF91cmlfZ2V0X3BvcnQobV9wcm94eVNlcnZlci5iYXNlVVJJKCkp
OwogICAgICAgICBHVW5pcXVlUHRyPGNoYXI+IHByb3h5VVJJKHNvdXBfdXJpX3RvX3N0cmluZyht
X3Byb3h5U2VydmVyLmJhc2VVUkkoKSwgRkFMU0UpKTsKICAgICAgICAgV2ViS2l0TmV0d29ya1By
b3h5U2V0dGluZ3MqIHNldHRpbmdzID0gd2Via2l0X25ldHdvcmtfcHJveHlfc2V0dGluZ3NfbmV3
KHByb3h5VVJJLmdldCgpLCBudWxscHRyKTsKLSAgICAgICAgd2Via2l0X3dlYl9jb250ZXh0X3Nl
dF9uZXR3b3JrX3Byb3h5X3NldHRpbmdzKG1fd2ViQ29udGV4dC5nZXQoKSwgV0VCS0lUX05FVFdP
UktfUFJPWFlfTU9ERV9DVVNUT00sIHNldHRpbmdzKTsKKyAgICAgICAgYXV0byogd2Vic2l0ZURh
dGFNYW5hZ2VyID0gd2Via2l0X3dlYl9jb250ZXh0X2dldF93ZWJzaXRlX2RhdGFfbWFuYWdlciht
X3dlYkNvbnRleHQuZ2V0KCkpOworICAgICAgICB3ZWJraXRfd2Vic2l0ZV9kYXRhX21hbmFnZXJf
c2V0X25ldHdvcmtfcHJveHlfc2V0dGluZ3Mod2Vic2l0ZURhdGFNYW5hZ2VyLCBXRUJLSVRfTkVU
V09SS19QUk9YWV9NT0RFX0NVU1RPTSwgc2V0dGluZ3MpOwogICAgICAgICB3ZWJraXRfbmV0d29y
a19wcm94eV9zZXR0aW5nc19mcmVlKHNldHRpbmdzKTsKICAgICB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>