217490 2020-10-08 13:02:45 -0700 [WinCairo] ASSERTION FAILED: m_renderingUpdateRemainingSteps.last().isEmpty() in WebCore::Page::finalizeRenderingUpdate since r268075 2020-10-08 14:19:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii simon.fraser webkit-bug-importer oldest_to_newest 1696003 0 fujii 2020-10-08 13:02:45 -0700 [WinCairo] ASSERTION FAILED: m_renderingUpdateRemainingSteps.last().isEmpty() in WebCore::Page::finalizeRenderingUpdate since r268075 WinCairo WK2 debug build fails the assertion WinCairo WK1 debug build doesn't fail. Bug 216726 – Redundant rendering updates can be scheduled from inside Page::updateRendering() ASSERTION FAILED: m_renderingUpdateRemainingSteps.last().isEmpty() C:\home\webkit\gb\Source\WebCore\page/Page.cpp(1655) : WebCore::Page::finalizeRenderingUpdate Callstack: > WTF.dll!WTFCrash() Line 295 C++ > WebKit2.dll!WTFCrashWithInfo(int __formal, const char * __formal, const char * __formal, int __formal) Line 672 C++ > WebKit2.dll!WebCore::Page::finalizeRenderingUpdate(WTF::OptionSet<enum WebCore::FinalizeRenderingUpdateFlags> flags) Line 1655 C++ > WebKit2.dll!WebKit::WebPage::finalizeRenderingUpdate(WTF::OptionSet<enum WebCore::FinalizeRenderingUpdateFlags> flags) Line 3899 C++ > WebKit2.dll!WebKit::DrawingAreaCoordinatedGraphics::display(WebKit::UpdateInfo & updateInfo) Line 756 C++ > WebKit2.dll!WebKit::DrawingAreaCoordinatedGraphics::display() Line 717 C++ > WebKit2.dll!WebKit::DrawingAreaCoordinatedGraphics::displayTimerFired() Line 692 C++ > WebKit2.dll!WTF::RunLoop::Timer<WebKit::DrawingAreaCoordinatedGraphics>::fired() Line 178 C++ > WTF.dll!WTF::RunLoop::TimerBase::timerFired() Line 165 C++ > WTF.dll!WTF::RunLoop::wndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 60 C++ > WTF.dll!WTF::RunLoop::RunLoopWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 39 C++ > user32.dll!00007ffce3dc5c7d() Unknown > user32.dll!00007ffce3dc5672() Unknown > WTF.dll!WTF::RunLoop::run() Line 74 C++ > WebKit2.dll!WebKit::AuxiliaryProcessMain<WebKit::WebProcess,WebKit::WebProcessMainWin>(int argc, char * * argv) Line 69 C++ > WebKit2.dll!WebKit::WebProcessMain(int argc, char * * argv) Line 58 C++ > WebKitWebProcess.exe!main(int argc, char * * argv) Line 35 C++ > [Inline Frame] WebKitWebProcess.exe!invoke_main() Line 78 C++ > WebKitWebProcess.exe!__scrt_common_main_seh() Line 288 C++ > kernel32.dll!00007ffce5b67bd4() Unknown > ntdll.dll!00007ffce5d6ce51() Unknown 1696007 1 simon.fraser 2020-10-08 13:15:47 -0700 Run with EventLoop logging enabled. What bits remain? 1696008 2 fujii 2020-10-08 13:17:48 -0700 m_renderingUpdateRemainingSteps was 0x2000. 0x2000 means RenderingUpdateStep::ScrollingTreeUpdate. 1696011 3 fujii 2020-10-08 13:21:42 -0700 This bug seems easy. I'm going to submit patch to condition out ScrollingTreeUpdate by ENABLE(ASYNC_SCROLLING). 1696012 4 simon.fraser 2020-10-08 13:22:19 -0700 Sounds right. 1696017 5 410877 fujii 2020-10-08 13:33:25 -0700 Created attachment 410877 Patch 1696028 6 410877 fujii 2020-10-08 14:18:00 -0700 Comment on attachment 410877 Patch Clearing flags on attachment: 410877 Committed r268208: <https://trac.webkit.org/changeset/268208> 1696029 7 fujii 2020-10-08 14:18:03 -0700 All reviewed patches have been landed. Closing bug. 1696030 8 webkit-bug-importer 2020-10-08 14:19:22 -0700 <rdar://problem/70109923> 410877 2020-10-08 13:33:25 -0700 2020-10-08 14:18:00 -0700 Patch bug-217490-20201009053324.patch text/plain 2650 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGE3MzczM2U5OWE4NzAz MTg4MGVkNTNiZDc0MmM4MDBiYjkyOGE5ZS4uY2E3M2IwOThkYjA1MjQ0ZmNjOTAwMWMzNWFiZTlh NDk5ZmIwZWFkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTEwLTA4ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b10gQVNTRVJUSU9OIEZBSUxFRDogbV9yZW5kZXJpbmdVcGRhdGVSZW1haW5pbmdTdGVwcy5sYXN0 KCkuaXNFbXB0eSgpIGluIFdlYkNvcmU6OlBhZ2U6OmZpbmFsaXplUmVuZGVyaW5nVXBkYXRlIHNp bmNlIHIyNjgwNzUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxNzQ5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdoZW4gdGhlIGFzc2VydGlvbiBmYWlsZWQsIG1fcmVuZGVyaW5nVXBkYXRlUmVtYWluaW5n U3RlcHMgd2FzCisgICAgICAgIDB4MjAwMCAoU2Nyb2xsaW5nVHJlZVVwZGF0ZSkuIFRoZSBmbGFn IFNjcm9sbGluZ1RyZWVVcGRhdGUgc2hvdWxkCisgICAgICAgIGJlIHVzZWQgb25seSBpZiBFTkFC TEUoQVNZTkNfU0NST0xMSU5HKS4KKworICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpvcGVyYXRvcjw8KToKKyAgICAgICAgKiBwYWdlL1BhZ2UuaDoKKyAgICAgICAg Q29uZGl0aW9uZWQgb3V0IFNjcm9sbGluZ1RyZWVVcGRhdGUgYnkgRU5BQkxFKEFTWU5DX1NDUk9M TElORykuCisKIDIwMjAtMTAtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCBmaXggV2luZG93cyBidWlsZCBhZnRlciByMjY4MTYxLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvUGFnZS5jcHAKaW5kZXggNWUwNzJjODNlOWU0YzQyNzQxZmRjZjI4OTEwNmRmN2E4YzdmYjE0 NS4uNjcyNTg1NmUxNDQyN2Y4MWY1YTBiOWNjZTQ4YWRiYzg1MjQxNWVhOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Bh Z2UuY3BwCkBAIC0zMzY0LDcgKzMzNjQsOSBAQCBXVEY6OlRleHRTdHJlYW0mIG9wZXJhdG9yPDwo V1RGOjpUZXh0U3RyZWFtJiB0cywgUmVuZGVyaW5nVXBkYXRlU3RlcCBzdGVwKQogICAgIGNhc2Ug UmVuZGVyaW5nVXBkYXRlU3RlcDo6Q3Vyc29yVXBkYXRlOiB0cyA8PCAiQ3Vyc29yVXBkYXRlIjsg YnJlYWs7CiAgICAgY2FzZSBSZW5kZXJpbmdVcGRhdGVTdGVwOjpFdmVudFJlZ2lvblVwZGF0ZTog dHMgPDwgIkV2ZW50UmVnaW9uVXBkYXRlIjsgYnJlYWs7CiAgICAgY2FzZSBSZW5kZXJpbmdVcGRh dGVTdGVwOjpMYXllckZsdXNoOiB0cyA8PCAiTGF5ZXJGbHVzaCI7IGJyZWFrOworI2lmIEVOQUJM RShBU1lOQ19TQ1JPTExJTkcpCiAgICAgY2FzZSBSZW5kZXJpbmdVcGRhdGVTdGVwOjpTY3JvbGxp bmdUcmVlVXBkYXRlOiB0cyA8PCAiU2Nyb2xsaW5nVHJlZVVwZGF0ZSI7IGJyZWFrOworI2VuZGlm CiAgICAgfQogICAgIHJldHVybiB0czsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvUGFnZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKaW5kZXggYTAyMGU4ODFhMjZh ZTY1MWY1NTE0NjIwMTVkODRjZWE5NzI1YTBhOC4uOTYxMDdjN2UzZDBmYzI1NDMzYTI2OTZhZjNj NTdiOGM5NThhYzhjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKQEAgLTE5MSw3ICsxOTEsOSBAQCBlbnVtIGNs YXNzIFJlbmRlcmluZ1VwZGF0ZVN0ZXAgOiB1aW50MTZfdCB7CiAgICAgQ3Vyc29yVXBkYXRlICAg ICAgICAgICAgICAgICAgICA9IDEgPDwgMTAsCiAgICAgRXZlbnRSZWdpb25VcGRhdGUgICAgICAg ICAgICAgICA9IDEgPDwgMTEsCiAgICAgTGF5ZXJGbHVzaCAgICAgICAgICAgICAgICAgICAgICA9 IDEgPDwgMTIsCisjaWYgRU5BQkxFKEFTWU5DX1NDUk9MTElORykKICAgICBTY3JvbGxpbmdUcmVl VXBkYXRlICAgICAgICAgICAgID0gMSA8PCAxMywKKyNlbmRpZgogfTsKIAogY29uc3RleHByIE9w dGlvblNldDxSZW5kZXJpbmdVcGRhdGVTdGVwPiB1cGRhdGVSZW5kZXJpbmdTdGVwcyA9IHsKQEAg LTIxNSw3ICsyMTcsOSBAQCBjb25zdGV4cHIgT3B0aW9uU2V0PFJlbmRlcmluZ1VwZGF0ZVN0ZXA+ IHVwZGF0ZVJlbmRlcmluZ1N0ZXBzID0gewogCiBjb25zdGV4cHIgYXV0byBhbGxSZW5kZXJpbmdV cGRhdGVTdGVwcyA9IHVwZGF0ZVJlbmRlcmluZ1N0ZXBzIHwgT3B0aW9uU2V0PFJlbmRlcmluZ1Vw ZGF0ZVN0ZXA+IHsKICAgICBSZW5kZXJpbmdVcGRhdGVTdGVwOjpMYXllckZsdXNoLAorI2lmIEVO QUJMRShBU1lOQ19TQ1JPTExJTkcpCiAgICAgUmVuZGVyaW5nVXBkYXRlU3RlcDo6U2Nyb2xsaW5n VHJlZVVwZGF0ZSwKKyNlbmRpZgogfTsKIAogCg==