<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>217431</bug_id>
          
          <creation_ts>2020-10-07 08:20:06 -0700</creation_ts>
          <short_desc>[build.webkit.org] Ensure that invalid step names are not allowed</short_desc>
          <delta_ts>2021-02-08 07:37:49 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=217394</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>175056</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>darin</cc>
    
    <cc>dewei_zhu</cc>
    
    <cc>jbedard</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1695540</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-10-07 08:20:06 -0700</bug_when>
    <thetext>Bug 217394 modified step names as per new buildbot requirement. We should ensure that invalid step names are not allowed. Unit-tests should fail if any invalid step-name is added.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1695541</commentid>
    <comment_count>1</comment_count>
      <attachid>410750</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-10-07 08:21:22 -0700</bug_when>
    <thetext>Created attachment 410750
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1695560</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-10-07 09:02:01 -0700</bug_when>
    <thetext>Committed r268128: &lt;https://trac.webkit.org/changeset/268128&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410750.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1695561</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-10-07 09:02:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/70050089&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410750</attachid>
            <date>2020-10-07 08:21:22 -0700</date>
            <delta_ts>2020-10-07 09:02:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-217431-20201007112121.patch</filename>
            <type>text/plain</type>
            <size>1903</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI2ODEyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDEzIEBACisyMDIwLTEwLTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gRW5zdXJlIHRoYXQgaW52YWxpZCBzdGVw
IG5hbWVzIGFyZSBub3QgYWxsb3dlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MjE3NDMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp
Zy9sb2FkQ29uZmlnLnB5OgorICAgICAgICAobG9hZEJ1aWxkZXJDb25maWcpOgorCiAyMDIwLTEw
LTA3ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdS
RVNTSU9OOiBEYXRlL3RpbWUgcGlja2VycyBhcmUgbm90IGRpc3BsYXllZCBpbiBVSVdlYlZpZXdz
CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9s
b2FkQ29uZmlnLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk
LndlYmtpdC5vcmctY29uZmlnL2xvYWRDb25maWcucHkJKHJldmlzaW9uIDI2ODEyMykKKysrIFRv
b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL2xvYWRDb25maWcu
cHkJKHdvcmtpbmcgY29weSkKQEAgLTM3LDYgKzM3LDkgQEAgaW1wb3J0IG1ha2VfcGFzc3dvcmRz
X2pzb24KIGltcG9ydCB3a2J1aWxkCiAKIHRydW5rX2ZpbHRlciA9IENoYW5nZUZpbHRlcihicmFu
Y2g9WyJ0cnVuayIsIE5vbmVdKQorYnVpbGRib3RfaWRlbnRpZmllcnNfcmUgPSByZS5jb21waWxl
KCdeW2EtekEtWl8tXVthLXpBLVowLTlfLV0qJCcpCisKK1NURVBfTkFNRV9MRU5HVEhfTElNSVQg
PSA1MAogCiAKIGRlZiBwaWNrTGF0ZXN0QnVpbGQoYnVpbGRlciwgcmVxdWVzdHMpOgpAQCAtMTA4
LDYgKzExMSwxMyBAQCBkZWYgbG9hZEJ1aWxkZXJDb25maWcoYywgdGVzdF9tb2RlX2lzX2VuCiAK
ICAgICAgICAgYnVpbGRlclsiZmFjdG9yeSJdID0gZmFjdG9yeSgqKmZhY3Rvcnlrd2FyZ3MpCiAK
KyAgICAgICAgZm9yIHN0ZXAgaW4gYnVpbGRlclsiZmFjdG9yeSJdLnN0ZXBzOgorICAgICAgICAg
ICAgc3RlcF9uYW1lID0gc3RlcFswXS5uYW1lCisgICAgICAgICAgICBpZiBsZW4oc3RlcF9uYW1l
KSA+IFNURVBfTkFNRV9MRU5HVEhfTElNSVQ6CisgICAgICAgICAgICAgICAgcmFpc2UgRXhjZXB0
aW9uKCdzdGVwIG5hbWUgInt9IiBpcyBsb25nZXIgdGhhbiBtYXhpbXVtIGFsbG93ZWQgYnkgQnVp
bGRib3QgKHt9IGNoYXJhY3RlcnMpLicuZm9ybWF0KHN0ZXBfbmFtZSwgU1RFUF9OQU1FX0xFTkdU
SF9MSU1JVCkpCisgICAgICAgICAgICBpZiBub3QgYnVpbGRib3RfaWRlbnRpZmllcnNfcmUubWF0
Y2goc3RlcF9uYW1lKToKKyAgICAgICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oJ3N0ZXAgbmFt
ZSAie30iIGlzIG5vdCBhIHZhbGlkIGJ1aWxkYm90IGlkZW50aWZpZXIuJy5mb3JtYXQoc3RlcF9u
YW1lKSkKKwogICAgICAgICBpZiBwbGF0Zm9ybS5zdGFydHN3aXRoKCdtYWMnKToKICAgICAgICAg
ICAgIGJ1aWxkZXJbImNhdGVnb3J5Il0gPSAnQXBwbGVNYWMnCiAgICAgICAgIGVsaWYgcGxhdGZv
cm0uc3RhcnRzd2l0aCgnaW9zJyk6Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>