216910 2020-09-23 19:03:24 -0700 [SVG2] Remove color-profile tag 2020-09-24 20:09:52 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed P2 Normal --- 191292 1 fujii fujii cdumez darin dino esprehn+autocc ews-watchlist fmalita gyuyoung.kim kangil.han pdr sabouhallawa sam schenney sergio simon.fraser webkit-bug-importer zimmermann oldest_to_newest 1691353 0 fujii 2020-09-23 19:03:24 -0700 SVG2 removed color_profile element. Element Index — SVG 2 https://www.w3.org/TR/SVG2/eltindex.html 1691354 1 409524 fujii 2020-09-23 19:06:44 -0700 Created attachment 409524 Patch 1691359 2 fujii 2020-09-23 19:45:22 -0700 EWS reported test failures. imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html imported/w3c/web-platform-tests/custom-elements/custom-element-registry/define.html WPT has test cases for color-profile element. 1691384 3 fujii 2020-09-23 22:10:29 -0700 We should keep color-profile tag. I'm going to reuse this ticket to add color-profile tag. 1691387 4 409532 fujii 2020-09-23 22:33:24 -0700 Created attachment 409532 Patch 1691410 5 fujii 2020-09-24 00:11:31 -0700 OMG, some test failures and crashes on EWS. 1691518 6 sam 2020-09-24 07:47:32 -0700 I'm not clear I understand the purpose of this change? What is desired web observable effect you are going for? 1691642 7 fujii 2020-09-24 12:59:30 -0700 My motivations are 1. I'd like to stop using C preprocessor to avoid Cygwin fork failure (Bug 206565 comment 1) 2. I'd like to remove "#if 0" hack which looks too tricky I don't want any web observable effects. Do you have any better idea? Or, should I give up this? 1691644 8 sam 2020-09-24 13:03:13 -0700 (In reply to Fujii Hironori from comment #7) > My motivations are > 1. I'd like to stop using C preprocessor to avoid Cygwin fork failure (Bug > 206565 comment 1) > 2. I'd like to remove "#if 0" hack which looks too tricky > > I don't want any web observable effects. > Do you have any better idea? Or, should I give up this? Just remove the three lines entirely. Longtime #if 0'd code is not useful. 1691645 9 sam 2020-09-24 13:06:14 -0700 (In reply to Sam Weinig from comment #8) > (In reply to Fujii Hironori from comment #7) > > My motivations are > > 1. I'd like to stop using C preprocessor to avoid Cygwin fork failure (Bug > > 206565 comment 1) > > 2. I'd like to remove "#if 0" hack which looks too tricky > > > > I don't want any web observable effects. > > Do you have any better idea? Or, should I give up this? > > Just remove the three lines entirely. Longtime #if 0'd code is not useful. Oh, I see, your first change tried that? Hm. I'd like to understand why the #if isn't working right now. 1691652 10 sam 2020-09-24 13:17:35 -0700 (In reply to Sam Weinig from comment #9) > (In reply to Sam Weinig from comment #8) > > (In reply to Fujii Hironori from comment #7) > > > My motivations are > > > 1. I'd like to stop using C preprocessor to avoid Cygwin fork failure (Bug > > > 206565 comment 1) > > > 2. I'd like to remove "#if 0" hack which looks too tricky > > > > > > I don't want any web observable effects. > > > Do you have any better idea? Or, should I give up this? > > > > Just remove the three lines entirely. Longtime #if 0'd code is not useful. > > Oh, I see, your first change tried that? Hm. I'd like to understand why the > #if isn't working right now. Ok, so make_names.pl does a weird thing where it does two passes over the input, one preprocessed, one not. Very fun. But now I see what we should do. You should go back to your initial change, which is correct, but we need to add "color_profile" to the list of invalid names for custom elements (you can see it in the spec here https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom-element-name). This will probably mean making a change to JSCustomElementRegistry::define(...). If you need some help with this, let me know and I can try my hand at it. 1691653 11 sam 2020-09-24 13:20:01 -0700 (In reply to Sam Weinig from comment #10) > (In reply to Sam Weinig from comment #9) > > (In reply to Sam Weinig from comment #8) > > > (In reply to Fujii Hironori from comment #7) > > > > My motivations are > > > > 1. I'd like to stop using C preprocessor to avoid Cygwin fork failure (Bug > > > > 206565 comment 1) > > > > 2. I'd like to remove "#if 0" hack which looks too tricky > > > > > > > > I don't want any web observable effects. > > > > Do you have any better idea? Or, should I give up this? > > > > > > Just remove the three lines entirely. Longtime #if 0'd code is not useful. > > > > Oh, I see, your first change tried that? Hm. I'd like to understand why the > > #if isn't working right now. > > Ok, so make_names.pl does a weird thing where it does two passes over the > input, one preprocessed, one not. Very fun. > > But now I see what we should do. > > You should go back to your initial change, which is correct, but we need to > add "color_profile" to the list of invalid names for custom elements (you > can see it in the spec here > https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom- > element-name). This will probably mean making a change to > JSCustomElementRegistry::define(...). If you need some help with this, let > me know and I can try my hand at it. Actually, your original patch was very close to solving this. Instead of removing the line: localName == SVGNames::color_profileTag->localName() just replace it with localName == color_profileLocalName and add: static MainThreadNeverDestroyed<const AtomString> color_profileLocalName("color_profile", AtomString::ConstructFromLiteral); above it. 1691656 12 fujii 2020-09-24 13:34:28 -0700 It sounds great. I'm going to try it. Thanks. 1691659 13 409619 fujii 2020-09-24 13:51:18 -0700 Created attachment 409619 Patch 1691688 14 ews-feeder 2020-09-24 15:25:50 -0700 Committed r267550: <https://trac.webkit.org/changeset/267550> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409619. 1691689 15 webkit-bug-importer 2020-09-24 15:26:18 -0700 <rdar://problem/69529787> 409524 2020-09-23 19:06:44 -0700 2020-09-23 23:00:47 -0700 Patch bug-216910-20200924110642.patch text/plain 1994 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI1ZWY4MmYxNzgxMDM3 NmFjYzU2Y2EwMzc3MGM2NTcyNmE0NjUyYS4uNDAwZmQ3YWY2YzlkMGU0MTViMGUxMmI2ZTcxZTRl YzBkZmFmYjg1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA5LTIzICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtTVkcyXSBS ZW1vdmUgY29sb3JfcHJvZmlsZSB0YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNjkxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFNWRzIgcmVtb3ZlZCBjb2xvcl9wcm9maWxlIGVsZW1lbnQuCisKKyAg ICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnZh bGlkYXRlQ3VzdG9tRWxlbWVudE5hbWUpOgorICAgICAgICAqIHN2Zy9zdmd0YWdzLmluOgorCiAy MDIwLTA5LTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFtMRkMgRGlzcGxheV0gQWRkIHRoZSBiZWdpbm5pbmdzIG9mIGEgQ1NTIGRpc3BsYXkgYm94 IGhpZXJhcmNoeSBhbmQgQ1NTIHBhaW50ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGIy NjYwNDkxMmU0MmI0MTJlNTYyODI1ZWYyMDZlZjFhMjEwMGVmZTYuLjUzNmIzM2U5NWZkNDcxNDVj Mzk2MmQ1OWQ1MTM3ZDI5MDBhNjc4ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMTI2 Nyw4ICsxMjY3LDcgQEAgQ3VzdG9tRWxlbWVudE5hbWVWYWxpZGF0aW9uU3RhdHVzIERvY3VtZW50 Ojp2YWxpZGF0ZUN1c3RvbUVsZW1lbnROYW1lKGNvbnN0IEF0b20KICAgICBzdGF0aWMgTWFpblRo cmVhZE5ldmVyRGVzdHJveWVkPGNvbnN0IEF0b21TdHJpbmc+IGFubm90YXRpb25YbWxMb2NhbE5h bWUoImFubm90YXRpb24teG1sIiwgQXRvbVN0cmluZzo6Q29uc3RydWN0RnJvbUxpdGVyYWwpOwog I2VuZGlmCiAKLSAgICBpZiAobG9jYWxOYW1lID09IFNWR05hbWVzOjpjb2xvcl9wcm9maWxlVGFn LT5sb2NhbE5hbWUoKQotICAgICAgICB8fCBsb2NhbE5hbWUgPT0gU1ZHTmFtZXM6OmZvbnRfZmFj ZVRhZy0+bG9jYWxOYW1lKCkKKyAgICBpZiAobG9jYWxOYW1lID09IFNWR05hbWVzOjpmb250X2Zh Y2VUYWctPmxvY2FsTmFtZSgpCiAgICAgICAgIHx8IGxvY2FsTmFtZSA9PSBTVkdOYW1lczo6Zm9u dF9mYWNlX2Zvcm1hdFRhZy0+bG9jYWxOYW1lKCkKICAgICAgICAgfHwgbG9jYWxOYW1lID09IFNW R05hbWVzOjpmb250X2ZhY2VfbmFtZVRhZy0+bG9jYWxOYW1lKCkKICAgICAgICAgfHwgbG9jYWxO YW1lID09IFNWR05hbWVzOjpmb250X2ZhY2Vfc3JjVGFnLT5sb2NhbE5hbWUoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvc3ZnL3N2Z3RhZ3MuaW4gYi9Tb3VyY2UvV2ViQ29yZS9zdmcvc3Zn dGFncy5pbgppbmRleCBjMzdiYTIwZTUwY2NmZGZjMDU4M2Y5OTMyZDFhMTE5MWU5ZDcwZDI1Li4x M2M3YTUxNTI2ZGUxODQyZjg1MmEwNGFlY2U0M2M2YTNjMGFkMmZkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9zdmcvc3ZndGFncy5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvc3ZndGFn cy5pbgpAQCAtMTQsOSArMTQsNiBAQCBhbmltYXRlVHJhbnNmb3JtCiBzZXQKIGNpcmNsZQogY2xp cFBhdGgKLSNpZiAwCi1jb2xvcl9wcm9maWxlCi0jZW5kaWYKIGN1cnNvcgogZGVmcwogZGVzYwo= 409532 2020-09-23 22:33:24 -0700 2020-09-24 13:51:15 -0700 Patch bug-216910-20200924143323.patch text/plain 3502 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI1ZWY4MmYxNzgxMDM3 NmFjYzU2Y2EwMzc3MGM2NTcyNmE0NjUyYS4uMTg1MWEyZTgzM2M4MjlhYzM3YjA1MGNiYWI5NzA5 ZDk1YTcyZjcxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDIwLTA5LTIzICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtTVkddIERl ZmluZSBjb2xvci1wcm9maWxlIHRhZyB3aXRob3V0ICNpZiAwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY5MTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFdmVuIHRob3VnaCBTVkcyIHJlbW92ZWQgY29s b3ItcHJvZmlsZSBlbGVtZW50LCB3ZSBjYW4ndCByZW1vdmUKKyAgICAgICAgY29sb3ItcHJvZmls ZSB0YWcgYmVjdWFzZSBXUFQgaGFzIHRlc3QgY2FzZXMgZm9yIGl0LgorCisgICAgICAgIGNvbG9y LXByb2ZpbGUgdGFnIHdhcyBkZWZpbmVkIGluIHN2Z3RhZ3MuaW4gYnkgdXNpbmcgIiNpZiAwIi4g VGhpcworICAgICAgICBsb29rZWQgdHJpY2t5IGFuZCBuZWVkcyBDIHByZXByb2Nlc3Nvci4gSFRN TFRhZ05hbWVzLmluIGhhcyBzb21lCisgICAgICAgIHRhZ3Mgd2hpY2ggZG9uJ3QgaGF2ZSBvd24g aW1wbGVtZW50YXRpb24gY2xhc3MgYnkgc3BlY2lmeWluZworICAgICAgICAiaW50ZXJmYWNlTmFt ZT1IVE1MRWxlbWVudCIuIFRoaXMgY2hhbmdlIGRlZmluZXMgY29sb3ItcHJvZmlsZSB0YWcKKyAg ICAgICAgd2l0aCB0aGUgc2FtZSBhcHByb2FjaC4gRGVmaW5lIGNvbG9yX3Byb2ZpbGUgdGFnIHdp dGgKKyAgICAgICAgImludGVyZmFjZU5hbWU9U1ZHRWxlbWVudCIuCisKKyAgICAgICAgImN1c3Rv bVR5cGVIZWxwZXIiIGtleXdvcmQgaXMgbmVlZGVkIGZvciBjb2xvci1wcm9maWxlIHRhZyB0bwor ICAgICAgICBzdXBwcmVzcyBUeXBlQ2FzdFRyYWl0cyBnZW5lcmF0aW9uLiBtYWtlX25hbWVzLnBs IGdlbmVyYXRlcworICAgICAgICBUeXBlQ2FzdFRyYWl0cyBmb3IgYWxsIGltcGxlbWVudGF0aW9u IGNsYXNzZXMgd2hpY2ggY29ycmVzcG9uZHMgdG8KKyAgICAgICAgYSBzaW5nbGUgdGFnLiBTVkdF bGVtZW50IGNsYXNzIGNvcnJlc3BvbmRzIG9ubHkgdG8gY29sb3ItcHJvZmlsZQorICAgICAgICBh dCB0aGUgbW9tZW50LgorCisgICAgICAgICogc3ZnL1NWR0VsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U1ZHRWxlbWVudDo6Y3JlYXRlKToKKyAgICAgICAgKiBzdmcvU1ZHRWxlbWVudC5o OgorICAgICAgICAqIHN2Zy9zdmd0YWdzLmluOiBSZW1vdmVkIHRoZSAiI2lmIDAiIG9mIGNvbG9y LXByb2ZpbGUuIEFkZGVkCisgICAgICAgICJpbnRlcmZhY2VOYW1lPVNWR0VsZW1lbnQsIGN1c3Rv bVR5cGVIZWxwZXIiIHRvIGNvbG9yLXByb2ZpbGUuCisKIDIwMjAtMDktMjAgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQyBEaXNwbGF5XSBBZGQg dGhlIGJlZ2lubmluZ3Mgb2YgYSBDU1MgZGlzcGxheSBib3ggaGllcmFyY2h5IGFuZCBDU1MgcGFp bnRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuY3BwCmluZGV4IDc0NWQzNGNmNTkwMzE3MmMwNWQ1 NDQwOGQ4N2Y0NjAzNjM3OWZhNGIuLjI4ODk2M2M2YjYwMmJlNjgyYzg1YzMzMDZkNTliMGYwOTM1 M2FkNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudC5jcHAKQEAgLTE1NSw2ICsxNTUsMTEgQEAg c3RhdGljIE5FVkVSX0lOTElORSBIYXNoTWFwPEF0b21TdHJpbmdJbXBsKiwgQ1NTUHJvcGVydHlJ RD4gY3JlYXRlQXR0cmlidXRlTmFtZVQKICAgICByZXR1cm4gbWFwOwogfQogCitSZWY8U1ZHRWxl bWVudD4gU1ZHRWxlbWVudDo6Y3JlYXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERv Y3VtZW50JiBkb2N1bWVudCkKK3sKKyAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBTVkdFbGVtZW50 KHRhZ05hbWUsIGRvY3VtZW50KSk7Cit9CisKIFNWR0VsZW1lbnQ6OlNWR0VsZW1lbnQoY29uc3Qg UXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQmIGRvY3VtZW50KQogICAgIDogU3R5bGVk RWxlbWVudCh0YWdOYW1lLCBkb2N1bWVudCwgQ3JlYXRlU1ZHRWxlbWVudCkKICAgICAsIG1fcHJv cGVydHlBbmltYXRvckZhY3RvcnkobWFrZVVuaXF1ZTxTVkdQcm9wZXJ0eUFuaW1hdG9yRmFjdG9y eT4oKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmggYi9Tb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudC5oCmluZGV4IDIyOTkwZWQ5M2IwMTNlODdmMjAwNjc1 MDhiYWYzNWJiZGNkNzdkN2MuLjU1MTJmZmMyZTdlNjQzMWFiYTQ4N2M4M2I4M2EwYjZjYmU5OGIz Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuaApAQCAtNDksNiArNDksNyBAQCB2b2lkIG1hcEF0 dHJpYnV0ZVRvQ1NTUHJvcGVydHkoSGFzaE1hcDxBdG9tU3RyaW5nSW1wbCosIENTU1Byb3BlcnR5 SUQ+KiBwcm9wZXJ0eQogY2xhc3MgU1ZHRWxlbWVudCA6IHB1YmxpYyBTdHlsZWRFbGVtZW50LCBw dWJsaWMgU1ZHUHJvcGVydHlPd25lciB7CiAgICAgV1RGX01BS0VfSVNPX0FMTE9DQVRFRChTVkdF bGVtZW50KTsKIHB1YmxpYzoKKyAgICBzdGF0aWMgUmVmPFNWR0VsZW1lbnQ+IGNyZWF0ZShjb25z dCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCYpOwogICAgIGJvb2wgaXNPdXRlcm1v c3RTVkdTVkdFbGVtZW50KCkgY29uc3Q7CiAKICAgICBTVkdTVkdFbGVtZW50KiBvd25lclNWR0Vs ZW1lbnQoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9zdmd0YWdzLmlu IGIvU291cmNlL1dlYkNvcmUvc3ZnL3N2Z3RhZ3MuaW4KaW5kZXggYzM3YmEyMGU1MGNjZmRmYzA1 ODNmOTkzMmQxYTExOTFlOWQ3MGQyNS4uMzg4YzA0MzQyMDBmMmZjYWJhZDdjM2MxMDdkZjYwNDA5 NjBmZTBmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL3N2Z3RhZ3MuaW4KKysrIGIv U291cmNlL1dlYkNvcmUvc3ZnL3N2Z3RhZ3MuaW4KQEAgLTE0LDkgKzE0LDcgQEAgYW5pbWF0ZVRy YW5zZm9ybQogc2V0CiBjaXJjbGUKIGNsaXBQYXRoCi0jaWYgMAotY29sb3JfcHJvZmlsZQotI2Vu ZGlmCitjb2xvcl9wcm9maWxlIGludGVyZmFjZU5hbWU9U1ZHRWxlbWVudCwgY3VzdG9tVHlwZUhl bHBlcgogY3Vyc29yCiBkZWZzCiBkZXNjCg== 409619 2020-09-24 13:51:18 -0700 2020-09-24 15:25:51 -0700 Patch bug-216910-20200925055116.patch text/plain 2504 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQ3MjVhZDc5OGNiYzJm NmFkYTRlYWZmZTU2M2I1MmRiOTdmY2NkMi4uZjUxNTNjYWY5NmM3YTE1ZTBlMmNlNGNkMWEyYWJj OTNlNjgyYTI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA5LTI0ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtTVkcyXSBS ZW1vdmUgY29sb3ItcHJvZmlsZSB0YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNjkxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFNWRzIgcmVtb3ZlZCBjb2xvci1wcm9maWxlIGVsZW1lbnQuCisKKyAg ICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnZh bGlkYXRlQ3VzdG9tRWxlbWVudE5hbWUpOgorICAgICAgICAqIHN2Zy9zdmd0YWdzLmluOgorCiAy MDIwLTA5LTIzICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IGZlYXR1cmUgZmxhZ3MgZm9yIEdQVSBQcm9jZXNzIGZlYXR1cmVzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcAppbmRleCBiMjY2MDQ5MTJlNDJiNDEyZTU2MjgyNWVmMjA2ZWYxYTIxMDBlZmU2Li4zNmI1 MzRlZDIwZWU4NjMyYTllZTcxMTQyZjQ5YWY1ZGRjYTkyMGEzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKQEAgLTEyNjYsMTUgKzEyNjYsMTYgQEAgQ3VzdG9tRWxlbWVudE5hbWVWYWxpZGF0aW9u U3RhdHVzIERvY3VtZW50Ojp2YWxpZGF0ZUN1c3RvbUVsZW1lbnROYW1lKGNvbnN0IEF0b20KICNl bHNlCiAgICAgc3RhdGljIE1haW5UaHJlYWROZXZlckRlc3Ryb3llZDxjb25zdCBBdG9tU3RyaW5n PiBhbm5vdGF0aW9uWG1sTG9jYWxOYW1lKCJhbm5vdGF0aW9uLXhtbCIsIEF0b21TdHJpbmc6OkNv bnN0cnVjdEZyb21MaXRlcmFsKTsKICNlbmRpZgorICAgIHN0YXRpYyBNYWluVGhyZWFkTmV2ZXJE ZXN0cm95ZWQ8Y29uc3QgQXRvbVN0cmluZz4gY29sb3JQcm9maWxlTG9jYWxOYW1lKCJjb2xvci1w cm9maWxlIiwgQXRvbVN0cmluZzo6Q29uc3RydWN0RnJvbUxpdGVyYWwpOwogCi0gICAgaWYgKGxv Y2FsTmFtZSA9PSBTVkdOYW1lczo6Y29sb3JfcHJvZmlsZVRhZy0+bG9jYWxOYW1lKCkKLSAgICAg ICAgfHwgbG9jYWxOYW1lID09IFNWR05hbWVzOjpmb250X2ZhY2VUYWctPmxvY2FsTmFtZSgpCisg ICAgaWYgKGxvY2FsTmFtZSA9PSBTVkdOYW1lczo6Zm9udF9mYWNlVGFnLT5sb2NhbE5hbWUoKQog ICAgICAgICB8fCBsb2NhbE5hbWUgPT0gU1ZHTmFtZXM6OmZvbnRfZmFjZV9mb3JtYXRUYWctPmxv Y2FsTmFtZSgpCiAgICAgICAgIHx8IGxvY2FsTmFtZSA9PSBTVkdOYW1lczo6Zm9udF9mYWNlX25h bWVUYWctPmxvY2FsTmFtZSgpCiAgICAgICAgIHx8IGxvY2FsTmFtZSA9PSBTVkdOYW1lczo6Zm9u dF9mYWNlX3NyY1RhZy0+bG9jYWxOYW1lKCkKICAgICAgICAgfHwgbG9jYWxOYW1lID09IFNWR05h bWVzOjpmb250X2ZhY2VfdXJpVGFnLT5sb2NhbE5hbWUoKQogICAgICAgICB8fCBsb2NhbE5hbWUg PT0gU1ZHTmFtZXM6Om1pc3NpbmdfZ2x5cGhUYWctPmxvY2FsTmFtZSgpCi0gICAgICAgIHx8IGxv Y2FsTmFtZSA9PSBhbm5vdGF0aW9uWG1sTG9jYWxOYW1lKQorICAgICAgICB8fCBsb2NhbE5hbWUg PT0gYW5ub3RhdGlvblhtbExvY2FsTmFtZQorICAgICAgICB8fCBsb2NhbE5hbWUgPT0gY29sb3JQ cm9maWxlTG9jYWxOYW1lKQogICAgICAgICByZXR1cm4gQ3VzdG9tRWxlbWVudE5hbWVWYWxpZGF0 aW9uU3RhdHVzOjpDb25mbGljdHNXaXRoU3RhbmRhcmRFbGVtZW50TmFtZTsKIAogICAgIHJldHVy biBDdXN0b21FbGVtZW50TmFtZVZhbGlkYXRpb25TdGF0dXM6OlZhbGlkOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvc3ZnL3N2Z3RhZ3MuaW4gYi9Tb3VyY2UvV2ViQ29yZS9zdmcvc3ZndGFn cy5pbgppbmRleCBjMzdiYTIwZTUwY2NmZGZjMDU4M2Y5OTMyZDFhMTE5MWU5ZDcwZDI1Li4xM2M3 YTUxNTI2ZGUxODQyZjg1MmEwNGFlY2U0M2M2YTNjMGFkMmZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9zdmcvc3ZndGFncy5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvc3ZndGFncy5p bgpAQCAtMTQsOSArMTQsNiBAQCBhbmltYXRlVHJhbnNmb3JtCiBzZXQKIGNpcmNsZQogY2xpcFBh dGgKLSNpZiAwCi1jb2xvcl9wcm9maWxlCi0jZW5kaWYKIGN1cnNvcgogZGVmcwogZGVzYwo=