216839 2020-09-22 12:31:18 -0700 AudioParam.setValueCurveAtTime() should have an implicit call to setValueAtTime() at the end 2020-09-22 13:14:19 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212611 1 cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1690819 0 cdumez 2020-09-22 12:31:18 -0700 AudioParam.setValueCurveAtTime() should have an implicit call to setValueAtTime() at the end, as specified here: - https://www.w3.org/TR/webaudio/#dom-audioparam-setvaluecurveattime """ An implicit call to setValueAtTime() is made at time 𝑇0+𝑇𝐷 with value 𝑉[𝑁−1] so that following automations will start from the end of the setValueCurveAtTime() event. """ 1690821 1 409388 cdumez 2020-09-22 12:32:44 -0700 Created attachment 409388 Patch 1690838 2 ews-feeder 2020-09-22 13:13:46 -0700 Committed r267435: <https://trac.webkit.org/changeset/267435> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409388. 1690839 3 webkit-bug-importer 2020-09-22 13:14:19 -0700 <rdar://problem/69388018> 409388 2020-09-22 12:32:44 -0700 2020-09-22 13:13:47 -0700 Patch bug-216839-20200922123243.patch text/plain 7254 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTkzMDJjMGRiN2IyZTVh YmU0YmU5NzBiMjMwOWYwNGIzOGEwODYxOS4uMmUxZjY3ZjkxYjQ3NWVkOWE5Y2RjMjM2ZjkzYTcz M2JhYTJlOGQ3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA5LTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXVkaW9QYXJhbS5zZXRWYWx1 ZUN1cnZlQXRUaW1lKCkgc2hvdWxkIGhhdmUgYW4gaW1wbGljaXQgY2FsbCB0byBzZXRWYWx1ZUF0 VGltZSgpIGF0IHRoZSBlbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNjgzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEF1ZGlvUGFyYW0uc2V0VmFsdWVDdXJ2ZUF0VGltZSgpIHNob3VsZCBoYXZlIGFu IGltcGxpY2l0IGNhbGwgdG8gc2V0VmFsdWVBdFRpbWUoKSBhdCB0aGUgZW5kLAorICAgICAgICBh cyBzcGVjaWZpZWQgaGVyZToKKyAgICAgICAgLSBodHRwczovL3d3dy53My5vcmcvVFIvd2ViYXVk aW8vI2RvbS1hdWRpb3BhcmFtLXNldHZhbHVlY3VydmVhdHRpbWUKKworICAgICAgICAiIiIKKyAg ICAgICAgQW4gaW1wbGljaXQgY2FsbCB0byBzZXRWYWx1ZUF0VGltZSgpIGlzIG1hZGUgYXQgdGlt ZSDwnZGHMCvwnZGH8J2QtyB3aXRoIHZhbHVlIPCdkYlb8J2RgeKIkjFdIHNvIHRoYXQKKyAgICAg ICAgZm9sbG93aW5nIGF1dG9tYXRpb25zIHdpbGwgc3RhcnQgZnJvbSB0aGUgZW5kIG9mIHRoZSBz ZXRWYWx1ZUN1cnZlQXRUaW1lKCkgZXZlbnQuCisgICAgICAgICIiIgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIE1vZHVsZXMv d2ViYXVkaW8vQXVkaW9QYXJhbVRpbWVsaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlv UGFyYW1UaW1lbGluZTo6c2V0VmFsdWVDdXJ2ZUF0VGltZSk6CisKIDIwMjAtMDktMjIgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBwYXJ0aWFs IHJldmVydCBvZiByMjY3MzgzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9BdWRpb1BhcmFtVGltZWxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9BdWRpb1BhcmFtVGltZWxpbmUuY3BwCmluZGV4IDdmNTI4MzU4MWUwYTM1YjkyNGMx Njc2NmVhNTQ3YTRhMGE1YWJmOTYuLmYwOWY5OTk3MDM4ZmIwNmYwOGJjMzVkNDE0ZjI1MTgwZWVi ZWJlMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Q YXJhbVRpbWVsaW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1 ZGlvUGFyYW1UaW1lbGluZS5jcHAKQEAgLTEwMyw3ICsxMDMsMTUgQEAgRXhjZXB0aW9uT3I8dm9p ZD4gQXVkaW9QYXJhbVRpbWVsaW5lOjpzZXRUYXJnZXRBdFRpbWUoZmxvYXQgdGFyZ2V0LCBTZWNv bmRzIHRpbWUKIEV4Y2VwdGlvbk9yPHZvaWQ+IEF1ZGlvUGFyYW1UaW1lbGluZTo6c2V0VmFsdWVD dXJ2ZUF0VGltZShWZWN0b3I8ZmxvYXQ+JiYgY3VydmUsIFNlY29uZHMgdGltZSwgU2Vjb25kcyBk dXJhdGlvbikKIHsKICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1fZXZlbnRzTXV0ZXgpOwot ICAgIHJldHVybiBpbnNlcnRFdmVudChQYXJhbUV2ZW50OjpjcmVhdGVTZXRWYWx1ZUN1cnZlRXZl bnQoV1RGTW92ZShjdXJ2ZSksIHRpbWUsIGR1cmF0aW9uKSk7CisKKyAgICBmbG9hdCBjdXJ2ZUVu ZFZhbHVlID0gY3VydmUubGFzdCgpOworICAgIGF1dG8gcmVzdWx0ID0gaW5zZXJ0RXZlbnQoUGFy YW1FdmVudDo6Y3JlYXRlU2V0VmFsdWVDdXJ2ZUV2ZW50KFdURk1vdmUoY3VydmUpLCB0aW1lLCBk dXJhdGlvbikpOworICAgIGlmIChyZXN1bHQuaGFzRXhjZXB0aW9uKCkpCisgICAgICAgIHJldHVy biByZXN1bHQucmVsZWFzZUV4Y2VwdGlvbigpOworCisgICAgLy8gVGhlIHNwZWNpZmljYXRpb24g c2F5cyBhbiBpbXBsaWNpdCBjYWxsIHRvIHNldFZhbHVlQXRUaW1lKCkgaXMgbWFkZSBhdCB0aW1l IFQwK1REIHdpdGggdmFsdWUgVltOLTFdCisgICAgLy8gc28gdGhhdCBmb2xsb3dpbmcgYXV0b21h dGlvbnMgd2lsbCBzdGFydCBmcm9tIHRoZSBlbmQgb2YgdGhlIHNldFZhbHVlQ3VydmVBdFRpbWUo KSBldmVudC4KKyAgICByZXR1cm4gaW5zZXJ0RXZlbnQoUGFyYW1FdmVudDo6Y3JlYXRlU2V0VmFs dWVFdmVudChjdXJ2ZUVuZFZhbHVlLCB0aW1lICsgZHVyYXRpb24pKTsKIH0KIAogc3RhdGljIGJv b2wgaXNWYWxpZE51bWJlcihmbG9hdCB4KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDY1MmY1Y2ViOTJkN2VhYzUzMTZkODE3 MDFiNjNhZWRhMDZhYjA4MDAuLmJmYTMxMGIzZGU4MzgzM2QwYjQ0MGZjOThiNDA3MTUxZDNhNTZk MjkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOS0yMiAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgorCisgICAgICAgIEF1ZGlvUGFyYW0uc2V0VmFsdWVDdXJ2ZUF0VGltZSgp IHNob3VsZCBoYXZlIGFuIGltcGxpY2l0IGNhbGwgdG8gc2V0VmFsdWVBdFRpbWUoKSBhdCB0aGUg ZW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY4 MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWJh c2VsaW5lIHRlc3QgdGhhdCBpcyBub3cgcGFzc2luZy4KKworICAgICAgICAqIHdlYmF1ZGlvL0F1 ZGlvUGFyYW0vYXVkaW9wYXJhbS1zZXRWYWx1ZUN1cnZlLWVuZC1leHBlY3RlZC50eHQ6CisKIDIw MjAtMDktMjIgIERpZWdvIFBpbm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KIAogICAgICAg ICBbR0xJQl0gVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZy4gTWFyayBzZXZlcmFsIGF1ZGlvIHJl bGF0ZWQgdGVzdHMgYXMgZmFpbHVyZSBhZnRlciByMjY3MzgzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvd2ViYXVkaW8vQXVkaW9QYXJhbS9hdWRpb3BhcmFtLXNldFZhbHVlQ3VydmUtZW5kLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL0F1ZGlvUGFyYW0vYXVkaW9wYXJhbS1z ZXRWYWx1ZUN1cnZlLWVuZC1leHBlY3RlZC50eHQKaW5kZXggZTQ2NTMyNjI2ZDZlMTg2ZjU3NGNi MDVkNmUyNWNlYjY0YWJhY2M2Ny4uY2Y5OTZkNjE5YTY1MGM4ZDZlM2FlYzJhMWM1YWU1YzFmYjY4 NDcxZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vQXVkaW9QYXJhbS9hdWRpb3Bh cmFtLXNldFZhbHVlQ3VydmUtZW5kLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy93ZWJh dWRpby9BdWRpb1BhcmFtL2F1ZGlvcGFyYW0tc2V0VmFsdWVDdXJ2ZS1lbmQtZXhwZWN0ZWQudHh0 CkBAIC04LDIyICs4LDIyIEBAIFBBU1MgRXhlY3V0aW5nICI0OiBzZXRUYXJnZXRBdFRpbWUiCiBQ QVNTIEV4ZWN1dGluZyAiNTogc2V0VGFyZ2V0QXRUaW1lIiAKIFBBU1MgQXVkaXQgcmVwb3J0IAog UEFTUyA+IFswOiBsaW5lYXJSYW1wVG9WYWx1ZUF0VGltZV0gIAotRkFJTCBYIHNldFZhbHVlQ3Vy dmUoLi4uLCAwLCAwLjAxKS5saW5lYXJSYW1wVG9WYWx1ZUF0VGltZSgyLCAwLjAyKTogdmFsdWUg YXQgdGltZSAwLjAxIGlzIG5vdCBjbG9zZSB0byAwLjMgd2l0aGluIGEgcmVsYXRpdmUgZXJyb3Ig b2YgMy45NzM3ZS04IChSZWxFcnI9Mi4zMzMzMzMzMzMzMzMzMzM1KS4gR290IDEuIGFzc2VydF90 cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQotRkFJTCA8IFswOiBsaW5lYXJSYW1wVG9WYWx1 ZUF0VGltZV0gMSBvdXQgb2YgMSBhc3NlcnRpb25zIHdlcmUgZmFpbGVkLiBhc3NlcnRfdHJ1ZTog ZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKK1BBU1MgICBzZXRWYWx1ZUN1cnZlKC4uLiwgMCwgMC4w MSkubGluZWFyUmFtcFRvVmFsdWVBdFRpbWUoMiwgMC4wMik6IHZhbHVlIGF0IHRpbWUgMC4wMSBp cyAwLjMgd2l0aGluIGFuIGVycm9yIG9mIDMuOTczN2UtOC4gCitQQVNTIDwgWzA6IGxpbmVhclJh bXBUb1ZhbHVlQXRUaW1lXSBBbGwgYXNzZXJ0aW9ucyBwYXNzZWQuICh0b3RhbCAxIGFzc2VydGlv bnMpIAogUEFTUyA+IFsxOiBsaW5lYXJSYW1wVG9WYWx1ZUF0VGltZV0gIAotRkFJTCBYIHNldFZh bHVlQ3VydmUoLi4uLCAwLCAwLjAxMDAzOTA2MjUpLmxpbmVhclJhbXBUb1ZhbHVlQXRUaW1lKDIs IDAuMDIpOiB2YWx1ZSBhdCB0aW1lIDAuMDEwMDc4MTI1IGlzIG5vdCBjbG9zZSB0byAwLjMwNjY2 NjY2NjY2NjY2Njggd2l0aGluIGEgcmVsYXRpdmUgZXJyb3Igb2YgMS44MTQxZS04IChSZWxFcnI9 Mi4yODYzNDUxMDg2OTU2NTA2KS4gR290IDEuMDA3ODEyNS4gYXNzZXJ0X3RydWU6IGV4cGVjdGVk IHRydWUgZ290IGZhbHNlCi1GQUlMIDwgWzE6IGxpbmVhclJhbXBUb1ZhbHVlQXRUaW1lXSAxIG91 dCBvZiAxIGFzc2VydGlvbnMgd2VyZSBmYWlsZWQuIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVl IGdvdCBmYWxzZQorUEFTUyAgIHNldFZhbHVlQ3VydmUoLi4uLCAwLCAwLjAxMDAzOTA2MjUpLmxp bmVhclJhbXBUb1ZhbHVlQXRUaW1lKDIsIDAuMDIpOiB2YWx1ZSBhdCB0aW1lIDAuMDEwMDc4MTI1 IGlzIDAuMzA2NjY2NjY2NjY2NjY2OCB3aXRoaW4gYW4gZXJyb3Igb2YgMS44MTQxZS04LiAKK1BB U1MgPCBbMTogbGluZWFyUmFtcFRvVmFsdWVBdFRpbWVdIEFsbCBhc3NlcnRpb25zIHBhc3NlZC4g KHRvdGFsIDEgYXNzZXJ0aW9ucykgCiBQQVNTID4gWzI6IGV4cG9uZW50aWFsUmFtcFRvVmFsdWVB dFRpbWVdICAKLUZBSUwgWCBzZXRWYWx1ZUN1cnZlKC4uLiwgMCwgMC4wMSkuZXhwb25lbnRpYWxS YW1wVG9WYWx1ZUF0VGltZSgyLCAwLjAyKTogdmFsdWUgYXQgdGltZSAwLjAxIGlzIG5vdCBjbG9z ZSB0byAwLjMgd2l0aGluIGEgcmVsYXRpdmUgZXJyb3Igb2YgMy45NzM3ZS04IChSZWxFcnI9MSku IEdvdCAwLiBhc3NlcnRfdHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKLUZBSUwgPCBbMjog ZXhwb25lbnRpYWxSYW1wVG9WYWx1ZUF0VGltZV0gMSBvdXQgb2YgMSBhc3NlcnRpb25zIHdlcmUg ZmFpbGVkLiBhc3NlcnRfdHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKK1BBU1MgICBzZXRW YWx1ZUN1cnZlKC4uLiwgMCwgMC4wMSkuZXhwb25lbnRpYWxSYW1wVG9WYWx1ZUF0VGltZSgyLCAw LjAyKTogdmFsdWUgYXQgdGltZSAwLjAxIGlzIDAuMyB3aXRoaW4gYW4gZXJyb3Igb2YgMy45NzM3 ZS04LiAKK1BBU1MgPCBbMjogZXhwb25lbnRpYWxSYW1wVG9WYWx1ZUF0VGltZV0gQWxsIGFzc2Vy dGlvbnMgcGFzc2VkLiAodG90YWwgMSBhc3NlcnRpb25zKSAKIFBBU1MgPiBbMzogZXhwb25lbnRp YWxSYW1wVG9WYWx1ZUF0VGltZV0gIAotRkFJTCBYIHNldFZhbHVlQ3VydmUoLi4uLCAwLCAwLjAx MDAzOTA2MjUpLmV4cG9uZW50aWFsUmFtcFRvVmFsdWVBdFRpbWUoMiwgMC4wMik6IHZhbHVlIGF0 IHRpbWUgMC4wMTAwNzgxMjUgaXMgbm90IGNsb3NlIHRvIDAuMzAyMjQwMjI4ODMxNTAzNjQgd2l0 aGluIGEgcmVsYXRpdmUgZXJyb3Igb2YgNy44Mjk0ZS04IChSZWxFcnI9MSkuIEdvdCAwLiBhc3Nl cnRfdHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKLUZBSUwgPCBbMzogZXhwb25lbnRpYWxS YW1wVG9WYWx1ZUF0VGltZV0gMSBvdXQgb2YgMSBhc3NlcnRpb25zIHdlcmUgZmFpbGVkLiBhc3Nl cnRfdHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKK1BBU1MgICBzZXRWYWx1ZUN1cnZlKC4u LiwgMCwgMC4wMTAwMzkwNjI1KS5leHBvbmVudGlhbFJhbXBUb1ZhbHVlQXRUaW1lKDIsIDAuMDIp OiB2YWx1ZSBhdCB0aW1lIDAuMDEwMDc4MTI1IGlzIDAuMzAyMjQwMjI4ODMxNTAzNjQgd2l0aGlu IGFuIGVycm9yIG9mIDcuODI5NGUtOC4gCitQQVNTIDwgWzM6IGV4cG9uZW50aWFsUmFtcFRvVmFs dWVBdFRpbWVdIEFsbCBhc3NlcnRpb25zIHBhc3NlZC4gKHRvdGFsIDEgYXNzZXJ0aW9ucykgCiBQ QVNTID4gWzQ6IHNldFRhcmdldEF0VGltZV0gIAogUEFTUyAgIHNldFZhbHVlQ3VydmUoLi4uLCAw LCAwLjAxKS5zZXRUYXJnZXRBdFRpbWUoMiwgMC4wMiwgMC4wMSk6IHZhbHVlIGF0IHRpbWUgMC4w MSBpcyAwLjMwMDAwMDAwMDAwMDAwMDA0IHdpdGhpbiBhbiBlcnJvciBvZiAxLjU4OTVlLTcuIAog UEFTUyA8IFs0OiBzZXRUYXJnZXRBdFRpbWVdIEFsbCBhc3NlcnRpb25zIHBhc3NlZC4gKHRvdGFs IDEgYXNzZXJ0aW9ucykgCiBQQVNTID4gWzU6IHNldFRhcmdldEF0VGltZV0gIAotRkFJTCBYIHNl dFZhbHVlQ3VydmUoLi4uLCAwLCAwLjAxMDAzOTA2MjUpLnNldFRhcmdldEF0VGltZSgyLCAwLjAy LCAwLjAxKTogdmFsdWUgYXQgdGltZSAwLjAxMDA3ODEyNSBpcyBub3QgY2xvc2UgdG8gMC4zMDY2 Mjc2NzE5MDA4MDA1NCB3aXRoaW4gYSByZWxhdGl2ZSBlcnJvciBvZiAxLjMyNzhlLTcgKFJlbEVy cj0wLjA0Mjk3NzEzODc1ODA5MzY5KS4gR290IDAuMzE5ODA1NjUxOTAzMTUyNDcuIGFzc2VydF90 cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQotRkFJTCA8IFs1OiBzZXRUYXJnZXRBdFRpbWVd IDEgb3V0IG9mIDEgYXNzZXJ0aW9ucyB3ZXJlIGZhaWxlZC4gYXNzZXJ0X3RydWU6IGV4cGVjdGVk IHRydWUgZ290IGZhbHNlCi1GQUlMICMgQVVESVQgVEFTSyBSVU5ORVIgRklOSVNIRUQ6IDUgb3V0 IG9mIDYgdGFza3Mgd2VyZSBmYWlsZWQuIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBm YWxzZQorUEFTUyAgIHNldFZhbHVlQ3VydmUoLi4uLCAwLCAwLjAxMDAzOTA2MjUpLnNldFRhcmdl dEF0VGltZSgyLCAwLjAyLCAwLjAxKTogdmFsdWUgYXQgdGltZSAwLjAxMDA3ODEyNSBpcyAwLjMw NjYyNzY3MTkwMDgwMDU0IHdpdGhpbiBhbiBlcnJvciBvZiAxLjMyNzhlLTcuIAorUEFTUyA8IFs1 OiBzZXRUYXJnZXRBdFRpbWVdIEFsbCBhc3NlcnRpb25zIHBhc3NlZC4gKHRvdGFsIDEgYXNzZXJ0 aW9ucykgCitQQVNTICMgQVVESVQgVEFTSyBSVU5ORVIgRklOSVNIRUQ6IDYgdGFza3MgcmFuIHN1 Y2Nlc3NmdWxseS4gCiAK