216688 2020-09-18 00:16:04 -0700 MediaRecorder should allow setting low bit rates for audio 2020-10-01 00:34:24 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 85851 1 youennf youennf eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf zach oldest_to_newest 1689722 0 youennf 2020-09-18 00:16:04 -0700 Currently this is restricted to high bitrates. 1689726 1 webkit-bug-importer 2020-09-18 00:31:11 -0700 <rdar://problem/69129142> 1690410 2 zach 2020-09-21 12:12:06 -0700 Is any info available on what the minimum bitrates are for audio and video? 1690710 3 youennf 2020-09-22 08:42:34 -0700 This is limited so far to 128000, 192000 or 256000 for now. 1693333 4 410104 youennf 2020-09-30 02:50:29 -0700 Created attachment 410104 Patch 1693663 5 ews-feeder 2020-10-01 00:34:23 -0700 Committed r267822: <https://trac.webkit.org/changeset/267822> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410104. 410104 2020-09-30 02:50:29 -0700 2020-10-01 00:34:24 -0700 Patch bug-216688-20200930115028.patch text/plain 7225 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3NzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGIzM2Y5ODQ2YzUwNGJi YmYzODNhNTdmM2ViZGRjN2FkMjcxNzNmYi4uNTVhOTFiMDViZDliYzhiNDFhNjZjMjJjMzM0YWU3 OWZiNDQ0NGY2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA5LTMwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYVJlY29yZGVyIHNo b3VsZCBhbGxvdyBzZXR0aW5nIGxvdyBiaXQgcmF0ZXMgZm9yIGF1ZGlvCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY2ODgKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzY5MTI5MTQyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdoZW4gc2V0dGluZyB0aGUgYml0cmF0ZSBwcm92aWRlZCBieSB0aGUgd2Vi IGFwcCBmYWlscywgd2Ugbm93IHVzZSBkZWZhdWx0IGJpdCByYXRlIHZhbHVlcyB0aGF0IGFyZSBl eHBlY3RlZCB0byB3b3JrIHByb3Blcmx5LgorICAgICAgICBDb3ZlcmVkIGJ5IHVwZGF0ZWQgdGVz dHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXJlY29yZGVyL2NvY29hL0F1ZGlvU2FtcGxl QnVmZmVyQ29tcHJlc3Nvci5oOgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhcmVjb3JkZXIvY29j b2EvQXVkaW9TYW1wbGVCdWZmZXJDb21wcmVzc29yLm1tOgorICAgICAgICAoV2ViQ29yZTo6QXVk aW9TYW1wbGVCdWZmZXJDb21wcmVzc29yOjpzZXRCaXRzUGVyU2Vjb25kKToKKyAgICAgICAgKFdl YkNvcmU6OkF1ZGlvU2FtcGxlQnVmZmVyQ29tcHJlc3Nvcjo6ZGVmYXVsdE91dHB1dEJpdFJhdGUg Y29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9TYW1wbGVCdWZmZXJDb21wcmVzc29yOjpp bml0QXVkaW9Db252ZXJ0ZXJGb3JTb3VyY2VGb3JtYXREZXNjcmlwdGlvbik6CisKIDIwMjAtMDkt MjkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlhUmVj b3JkZXIgc2hvdWxkIHN1cHBvcnQgaXNUeXBlU3VwcG9ydGVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXJlY29yZGVyL2NvY29hL0F1ZGlvU2FtcGxlQnVmZmVyQ29t cHJlc3Nvci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFyZWNvcmRlci9jb2NvYS9B dWRpb1NhbXBsZUJ1ZmZlckNvbXByZXNzb3IuaAppbmRleCAyODU4MTYwYTA2M2E1NzMxMWEyNGRl NDdhNzc5Nzc2MjkxZjU5ZDJkLi4wNzk4YzBjYTNmY2RjMTcxZjBlMzc4N2UwYjk3YWE0Y2YzYjhi NjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXJlY29yZGVyL2Nv Y29hL0F1ZGlvU2FtcGxlQnVmZmVyQ29tcHJlc3Nvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21lZGlhcmVjb3JkZXIvY29jb2EvQXVkaW9TYW1wbGVCdWZmZXJDb21wcmVzc29yLmgK QEAgLTQ4LDcgKzQ4LDcgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBBdWRpb1NhbXBsZUJ1ZmZl ckNvbXByZXNzb3IoKTsKICAgICBib29sIGluaXRpYWxpemUoQ01CdWZmZXJRdWV1ZVRyaWdnZXJD YWxsYmFjaywgdm9pZCogY2FsbGJhY2tPYmplY3QpOwotICAgIFVJbnQzMiBvdXRwdXRCaXRSYXRl KGNvbnN0IEF1ZGlvU3RyZWFtQmFzaWNEZXNjcmlwdGlvbiYpIGNvbnN0OworICAgIFVJbnQzMiBk ZWZhdWx0T3V0cHV0Qml0UmF0ZShjb25zdCBBdWRpb1N0cmVhbUJhc2ljRGVzY3JpcHRpb24mKSBj b25zdDsKIAogICAgIHN0YXRpYyBPU1N0YXR1cyBhdWRpb0NvbnZlcnRlckNvbXBsZXhJbnB1dERh dGFQcm9jKEF1ZGlvQ29udmVydGVyUmVmLCBVSW50MzIqLCBBdWRpb0J1ZmZlckxpc3QqLCBBdWRp b1N0cmVhbVBhY2tldERlc2NyaXB0aW9uKiosIHZvaWQqKTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFyZWNvcmRlci9jb2NvYS9BdWRpb1NhbXBsZUJ1ZmZlckNv bXByZXNzb3IubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXJlY29yZGVyL2NvY29h L0F1ZGlvU2FtcGxlQnVmZmVyQ29tcHJlc3Nvci5tbQppbmRleCAyY2VlNzliMGU5YzI4OTQ2NWVk YzNkYTFiNzg1MWQxOGU5NGZiOWM2Li5kNDZiNmRmMGRmMmM5MzlmMjljZTgxOGE1ZjRkM2JiNDI2 NjM5NDM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXJlY29yZGVy L2NvY29hL0F1ZGlvU2FtcGxlQnVmZmVyQ29tcHJlc3Nvci5tbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tZWRpYXJlY29yZGVyL2NvY29hL0F1ZGlvU2FtcGxlQnVmZmVyQ29tcHJlc3Nv ci5tbQpAQCAtOTksMjUgKzk5LDExIEBAIHZvaWQgQXVkaW9TYW1wbGVCdWZmZXJDb21wcmVzc29y OjpmaW5pc2goKQogCiB2b2lkIEF1ZGlvU2FtcGxlQnVmZmVyQ29tcHJlc3Nvcjo6c2V0Qml0c1Bl clNlY29uZCh1bnNpZ25lZCBiaXRSYXRlKQogewotICAgIC8vIEZJWE1FOiB3ZSBoYXZlIHNvbWUg aXNzdWVzIHdoZW4gc2V0dGluZyB1cCBzb21lIGJpdCByYXRlcywgb25seSBhbGxvdyBzb21lIHRo YXQgd29yayBmb3IgdGhlIG1vbWVudC4KLSAgICBpZiAoYml0UmF0ZSA8IDEyODAwMCkgewotICAg ICAgICBSRUxFQVNFX0xPR19JTkZPKFdlYlJUQywgIkF1ZGlvU2FtcGxlQnVmZmVyQ29tcHJlc3Nv cjo6b3V0cHV0Qml0UmF0ZSBjbGFtcGVkIHRvIDEyODAwMC4iKTsKLSAgICAgICAgYml0UmF0ZSA9 IDEyODAwMDsKLSAgICB9IGVsc2UgaWYgKGJpdFJhdGUgPiAyNTYwMDApIHsKLSAgICAgICAgUkVM RUFTRV9MT0dfSU5GTyhXZWJSVEMsICJBdWRpb1NhbXBsZUJ1ZmZlckNvbXByZXNzb3I6Om91dHB1 dEJpdFJhdGUgY2xhbXBlZCB0byAyNTYwMDAuIik7Ci0gICAgICAgIGJpdFJhdGUgPSAyNTYwMDA7 Ci0gICAgfSBlbHNlIGlmIChiaXRSYXRlICE9IDEyODAwMCAmJiBiaXRSYXRlICE9IDE5MjAwMCAm JiBiaXRSYXRlICE9IDI1NjAwMCkgewotICAgICAgICBSRUxFQVNFX0xPR19JTkZPKFdlYlJUQywg IkF1ZGlvU2FtcGxlQnVmZmVyQ29tcHJlc3Nvcjo6b3V0cHV0Qml0UmF0ZSBkaWQgbm90IHNldCBv dXRwdXQgYml0IHJhdGUgYXMgdmFsdWUgaXMgbm90IHN1cHBvcnRlZC4iKTsKLSAgICAgICAgcmV0 dXJuOwotICAgIH0KICAgICBtX291dHB1dEJpdFJhdGUgPSBiaXRSYXRlOwogfQogCi1VSW50MzIg QXVkaW9TYW1wbGVCdWZmZXJDb21wcmVzc29yOjpvdXRwdXRCaXRSYXRlKGNvbnN0IEF1ZGlvU3Ry ZWFtQmFzaWNEZXNjcmlwdGlvbiYgZGVzdGluYXRpb25Gb3JtYXQpIGNvbnN0CitVSW50MzIgQXVk aW9TYW1wbGVCdWZmZXJDb21wcmVzc29yOjpkZWZhdWx0T3V0cHV0Qml0UmF0ZShjb25zdCBBdWRp b1N0cmVhbUJhc2ljRGVzY3JpcHRpb24mIGRlc3RpbmF0aW9uRm9ybWF0KSBjb25zdAogewotICAg IGlmIChtX291dHB1dEJpdFJhdGUpCi0gICAgICAgIHJldHVybiAqbV9vdXRwdXRCaXRSYXRlOwot CiAgICAgaWYgKGRlc3RpbmF0aW9uRm9ybWF0Lm1TYW1wbGVSYXRlID49IDQ0MTAwKQogICAgICAg ICByZXR1cm4gMTkyMDAwOwogICAgIGlmIChkZXN0aW5hdGlvbkZvcm1hdC5tU2FtcGxlUmF0ZSA8 IDIyMDAwKQpAQCAtMTgwLDEwICsxNjYsMTggQEAgYm9vbCBBdWRpb1NhbXBsZUJ1ZmZlckNvbXBy ZXNzb3I6OmluaXRBdWRpb0NvbnZlcnRlckZvclNvdXJjZUZvcm1hdERlc2NyaXB0aW9uKEMKICAg ICB9CiAKICAgICBpZiAobV9kZXN0aW5hdGlvbkZvcm1hdC5tRm9ybWF0SUQgPT0ga0F1ZGlvRm9y bWF0TVBFRzRBQUMpIHsKLSAgICAgICAgYXV0byBvdXRwdXRCaXRSYXRlID0gdGhpcy0+b3V0cHV0 Qml0UmF0ZShtX2Rlc3RpbmF0aW9uRm9ybWF0KTsKLSAgICAgICAgc2l6ZSA9IHNpemVvZihvdXRw dXRCaXRSYXRlKTsKLSAgICAgICAgaWYgKGF1dG8gZXJyb3IgPSBBdWRpb0NvbnZlcnRlclNldFBy b3BlcnR5KG1fY29udmVydGVyLCBrQXVkaW9Db252ZXJ0ZXJFbmNvZGVCaXRSYXRlLCBzaXplLCAm b3V0cHV0Qml0UmF0ZSkpCi0gICAgICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihNZWRpYVN0cmVh bSwgIkF1ZGlvU2FtcGxlQnVmZmVyQ29tcHJlc3NvciBzZXR0aW5nIGtBdWRpb0NvbnZlcnRlckVu Y29kZUJpdFJhdGUgZmFpbGVkIHdpdGggJWQiLCBlcnJvcik7CisgICAgICAgIGJvb2wgc2hvdWxk U2V0RGVmYXVsdE91dHB1dEJpdFJhdGUgPSB0cnVlOworICAgICAgICBpZiAobV9vdXRwdXRCaXRS YXRlKSB7CisgICAgICAgICAgICBhdXRvIGVycm9yID0gQXVkaW9Db252ZXJ0ZXJTZXRQcm9wZXJ0 eShtX2NvbnZlcnRlciwga0F1ZGlvQ29udmVydGVyRW5jb2RlQml0UmF0ZSwgc2l6ZW9mKCptX291 dHB1dEJpdFJhdGUpLCAmbV9vdXRwdXRCaXRSYXRlLnZhbHVlKCkpOworICAgICAgICAgICAgUkVM RUFTRV9MT0dfRVJST1JfSUYoZXJyb3IsIE1lZGlhU3RyZWFtLCAiQXVkaW9TYW1wbGVCdWZmZXJD b21wcmVzc29yIHNldHRpbmcga0F1ZGlvQ29udmVydGVyRW5jb2RlQml0UmF0ZSBmYWlsZWQgd2l0 aCAlZCIsIGVycm9yKTsKKyAgICAgICAgICAgIHNob3VsZFNldERlZmF1bHRPdXRwdXRCaXRSYXRl ID0gISFlcnJvcjsKKyAgICAgICAgfQorICAgICAgICBpZiAoc2hvdWxkU2V0RGVmYXVsdE91dHB1 dEJpdFJhdGUpIHsKKyAgICAgICAgICAgIGF1dG8gb3V0cHV0Qml0UmF0ZSA9IGRlZmF1bHRPdXRw dXRCaXRSYXRlKG1fZGVzdGluYXRpb25Gb3JtYXQpOworICAgICAgICAgICAgc2l6ZSA9IHNpemVv ZihvdXRwdXRCaXRSYXRlKTsKKyAgICAgICAgICAgIGlmIChhdXRvIGVycm9yID0gQXVkaW9Db252 ZXJ0ZXJTZXRQcm9wZXJ0eShtX2NvbnZlcnRlciwga0F1ZGlvQ29udmVydGVyRW5jb2RlQml0UmF0 ZSwgc2l6ZSwgJm91dHB1dEJpdFJhdGUpKQorICAgICAgICAgICAgICAgIFJFTEVBU0VfTE9HX0VS Uk9SKE1lZGlhU3RyZWFtLCAiQXVkaW9TYW1wbGVCdWZmZXJDb21wcmVzc29yIHNldHRpbmcgZGVm YXVsdCBrQXVkaW9Db252ZXJ0ZXJFbmNvZGVCaXRSYXRlIGZhaWxlZCB3aXRoICVkIiwgZXJyb3Ip OworICAgICAgICB9CiAgICAgfQogCiAgICAgaWYgKCFtX2Rlc3RpbmF0aW9uRm9ybWF0Lm1CeXRl c1BlclBhY2tldCkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJhMDlmYTE0N2EzOTk5YjZlZTNiZjZlYzUwZTVkMDI0Mzgw OWE5NTguLjkyYTQ2NmU0MDJlMDY3M2JkNzE3MDcyYTlhNmEzNmJjY2MzNTJiODEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAyMC0wOS0zMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CisKKyAgICAgICAgTWVkaWFSZWNvcmRlciBzaG91bGQgYWxsb3cgc2V0dGluZyBsb3cgYml0 IHJhdGVzIGZvciBhdWRpbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjE2Njg4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82OTEyOTE0Mj4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbW9yZSBiaXRy YXRlIHRlc3RzLgorCisgICAgICAgICogaHR0cC93cHQvbWVkaWFyZWNvcmRlci9NZWRpYVJlY29y ZGVyLWF1ZGlvLWJpdHJhdGUuaHRtbDoKKwogMjAyMC0wOS0yOSAgWW91ZW5uIEZhYmxldCAgPHlv dWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWFSZWNvcmRlciBzaG91bGQgc3VwcG9ydCBp c1R5cGVTdXBwb3J0ZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L21lZGlhcmVj b3JkZXIvTWVkaWFSZWNvcmRlci1hdWRpby1iaXRyYXRlLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRw L3dwdC9tZWRpYXJlY29yZGVyL01lZGlhUmVjb3JkZXItYXVkaW8tYml0cmF0ZS5odG1sCmluZGV4 IDlhMmE5ZDI0ZTZjMDliY2I4MDQ0YWJiMGZlNmFhYjcwM2VjZmZiYjMuLjg3NTI3ZTQzMjc5ZjJh NGJiZDA2NDI3MTkwOTc1YjM3NGVjZDg3MWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAv d3B0L21lZGlhcmVjb3JkZXIvTWVkaWFSZWNvcmRlci1hdWRpby1iaXRyYXRlLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvaHR0cC93cHQvbWVkaWFyZWNvcmRlci9NZWRpYVJlY29yZGVyLWF1ZGlvLWJp dHJhdGUuaHRtbApAQCAtMjEsMTggKzIxLDIyIEBACiAKICAgICBwcm9taXNlX3Rlc3QoYXN5bmMg KHQpID0+IHsKICAgICAgICAgY29uc3Qgc3RyZWFtID0gYXdhaXQgbmF2aWdhdG9yLm1lZGlhRGV2 aWNlcy5nZXRVc2VyTWVkaWEoeyBhdWRpbyA6IHRydWUgfSk7Ci0gICAgICAgIGNvbnN0IGJpdFJh dGVzID0gWzEyODAwMCwgMTkyMDAwLCAyNTYwMDBdOworICAgICAgICBjb25zdCBiaXRSYXRlcyA9 IFsxMjgwMDAsIDE5MjAwMCwgMjU2MDAwLCAxMjAwMCwgMjQwMDAsIDEwODU1NV07CiAgICAgICAg IGxldCBwcm9taXNlcyA9IFtdOwogICAgICAgICBiaXRSYXRlcy5mb3JFYWNoKGJpdFJhdGUgPT4g ewogICAgICAgICAgICAgcHJvbWlzZXMucHVzaChyZWNvcmQoc3RyZWFtLCBiaXRSYXRlKSk7CiAg ICAgICAgIH0pOwogCi0gICAgICAgIGxldCBibG9icyA9IFswLCAwLCAwXTsKKyAgICAgICAgbGV0 IGJsb2JzID0gbmV3IEFycmF5KGJpdFJhdGVzLmxlbmd0aCkuZmlsbCgwKTsKICAgICAgICAgcHJv bWlzZXMuZm9yRWFjaChhc3luYyAocHJvbWlzZSwgaW5kZXgpID0+IHsKICAgICAgICAgICAgIGJs b2JzW2luZGV4XSA9IGF3YWl0IHByb21pc2U7CiAgICAgICAgIH0pOwogICAgICAgICBhd2FpdCBQ cm9taXNlLmFsbChwcm9taXNlcyk7Ci0gICAgICAgIGFzc2VydF9ub3RfZXF1YWxzKGJsb2JzWzBd LnNpemUsIDApOworCisgICAgICAgIGxldCBjb3VudGVyID0gMDsKKyAgICAgICAgYmxvYnMuZm9y RWFjaChibG9iID0+IHsKKyAgICAgICAgICAgIGFzc2VydF9ub3RfZXF1YWxzKGJsb2Iuc2l6ZSwg MCwgImJpdHJhdGUgIiArIGJpdFJhdGVzW2NvdW50ZXIrK10pOworICAgICAgICB9KTsKICAgICAg ICAgYXNzZXJ0X2dyZWF0ZXJfdGhhbihibG9ic1syXS5zaXplLCBibG9ic1swXS5zaXplKTsKICAg ICB9LCAiVmFyaW91cyBhdWRpbyBiaXRyYXRlcyIpOwogPC9zY3JpcHQ+Cg==