216623 2020-09-16 15:37:21 -0700 AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0 2020-09-16 16:27:18 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212611 1 cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1689241 0 cdumez 2020-09-16 15:37:21 -0700 AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0. 1689244 1 408960 cdumez 2020-09-16 15:42:41 -0700 Created attachment 408960 Patch 1689250 2 408960 eric.carlson 2020-09-16 16:23:39 -0700 Comment on attachment 408960 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408960&action=review > Source/WebCore/ChangeLog:10 > + begining out the destination buffer, ignoring the computed writeIndex. As a result, s/out/of/ 1689252 3 cdumez 2020-09-16 16:26:14 -0700 Committed r267170: <https://trac.webkit.org/changeset/267170> 1689253 4 webkit-bug-importer 2020-09-16 16:27:18 -0700 <rdar://problem/69023062> 408960 2020-09-16 15:42:41 -0700 2020-09-16 16:23:39 -0700 Patch bug-216623-20200916154241.patch text/plain 4861 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2U0YWRhMTgzMjFmNWM3 YWQ4MGFlMTRmOTY2YzNiZmM5M2QwYWQxNy4uOWFlN2NiNWYwZmIyNTE1YmUyOTQwYTYzNjUwZDI4 YmU1N2YyOTlkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA5LTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXVkaW9CdWZmZXJTb3VyY2VO b2RlLnN0YXJ0KCkgaWdub3JlcyAnd2hlbicgcGFyYW1ldGVyIHdoZW4gcGl0Y2ggcmF0ZSBpcyAw CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY2MjMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdWRpb0J1 ZmZlclNvdXJjZU5vZGU6OnJlbmRlckZyb21CdWZmZXIoKSBoYXMgc3BlY2lhbCBsb2dpYyB3aGVu IHBpdGNoIHJhdGUgaXMgMCBzaW5jZQorICAgICAgICB0aGUgb3V0cHV0IHZhbHVlIGlzIGNvbnN0 YW50LiBIb3dldmVyLCB0aGF0IGxvZ2ljIHdhcyB3cm9uZ2x5IGFsd2F5cyB3cml0aW5nIHRvIHRo ZQorICAgICAgICBiZWdpbmluZyBvdXQgdGhlIGRlc3RpbmF0aW9uIGJ1ZmZlciwgaWdub3Jpbmcg dGhlIGNvbXB1dGVkIHdyaXRlSW5kZXguIEFzIGEgcmVzdWx0LAorICAgICAgICBpbnN0ZWFkIG9m IGhhdmluZyBzaWxlbmNlIGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIGRlc3RpbmF0aW9uIGJ1ZmZl ciwgd2Ugd291bGQgaGF2ZQorICAgICAgICBpdCBhdCB0aGUgZW5kLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIE1vZHVsZXMv d2ViYXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1 ZGlvQnVmZmVyU291cmNlTm9kZTo6cmVuZGVyRnJvbUJ1ZmZlcik6CisKIDIwMjAtMDktMTYgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBdWRpb0J1ZmZlclNvdXJj ZU5vZGUuc3RhcnQoKSBiZWhhdmlvciBpcyBpbmNvcnJlY3Qgd2hlbiBvZmZzZXQgaXMgcGFzdCB0 aGUgZW5kIG9mIHRoZSBidWZmZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2ViYXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmNwcAppbmRleCA4NWY5Y2RhN2UyNjJm NTAwYjZmZmU3OTNiNzU0ZWFjMjZiNDQxMmMzLi4xNDI1NzI3MWJkOTM0ZGQwM2M4MzFmODYwNDQz NTZlMTBhNmVlZTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L0F1ZGlvQnVmZmVyU291cmNlTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9BdWRpb0J1ZmZlclNvdXJjZU5vZGUuY3BwCkBAIC0zMjUsNyArMzI1LDcgQEAgYm9v bCBBdWRpb0J1ZmZlclNvdXJjZU5vZGU6OnJlbmRlckZyb21CdWZmZXIoQXVkaW9CdXMqIGJ1cywg dW5zaWduZWQgZGVzdGluYXRpb24KICAgICAgICAgdW5zaWduZWQgcmVhZEluZGV4ID0gc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+KHZpcnR1YWxSZWFkSW5kZXgpOwogCiAgICAgICAgIGZvciAodW5zaWdu ZWQgaSA9IDA7IGkgPCBudW1iZXJPZkNoYW5uZWxzOyArK2kpCi0gICAgICAgICAgICBzdGQ6OmZp bGxfbihkZXN0aW5hdGlvbkNoYW5uZWxzW2ldLCBmcmFtZXNUb1Byb2Nlc3MsIHNvdXJjZUNoYW5u ZWxzW2ldW3JlYWRJbmRleF0pOworICAgICAgICAgICAgc3RkOjpmaWxsX24oZGVzdGluYXRpb25D aGFubmVsc1tpXSArIHdyaXRlSW5kZXgsIGZyYW1lc1RvUHJvY2Vzcywgc291cmNlQ2hhbm5lbHNb aV1bcmVhZEluZGV4XSk7CiAgICAgfSBlbHNlIGlmIChyZXZlcnNlKSB7CiAgICAgICAgIHVuc2ln bmVkIG1heEZyYW1lID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHZpcnR1YWxNYXhGcmFtZSk7CiAg ICAgICAgIHVuc2lnbmVkIG1pbkZyYW1lID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGZsb29yZih2 aXJ0dWFsTWluRnJhbWUpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGMxMjNh N2UwZGJhNTIxYTNlZmE5NjMyODkxZDczNTMzNjUwZmIzYjUuLmE4MmMwNWMzYWVlYWQxNDFhM2Ri NjJlY2ZmNTU0ZTFhMDM0YTEyOWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDIwLTA5LTE2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CisKKyAgICAgICAgQXVkaW9CdWZmZXJTb3VyY2VOb2RlLnN0YXJ0KCkgaWdub3JlcyAnd2hlbicg cGFyYW1ldGVyIHdoZW4gcGl0Y2ggcmF0ZSBpcyAwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTY2MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZWJhc2VsaW5lIFdQVCB0ZXN0IHRoYXQgaXMgbm93IHBh c3NpbmcuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlv LWFwaS90aGUtYXVkaW9idWZmZXJzb3VyY2Vub2RlLWludGVyZmFjZS9hdWRpb2J1ZmZlcnNvdXJj ZS1wbGF5YmFja3JhdGUtemVyby1leHBlY3RlZC50eHQ6CisKIDIwMjAtMDktMTYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBdWRpb0J1ZmZlclNvdXJjZU5vZGUu c3RhcnQoKSBiZWhhdmlvciBpcyBpbmNvcnJlY3Qgd2hlbiBvZmZzZXQgaXMgcGFzdCB0aGUgZW5k IG9mIHRoZSBidWZmZXIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYXVkaW9idWZmZXJzb3Vy Y2Vub2RlLWludGVyZmFjZS9hdWRpb2J1ZmZlcnNvdXJjZS1wbGF5YmFja3JhdGUtemVyby1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dl YmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWF1ZGlvYnVmZmVyc291cmNlbm9kZS1pbnRlcmZhY2Uv YXVkaW9idWZmZXJzb3VyY2UtcGxheWJhY2tyYXRlLXplcm8tZXhwZWN0ZWQudHh0CmluZGV4IGRm OTU4ODYyMDFjZTRlOTViZGQ5OGNiOGJjNTBmMWE4YzQxYTQzNDcuLjNjODVjOTBiMjU1NTlmYjI1 MDEwMTY0YTIwNWUxZjE3MDQ2N2FhNDcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYXVkaW9i dWZmZXJzb3VyY2Vub2RlLWludGVyZmFjZS9hdWRpb2J1ZmZlcnNvdXJjZS1wbGF5YmFja3JhdGUt emVyby1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1hdWRpb2J1ZmZlcnNvdXJjZW5v ZGUtaW50ZXJmYWNlL2F1ZGlvYnVmZmVyc291cmNlLXBsYXliYWNrcmF0ZS16ZXJvLWV4cGVjdGVk LnR4dApAQCAtNywyMCArNyw4IEBAIFBBU1MgPiBbc3ludGhlc2l6ZS12ZXJpZnldCiBQQVNTICAg VGhlIHplcm8gcGxheWJhY2tSYXRlIGhlbGQgdGhlIHNhbXBsZSB2YWx1ZSBjb3JyZWN0bHkgCiBQ QVNTIDwgW3N5bnRoZXNpemUtdmVyaWZ5XSBBbGwgYXNzZXJ0aW9ucyBwYXNzZWQuICh0b3RhbCAx IGFzc2VydGlvbnMpIAogUEFTUyA+IFtzdWJzYW1wbGUgc3RhcnQgd2l0aCBwbGF5YmFjayByYXRl IDBdICAKLUZBSUwgWCBvdXRwdXRbMDoyN106IEV4cGVjdGVkIDAgZm9yIGFsbCB2YWx1ZXMgYnV0 IGZvdW5kIDI4IHVuZXhwZWN0ZWQgdmFsdWVzOiAKLQlJbmRleAlBY3R1YWwKLQlbMF0JNQotCVsx XQk1Ci0JWzJdCTUKLQlbM10JNQotCS4uLmFuZCAyNCBtb3JlIGVycm9ycy4gYXNzZXJ0X3RydWU6 IGV4cGVjdGVkIHRydWUgZ290IGZhbHNlCi1GQUlMIFggb3V0cHV0WzI4Ol06IEV4cGVjdGVkIDUg Zm9yIGFsbCB2YWx1ZXMgYnV0IGZvdW5kIDI4IHVuZXhwZWN0ZWQgdmFsdWVzOiAKLQlJbmRleAlB Y3R1YWwKLQlbNzJdCTAKLQlbNzNdCTAKLQlbNzRdCTAKLQlbNzVdCTAKLQkuLi5hbmQgMjQgbW9y ZSBlcnJvcnMuIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQotRkFJTCA8IFtz dWJzYW1wbGUgc3RhcnQgd2l0aCBwbGF5YmFjayByYXRlIDBdIDIgb3V0IG9mIDIgYXNzZXJ0aW9u cyB3ZXJlIGZhaWxlZC4gYXNzZXJ0X3RydWU6IGV4cGVjdGVkIHRydWUgZ290IGZhbHNlCi1GQUlM ICMgQVVESVQgVEFTSyBSVU5ORVIgRklOSVNIRUQ6IDEgb3V0IG9mIDIgdGFza3Mgd2VyZSBmYWls ZWQuIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQorUEFTUyAgIG91dHB1dFsw OjI3XSBjb250YWlucyBvbmx5IHRoZSBjb25zdGFudCAwLiAKK1BBU1MgICBvdXRwdXRbMjg6XSBj b250YWlucyBvbmx5IHRoZSBjb25zdGFudCA1LiAKK1BBU1MgPCBbc3Vic2FtcGxlIHN0YXJ0IHdp dGggcGxheWJhY2sgcmF0ZSAwXSBBbGwgYXNzZXJ0aW9ucyBwYXNzZWQuICh0b3RhbCAyIGFzc2Vy dGlvbnMpIAorUEFTUyAjIEFVRElUIFRBU0sgUlVOTkVSIEZJTklTSEVEOiAyIHRhc2tzIHJhbiBz dWNjZXNzZnVsbHkuIAogCg==