216602 2020-09-16 00:11:38 -0700 Build fails with -DENABLE_ACCELERATED_2D_CANVAS=ON 2020-10-13 12:23:03 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 217384 https://bugs.webkit.org/show_bug.cgi?id=216193 InRadar P2 Normal --- 1 psaavedra psaavedra aperez ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1689026 0 psaavedra 2020-09-16 00:11:38 -0700 Original report: https://github.com/Igalia/meta-webkit/pull/197 Logs: https://github.com/Igalia/meta-webkit/files/5220720/20200914201256.log 1689028 1 408901 psaavedra 2020-09-16 00:14:33 -0700 Created attachment 408901 patch 1689031 2 psaavedra 2020-09-16 00:19:50 -0700 The https://bugs.webkit.org/attachment.cgi?id=408901 patch solve most of the compilation errors but still there is a problem in linking time: ``` lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/IntlNumberFormatPrototype.cpp.o):IntlNumberFormatPrototype.cpp:function JSC::IntlNumberFormatPrototypeFuncResolvedOptions(JSC::JSGlobalObject*, JSC::CallFrame*): error: undefined reference to 'JSC::IntlNumberFormat::unwrapForOldFunctions(JSC::JSGlobalObject*, JSC::JSValue)' lib/libJavaScriptCore.a(lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/IntlNumberFormatPrototype.cpp.o):IntlNumberFormatPrototype.cpp:function JSC::IntlNumberFormatPrototypeGetterFormat(JSC::JSGlobalObject*, JSC::CallFrame*): error: undefined reference to 'JSC::IntlNumberFormat::unwrapForOldFunctions(JSC::JSGlobalObject*, JSC::JSValue)' collect2: error: ld returned 1 exit status ``` That part of the code was recently modified by this commit ``` commit ddc87c0a4c05321205286709f1e073518add1f2f Author: ysuzuki@apple.com <ysuzuki@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Sat Sep 5 04:53:16 2020 +0000 [JSC] Align legacy Intl constructor behavior to spec https://bugs.webkit.org/show_bug.cgi?id=216193 Reviewed by Darin Adler. ``` 1691043 3 webkit-bug-importer 2020-09-23 00:12:13 -0700 <rdar://problem/69418679> 1697246 4 mcatanzaro 2020-10-13 07:31:14 -0700 I've just closed all the other ENABLE_ACCELERATED_2D_CANVAS build failures I could find (obsoleted by bug #217603). I'll leave this one in case you want to fix it on 2.30, but probably better to just stop enabling that option. 1697336 5 aperez 2020-10-13 12:23:03 -0700 We fixed this in bug #217384 — unfortunately that went under my radar. Pablo, next time please poke us a bit to not let patches get outdated in Bugzilla; I am sorry for neglecting this one 😓️ Side note: the linker errors about the JSC symbols are unrelated, and most likely caused by problems masked by unified builds, because they look similar to the usual stuff we fix when making patches to keep non-unified builds working. *** This bug has been marked as a duplicate of bug 217384 *** 408901 2020-09-16 00:14:33 -0700 2020-09-16 00:14:33 -0700 patch bug-216602-20200916091237.patch text/plain 3950 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 MWZkMmQxNGQ2ZGJkNjJmN2I0M2RhMjMzZTVjZGExMmVlZGYzM2NhLi41OTBjOWQ2Mzk0ZWQwMDk0 MDljNTIxOGU5Y2YyNjMyMjAzYTA0ZGIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMC0wOS0xNiAgUGFibG8gU2FhdmVkcmEgIDxwc2FhdmVkcmFAaWdhbGlh LmNvbT4KKworICAgICAgICBCdWlsZCBmYWlscyB3aXRoIC1ERU5BQkxFX0FDQ0VMRVJBVEVEXzJE X0NBTlZBUz1PTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE2NjAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBydW50aW1lL0ludGxDYWNoZS5jcHA6CisgICAgICAgICogcnVudGltZS9JbnRsQ2FjaGUu aDoKKwogMjAyMC0wOS0xNSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAg ICAgICBKU0ltbXV0YWJsZUJ1dHRlcmZseTo6Z2V0IG5lZWRzIHRvIHJldHVybiBqc0RvdWJsZU51 bWJlciBmb3IgZG91YmxlIGFycmF5cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQ0YTBkZDA1NTIzZTYyYWMxY2Rl OTZhOWFiMjZjOGQzMzM0MDE2ZTcuLjFmN2VhZGNhZjcwYTgyZmQ1MTRjODc0NTgwYThmNjUyMzE3 MGE0ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wOS0xNiAgUGFibG8gU2Fh dmVkcmEgIDxwc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBCdWlsZCBmYWlscyB3aXRo IC1ERU5BQkxFX0FDQ0VMRVJBVEVEXzJEX0NBTlZBUz1PTgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2NjAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Db25jcmV0ZUlt YWdlQnVmZmVyLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZm ZXJDYWlyb0dMU3VyZmFjZUJhY2tlbmQuaDoKKwogMjAyMC0wOS0xNSAgU2FpZCBBYm91LUhhbGxh d2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2NjY3 Nyk6IEFTU0VSVElPTiBGQUlMRUQgaW4gUGFpbnRGcmVxdWVuY3lUcmFja2VyOjplbmQoKQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bENhY2hlLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxDYWNoZS5jcHAKaW5kZXggMmE3OTE1YWM1 MTA1NjI2Y2NkMmQ0ODg0MTlkNzMyMjUwNjIwYzBhZC4uNTA0ODAxMTM0ZjM4NjQyNjRmNjU3OTY3 ZjEzNDg2MmNhNThhYmQ4OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSW50bENhY2hlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRs Q2FjaGUuY3BwCkBAIC0yNSw2ICsyNSw3IEBACiAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs dWRlICJJbnRsQ2FjaGUuaCIKKyNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKIG5hbWVzcGFjZSBK U0MgewogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsQ2Fj aGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxDYWNoZS5oCmluZGV4IGI5 NjcyZmY1MWE0ZTI5OTUzOTUwOGFmYWFjZDA3ZDJmOTNjY2RhZjkuLjQyZDVlMTE0YjQ0NTZjOTY0 N2ZkY2VhNTc2OGZlOWUzNDY1MTkxMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0ludGxDYWNoZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0ludGxDYWNoZS5oCkBAIC0yNyw2ICsyNyw3IEBACiAKICNpbmNsdWRlIDx1bmljb2RlL3VkYXRw Zy5oPgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgorI2luY2x1ZGUgPHd0Zi90ZXh0L0NT dHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdW5pY29kZS9pY3UvSUNVSGVscGVycy5oPgogCiBuYW1l c3BhY2UgSlNDIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0NvbmNyZXRlSW1hZ2VCdWZmZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0NvbmNyZXRlSW1hZ2VCdWZmZXIuaAppbmRleCAzYmE4YzEyYmVjMDBmNDdkNTMzNjI4ZGQwNWE4 ZDBmMjM0NGE1OTA5Li5kNDQ2MzE5ZDcwNzBiYjg0NThkYTRjYWNiOGMyYjVkNjhiMDc0MWUxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db25jcmV0ZUltYWdl QnVmZmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29uY3JldGVJ bWFnZUJ1ZmZlci5oCkBAIC0yNTQsNyArMjU0LDExIEBAIHByb3RlY3RlZDoKICAgICBib29sIGNv cHlUb1BsYXRmb3JtVGV4dHVyZShHcmFwaGljc0NvbnRleHRHTE9wZW5HTCYgY29udGV4dCwgR0NH TGVudW0gdGFyZ2V0LCBQbGF0Zm9ybUdMT2JqZWN0IGRlc3RpbmF0aW9uVGV4dHVyZSwgR0NHTGVu dW0gaW50ZXJuYWxmb3JtYXQsIGJvb2wgcHJlbXVsdGlwbHlBbHBoYSwgYm9vbCBmbGlwWSkgY29u c3Qgb3ZlcnJpZGUKICAgICB7CiAgICAgICAgIGlmIChhdXRvKiBiYWNrZW5kID0gZW5zdXJlQmFj a2VuZENyZWF0ZWQoKSkKKyNpZiBVU0UoQ0FJUk8pICYmIEVOQUJMRShBQ0NFTEVSQVRFRF8yRF9D QU5WQVMpCisgICAgICAgICAgICByZXR1cm4gYmFja2VuZC0+Y29weVRvUGxhdGZvcm1UZXh0dXJl KHRhcmdldCwgZGVzdGluYXRpb25UZXh0dXJlLCBpbnRlcm5hbGZvcm1hdCwgcHJlbXVsdGlwbHlB bHBoYSwgZmxpcFkpOworI2Vsc2UKICAgICAgICAgICAgIHJldHVybiBiYWNrZW5kLT5jb3B5VG9Q bGF0Zm9ybVRleHR1cmUoY29udGV4dCwgdGFyZ2V0LCBkZXN0aW5hdGlvblRleHR1cmUsIGludGVy bmFsZm9ybWF0LCBwcmVtdWx0aXBseUFscGhhLCBmbGlwWSk7CisjZW5kaWYKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyb0dMU3VyZmFjZUJhY2tlbmQuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm9HTFN1cmZh Y2VCYWNrZW5kLmgKaW5kZXggY2RmMGZhZTdlMmMzNDllMjE2NDE5ODQ1NWQ0MThjM2NhYjY3NDdi NC4uZGU4NWU2MDc1MDdhZDhlMTBhNWE3NDhkOTI3NDU5NmM2ODJhZTZjZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyb0dM U3VyZmFjZUJhY2tlbmQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9JbWFnZUJ1ZmZlckNhaXJvR0xTdXJmYWNlQmFja2VuZC5oCkBAIC03OSw3ICs3OSw2IEBA IHByaXZhdGU6CiAjZWxzZQogICAgIFJlZlB0cjxUZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllclBy b3h5PiBtX3BsYXRmb3JtTGF5ZXJQcm94eTsKICNlbmRpZgotICAgIHVpbnQzMl90IG1fdGV4dHVy ZTsKICAgICBSZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PiBtX2NvbXBvc2l0b3JTdXJmYWNlOwogICAg IFJlZlB0cjxjYWlyb190PiBtX2NvbXBvc2l0b3JDcjsKICAgICB1aW50MzJfdCBtX2NvbXBvc2l0 b3JUZXh0dXJlIHsgMCB9Owo=