216583 2020-09-15 14:07:37 -0700 ScriptProcessorNode should throw when trying to change its channel count or channel count mode 2020-09-15 15:39:17 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 216579 212611 216584 1 cdumez cdumez darin eric.carlson ggaren jer.noble webkit-bug-importer youennf oldest_to_newest 1688842 0 cdumez 2020-09-15 14:07:37 -0700 ScriptProcessorNode should throw when trying to change its channel count or channel count mode: - https://www.w3.org/TR/webaudio/#audionode-channelcount-constraints - https://www.w3.org/TR/webaudio/#audionode-channelcountmode-constraints 1688844 1 408861 cdumez 2020-09-15 14:09:16 -0700 Created attachment 408861 Patch 1688880 2 408861 ggaren 2020-09-15 15:36:38 -0700 Comment on attachment 408861 Patch r=me 1688882 3 408861 cdumez 2020-09-15 15:38:02 -0700 Comment on attachment 408861 Patch Clearing flags on attachment: 408861 Committed r267107: <https://trac.webkit.org/changeset/267107> 1688883 4 cdumez 2020-09-15 15:38:04 -0700 All reviewed patches have been landed. Closing bug. 1688884 5 webkit-bug-importer 2020-09-15 15:39:17 -0700 <rdar://problem/68945910> 408861 2020-09-15 14:09:16 -0700 2020-09-15 15:38:02 -0700 Patch bug-216583-20200915140915.patch text/plain 6792 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3MDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWFjNzkwOTE1MWQ1ODdj NWJkMGE5ZTIxOWNmNzFjN2VhYjBmOWVmNS4uOGI5MWM1MDYxOWFhNzdjZWIxMzhkNzM3NjYxMjQy ZjZiNWY5M2FiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA5LTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2NyaXB0UHJvY2Vzc29yTm9k ZSBzaG91bGQgdGhyb3cgd2hlbiB0cnlpbmcgdG8gY2hhbmdlIGl0cyBjaGFubmVsIGNvdW50IG9y IGNoYW5uZWwgY291bnQgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE2NTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU2NyaXB0UHJvY2Vzc29yTm9kZSBzaG91bGQgdGhyb3cgd2hlbiB0cnlpbmcg dG8gY2hhbmdlIGl0cyBjaGFubmVsIGNvdW50IG9yIGNoYW5uZWwgY291bnQgbW9kZToKKyAgICAg ICAgLSBodHRwczovL3d3dy53My5vcmcvVFIvd2ViYXVkaW8vI2F1ZGlvbm9kZS1jaGFubmVsY291 bnQtY29uc3RyYWludHMKKyAgICAgICAgLSBodHRwczovL3d3dy53My5vcmcvVFIvd2ViYXVkaW8v I2F1ZGlvbm9kZS1jaGFubmVsY291bnRtb2RlLWNvbnN0cmFpbnRzCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCByZWJhc2VsaW5lZCBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogTW9kdWxlcy93 ZWJhdWRpby9TY3JpcHRQcm9jZXNzb3JOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlw dFByb2Nlc3Nvck5vZGU6OnNldENoYW5uZWxDb3VudCk6CisgICAgICAgIChXZWJDb3JlOjpTY3Jp cHRQcm9jZXNzb3JOb2RlOjpzZXRDaGFubmVsQ291bnRNb2RlKToKKyAgICAgICAgKiBNb2R1bGVz L3dlYmF1ZGlvL1NjcmlwdFByb2Nlc3Nvck5vZGUuaDoKKwogMjAyMC0wOS0xNSAgU2FtIFdlaW5p ZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHJ1bnRpbWUgc2V0dGluZyBm b3IgZW5hYmxpbmcvZGlzYWJsaW5nIGN1c3RvbSBlbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9TY3JpcHRQcm9jZXNzb3JOb2RlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vU2NyaXB0UHJvY2Vzc29yTm9kZS5jcHAKaW5kZXgg MTY3NGFhYzc0YjE1NjU4NWE1OTQ0MTgyZTEzMjJjZDJlYWJlMWQ4NC4uMGZhOWRmYjg3OTcwZTZl ZDczNDllMmZhOWU0ZDJhMTdkZTY3M2FmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJhdWRpby9TY3JpcHRQcm9jZXNzb3JOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYmF1ZGlvL1NjcmlwdFByb2Nlc3Nvck5vZGUuY3BwCkBAIC0yNTAsNiArMjUw LDI1IEBAIHZvaWQgU2NyaXB0UHJvY2Vzc29yTm9kZTo6cmVzZXQoKQogICAgIH0KIH0KIAorRXhj ZXB0aW9uT3I8dm9pZD4gU2NyaXB0UHJvY2Vzc29yTm9kZTo6c2V0Q2hhbm5lbENvdW50KHVuc2ln bmVkIGNoYW5uZWxDb3VudCkKK3sKKyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworCisgICAg aWYgKGNoYW5uZWxDb3VudCAhPSB0aGlzLT5jaGFubmVsQ291bnQoKSkKKyAgICAgICAgcmV0dXJu IEV4Y2VwdGlvbiB7IE5vdFN1cHBvcnRlZEVycm9yLCAiU2NyaXB0UHJvY2Vzc29yTm9kZSdzIGNo YW5uZWxDb3VudCBjYW5ub3QgYmUgY2hhbmdlZCJfcyB9OworICAgIHJldHVybiB7IH07Cit9CisK K0V4Y2VwdGlvbk9yPHZvaWQ+IFNjcmlwdFByb2Nlc3Nvck5vZGU6OnNldENoYW5uZWxDb3VudE1v ZGUoQ2hhbm5lbENvdW50TW9kZSBtb2RlKQoreworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7 CisKKyAgICBpZiAobW9kZSAhPSB0aGlzLT5jaGFubmVsQ291bnRNb2RlKCkpCisgICAgICAgIHJl dHVybiBFeGNlcHRpb24geyBOb3RTdXBwb3J0ZWRFcnJvciwgIlNjcmlwdFByb2Nlc3Nvck5vZGUn cyBjaGFubmVsQ291bnRNb2RlIGNhbm5vdCBiZSBjaGFuZ2VkIGZyb20gJ2V4cGxpY2l0JyJfcyB9 OworCisgICAgcmV0dXJuIHsgfTsKK30KKwogZG91YmxlIFNjcmlwdFByb2Nlc3Nvck5vZGU6OnRh aWxUaW1lKCkgY29uc3QKIHsKICAgICByZXR1cm4gc3RkOjpudW1lcmljX2xpbWl0czxkb3VibGU+ OjppbmZpbml0eSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRp by9TY3JpcHRQcm9jZXNzb3JOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L1NjcmlwdFByb2Nlc3Nvck5vZGUuaAppbmRleCA1NWZiYWJjYWNiNjUzZTVlMWU5NTJjMGM3ZGM4 NjI2NmM0MTUwNzdiLi5hMWExMGZiZDlmMzA1N2EzNmU5MWQ4YjU3MjNmMTM3NjhmZjg5YTUxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1NjcmlwdFByb2Nlc3Nv ck5vZGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1NjcmlwdFByb2Nl c3Nvck5vZGUuaApAQCAtNjcsNiArNjcsOSBAQCBwdWJsaWM6CiAKICAgICBzaXplX3QgYnVmZmVy U2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fYnVmZmVyU2l6ZTsgfQogCisgICAgRXhjZXB0aW9uT3I8 dm9pZD4gc2V0Q2hhbm5lbENvdW50KHVuc2lnbmVkKSBmaW5hbDsKKyAgICBFeGNlcHRpb25Pcjx2 b2lkPiBzZXRDaGFubmVsQ291bnRNb2RlKENoYW5uZWxDb3VudE1vZGUpIGZpbmFsOworCiBwcml2 YXRlOgogICAgIGRvdWJsZSB0YWlsVGltZSgpIGNvbnN0IG92ZXJyaWRlOwogICAgIGRvdWJsZSBs YXRlbmN5VGltZSgpIGNvbnN0IG92ZXJyaWRlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg5MWNkMTkxN2Q0ZDAxMTM3MTUw MGZmM2EyNjQ1OWRlYTVhYmJlYzAuLmQyMTZjOWJjYjM2YTc0OTA1Y2E1YzczMDBmMzdiODYzM2Ez YTg1OGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOS0xNSAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFNjcmlwdFByb2Nlc3Nvck5vZGUgc2hvdWxkIHRo cm93IHdoZW4gdHJ5aW5nIHRvIGNoYW5nZSBpdHMgY2hhbm5lbCBjb3VudCBvciBjaGFubmVsIGNv dW50IG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxNjU4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlYmFzZWxpbmUgdGVzdCBub3cgdGhhdCBtb3JlIGNoZWNrcyBhcmUgcGFzc2luZy4KKworICAg ICAgICAqIHdlYmF1ZGlvL2RvbS1leGNlcHRpb25zLWV4cGVjdGVkLnR4dDoKKwogMjAyMC0wOS0x NSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEltcG9ydCB3ZWJh dWRpby9kb20tZXhjZXB0aW9ucy5odG1sIGxheW91dCB0ZXN0IGZyb20gQmxpbmsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2RvbS1leGNlcHRpb25zLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL3dlYmF1ZGlvL2RvbS1leGNlcHRpb25zLWV4cGVjdGVkLnR4dAppbmRleCBkNGQ3 ZTgzZDc0NjhiMjM2MzIxNDliN2RkMWQ4YjI3NGNhOWQ3NTAwLi5kNjY1YzNmMTRmNTg4ZmEyNzFh N2E4NjhkMjI3ZmY0MGUxYTJmMzNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9k b20tZXhjZXB0aW9ucy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vZG9t LWV4Y2VwdGlvbnMtZXhwZWN0ZWQudHh0CkBAIC0yNDEsMjIgKzI0MSwyMiBAQCBQQVNTICAgc2Ny aXB0ID0gY29udGV4dC5jcmVhdGVTY3JpcHRQcm9jZXNzb3IoMjU2LCAzKSBkaWQgbm90IHRocm93 IGFuIGV4Y2VwdGlvbgogUEFTUyAgIHNjcmlwdC5jaGFubmVsQ291bnQgaXMgZXF1YWwgdG8gMy4g CiBQQVNTICAgc2NyaXB0LmNoYW5uZWxDb3VudE1vZGUgaXMgZXF1YWwgdG8gZXhwbGljaXQuIAog UEFTUyAgIHNjcmlwdC5jaGFubmVsQ291bnQgPSAzIGRpZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9u LiAKLUZBSUwgWCBTY3JpcHRQcm9jZXNzb3JOb2RlLmNoYW5uZWxDb3VudCA9IDEgZGlkIG5vdCB0 aHJvdyBhbiBleGNlcHRpb24uIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQot RkFJTCBYIFNjcmlwdFByb2Nlc3Nvck5vZGUuY2hhbm5lbENvdW50IHNob3VsZCBub3QgYmUgZXF1 YWwgdG8gMS4gR290IDEuIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQotRkFJ TCBYIFNjcmlwdFByb2Nlc3Nvck5vZGUuY2hhbm5lbENvdW50ID0gNyBkaWQgbm90IHRocm93IGFu IGV4Y2VwdGlvbi4gYXNzZXJ0X3RydWU6IGV4cGVjdGVkIHRydWUgZ290IGZhbHNlCi1GQUlMIFgg U2NyaXB0UHJvY2Vzc29yTm9kZS5jaGFubmVsQ291bnQgc2hvdWxkIG5vdCBiZSBlcXVhbCB0byA3 LiBHb3QgNy4gYXNzZXJ0X3RydWU6IGV4cGVjdGVkIHRydWUgZ290IGZhbHNlCitQQVNTICAgU2Ny aXB0UHJvY2Vzc29yTm9kZS5jaGFubmVsQ291bnQgPSAxIHRocmV3IE5vdFN1cHBvcnRlZEVycm9y OiAiU2NyaXB0UHJvY2Vzc29yTm9kZSdzIGNoYW5uZWxDb3VudCBjYW5ub3QgYmUgY2hhbmdlZCIu IAorUEFTUyAgIFNjcmlwdFByb2Nlc3Nvck5vZGUuY2hhbm5lbENvdW50IGlzIG5vdCBlcXVhbCB0 byAxLiAKK1BBU1MgICBTY3JpcHRQcm9jZXNzb3JOb2RlLmNoYW5uZWxDb3VudCA9IDcgdGhyZXcg Tm90U3VwcG9ydGVkRXJyb3I6ICJTY3JpcHRQcm9jZXNzb3JOb2RlJ3MgY2hhbm5lbENvdW50IGNh bm5vdCBiZSBjaGFuZ2VkIi4gCitQQVNTICAgU2NyaXB0UHJvY2Vzc29yTm9kZS5jaGFubmVsQ291 bnQgaXMgbm90IGVxdWFsIHRvIDcuIAogUEFTUyAgIHNjcmlwdC5jaGFubmVsQ291bnRNb2RlID0g ImV4cGxpY2l0IiBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbi4gCi1GQUlMIFggU2NyaXB0UHJv Y2Vzc29yTm9kZS5jaGFubmVsQ291bnRNb2RlID0gbWF4IGRpZCBub3QgdGhyb3cgYW4gZXhjZXB0 aW9uLiBhc3NlcnRfdHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKLUZBSUwgWCBTY3JpcHRQ cm9jZXNzb3JOb2RlLmNoYW5uZWxDb3VudE1vZGUgc2hvdWxkIG5vdCBiZSBlcXVhbCB0byBtYXgu IEdvdCBtYXguIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQotRkFJTCBYIFNj cmlwdFByb2Nlc3Nvck5vZGUuY2hhbm5lbENvdW50TW9kZSA9IGNsYW1wZWQtbWF4IGRpZCBub3Qg dGhyb3cgYW4gZXhjZXB0aW9uLiBhc3NlcnRfdHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UK LUZBSUwgWCBTY3JpcHRQcm9jZXNzb3JOb2RlLmNoYW5uZWxDb3VudE1vZGUgc2hvdWxkIG5vdCBi ZSBlcXVhbCB0byBjbGFtcGVkLW1heC4gR290IGNsYW1wZWQtbWF4LiBhc3NlcnRfdHJ1ZTogZXhw ZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKK1BBU1MgICBTY3JpcHRQcm9jZXNzb3JOb2RlLmNoYW5uZWxD b3VudE1vZGUgPSBtYXggdGhyZXcgTm90U3VwcG9ydGVkRXJyb3I6ICJTY3JpcHRQcm9jZXNzb3JO b2RlJ3MgY2hhbm5lbENvdW50TW9kZSBjYW5ub3QgYmUgY2hhbmdlZCBmcm9tICdleHBsaWNpdCci LiAKK1BBU1MgICBTY3JpcHRQcm9jZXNzb3JOb2RlLmNoYW5uZWxDb3VudE1vZGUgaXMgbm90IGVx dWFsIHRvIG1heC4gCitQQVNTICAgU2NyaXB0UHJvY2Vzc29yTm9kZS5jaGFubmVsQ291bnRNb2Rl ID0gY2xhbXBlZC1tYXggdGhyZXcgTm90U3VwcG9ydGVkRXJyb3I6ICJTY3JpcHRQcm9jZXNzb3JO b2RlJ3MgY2hhbm5lbENvdW50TW9kZSBjYW5ub3QgYmUgY2hhbmdlZCBmcm9tICdleHBsaWNpdCci LiAKK1BBU1MgICBTY3JpcHRQcm9jZXNzb3JOb2RlLmNoYW5uZWxDb3VudE1vZGUgaXMgbm90IGVx dWFsIHRvIGNsYW1wZWQtbWF4LiAKIFBBU1MgICBzY3JpcHQuY2hhbm5lbENvdW50TW9kZSA9ICJq dW5rIiBkaWQgbm90IHRocm93IGFuIGV4Y2VwdGlvbi4gCi1GQUlMIDwgW3NjcmlwdC1wcm9jZXNz b3JdIDggb3V0IG9mIDE0IGFzc2VydGlvbnMgd2VyZSBmYWlsZWQuIGFzc2VydF90cnVlOiBleHBl Y3RlZCB0cnVlIGdvdCBmYWxzZQorUEFTUyA8IFtzY3JpcHQtcHJvY2Vzc29yXSBBbGwgYXNzZXJ0 aW9ucyBwYXNzZWQuICh0b3RhbCAxNCBhc3NlcnRpb25zKSAKIFBBU1MgPiBbbWlzY10gTWlzY2Vs bGFuZW91cyB0ZXN0cyAKIFBBU1MgICBvc2Mubm90ZU9uIGlzIGVxdWFsIHRvIHVuZGVmaW5lZC4g CiBQQVNTICAgb3NjLm5vdGVPZmYgaXMgZXF1YWwgdG8gdW5kZWZpbmVkLiAKIFBBU1MgICBzb3Vy Y2Uubm90ZU9uIGlzIGVxdWFsIHRvIHVuZGVmaW5lZC4gCiBQQVNTICAgc291cmNlLm5vdGVPZmYg aXMgZXF1YWwgdG8gdW5kZWZpbmVkLiAKIFBBU1MgPCBbbWlzY10gQWxsIGFzc2VydGlvbnMgcGFz c2VkLiAodG90YWwgNCBhc3NlcnRpb25zKSAKLUZBSUwgIyBBVURJVCBUQVNLIFJVTk5FUiBGSU5J U0hFRDogMyBvdXQgb2YgMjQgdGFza3Mgd2VyZSBmYWlsZWQuIGFzc2VydF90cnVlOiBleHBlY3Rl ZCB0cnVlIGdvdCBmYWxzZQorRkFJTCAjIEFVRElUIFRBU0sgUlVOTkVSIEZJTklTSEVEOiAyIG91 dCBvZiAyNCB0YXNrcyB3ZXJlIGZhaWxlZC4gYXNzZXJ0X3RydWU6IGV4cGVjdGVkIHRydWUgZ290 IGZhbHNlCiAK