<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>216290</bug_id>
          
          <creation_ts>2020-09-08 15:52:33 -0700</creation_ts>
          <short_desc>Drop non-standard name / units attributes from AudioParam</short_desc>
          <delta_ts>2020-09-08 17:24:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Audio</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>212611</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>darin</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>philipj</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1686783</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-09-08 15:52:33 -0700</bug_when>
    <thetext>Drop non-standard name / units attributes from AudioParam:
- https://www.w3.org/TR/webaudio/#AudioParam

Blink does not have them either.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1686789</commentid>
    <comment_count>1</comment_count>
      <attachid>408280</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-09-08 16:07:08 -0700</bug_when>
    <thetext>Created attachment 408280
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1686798</commentid>
    <comment_count>2</comment_count>
      <attachid>408280</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2020-09-08 16:20:53 -0700</bug_when>
    <thetext>Comment on attachment 408280
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1686833</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-09-08 17:23:47 -0700</bug_when>
    <thetext>Committed r266763: &lt;https://trac.webkit.org/changeset/266763&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408280.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1686834</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-09-08 17:24:20 -0700</bug_when>
    <thetext>&lt;rdar://problem/68539840&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>408280</attachid>
            <date>2020-09-08 16:07:08 -0700</date>
            <delta_ts>2020-09-08 17:23:47 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-216290-20200908160708.patch</filename>
            <type>text/plain</type>
            <size>4324</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGE5NDNhYzVkZTQ0ZWEx
MzRiNDM5ZTc3MGI3MTUwMmM5MzBhNDc5Zi4uZTQwOTY4OWU1ODY0YjE4MDE4NTE2YzdjYmU0OGUy
MTE2MWM4YjEwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA5LTA4ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBub24tc3RhbmRhcmQg
bmFtZSAvIHVuaXRzIGF0dHJpYnV0ZXMgZnJvbSBBdWRpb1BhcmFtCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYyOTAKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcm9wIG5vbi1zdGFuZGFyZCBuYW1lIC8g
dW5pdHMgYXR0cmlidXRlcyBmcm9tIEF1ZGlvUGFyYW06CisgICAgICAgIC0gaHR0cHM6Ly93d3cu
dzMub3JnL1RSL3dlYmF1ZGlvLyNBdWRpb1BhcmFtCisKKyAgICAgICAgQmxpbmsgZG9lcyBub3Qg
aGF2ZSB0aGVtIGVpdGhlci4KKworICAgICAgICBUZXN0OiB3ZWJhdWRpby9hdWRpb3BhcmFtLW9i
c29sZXRlLWFwaS5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvUGFyYW0u
aDoKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvUGFyYW0uaWRsOgorCiAyMDIwLTA5
LTA4ICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViSURMXSBB
ZGQgc3VwcG9ydCBmb3IgcGFydGlhbCBpbnRlcmZhY2UgbWl4aW5zCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvUGFyYW0uaCBiL1NvdXJjZS9XZWJDb3Jl
L01vZHVsZXMvd2ViYXVkaW8vQXVkaW9QYXJhbS5oCmluZGV4IDBmZDdlNjUxMDVmOGFlMGQ1YzVl
YzRmMWExODUwNjU0MWI0NTMwZWQuLmQ5MTI3MzE5OWI2NDMwMzU3NjAwMTE2Y2E1ZjdiZTgxNTYw
ZDE1YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Q
YXJhbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9QYXJhbS5o
CkBAIC04NSw5ICs4NSw2IEBAIHB1YmxpYzoKICAgICBmbG9hdCBtYXhWYWx1ZSgpIGNvbnN0IHsg
cmV0dXJuIG1fbWF4VmFsdWU7IH0KICAgICBmbG9hdCBkZWZhdWx0VmFsdWUoKSBjb25zdCB7IHJl
dHVybiBtX2RlZmF1bHRWYWx1ZTsgfQogCi0gICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG9uY2Ug
aXQgaXMgbm8gbG9uZ2VyIGV4cG9zZWQgdG8gdGhlIFdlYi4KLSAgICBzdGF0aWMgdW5zaWduZWQg
dW5pdHMoKSB7IHJldHVybiAwOyB9Ci0KICAgICAvLyBWYWx1ZSBzbW9vdGhpbmc6CiAKICAgICAv
LyBXaGVuIGEgbmV3IHZhbHVlIGlzIHNldCB3aXRoIHNldFZhbHVlKCksIGluIG91ciBpbnRlcm5h
bCB1c2Ugb2YgdGhlIHBhcmFtZXRlciB3ZSBkb24ndCBpbW1lZGlhdGVseSBqdW1wIHRvIGl0Lgpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1BhcmFtLmlk
bCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9QYXJhbS5pZGwKaW5kZXgg
YjJjYWFkYzcyNjBlOWUyYTQxZWRkOTllMmE4NzQ5ZmEyMmM2YWI0Ni4uMWJkZDdhYWY4Y2NlODIy
ZDc5ZjEzM2UwZjUyNTZjNWUxZDE5YmQwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k
dWxlcy93ZWJhdWRpby9BdWRpb1BhcmFtLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz
L3dlYmF1ZGlvL0F1ZGlvUGFyYW0uaWRsCkBAIC02MCw4ICs2MCw0IEBACiAgICAgLy8gQ2FuY2Vs
cyBhbGwgc2NoZWR1bGVkIHBhcmFtZXRlciBjaGFuZ2VzIHdpdGggdGltZXMgZ3JlYXRlciB0aGFu
IG9yIGVxdWFsIHRvIHN0YXJ0VGltZS4KICAgICBbTWF5VGhyb3dFeGNlcHRpb25dIEF1ZGlvUGFy
YW0gY2FuY2VsU2NoZWR1bGVkVmFsdWVzKGRvdWJsZSBjYW5jZWxUaW1lKTsKICAgICBbTWF5VGhy
b3dFeGNlcHRpb25dIEF1ZGlvUGFyYW0gY2FuY2VsQW5kSG9sZEF0VGltZShkb3VibGUgY2FuY2Vs
VGltZSk7Ci0KLSAgICAvLyBGSVhNRTogVGhlc2UgYXJlIG5vdCBzdGFuZGFyZC4KLSAgICBbRW5h
YmxlZEJ5U2V0dGluZz1QcmVmaXhlZFdlYkF1ZGlvXSByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3Ry
aW5nIG5hbWU7Ci0gICAgW0VuYWJsZWRCeVNldHRpbmc9UHJlZml4ZWRXZWJBdWRpb10gcmVhZG9u
bHkgYXR0cmlidXRlIHVuc2lnbmVkIHNob3J0IHVuaXRzOwogfTsKZGlmZiAtLWdpdCBhL0xheW91
dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyM2U3YjFiYzg0
ZDY1OTZiMGFjMmU0YjYxYjE2YzI1NzliOTBhZGI0Li40YmFhOTRjY2FmNGYzYTNkMDJiZmMxZWU5
Zjg3NWEzZjlkMDVhMmVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv
TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDktMDggIENocmlz
IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBEcm9wIG5vbi1zdGFuZGFyZCBu
YW1lIC8gdW5pdHMgYXR0cmlidXRlcyBmcm9tIEF1ZGlvUGFyYW0KKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjI5MAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsYXlvdXQgdGVzdCBjb3ZlcmFnZS4K
KworICAgICAgICAqIHdlYmF1ZGlvL2F1ZGlvcGFyYW0tb2Jzb2xldGUtYXBpLWV4cGVjdGVkLnR4
dDogQWRkZWQuCisgICAgICAgICogd2ViYXVkaW8vYXVkaW9wYXJhbS1vYnNvbGV0ZS1hcGkuaHRt
bDogQWRkZWQuCisKIDIwMjAtMDktMDggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A
d2Via2l0Lm9yZz4KIAogICAgICAgICBuZXcgVVJMKCIjIikgc2hvdWxkIHRocm93IGFuIGVycm9y
CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb3BhcmFtLW9ic29sZXRlLWFw
aS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb3BhcmFtLW9ic29sZXRl
LWFwaS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTBiMGUxNTE1NmEyYTI1OGIyOGJlNjA4Yjdl
YjJhYzU1NDQ1NGU3ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1
ZGlvcGFyYW0tb2Jzb2xldGUtYXBpLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitDaGVj
a3MgdGhhdCBvYnNvbGV0ZSBBUEkgaXMgbm8gbG9uZ2VyIHByZXNlbnQgb24gQXVkaW9QYXJhbS4K
KworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg
Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgQXVkaW9QYXJhbS5wcm90b3R5
cGUubmFtZSBpcyB1bmRlZmluZWQuCitQQVNTIEF1ZGlvUGFyYW0ucHJvdG90eXBlLnVuaXRzIGlz
IHVuZGVmaW5lZC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q
TEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb3BhcmFtLW9ic29s
ZXRlLWFwaS5odG1sIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVkaW9wYXJhbS1vYnNvbGV0ZS1h
cGkuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwLi4yMjc3NWM5ZjcyYWRiNTllNzBkZGNmZWM3MjY1MWVhZWY4YjVh
MjdjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVkaW9wYXJhbS1v
YnNvbGV0ZS1hcGkuaHRtbApAQCAtMCwwICsxLDEyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s
PgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0
PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJDaGVja3MgdGhhdCBvYnNvbGV0ZSBBUEkgaXMgbm8g
bG9uZ2VyIHByZXNlbnQgb24gQXVkaW9QYXJhbS4iKTsKKworc2hvdWxkQmVVbmRlZmluZWQoIkF1
ZGlvUGFyYW0ucHJvdG90eXBlLm5hbWUiKTsKK3Nob3VsZEJlVW5kZWZpbmVkKCJBdWRpb1BhcmFt
LnByb3RvdHlwZS51bml0cyIpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>