216091 2020-09-02 12:53:50 -0700 Fix rounding for DelayDSPKernel's buffer size calculation 2020-09-02 15:08:16 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212611 1 cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1684931 0 cdumez 2020-09-02 12:53:50 -0700 Fix rounding for DelayDSPKernel's buffer size calculation. The DelayNode needs to buffer |maxDelayTime| sample frames, plus one frame for interpolation. If |maxDelayTime| isn't an integer, we have to round it up or the buffer would end up one frame short. 1684933 1 407789 cdumez 2020-09-02 12:55:08 -0700 Created attachment 407789 Patch 1684935 2 407789 ggaren 2020-09-02 12:58:57 -0700 Comment on attachment 407789 Patch r=me 1685015 3 407789 cdumez 2020-09-02 15:07:30 -0700 Comment on attachment 407789 Patch Clearing flags on attachment: 407789 Committed r266491: <https://trac.webkit.org/changeset/266491> 1685016 4 cdumez 2020-09-02 15:07:32 -0700 All reviewed patches have been landed. Closing bug. 1685017 5 webkit-bug-importer 2020-09-02 15:08:16 -0700 <rdar://problem/68235721> 407789 2020-09-02 12:55:08 -0700 2020-09-02 15:07:30 -0700 Patch bug-216091-20200902125507.patch text/plain 4329 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRiNTk2ZThjNjhlYjhh ZGU3YjQxMGI5Y2U5MDQyYjgxM2M5Mjg3Yi4uMmU2NjdiM2RkMDQ5ZDgwYjBjNjdiMTQ3MTJiZmMy MDUyZTdiNDVhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA5LTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHJvdW5kaW5nIGZvciBE ZWxheURTUEtlcm5lbCdzIGJ1ZmZlciBzaXplIGNhbGN1bGF0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYwOTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcm91bmRpbmcgZm9yIERlbGF5RFNQ S2VybmVsJ3MgYnVmZmVyIHNpemUgY2FsY3VsYXRpb24uIFRoZSBEZWxheU5vZGUgbmVlZHMgdG8g YnVmZmVyCisgICAgICAgIHxtYXhEZWxheVRpbWV8IHNhbXBsZSBmcmFtZXMsIHBsdXMgb25lIGZy YW1lIGZvciBpbnRlcnBvbGF0aW9uLiBJZiB8bWF4RGVsYXlUaW1lfCBpc24ndAorICAgICAgICBh biBpbnRlZ2VyLCB3ZSBoYXZlIHRvIHJvdW5kIGl0IHVwIG9yIHRoZSBidWZmZXIgd291bGQgZW5k IHVwIG9uZSBmcmFtZSBzaG9ydC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHJlYmFzZWxpbmVk IGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0RlbGF5RFNQS2Vy bmVsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRlbGF5RFNQS2VybmVsOjpidWZmZXJMZW5ndGhG b3JEZWxheSBjb25zdCk6CisKIDIwMjAtMDktMDIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBOZXcgQXV0b1BhcmFtIHRpbWVsaW5lIGV2ZW50cyBzaG91bGQgaGF2 ZSB0aGVpciBzdGFydFRpbWUgYWRqdXN0ZWQgd2hlbiB0aGV5IGFyZSBpbiB0aGUgcGFzdApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9EZWxheURTUEtlcm5lbC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0RlbGF5RFNQS2VybmVsLmNwcApp bmRleCBhZTE2MWE5ZjU0Y2ZhY2I5NGM5NWI4YWY0MDEwNjIzZWE1ZmM5Y2ZmLi5iZGM5NjUyYzg2 ZWU1YzczOGQ4YzUxZDhmZGViMTViYmQwYWI0OTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYmF1ZGlvL0RlbGF5RFNQS2VybmVsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYmF1ZGlvL0RlbGF5RFNQS2VybmVsLmNwcApAQCAtODEsNyArODEsNyBAQCBz aXplX3QgRGVsYXlEU1BLZXJuZWw6OmJ1ZmZlckxlbmd0aEZvckRlbGF5KGRvdWJsZSBtYXhEZWxh eVRpbWUsIGRvdWJsZSBzYW1wbGVSYQogewogICAgIC8vIENvbXB1dGUgdGhlIGxlbmd0aCBvZiB0 aGUgYnVmZmVyIG5lZWRlZCB0byBoYW5kbGUgYSBtYXggZGVsYXkgb2YgfG1heERlbGF5VGltZXwu IE9uZSBpcwogICAgIC8vIGFkZGVkIHRvIGhhbmRsZSB0aGUgY2FzZSB3aGVyZSB0aGUgYWN0dWFs IGRlbGF5IGVxdWFscyB0aGUgbWF4aW11bSBkZWxheS4KLSAgICByZXR1cm4gMSArIEF1ZGlvVXRp bGl0aWVzOjp0aW1lVG9TYW1wbGVGcmFtZShtYXhEZWxheVRpbWUsIHNhbXBsZVJhdGUpOworICAg IHJldHVybiAxICsgQXVkaW9VdGlsaXRpZXM6OnRpbWVUb1NhbXBsZUZyYW1lKG1heERlbGF5VGlt ZSwgc2FtcGxlUmF0ZSwgQXVkaW9VdGlsaXRpZXM6OlNhbXBsZUZyYW1lUm91bmRpbmc6OlVwKTsK IH0KIAogdm9pZCBEZWxheURTUEtlcm5lbDo6cHJvY2Vzcyhjb25zdCBmbG9hdCogc291cmNlLCBm bG9hdCogZGVzdGluYXRpb24sIHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQv dzNjL0NoYW5nZUxvZwppbmRleCAwM2NlMDBjYTIyMWZiNTVkNzA2NWYzZDAyNWRmYzNmNzMzOGJj ZWVhLi41MjFlOTMzNWU1NTY4ZmRiODZmNTA1MTFhM2RlMzJjZjFmMWRlOWFhIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOS0wMiAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCByb3VuZGluZyBmb3IgRGVs YXlEU1BLZXJuZWwncyBidWZmZXIgc2l6ZSBjYWxjdWxhdGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2MDkxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBXUFQgdGVzdCB0aGF0IGlz IG5vdyBwYXNzaW5nLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1ZGlvL3Ro ZS1hdWRpby1hcGkvdGhlLWRlbGF5bm9kZS1pbnRlcmZhY2UvbWF4ZGVsYXktcm91bmRpbmctZXhw ZWN0ZWQudHh0OgorCiAyMDIwLTA5LTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgTmV3IEF1dG9QYXJhbSB0aW1lbGluZSBldmVudHMgc2hvdWxkIGhhdmUgdGhl aXIgc3RhcnRUaW1lIGFkanVzdGVkIHdoZW4gdGhleSBhcmUgaW4gdGhlIHBhc3QKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8v dGhlLWF1ZGlvLWFwaS90aGUtZGVsYXlub2RlLWludGVyZmFjZS9tYXhkZWxheS1yb3VuZGluZy1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L3dlYmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWRlbGF5bm9kZS1pbnRlcmZhY2UvbWF4ZGVsYXkt cm91bmRpbmctZXhwZWN0ZWQudHh0CmluZGV4IDgwNmY3NzA1ZjUxNDIzN2ZhYmU0NjQ4Mzk5Y2Zk OGVmODI4ODRhYzguLjBiZjJkYTRkYWQ1NzU1NWU1YTAyN2ZmNzJlMDU2NjRiZGNhNzU5OTQgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2Vi YXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtZGVsYXlub2RlLWludGVyZmFjZS9tYXhkZWxheS1yb3Vu ZGluZy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1kZWxheW5vZGUtaW50ZXJmYWNl L21heGRlbGF5LXJvdW5kaW5nLWV4cGVjdGVkLnR4dApAQCAtMywxNCArMyw4IEBAIFBBU1MgIyBB VURJVCBUQVNLIFJVTk5FUiBTVEFSVEVELgogUEFTUyBFeGVjdXRpbmcgIm1heGRlbGF5LXJvdW5k aW5nIiAKIFBBU1MgQXVkaXQgcmVwb3J0IAogUEFTUyA+IFttYXhkZWxheS1yb3VuZGluZ10gVGVz dCBEZWxheU5vZGUgd2hlbiBtYXhEZWxheVRpbWUgcmVxdWlyZXMgcm91bmRpbmcgCi1GQUlMIFgg b3V0cHV0WzA6NDQwOTldOiBFeHBlY3RlZCAwIGZvciBhbGwgdmFsdWVzIGJ1dCBmb3VuZCA0NDEw MCB1bmV4cGVjdGVkIHZhbHVlczogCi0JSW5kZXgJQWN0dWFsCi0JWzBdCTAuMzk5NTQxODU0ODU4 Mzk4NDQKLQlbMV0JMC4zOTk1NDE4NTQ4NTgzOTg0NAotCVsyXQkwLjM5OTU0MTg1NDg1ODM5ODQ0 Ci0JWzNdCTAuMzk5NTQxODU0ODU4Mzk4NDQKLQkuLi5hbmQgNDQwOTYgbW9yZSBlcnJvcnMuIGFz c2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQorUEFTUyAgIG91dHB1dFswOjQ0MDk5 XSBjb250YWlucyBvbmx5IHRoZSBjb25zdGFudCAwLiAKIFBBU1MgICBvdXRwdXRbNDQxMDA6XSBp cyBub3QgY29uc3RhbnRseSAwIChjb250YWlucyA0NDEwMCBkaWZmZXJlbnQgdmFsdWVzKS4gCi1G QUlMIDwgW21heGRlbGF5LXJvdW5kaW5nXSAxIG91dCBvZiAyIGFzc2VydGlvbnMgd2VyZSBmYWls ZWQuIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQotRkFJTCAjIEFVRElUIFRB U0sgUlVOTkVSIEZJTklTSEVEOiAxIG91dCBvZiAxIHRhc2tzIHdlcmUgZmFpbGVkLiBhc3NlcnRf dHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKK1BBU1MgPCBbbWF4ZGVsYXktcm91bmRpbmdd IEFsbCBhc3NlcnRpb25zIHBhc3NlZC4gKHRvdGFsIDIgYXNzZXJ0aW9ucykgCitQQVNTICMgQVVE SVQgVEFTSyBSVU5ORVIgRklOSVNIRUQ6IDEgdGFza3MgcmFuIHN1Y2Nlc3NmdWxseS4gCiAK