215886 2020-08-27 08:22:11 -0700 REGRESSION(r266221) Layout tests step hanging due to slow WaveDiff comparison 2020-08-27 20:25:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215868 InRadar P2 Normal --- 1 lmoura lmoura ap bugs-noreply cdumez darin ews-watchlist glenn jbedard jer.noble webkit-bug-importer oldest_to_newest 1683371 0 lmoura 2020-08-27 08:22:11 -0700 GTK/WPE layout-tests steps are timing out after r266221. Some tests seem to hold the driver alive, and the step fails with those "no console output for 1200 seconds". For example, running webaudio/ tests (defaults to 5 shards), webaudio/audiobuffersource-loop-points.html (skipped in mac in bug119467) get stuck and the test run does not progress. The same happens regardless of the number of shards, always getting stuck in this test. List of webaudio/ tests skipped to allow all other webaudio/ tests to run: * webaudio/audiobuffersource-loop-points.html * webaudio/audiobuffersource-playbackrate.html PS: Not sure if this happens due to some webkitpy bug uncovered by these timeouts. 1683377 1 cdumez 2020-08-27 08:32:49 -0700 Interesting. I had some very slow layout tests runs locally as well until I rebaselined the couple of Web Audio tests that were failing. You should consider rebaselining the couple of tests that are failing with audio diff to see if it makes the issue go away (Seems like it did on macOS). 1683389 2 lmoura 2020-08-27 09:04:34 -0700 (In reply to Chris Dumez from comment #1) > Interesting. I had some very slow layout tests runs locally as well until I > rebaselined the couple of Web Audio tests that were failing. > > You should consider rebaselining the couple of tests that are failing with > audio diff to see if it makes the issue go away (Seems like it did on macOS). Indeed rebaselining made the test pass. O_o In any case, the test suite should not hang because a WAV diff failed, no? 1683391 3 cdumez 2020-08-27 09:11:56 -0700 (In reply to Lauro Moura from comment #2) > (In reply to Chris Dumez from comment #1) > > Interesting. I had some very slow layout tests runs locally as well until I > > rebaselined the couple of Web Audio tests that were failing. > > > > You should consider rebaselining the couple of tests that are failing with > > audio diff to see if it makes the issue go away (Seems like it did on macOS). > > Indeed rebaselining made the test pass. O_o > > In any case, the test suite should not hang because a WAV diff failed, no? Yes, I suspect we have a tooling bug. I saw a Python process using 100% CPU constantly. I was just trying to help you get back in a good state. 1683503 4 lmoura 2020-08-27 15:38:57 -0700 (In reply to Chris Dumez from comment #3) > > I was just trying to help you get back in a good state. Sure, sure. Thanks. In the loop-points test, the new test results had small deviations that increased as the frequency increased (looping was right, though). This caused the WaveDiff class to generate a sample diff for 340k of the 666k samples. And as the current WaveDiff uses string concat for each sample diff, it ended up being too slow, likely leading the timeout to be triggered on the test controller and it somehow losing track of the runner. 1683506 5 407429 lmoura 2020-08-27 15:51:40 -0700 Created attachment 407429 Patch 1683570 6 ews-feeder 2020-08-27 20:24:28 -0700 Committed r266272: <https://trac.webkit.org/changeset/266272> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407429. 1683571 7 webkit-bug-importer 2020-08-27 20:25:17 -0700 <rdar://problem/67915158> 407429 2020-08-27 15:51:40 -0700 2020-08-27 20:24:29 -0700 Patch bug-215886-20200827195139.patch text/plain 4284 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MjQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDZiMzg1ZGIwNzFjZmQ0MTU4NmYwMjkxNmQwYjU5NDVl ZGZjNTU1YS4uMGE3MGQ3YmMwZjc2NTFhNDdmODQxZGMwNGNmZThjZWNjZWU3MjY5YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDIwLTA4LTI3ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjI2NjIyMSkgTGF5b3V0IHRlc3RzIHN0ZXAgaGFuZ2luZyBkdWUgdG8g c2xvdyBXYXZlRGlmZiBjb21wYXJpc29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTU4ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZnRlciByMjY2MjIxLCBhIGNvdXBsZSBvZiB3ZWJhdWRpbyB0ZXN0 cyBnZW5lcmF0ZWQgV0FWIGZpbGVzIHdpdGggYQorICAgICAgICBzbWFsbCBkaWZmZXJlbmNlIGlu IGEgbGFyZ2UgbnVtYmVyIG9mIHNhbXBsZXMuIFRoaXMgY2F1c2VkIHRoZQorICAgICAgICBXYXZl RGlmZiBjb21wYXJpc29uIHRvIHRha2UgdG9vIGxvbmcuCisKKyAgICAgICAgV2hpbGUgaXQgd29y a3MgZmluZSBmb3Igc21hbGwgZGlmZnMsIHRoaXMgZW5kcyB1cCBjcmVhdGluZyByZXBlYXRlZGx5 CisgICAgICAgIGxhcmdlIHN0cmluZ3MgZm9yIGVhY2ggY29uY2F0ZW5hdGlvbiwgYnJpbmdpbmcg dGhlIGNvbXBhcmlzb25zIHRvIGEKKyAgICAgICAgaGFsdC4KKworICAgICAgICBJbnN0ZWFkIG9m IHJlbHlpbmcgb24gc3RyaW5nIGNvbmNhdGVuYXRpb24sIHVzZSBhIGxpc3QgdG8gY29sbGVjdCB0 aGVuCisgICAgICAgIGFuZCBvbmx5IGNvbmNhdCB3aGVuIGFjdHVhbGx5IHJldHJpZXZpbmcgdGhl IGZ1bGwgc3RyaW5nLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vd2F2ZWRp ZmYucHk6CisgICAgICAgIChXYXZlRGlmZi5fX2luaXRfXyk6CisgICAgICAgIChXYXZlRGlmZi5f ZGlmZlBhcmFtKToKKyAgICAgICAgKFdhdmVEaWZmLl9kaWZmU2FtcGxlKToKKyAgICAgICAgKFdh dmVEaWZmLmRpZmZUZXh0KToKKwogMjAyMC0wOC0yNyAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFw cGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjY0NzkwKTogSW5kZXhlZERCIG1heSBh Ym9ydCB0cmFuc2FjdGlvbnMgb2YgaW4tbWVtb3J5IGRhdGFiYXNlcwpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vd2F2ZWRpZmYucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi93YXZlZGlmZi5weQppbmRleCAzNmY2ODNiMzE0NzNmZTY2NDc3Mjc2YWY0 ZTJiNGM0OTcyOTBiN2U1Li5mYjBiN2QxMDhlZmFlNTdjZWI3MjU5Y2EzNGEyMTYwZTIxMTRkZmQx IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi93YXZlZGlmZi5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi93YXZlZGlmZi5weQpAQCAtNDUsNyAr NDUsNyBAQCBjbGFzcyBXYXZlRGlmZihvYmplY3QpOgogICAgICAgICBwYXJhbXMxID0gd2F2ZUZp bGUxLmdldHBhcmFtcygpCiAgICAgICAgIHBhcmFtczIgPSB3YXZlRmlsZTIuZ2V0cGFyYW1zKCkK IAotICAgICAgICBzZWxmLl9kaWZmID0gJycKKyAgICAgICAgc2VsZi5fZGlmZiA9IFtdCiAKICAg ICAgICAgc2VsZi5fZmlsZXNBcmVJZGVudGljYWwgPSBub3Qgc3VtKG1hcChzZWxmLl9kaWZmUGFy YW0sIHBhcmFtczEsIHBhcmFtczIsIHNlbGYuX3BhcmFtTmFtZXMpKQogICAgICAgICBzZWxmLl9m aWxlc0FyZUlkZW50aWNhbFdpdGhpblRvbGVyYW5jZSA9IHNlbGYuX2ZpbGVzQXJlSWRlbnRpY2Fs CkBAIC03MiwxOSArNzIsMTkgQEAgY2xhc3MgV2F2ZURpZmYob2JqZWN0KToKICAgICAgICAgc2Vs Zi5fZmlsZXNBcmVJZGVudGljYWxXaXRoaW5Ub2xlcmFuY2UgPSBub3QgbGVuKGxpc3QoZmlsdGVy KGxhbWJkYSB4OiB4ID4gc2VsZi5fdG9sZXJhbmNlLCByZXN1bHRzKSkpCiAKICAgICAgICAgaWYg ZGlmZmVyaW5nU2FtcGxlQ291bnQ6Ci0gICAgICAgICAgICBzZWxmLl9kaWZmICs9ICdcbicKLSAg ICAgICAgICAgIHNlbGYuX2RpZmYgKz0gJ1RvdGFsIGRpZmZlcmluZyBzYW1wbGVzOiAlZFxuJyAl IGRpZmZlcmluZ1NhbXBsZUNvdW50Ci0gICAgICAgICAgICBzZWxmLl9kaWZmICs9ICdQZXJjZW50 YWdlIG9mIGRpZmZlcmluZyBzYW1wbGVzOiAlMC4zZiUlXG4nICUgKDEwMCAqIGZsb2F0KGRpZmZl cmluZ1NhbXBsZUNvdW50KSAvIG1heChmcmFtZUNvdW50MSwgZnJhbWVDb3VudDIpKQotICAgICAg ICAgICAgc2VsZi5fZGlmZiArPSAnQ3VtdWxhdGl2ZSBzYW1wbGUgZGlmZmVyZW5jZTogJWRcbicg JSBjdW11bGF0aXZlU2FtcGxlRGlmZgotICAgICAgICAgICAgc2VsZi5fZGlmZiArPSAnQXZlcmFn ZSBzYW1wbGUgZGlmZmVyZW5jZTogJWZcbicgJSAoZmxvYXQoY3VtdWxhdGl2ZVNhbXBsZURpZmYp IC8gZGlmZmVyaW5nU2FtcGxlQ291bnQpCisgICAgICAgICAgICBzZWxmLl9kaWZmLmFwcGVuZCgn JykKKyAgICAgICAgICAgIHNlbGYuX2RpZmYuYXBwZW5kKCdUb3RhbCBkaWZmZXJpbmcgc2FtcGxl czogJWQnICUgZGlmZmVyaW5nU2FtcGxlQ291bnQpCisgICAgICAgICAgICBzZWxmLl9kaWZmLmFw cGVuZCgnUGVyY2VudGFnZSBvZiBkaWZmZXJpbmcgc2FtcGxlczogJTAuM2YlJScgJSAoMTAwICog ZmxvYXQoZGlmZmVyaW5nU2FtcGxlQ291bnQpIC8gbWF4KGZyYW1lQ291bnQxLCBmcmFtZUNvdW50 MikpKQorICAgICAgICAgICAgc2VsZi5fZGlmZi5hcHBlbmQoJ0N1bXVsYXRpdmUgc2FtcGxlIGRp ZmZlcmVuY2U6ICVkJyAlIGN1bXVsYXRpdmVTYW1wbGVEaWZmKQorICAgICAgICAgICAgc2VsZi5f ZGlmZi5hcHBlbmQoJ0F2ZXJhZ2Ugc2FtcGxlIGRpZmZlcmVuY2U6ICVmJyAlIChmbG9hdChjdW11 bGF0aXZlU2FtcGxlRGlmZikgLyBkaWZmZXJpbmdTYW1wbGVDb3VudCkpCiAKICAgICBkZWYgX2Rp ZmZQYXJhbShzZWxmLCBwYXJhbTEsIHBhcmFtMiwgcGFyYW1OYW1lKToKICAgICAgICAgaWYgcGFy YW0xID09IHBhcmFtMjoKICAgICAgICAgICAgIHJldHVybiBGYWxzZQotICAgICAgICBzZWxmLl9k aWZmICs9IHBhcmFtTmFtZSArICdcbicKLSAgICAgICAgc2VsZi5fZGlmZiArPSAnPCAlc1xuJyAl IHN0cihwYXJhbTEpCi0gICAgICAgIHNlbGYuX2RpZmYgKz0gJy0tLVxuJwotICAgICAgICBzZWxm Ll9kaWZmICs9ICc+ICVzXG4nICUgc3RyKHBhcmFtMikKKyAgICAgICAgc2VsZi5fZGlmZi5hcHBl bmQocGFyYW1OYW1lKQorICAgICAgICBzZWxmLl9kaWZmLmFwcGVuZCgnPCAlcycgJSBzdHIocGFy YW0xKSkKKyAgICAgICAgc2VsZi5fZGlmZi5hcHBlbmQoJy0tLScpCisgICAgICAgIHNlbGYuX2Rp ZmYuYXBwZW5kKCc+ICVzJyAlIHN0cihwYXJhbTIpKQogICAgICAgICByZXR1cm4gVHJ1ZQogCiAg ICAgQHN0YXRpY21ldGhvZApAQCAtOTUsMTAgKzk1LDEwIEBAIGNsYXNzIFdhdmVEaWZmKG9iamVj dCk6CiAKICAgICBkZWYgX2RpZmZTYW1wbGUoc2VsZiwgZGF0YTEsIGRhdGEyLCBpKToKICAgICAg ICAgaWYgKGRhdGExICE9IGRhdGEyKToKLSAgICAgICAgICAgIHNlbGYuX2RpZmYgKz0gJ1NhbXBs ZSAjJWRcbicgJSBpCi0gICAgICAgICAgICBzZWxmLl9kaWZmICs9ICc8ICVkXG4nICUgZGF0YTEK LSAgICAgICAgICAgIHNlbGYuX2RpZmYgKz0gJy0tLVxuJwotICAgICAgICAgICAgc2VsZi5fZGlm ZiArPSAnPiAlZFxuJyAlIGRhdGEyCisgICAgICAgICAgICBzZWxmLl9kaWZmLmFwcGVuZCgnU2Ft cGxlICMlZCcgJSBpKQorICAgICAgICAgICAgc2VsZi5fZGlmZi5hcHBlbmQoJzwgJWQnICUgZGF0 YTEpCisgICAgICAgICAgICBzZWxmLl9kaWZmLmFwcGVuZCgnLS0tJykKKyAgICAgICAgICAgIHNl bGYuX2RpZmYuYXBwZW5kKCc+ICVkJyAlIGRhdGEyKQogICAgICAgICByZXR1cm4gYWJzKGRhdGEx IC0gZGF0YTIpCiAKICAgICBkZWYgZmlsZXNBcmVJZGVudGljYWwoc2VsZik6CkBAIC0xMDgsNCAr MTA4LDQgQEAgY2xhc3MgV2F2ZURpZmYob2JqZWN0KToKICAgICAgICAgcmV0dXJuIHNlbGYuX2Zp bGVzQXJlSWRlbnRpY2FsV2l0aGluVG9sZXJhbmNlCiAKICAgICBkZWYgZGlmZlRleHQoc2VsZik6 Ci0gICAgICAgIHJldHVybiBzZWxmLl9kaWZmCisgICAgICAgIHJldHVybiAnXG4nLmpvaW4oc2Vs Zi5fZGlmZikK