215625 2020-08-18 14:19:36 -0700 PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear" 2020-08-18 16:16:16 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://www.w3.org/TR/webaudio/#dom-pannernode-rollofffactor InRadar P2 Normal --- 212611 1 cdumez cdumez clark_wang darin eric.carlson ews-watchlist ggaren glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1681182 0 cdumez 2020-08-18 14:19:36 -0700 PannerNode.rolloffFactor setter should clamp value to [0, 1] when distanceModel is "linear": - https://www.w3.org/TR/webaudio/#dom-pannernode-rollofffactor 1681203 1 406814 cdumez 2020-08-18 14:52:31 -0700 Created attachment 406814 Patch 1681207 2 406814 darin 2020-08-18 15:03:29 -0700 Comment on attachment 406814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406814&action=review > Source/WebCore/platform/audio/Distance.cpp:72 > + auto clampedRolloffFactor = std::min(m_rolloffFactor, 1.0); This says clamped but it only does the 1.0 half of the clamping. I’d expect to see std::max or std::clamp here. 1681208 3 406814 darin 2020-08-18 15:04:37 -0700 Comment on attachment 406814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406814&action=review >> Source/WebCore/platform/audio/Distance.cpp:72 >> + auto clampedRolloffFactor = std::min(m_rolloffFactor, 1.0); > > This says clamped but it only does the 1.0 half of the clamping. I’d expect to see std::max or std::clamp here. to handle the 0.0 minimum. 1681213 4 cdumez 2020-08-18 15:11:17 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 406814 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406814&action=review > > >> Source/WebCore/platform/audio/Distance.cpp:72 > >> + auto clampedRolloffFactor = std::min(m_rolloffFactor, 1.0); > > > > This says clamped but it only does the 1.0 half of the clamping. I’d expect to see std::max or std::clamp here. > > to handle the 0.0 minimum. We already throw an exception in the setter if the JS tries to set a negative value. Therefore, we only need to make sure the value is no more than 1. 1681214 5 cdumez 2020-08-18 15:12:23 -0700 (In reply to Chris Dumez from comment #4) > (In reply to Darin Adler from comment #3) > > Comment on attachment 406814 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=406814&action=review > > > > >> Source/WebCore/platform/audio/Distance.cpp:72 > > >> + auto clampedRolloffFactor = std::min(m_rolloffFactor, 1.0); > > > > > > This says clamped but it only does the 1.0 half of the clamping. I’d expect to see std::max or std::clamp here. > > > > to handle the 0.0 minimum. > > We already throw an exception in the setter if the JS tries to set a > negative value. Therefore, we only need to make sure the value is no more > than 1. From https://www.w3.org/TR/webaudio/#dom-pannernode-rollofffactor: "A RangeError exception MUST be thrown if this is set to a negative value." 1681216 6 406814 cdumez 2020-08-18 15:15:41 -0700 Comment on attachment 406814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406814&action=review > Source/WebCore/Modules/webaudio/PannerNode.cpp:282 > return Exception { RangeError, "rolloffFactor cannot be set to a negative value"_s }; Throwing happens here if value is negative. 1681223 7 406819 cdumez 2020-08-18 15:36:16 -0700 Created attachment 406819 Patch 1681232 8 ews-feeder 2020-08-18 16:15:33 -0700 Committed r265838: <https://trac.webkit.org/changeset/265838> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406819. 1681233 9 webkit-bug-importer 2020-08-18 16:16:16 -0700 <rdar://problem/67360120> 406814 2020-08-18 14:52:31 -0700 2020-08-18 15:36:13 -0700 Patch bug-215625-20200818145230.patch text/plain 5805 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA0OTcyMjYxYzc5MTQ5 Njg2Y2JiNGZiZWU5YjhkYmM4ZTE3NTIwNC4uN2UzMmY5NjViZjUzNTkyZTJhNDk5Mjg4MDliNjIx OGExNmMyMTc2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA4LTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUGFubmVyTm9kZSdzIHJvbGxv ZmZGYWN0b3Igc2hvdWxkIGJlIGNsYW1wZWQgdG8gWzAsIDFdIGludGVybmFsbHkgd2hlbiBkaXN0 YW5jZU1vZGVsIGlzICJsaW5lYXIiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTU2MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQYW5uZXJOb2RlJ3Mgcm9sbG9mZkZhY3RvciBzaG91bGQgYmUgY2xhbXBl ZCB0byBbMCwgMV0gaW50ZXJuYWxseSB3aGVuIGRpc3RhbmNlTW9kZWwgaXMgImxpbmVhciI6Cisg ICAgICAgIC0gaHR0cHM6Ly93d3cudzMub3JnL1RSL3dlYmF1ZGlvLyNkb20tcGFubmVybm9kZS1y b2xsb2ZmZmFjdG9yCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCByZWJhc2VsaW5lZCBleGlzdGlu ZyB0ZXN0LgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhbm5lck5vZGU6OnNldFJvbGxvZmZGYWN0b3IpOgorICAgICAgICAq IHBsYXRmb3JtL2F1ZGlvL0Rpc3RhbmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRpc3RhbmNl RWZmZWN0OjpsaW5lYXJHYWluKToKKwogMjAyMC0wOC0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFNjcmlwdFByb2Nlc3NOb2RlIHNob3VsZCBvbmx5IHJ1biBz Y3JpcHQgYXN5bmNocm9ub3VzbHkgaWYgdGhlIGF1ZGlvIGNvbnRleHQgaXMgbm90IGFuIE9mZmxp bmVBdWRpb0NvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVk aW8vUGFubmVyTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5l ck5vZGUuY3BwCmluZGV4IDJlYTU3NDAzZjAyZWUyM2NhZDBhZTY1MzQ0MWY0MmI1MTg0OWVkZjku LjIxNmFhMTE2Y2Y3MzU0M2RkYTBkNjVjZGM0M2U2YWZjYjE5ZjUyMzEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmNwcApAQCAtMjc4LDggKzI3OCw2 IEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IFBhbm5lck5vZGU6OnNldE1heERpc3RhbmNlKGRvdWJsZSBt YXhEaXN0YW5jZSkKIAogRXhjZXB0aW9uT3I8dm9pZD4gUGFubmVyTm9kZTo6c2V0Um9sbG9mZkZh Y3Rvcihkb3VibGUgcm9sbG9mZkZhY3RvcikKIHsKLSAgICAvLyBGSVhNRTogSW1wbGVtZW50IGNs YW1waW5nIG9mIGxpbmVhciBtb2RlbCBvbmNlIGZlZWRiYWNrIGlzIHJlY2VpdmVkCi0gICAgCiAg ICAgaWYgKHJvbGxvZmZGYWN0b3IgPCAwKQogICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgUmFu Z2VFcnJvciwgInJvbGxvZmZGYWN0b3IgY2Fubm90IGJlIHNldCB0byBhIG5lZ2F0aXZlIHZhbHVl Il9zIH07CiAgICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9E aXN0YW5jZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9EaXN0YW5jZS5jcHAK aW5kZXggZmFlMjEyY2Y0M2YwNjI4ZThhYTFmNjRlYTNmM2YwMmJkOTQzYjg2NC4uNDRlYjE5NDQx YzEwOWJmYjMyNDliNmJiZWQ5NjBkMjEyZmU5YjM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYXVkaW8vRGlzdGFuY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL0Rpc3RhbmNlLmNwcApAQCAtNjksOSArNjksMTAgQEAgZG91YmxlIERpc3RhbmNl RWZmZWN0OjpnYWluKGRvdWJsZSBkaXN0YW5jZSkKIAogZG91YmxlIERpc3RhbmNlRWZmZWN0Ojps aW5lYXJHYWluKGRvdWJsZSBkaXN0YW5jZSkKIHsKKyAgICBhdXRvIGNsYW1wZWRSb2xsb2ZmRmFj dG9yID0gc3RkOjptaW4obV9yb2xsb2ZmRmFjdG9yLCAxLjApOwogICAgIC8vIFdlIHdhbnQgYSBn YWluIHRoYXQgZGVjcmVhc2VzIGxpbmVhcmx5IGZyb20gbV9yZWZEaXN0YW5jZSB0bwogICAgIC8v IG1fbWF4RGlzdGFuY2UuIFRoZSBnYWluIGlzIDEgYXQgbV9yZWZEaXN0YW5jZS4KLSAgICByZXR1 cm4gKDEuMCAtIG1fcm9sbG9mZkZhY3RvciAqIChkaXN0YW5jZSAtIG1fcmVmRGlzdGFuY2UpIC8g KG1fbWF4RGlzdGFuY2UgLSBtX3JlZkRpc3RhbmNlKSk7CisgICAgcmV0dXJuICgxLjAgLSBjbGFt cGVkUm9sbG9mZkZhY3RvciAqIChkaXN0YW5jZSAtIG1fcmVmRGlzdGFuY2UpIC8gKG1fbWF4RGlz dGFuY2UgLSBtX3JlZkRpc3RhbmNlKSk7CiB9CiAKIGRvdWJsZSBEaXN0YW5jZUVmZmVjdDo6aW52 ZXJzZUdhaW4oZG91YmxlIGRpc3RhbmNlKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5k ZXggNmU1NjQyYzdjYzE5NGIxZTUwYzk1MTRlYjU4OWI2MjhiYTlmNDRjMy4uYWY4ZmY1MWY2YTRk NmYyMjY0NWFhNzk3NGMyMWQ1MTgzM2Y4ZmQ2YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDgtMTggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KKworICAgICAgICBQYW5uZXJOb2RlJ3Mgcm9sbG9mZkZhY3RvciBzaG91bGQgYmUg Y2xhbXBlZCB0byBbMCwgMV0gaW50ZXJuYWxseSB3aGVuIGRpc3RhbmNlTW9kZWwgaXMgImxpbmVh ciIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTYy NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYmFz ZWxpbmUgV1BUIHRlc3RzIG5vdyB0aGF0IG1vcmUgY2hlY2tzIGFyZSBwYXNzaW5nLgorCisgICAg ICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLXBhbm5l cm5vZGUtaW50ZXJmYWNlL3Bhbm5lci1yb2xsb2ZmLWNsYW1waW5nLWV4cGVjdGVkLnR4dDoKKwog MjAyMC0wOC0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFNj cmlwdFByb2Nlc3NOb2RlIHNob3VsZCBvbmx5IHJ1biBzY3JpcHQgYXN5bmNocm9ub3VzbHkgaWYg dGhlIGF1ZGlvIGNvbnRleHQgaXMgbm90IGFuIE9mZmxpbmVBdWRpb0NvbnRleHQKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8v dGhlLWF1ZGlvLWFwaS90aGUtcGFubmVybm9kZS1pbnRlcmZhY2UvcGFubmVyLXJvbGxvZmYtY2xh bXBpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1wYW5uZXJub2RlLWludGVyZmFjZS9w YW5uZXItcm9sbG9mZi1jbGFtcGluZy1leHBlY3RlZC50eHQKaW5kZXggMTczMDQ0ZGZmZTY1YTU1 MGIzNGU3YWM1YjI3MzVkM2QxZWJiYjE1Ni4uNTZlMWJlYjYxNjkxZGFjZmIxZjc3ZjlhMjc4MjZj NTAzMjkwOTQ4YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1wYW5uZXJub2RlLWludGVyZmFj ZS9wYW5uZXItcm9sbG9mZi1jbGFtcGluZy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3Ro ZS1wYW5uZXJub2RlLWludGVyZmFjZS9wYW5uZXItcm9sbG9mZi1jbGFtcGluZy1leHBlY3RlZC50 eHQKQEAgLTMsMTMgKzMsNyBAQCBQQVNTICMgQVVESVQgVEFTSyBSVU5ORVIgU1RBUlRFRC4KIFBB U1MgRXhlY3V0aW5nICJsaW5lYXItY2xhbXAtaGlnaCIgCiBQQVNTIEF1ZGl0IHJlcG9ydCAKIFBB U1MgPiBbbGluZWFyLWNsYW1wLWhpZ2hdIHJvbGxvZmZGYWN0b3IgY2xhbXBpbmcgZm9yIGxpbmVh ciBkaXN0YW5jZSBtb2RlbCAKLUZBSUwgWCBQYW5uZXIgZGlzdGFuY2VNb2RlbDogImxpbmVhciIs IHJvbGxvZmZGYWN0b3I6IDIgZXhwZWN0ZWQgdG8gYmUgZXF1YWwgdG8gdGhlIGFycmF5IFswLDAu MDAyOTYwMjkzNzg2NjAwMjMyLDAuMDA5MTE4MTg1Mzc4NjExMDg4LDAuMDEwNjQzNTY1MDk1OTYx MDk0LDAuMDE1NzgzMTUxNjExNjg1NzUzLDAuMDE5OTc5MjU1MjczOTM4MTgsMC4wMjI1ODk4NDU1 ODI4NDI4MjcsMC4wMjc0OTM3OTM1MTczNTExNSwwLjAzMTc0MDAyNDY4NTg1OTY4LDAuMDMzNjM2 NTk5Nzc5MTI5MDMsMC4wNDAzNzc5MjYwODE0MTg5OSwwLjA0MTkzMjgwMjY0NzM1MjIyLDAuMDQ2 NDg3NTg0NzEwMTIxMTU1LDAuMDUxNjA5MzIyNDI4NzAzMzEsMC4wNTMyMTM3NjM5ODIwNTc1Nyww LjA1OTAzNjIxMzkwNDYxOTIyLi4uXSBidXQgZGlmZmVycyBpbiAyMDQ3IHBsYWNlczoKLQlJbmRl eAlBY3R1YWwJCQlFeHBlY3RlZAotCVsxXQk1LjkyMDU4NzExMzkwNTYzOTllLTcJMi45NjAyOTM3 ODY2MDAyMzIxZS0zCi0JWzJdCTEuODIzNjM3MTQ4ODQ1NTkxNmUtNgk5LjExODE4NTM3ODYxMTA4 NzhlLTMKLQlbM10JMi4xMjg3MTMwNDkzODc0NDI5ZS02CTEuMDY0MzU2NTA5NTk2MTA5NGUtMgot CVs0XQkzLjE1NjYzMDU1NTE2Nzc5NDJlLTYJMS41NzgzMTUxNjExNjg1NzUzZS0yCi0JLi4uYW5k IDIwNDMgbW9yZSBlcnJvcnMuIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQot RkFJTCA8IFtsaW5lYXItY2xhbXAtaGlnaF0gMSBvdXQgb2YgMSBhc3NlcnRpb25zIHdlcmUgZmFp bGVkLiBhc3NlcnRfdHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKLUZBSUwgIyBBVURJVCBU QVNLIFJVTk5FUiBGSU5JU0hFRDogMSBvdXQgb2YgMSB0YXNrcyB3ZXJlIGZhaWxlZC4gYXNzZXJ0 X3RydWU6IGV4cGVjdGVkIHRydWUgZ290IGZhbHNlCitQQVNTICAgUGFubmVyIGRpc3RhbmNlTW9k ZWw6ICJsaW5lYXIiLCByb2xsb2ZmRmFjdG9yOiAyIGlzIGlkZW50aWNhbCB0byB0aGUgYXJyYXkg WzAsMC4wMDkwMTc0NDQyMTU3MTQ5MzEsMC4wMjY4NTM5MDA0MDI3ODQzNDgsMC4wMzI3MTQ1NzE4 MDM4MDgyMSwwLjA0NzA4NTk2MzE4OTYwMTksMC4wNTg0ODQzNTY4NTAzODU2NjYsMC4wNzE0NjUx NTY5NzI0MDgzLDAuMDc3NjM4NzM3ODU3MzQxNzcsMC4wOTg2NTczMTAwMDkwMDI2OSwwLjEwMTM2 Mjg3NjU5NDA2NjYyLDAuMTE2MzYwMDM4NTE4OTA1NjQsMC4xMzI0MDE4Njg3MDA5ODExNCwwLjEz NTE5ODE0NjEwNDgxMjYyLDAuMTUzODc4NTg0NTA0MTI3NSwwLjE2NDUxNDMwMzIwNzM5NzQ2LDAu MTc0NjI4NDA2NzYzMDc2NzguLi5dLiAKK1BBU1MgPCBbbGluZWFyLWNsYW1wLWhpZ2hdIEFsbCBh c3NlcnRpb25zIHBhc3NlZC4gKHRvdGFsIDEgYXNzZXJ0aW9ucykgCitQQVNTICMgQVVESVQgVEFT SyBSVU5ORVIgRklOSVNIRUQ6IDEgdGFza3MgcmFuIHN1Y2Nlc3NmdWxseS4gCiAK 406819 2020-08-18 15:36:16 -0700 2020-08-18 16:15:33 -0700 Patch bug-215625-20200818153615.patch text/plain 5735 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTZhMTZmNjc2ODI5MDk3 YTA3Y2RmNjhiNDBlOTA3NzY0NjE4MDcxYi4uMWQyZGI2ODNmMmNhNjI0M2U0MWU3MjFmZjYyN2Nk OWU4MTFmZTc3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA4LTE4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUGFubmVyTm9kZSdzIHJvbGxv ZmZGYWN0b3Igc2hvdWxkIGJlIGNsYW1wZWQgdG8gWzAsIDFdIGludGVybmFsbHkgd2hlbiBkaXN0 YW5jZU1vZGVsIGlzICJsaW5lYXIiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTU2MjUKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K KworICAgICAgICBQYW5uZXJOb2RlJ3Mgcm9sbG9mZkZhY3RvciBzaG91bGQgYmUgY2xhbXBlZCB0 byBbMCwgMV0gaW50ZXJuYWxseSB3aGVuIGRpc3RhbmNlTW9kZWwgaXMgImxpbmVhciI6CisgICAg ICAgIC0gaHR0cHM6Ly93d3cudzMub3JnL1RSL3dlYmF1ZGlvLyNkb20tcGFubmVybm9kZS1yb2xs b2ZmZmFjdG9yCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCByZWJhc2VsaW5lZCBleGlzdGluZyB0 ZXN0LgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlBhbm5lck5vZGU6OnNldFJvbGxvZmZGYWN0b3IpOgorICAgICAgICAqIHBs YXRmb3JtL2F1ZGlvL0Rpc3RhbmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRpc3RhbmNlRWZm ZWN0OjpsaW5lYXJHYWluKToKKwogMjAyMC0wOC0xOCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJs c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ2F0YWx5c3RdIFZpZGVvIHNob3VsZCBwYXVzZSBh dXRvbWF0aWNhbGx5IHdoZW4gc3dpdGNoaW5nIGRlc2t0b3BzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmNwcAppbmRleCAyZWE1NzQwM2YwMmVlMjNjYWQw YWU2NTM0NDFmNDJiNTE4NDllZGY5Li4yMTZhYTExNmNmNzM1NDNkZGEwZDY1Y2RjNDNlNmFmY2Ix OWY1MjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5l ck5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9k ZS5jcHAKQEAgLTI3OCw4ICsyNzgsNiBAQCBFeGNlcHRpb25Pcjx2b2lkPiBQYW5uZXJOb2RlOjpz ZXRNYXhEaXN0YW5jZShkb3VibGUgbWF4RGlzdGFuY2UpCiAKIEV4Y2VwdGlvbk9yPHZvaWQ+IFBh bm5lck5vZGU6OnNldFJvbGxvZmZGYWN0b3IoZG91YmxlIHJvbGxvZmZGYWN0b3IpCiB7Ci0gICAg Ly8gRklYTUU6IEltcGxlbWVudCBjbGFtcGluZyBvZiBsaW5lYXIgbW9kZWwgb25jZSBmZWVkYmFj ayBpcyByZWNlaXZlZAotICAgIAogICAgIGlmIChyb2xsb2ZmRmFjdG9yIDwgMCkKICAgICAgICAg cmV0dXJuIEV4Y2VwdGlvbiB7IFJhbmdlRXJyb3IsICJyb2xsb2ZmRmFjdG9yIGNhbm5vdCBiZSBz ZXQgdG8gYSBuZWdhdGl2ZSB2YWx1ZSJfcyB9OwogICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vRGlzdGFuY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vRGlzdGFuY2UuY3BwCmluZGV4IGZhZTIxMmNmNDNmMDYyOGU4YWExZjY0ZWEzZjNm MDJiZDk0M2I4NjQuLmQ4MDBiMDlkOGIyNmFhOWU1N2JlNmQzNGE5YTQ2NWViMzM1ZjRjNTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0Rpc3RhbmNlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9EaXN0YW5jZS5jcHAKQEAgLTY5LDkgKzY5 LDEwIEBAIGRvdWJsZSBEaXN0YW5jZUVmZmVjdDo6Z2Fpbihkb3VibGUgZGlzdGFuY2UpCiAKIGRv dWJsZSBEaXN0YW5jZUVmZmVjdDo6bGluZWFyR2Fpbihkb3VibGUgZGlzdGFuY2UpCiB7CisgICAg YXV0byBjbGFtcGVkUm9sbG9mZkZhY3RvciA9IHN0ZDo6Y2xhbXAobV9yb2xsb2ZmRmFjdG9yLCAw LjAsIDEuMCk7CiAgICAgLy8gV2Ugd2FudCBhIGdhaW4gdGhhdCBkZWNyZWFzZXMgbGluZWFybHkg ZnJvbSBtX3JlZkRpc3RhbmNlIHRvCiAgICAgLy8gbV9tYXhEaXN0YW5jZS4gVGhlIGdhaW4gaXMg MSBhdCBtX3JlZkRpc3RhbmNlLgotICAgIHJldHVybiAoMS4wIC0gbV9yb2xsb2ZmRmFjdG9yICog KGRpc3RhbmNlIC0gbV9yZWZEaXN0YW5jZSkgLyAobV9tYXhEaXN0YW5jZSAtIG1fcmVmRGlzdGFu Y2UpKTsKKyAgICByZXR1cm4gKDEuMCAtIGNsYW1wZWRSb2xsb2ZmRmFjdG9yICogKGRpc3RhbmNl IC0gbV9yZWZEaXN0YW5jZSkgLyAobV9tYXhEaXN0YW5jZSAtIG1fcmVmRGlzdGFuY2UpKTsKIH0K IAogZG91YmxlIERpc3RhbmNlRWZmZWN0OjppbnZlcnNlR2Fpbihkb3VibGUgZGlzdGFuY2UpCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBhMmVjMTA2MDU0ZTE5YzlhMzg2MzdjZjRl ZjBlOTk4NGQzY2JkNjY4Li42MWZhMWY3NDRlMTMzYTg2MGVhOTI3MTNmZDAxMDY3OWU0ZGEwYjVh IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0w OC0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFBhbm5lck5v ZGUncyByb2xsb2ZmRmFjdG9yIHNob3VsZCBiZSBjbGFtcGVkIHRvIFswLCAxXSBpbnRlcm5hbGx5 IHdoZW4gZGlzdGFuY2VNb2RlbCBpcyAibGluZWFyIgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1NjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCisKKyAgICAgICAgUmViYXNlbGluZSBXUFQgdGVzdHMgbm93IHRoYXQgbW9yZSBj aGVja3MgYXJlIHBhc3NpbmcuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVk aW8vdGhlLWF1ZGlvLWFwaS90aGUtcGFubmVybm9kZS1pbnRlcmZhY2UvcGFubmVyLXJvbGxvZmYt Y2xhbXBpbmctZXhwZWN0ZWQudHh0OgorCiAyMDIwLTA4LTE4ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CiAKICAgICAgICAgV2F2ZVNoYXBlck5vZGUuY3VydmUgc2V0dGVyIHNob3Vs ZCBjcmVhdGUgYSBjb3B5IG9mIHRoZSBpbnB1dCBhcnJheQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBp L3RoZS1wYW5uZXJub2RlLWludGVyZmFjZS9wYW5uZXItcm9sbG9mZi1jbGFtcGluZy1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1 ZGlvL3RoZS1hdWRpby1hcGkvdGhlLXBhbm5lcm5vZGUtaW50ZXJmYWNlL3Bhbm5lci1yb2xsb2Zm LWNsYW1waW5nLWV4cGVjdGVkLnR4dAppbmRleCAxNzMwNDRkZmZlNjVhNTUwYjM0ZTdhYzViMjcz NWQzZDFlYmJiMTU2Li41NmUxYmViNjE2OTFkYWNmYjFmNzdmOWEyNzgyNmM1MDMyOTA5NDhiIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dl YmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLXBhbm5lcm5vZGUtaW50ZXJmYWNlL3Bhbm5lci1yb2xs b2ZmLWNsYW1waW5nLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLXBhbm5lcm5vZGUt aW50ZXJmYWNlL3Bhbm5lci1yb2xsb2ZmLWNsYW1waW5nLWV4cGVjdGVkLnR4dApAQCAtMywxMyAr Myw3IEBAIFBBU1MgIyBBVURJVCBUQVNLIFJVTk5FUiBTVEFSVEVELgogUEFTUyBFeGVjdXRpbmcg ImxpbmVhci1jbGFtcC1oaWdoIiAKIFBBU1MgQXVkaXQgcmVwb3J0IAogUEFTUyA+IFtsaW5lYXIt Y2xhbXAtaGlnaF0gcm9sbG9mZkZhY3RvciBjbGFtcGluZyBmb3IgbGluZWFyIGRpc3RhbmNlIG1v ZGVsIAotRkFJTCBYIFBhbm5lciBkaXN0YW5jZU1vZGVsOiAibGluZWFyIiwgcm9sbG9mZkZhY3Rv cjogMiBleHBlY3RlZCB0byBiZSBlcXVhbCB0byB0aGUgYXJyYXkgWzAsMC4wMDI5NjAyOTM3ODY2 MDAyMzIsMC4wMDkxMTgxODUzNzg2MTEwODgsMC4wMTA2NDM1NjUwOTU5NjEwOTQsMC4wMTU3ODMx NTE2MTE2ODU3NTMsMC4wMTk5NzkyNTUyNzM5MzgxOCwwLjAyMjU4OTg0NTU4Mjg0MjgyNywwLjAy NzQ5Mzc5MzUxNzM1MTE1LDAuMDMxNzQwMDI0Njg1ODU5NjgsMC4wMzM2MzY1OTk3NzkxMjkwMyww LjA0MDM3NzkyNjA4MTQxODk5LDAuMDQxOTMyODAyNjQ3MzUyMjIsMC4wNDY0ODc1ODQ3MTAxMjEx NTUsMC4wNTE2MDkzMjI0Mjg3MDMzMSwwLjA1MzIxMzc2Mzk4MjA1NzU3LDAuMDU5MDM2MjEzOTA0 NjE5MjIuLi5dIGJ1dCBkaWZmZXJzIGluIDIwNDcgcGxhY2VzOgotCUluZGV4CUFjdHVhbAkJCUV4 cGVjdGVkCi0JWzFdCTUuOTIwNTg3MTEzOTA1NjM5OWUtNwkyLjk2MDI5Mzc4NjYwMDIzMjFlLTMK LQlbMl0JMS44MjM2MzcxNDg4NDU1OTE2ZS02CTkuMTE4MTg1Mzc4NjExMDg3OGUtMwotCVszXQky LjEyODcxMzA0OTM4NzQ0MjllLTYJMS4wNjQzNTY1MDk1OTYxMDk0ZS0yCi0JWzRdCTMuMTU2NjMw NTU1MTY3Nzk0MmUtNgkxLjU3ODMxNTE2MTE2ODU3NTNlLTIKLQkuLi5hbmQgMjA0MyBtb3JlIGVy cm9ycy4gYXNzZXJ0X3RydWU6IGV4cGVjdGVkIHRydWUgZ290IGZhbHNlCi1GQUlMIDwgW2xpbmVh ci1jbGFtcC1oaWdoXSAxIG91dCBvZiAxIGFzc2VydGlvbnMgd2VyZSBmYWlsZWQuIGFzc2VydF90 cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQotRkFJTCAjIEFVRElUIFRBU0sgUlVOTkVSIEZJ TklTSEVEOiAxIG91dCBvZiAxIHRhc2tzIHdlcmUgZmFpbGVkLiBhc3NlcnRfdHJ1ZTogZXhwZWN0 ZWQgdHJ1ZSBnb3QgZmFsc2UKK1BBU1MgICBQYW5uZXIgZGlzdGFuY2VNb2RlbDogImxpbmVhciIs IHJvbGxvZmZGYWN0b3I6IDIgaXMgaWRlbnRpY2FsIHRvIHRoZSBhcnJheSBbMCwwLjAwOTAxNzQ0 NDIxNTcxNDkzMSwwLjAyNjg1MzkwMDQwMjc4NDM0OCwwLjAzMjcxNDU3MTgwMzgwODIxLDAuMDQ3 MDg1OTYzMTg5NjAxOSwwLjA1ODQ4NDM1Njg1MDM4NTY2NiwwLjA3MTQ2NTE1Njk3MjQwODMsMC4w Nzc2Mzg3Mzc4NTczNDE3NywwLjA5ODY1NzMxMDAwOTAwMjY5LDAuMTAxMzYyODc2NTk0MDY2NjIs MC4xMTYzNjAwMzg1MTg5MDU2NCwwLjEzMjQwMTg2ODcwMDk4MTE0LDAuMTM1MTk4MTQ2MTA0ODEy NjIsMC4xNTM4Nzg1ODQ1MDQxMjc1LDAuMTY0NTE0MzAzMjA3Mzk3NDYsMC4xNzQ2Mjg0MDY3NjMw NzY3OC4uLl0uIAorUEFTUyA8IFtsaW5lYXItY2xhbXAtaGlnaF0gQWxsIGFzc2VydGlvbnMgcGFz c2VkLiAodG90YWwgMSBhc3NlcnRpb25zKSAKK1BBU1MgIyBBVURJVCBUQVNLIFJVTk5FUiBGSU5J U0hFRDogMSB0YXNrcyByYW4gc3VjY2Vzc2Z1bGx5LiAKIAo=