215418 2020-08-12 11:34:27 -0700 Add Copy WebKit Permalink items to Sublime Text command palette 2020-08-12 12:22:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189589 1 hi hi dbates hi joepeck keith_miller webkit-bug-importer oldest_to_newest 1679777 0 hi 2020-08-12 11:34:27 -0700 I use this all the time, and it would be nice to have a a way to invoke "Copy WebKit Permalink" without having to right-click :) 1679782 1 406466 hi 2020-08-12 11:37:08 -0700 Created attachment 406466 Patch 1679784 2 406466 keith_miller 2020-08-12 11:41:18 -0700 Comment on attachment 406466 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406466&action=review rs=me > Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-commands:3 > + { "caption": "Copy WebKit Permalink", "command": "copy_web_kit_permalink" }, > + { "caption": "Copy WebKit Permalink to Blame", "command": "copy_web_kit_permalink", "args": { "annotate_blame": true } }, What's with the underscores between web and kit? Don't we normally use one word even when not capitalizing? 1679788 3 406466 hi 2020-08-12 11:46:53 -0700 Comment on attachment 406466 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406466&action=review >> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-commands:3 >> + { "caption": "Copy WebKit Permalink to Blame", "command": "copy_web_kit_permalink", "args": { "annotate_blame": true } }, > > What's with the underscores between web and kit? Don't we normally use one word even when not capitalizing? I believe Sublime Text snakecases any `sublime_plugin.Command` using capital letters as delimiters. I don't know if it's possible to control over that. FWIW this is what `Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu` does too ¯\_(ツ)_/¯ 1679789 4 ews-feeder 2020-08-12 12:21:14 -0700 Committed r265557: <https://trac.webkit.org/changeset/265557> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406466. 1679790 5 webkit-bug-importer 2020-08-12 12:22:19 -0700 <rdar://problem/66925840> 406466 2020-08-12 11:37:08 -0700 2020-08-12 12:21:15 -0700 Patch bug-215418-20200812113707.patch text/plain 2733 hi ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmN2U2 NmI5YTg2Mjk4ZWY5Nzc1M2VhNDM3ZjBkYmU1ZTRiYTM2YTI2Li42ZWZiZThmNjgxZWZmMWI3ZjVk MDc4NjIxZDQ1YjVmNWY1Yjk1M2RiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDgtMTIgIERldmluIFJvdXNz byAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBDb3B5IFdlYktpdCBQZXJtYWxp bmsgaXRlbXMgdG8gU3VibGltZSBUZXh0IGNvbW1hbmQgcGFsZXR0ZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1NDE4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb3B5UGVybWFsaW5rL1N1YmxpbWUg VGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvbnRleHQuc3VibGltZS1jb21tYW5kczogQWRkZWQu CisgICAgICAgICogQ29weVBlcm1hbGluay9TdWJsaW1lIFRleHQvSU5TVEFMTDoKKwogMjAyMC0w OC0xMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAg ICAgIEVuYWJsZSBIVFRQLzIgcGluZyBBUEkgdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NvcHlQ ZXJtYWxpbmsvU3VibGltZSBUZXh0L0NvcHlXZWJLaXRQZXJtYWxpbmsvQ29udGV4dC5zdWJsaW1l LWNvbW1hbmRzIGIvVG9vbHMvQ29weVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBl cm1hbGluay9Db250ZXh0LnN1YmxpbWUtY29tbWFuZHMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzEwN2EyMjRjMjMw NzE4MjAwNjZiMDFlZWJmYmJhMjdlOGU3MGRlMwotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL0Nv cHlQZXJtYWxpbmsvU3VibGltZSBUZXh0L0NvcHlXZWJLaXRQZXJtYWxpbmsvQ29udGV4dC5zdWJs aW1lLWNvbW1hbmRzCQpAQCAtMCwwICsxLDQgQEAKK1sKKyAgICB7ICJjYXB0aW9uIjogIkNvcHkg V2ViS2l0IFBlcm1hbGluayIsICJjb21tYW5kIjogImNvcHlfd2ViX2tpdF9wZXJtYWxpbmsiIH0s CisgICAgeyAiY2FwdGlvbiI6ICJDb3B5IFdlYktpdCBQZXJtYWxpbmsgdG8gQmxhbWUiLCAiY29t bWFuZCI6ICJjb3B5X3dlYl9raXRfcGVybWFsaW5rIiwgImFyZ3MiOiB7ICJhbm5vdGF0ZV9ibGFt ZSI6IHRydWUgfSB9LAorXQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ29weVBlcm1hbGluay9TdWJsaW1l IFRleHQvSU5TVEFMTCBiL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBUZXh0L0lOU1RBTEwK aW5kZXggNDI3ZjFmZmI1NjViYzZiZGQ2NGI0MDdkODg1YzE5OTg3MTY1ODlkMy4uMTQ0MTFmYjBj NTYxODdkYzhhMGY3NDRmY2Q0NjQ1MjUzNzYzZTQxZSAxMDA2NDQKLS0tIGEvVG9vbHMvQ29weVBl cm1hbGluay9TdWJsaW1lIFRleHQvSU5TVEFMTAkKKysrIGIvVG9vbHMvQ29weVBlcm1hbGluay9T dWJsaW1lIFRleHQvSU5TVEFMTAkKQEAgLTIsMTIgKzIsMTQgQEAgQ29weSBXZWJLaXQgUGVybWFs aW5rIGlzIGEgU3VibGltZSBUZXh0IHBsdWdpbiB0aGF0IGNvcGllcyB0byB0aGUgQ2xpcGJvYXJk IGEgcGUKIAogPT0gSG93IHRvIGluc3RhbGwgPT0KIAotQ29weSB0aGUgZGlyZWN0b3J5IENvcHlX ZWJLaXRQZXJtYWxpbmsgKGxvY2F0ZWQgaW4gdGhlIHNhbWUgZGlyZWN0b3J5IGFzIHRoaXMgZmls ZSkgdG8geW91ciBQYWNrYWdlcyBkaXJlY3RvcnkuIE9uIE1hYywgeW91IGNhbiBvcGVuIHlvdXIg UGFja2FnZXMgZGlyZWN0b3J5IGJ5IGxhdW5jaGluZyBTdWJsaW1lIFRleHQgYW5kIGNob29zaW5n IFN1YmxpbWUgVGV4dCA+IFByZWZlcmVuY2VzID4gQnJvd3NlIFBhY2thZ2VzIGZyb20gdGhlIG1l bnUgYmFyLgorQ29weSAob3Igc3ltbGluay9zaG9ydGN1dCkgdGhlIGRpcmVjdG9yeSBDb3B5V2Vi S2l0UGVybWFsaW5rIChsb2NhdGVkIGluIHRoZSBzYW1lIGRpcmVjdG9yeSBhcyB0aGlzIGZpbGUp IHRvIHlvdXIgUGFja2FnZXMgZGlyZWN0b3J5LiBPbiBNYWMsIHlvdSBjYW4gb3BlbiB5b3VyIFBh Y2thZ2VzIGRpcmVjdG9yeSBieSBsYXVuY2hpbmcgU3VibGltZSBUZXh0IGFuZCBjaG9vc2luZyBT dWJsaW1lIFRleHQgPiBQcmVmZXJlbmNlcyA+IEJyb3dzZSBQYWNrYWdlcyBmcm9tIHRoZSBtZW51 IGJhci4KIAogPT0gSG93IHRvIHVzZSA9PQogCiBDb250cm9sLWNsaWNrIChvbiBNYWMpIG9yIHJp Z2h0LWNsaWNrIChvbiBMaW51eCBhbmQgV2luZG93cykgb24gYSBsaW5lIGFuZCBzZWxlY3QgQ29w eSBXZWJLaXQgUGVybWFsaW5rIG9yIENvcHkgV2ViS2l0IFBlcm1hbGluayB0byBCbGFtZSBmcm9t IHRoZSBjb250ZXh0IG1lbnUgdG8gY29weSB0byB0aGUgQ2xpcGJvYXJkIGEgcGVybWFuZW50IGh5 cGVybGluayB0byB0aGUgc2VsZWN0ZWQgbGluZSB3aXRob3V0IG9yIHdpdGggYmxhbWUgYW5ub3Rh dGlvbnMsIHJlc3BlY3RpdmVseS4KIAorQ29weSBXZWJLaXQgUGVybWFsaW5rIGFuZCBDb3B5IFdl YktpdCBQZXJtYWxpbmsgdG8gQmxhbWUgYXJlIGFsc28gYXZhaWxhYmxlIGFzIGFjdGlvbnMgaW4g dGhlIGNvbW1hbmQgcGFsZXR0ZS4KKwogPT0gS2V5IGJpbmRpbmdzIGZvciBNYWMgPT0KIAogV2l0 aG91dCBibGFtZSBhbm5vdGF0aW9uczogQ29tbWFuZCArIFNoaWZ0ICsgQ29udHJvbCArIEMK