<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>215394</bug_id>
          
          <creation_ts>2020-08-11 14:46:04 -0700</creation_ts>
          <short_desc>Address locking concerns and other review feedback from r265502</short_desc>
          <delta_ts>2020-08-11 15:05:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>214765</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kenneth Russell">kbr</reporter>
          <assigned_to name="Kenneth Russell">kbr</assigned_to>
          <cc>darin</cc>
    
    <cc>dino</cc>
    
    <cc>jdarpinian</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1679573</commentid>
    <comment_count>0</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-08-11 14:46:04 -0700</bug_when>
    <thetext>ysuzuki@ provided review feedback for Bug 214765 after the patch was landed which needs to be addressed.

The most significant concern is that locking is needed around some object traversals since GC marking can occur concurrently to the main thread. However, these objects represent a tree structure and it&apos;s not immediately clear how to organize such a lock.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1679589</commentid>
    <comment_count>1</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-08-11 15:05:16 -0700</bug_when>
    <thetext>Reverted the patch because of the potential for multithreading-related GC craghes. Will address this feedback in the parent bug.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>