215300 2020-08-07 16:26:24 -0700 Address additional review feedback from r265360 2020-08-14 16:27:40 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 183438 1 kbr kbr dino jdarpinian sabouhallawa webkit-bug-importer oldest_to_newest 1678810 0 kbr 2020-08-07 16:26:24 -0700 From Bug 183438: - Refactor copyPremultipliedToPremultiplied and copyUnpremultipliedToUnpremultiplied in Source/WebCore/platform/graphics/ImageBufferBackend.cpp . - Remove comment which was added in place of the previous assert in copyImagePixelsAccelerated in Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp . 1679246 1 sabouhallawa 2020-08-10 16:30:41 -0700 Also - The members: m_originClean, m_premultiplyAlpha and m_forciblyPremultiplyAlpha of ImageBitmap can be replaced by ImageBuffer::SerializationState. This will eliminate the need to sync the members of ImageBitmap and ImageBuffer::SerializationState. Also the whole struct can be copied in many places from std::pair<std::unique_ptr<ImageBuffer>, ImageBuffer::SerializationState> to ImageBitmap and vice versa. 1679758 2 sabouhallawa 2020-08-12 10:19:13 -0700 Another approach is to make SerializationState enum class type and have an OptionSet< SerializationState> be stored in ImageBitmap: enum class SerializationState { OriginClean = 1 << 0, PremultiplyAlpha = 1 << 1, ForciblyPremultiplyAlpha = 1 << 2, }; class ImageBitmap { public: bool originClean() const { return m_serializationState.contains(SerializationState::OriginClean); } private: OptionSet<SerializationState> m_serializationState; }; 1680515 3 webkit-bug-importer 2020-08-14 16:27:40 -0700 <rdar://problem/67105644>