<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>214763</bug_id>
          
          <creation_ts>2020-07-24 14:58:38 -0700</creation_ts>
          <short_desc>REGRESSION (r264845): webgl/2.0.0/conformance2/textures/misc/tex-unpack-params.html is failing</short_desc>
          <delta_ts>2020-07-24 15:57:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>ASSIGNED</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=126448</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>126448</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryan Haddad">ryanhaddad</reporter>
          <assigned_to name="Kenneth Russell">kbr</assigned_to>
          <cc>dino</cc>
    
    <cc>jdarpinian</cc>
    
    <cc>kbr</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1674853</commentid>
    <comment_count>0</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-07-24 14:58:38 -0700</bug_when>
    <thetext>webgl/2.0.0/conformance2/textures/misc/tex-unpack-params.html is failing after the rebaseline in https://trac.webkit.org/changeset/264845

https://results.webkit.org/?suite=layout-tests&amp;test=webgl%2F2.0.0%2Fconformance2%2Ftextures%2Fmisc%2Ftex-unpack-params.html

--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance2/textures/misc/tex-unpack-params-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance2/textures/misc/tex-unpack-params-actual.txt
@@ -1,5 +1,990 @@
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: ../../../resources/webgl_test_files/conformance2/textures/misc/tex-unpack-params.html
-[ PASS ] All tests passed
+[ 266: FAIL ] compare pixels: 32 pixels differ
+[ 340: FAIL ] compare pixels: 70 pixels differ
+[ 345: FAIL ] compare pixels: 12 pixels differ
+[ 363: FAIL ] compare pixels: 84 pixels differ
+[ 368: FAIL ] compare pixels: 20 pixels differ
+[ 386: FAIL ] compare pixels: 98 pixels differ
+[ 391: FAIL ] compare pixels: 15 pixels differ
+[ 409: FAIL ] compare pixels: 112 pixels differ
+[ 414: FAIL ] compare pixels: 24 pixels differ
+[ 765: FAIL ] compare pixels: 16 pixels differ
+[ 835: FAIL ] compare pixels: 70 pixels differ
+[ 840: FAIL ] compare pixels: 12 pixels differ
+[ 858: FAIL ] compare pixels: 84 pixels differ
+[ 863: FAIL ] compare pixels: 20 pixels differ
+[ 881: FAIL ] compare pixels: 49 pixels differ
+[ 904: FAIL ] compare pixels: 112 pixels differ</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674854</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-07-24 14:59:46 -0700</bug_when>
    <thetext>&lt;rdar://problem/66075979&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674855</commentid>
    <comment_count>2</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-07-24 15:00:06 -0700</bug_when>
    <thetext>I truncated the diff since it is quite long.. full one here: https://build.webkit.org/results/Apple-Catalina-Release-WK2-Tests/r264848%20(7369)/webgl/2.0.0/conformance2/textures/misc/tex-unpack-params-diff.txt</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674857</commentid>
    <comment_count>3</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-07-24 15:02:30 -0700</bug_when>
    <thetext>I suppose this is still a progression since there were 206 subtests failing before, now they are only 16.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674871</commentid>
    <comment_count>4</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-07-24 15:39:59 -0700</bug_when>
    <thetext>Sorry about the regression. I&apos;ll suppress the failure while investigating.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674872</commentid>
    <comment_count>5</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-07-24 15:40:37 -0700</bug_when>
    <thetext>BTW, this test passed on my MacBook Pro - that&apos;s where the rebaseline was done. Do you know how the failure made it through the commit queue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674874</commentid>
    <comment_count>6</comment_count>
      <attachid>405193</attachid>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-07-24 15:45:04 -0700</bug_when>
    <thetext>Created attachment 405193
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674877</commentid>
    <comment_count>7</comment_count>
      <attachid>405194</attachid>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-07-24 15:49:00 -0700</bug_when>
    <thetext>Created attachment 405194
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674878</commentid>
    <comment_count>8</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-07-24 15:52:02 -0700</bug_when>
    <thetext>(In reply to Kenneth Russell from comment #5)
&gt; BTW, this test passed on my MacBook Pro - that&apos;s where the rebaseline was
&gt; done. Do you know how the failure made it through the commit queue?
Maybe it is hardware dependent? The CQ runs on MacPro6,1 hardware and the post-commit testing is with MacMini8,1 (only integrated graphics).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674882</commentid>
    <comment_count>9</comment_count>
      <attachid>405194</attachid>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-07-24 15:53:33 -0700</bug_when>
    <thetext>Comment on attachment 405194
Patch

Clearing flags on attachment: 405194

Committed r264865: &lt;https://trac.webkit.org/changeset/264865&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674885</commentid>
    <comment_count>10</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-07-24 15:57:32 -0700</bug_when>
    <thetext>Yes, possible this test passes on discrete GPUs on macOS and not Intel integrated ones. It&apos;s also possible the test was revised after WebKit&apos;s snapshot was taken. I&apos;ll investigate.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405193</attachid>
            <date>2020-07-24 15:45:04 -0700</date>
            <delta_ts>2020-07-24 15:48:58 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214763-20200724154504.patch</filename>
            <type>text/plain</type>
            <size>1658</size>
            <attacher name="Kenneth Russell">kbr</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0ODYyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjQ4ODlhYmQ0MjllOWRkNGNmMGQ5
ZTgxMGJlNmVjZjJhMWQ2M2ZkNC4uNDQ0ODRhOWQwMDE4YThhMDFlYWRmNzQ5NjYwZGIxYWRlZDE2
MzI0ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3LTI0ICBLZW5uZXRoIFJ1c3NlbGwg
IDxrYnJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNjQ4NDUpOiB3ZWJn
bC8yLjAuMC9jb25mb3JtYW5jZTIvdGV4dHVyZXMvbWlzYy90ZXgtdW5wYWNrLXBhcmFtcy5odG1s
IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIxNDc2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIFRoaXMgdGVzdCdzIGZhaWxpbmcgYSBmZXcgY2FzZXMgb24gc29tZSBoYXJkd2FyZSAtIHRo
ZSBNYWNNaW5pOCwxCisgICAgICAgIGJvdHMgc3BlY2lmaWNhbGx5LiBNYXJrIGl0IFsgUGFzcyBG
YWlsdXJlIF0gdW50aWwgdGhpcyBjYW4gYmUKKyAgICAgICAgaW52ZXN0aWdhdGVkLgorCisgICAg
ICAgICogVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMC0wNy0yNCAgUnlhbiBIYWRkYWQgIDxyeWFu
aGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1MgV0sxXSBpbXBvcnRlZC93M2Mvd2Vi
LXBsYXRmb3JtLXRlc3RzL3N2Zy9wYXRoL2Rpc3RhbmNlL3BhdGhsZW5ndGgtcGF0aC1tdXRhdGlu
Zy5zdmcgaXMgYSBmbGFreSBmYWlsdXJlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhw
ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA0MGJhMGFkYTRk
OWFhNTdiODdiMzkxMTRlNGNjZmE1MTc4OGVhNGE2Li43N2RhNTAzZjU0MmIxOTRkOGNhMmZhZTI4
NDc5Yzc2ZmYxY2U3NjU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25z
CisrKyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTMzNzEsNiArMzM3MSw5IEBA
IHdlYmdsLzIuMC4wL2NvbmZvcm1hbmNlL3JlbmRlcmluZy9jbGlwcGluZy13aWRlLXBvaW50cy5o
dG1sIFsgUGFzcyBGYWlsdXJlIF0KIHdlYmdsLzIuMC4wL2NvbmZvcm1hbmNlMi9yZW5kZXJpbmcv
Y2xpcHBpbmctd2lkZS1wb2ludHMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJnbC8yLjAuMC9j
b25mb3JtYW5jZTIvdGV4dHVyZXMvbWlzYy90ZXgtM2Qtc2l6ZS1saW1pdC5odG1sIFsgUGFzcyBG
YWlsdXJlIF0KIAorIyB3ZWJraXQub3JnL2IvMjE0NzYzIHJlZ3Jlc3Npb24gb24gc29tZSBoYXJk
d2FyZQord2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UyL3RleHR1cmVzL21pc2MvdGV4LXVucGFjay1w
YXJhbXMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCisKICMgV2ViR0wgMiBUby1iZS1pbXBsZW1lbnRl
ZCBmbGFreSB0ZXN0cwogd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UyL3JlbmRlcmJ1ZmZlcnMvbXVs
dGlzYW1wbGVkLXJlbmRlcmJ1ZmZlci1pbml0aWFsaXphdGlvbi5odG1sIFsgUGFzcyBGYWlsdXJl
IF0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405194</attachid>
            <date>2020-07-24 15:49:00 -0700</date>
            <delta_ts>2020-07-24 15:49:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214763-20200724154859.patch</filename>
            <type>text/plain</type>
            <size>1657</size>
            <attacher name="Kenneth Russell">kbr</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0ODYyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjQ4ODlhYmQ0MjllOWRkNGNmMGQ5
ZTgxMGJlNmVjZjJhMWQ2M2ZkNC4uZmM2YWUwNGZlYTMzMmQzOTY1M2QxZjU0NGU3ZGEyYzM4OGUz
MTNhOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3LTI0ICBLZW5uZXRoIFJ1c3NlbGwg
IDxrYnJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNjQ4NDUpOiB3ZWJn
bC8yLjAuMC9jb25mb3JtYW5jZTIvdGV4dHVyZXMvbWlzYy90ZXgtdW5wYWNrLXBhcmFtcy5odG1s
IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIxNDc2MworCisgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcuCisKKyAgICAg
ICAgVGhpcyB0ZXN0J3MgZmFpbGluZyBhIGZldyBjYXNlcyBvbiBzb21lIGhhcmR3YXJlIC0gdGhl
IE1hY01pbmk4LDEKKyAgICAgICAgYm90cyBzcGVjaWZpY2FsbHkuIE1hcmsgaXQgWyBQYXNzIEZh
aWx1cmUgXSB1bnRpbCB0aGlzIGNhbiBiZQorICAgICAgICBpbnZlc3RpZ2F0ZWQuCisKKyAgICAg
ICAgKiBUZXN0RXhwZWN0YXRpb25zOgorCiAyMDIwLTA3LTI0ICBSeWFuIEhhZGRhZCAgPHJ5YW5o
YWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPUyBXSzFdIGltcG9ydGVkL3czYy93ZWIt
cGxhdGZvcm0tdGVzdHMvc3ZnL3BhdGgvZGlzdGFuY2UvcGF0aGxlbmd0aC1wYXRoLW11dGF0aW5n
LnN2ZyBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBl
Y3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDQwYmEwYWRhNGQ5
YWE1N2I4N2IzOTExNGU0Y2NmYTUxNzg4ZWE0YTYuLjc3ZGE1MDNmNTQyYjE5NGQ4Y2EyZmFlMjg0
NzljNzZmZjFjZTc2NTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMK
KysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzM3MSw2ICszMzcxLDkgQEAg
d2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UvcmVuZGVyaW5nL2NsaXBwaW5nLXdpZGUtcG9pbnRzLmh0
bWwgWyBQYXNzIEZhaWx1cmUgXQogd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UyL3JlbmRlcmluZy9j
bGlwcGluZy13aWRlLXBvaW50cy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIHdlYmdsLzIuMC4wL2Nv
bmZvcm1hbmNlMi90ZXh0dXJlcy9taXNjL3RleC0zZC1zaXplLWxpbWl0Lmh0bWwgWyBQYXNzIEZh
aWx1cmUgXQogCisjIHdlYmtpdC5vcmcvYi8yMTQ3NjMgcmVncmVzc2lvbiBvbiBzb21lIGhhcmR3
YXJlCit3ZWJnbC8yLjAuMC9jb25mb3JtYW5jZTIvdGV4dHVyZXMvbWlzYy90ZXgtdW5wYWNrLXBh
cmFtcy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KKwogIyBXZWJHTCAyIFRvLWJlLWltcGxlbWVudGVk
IGZsYWt5IHRlc3RzCiB3ZWJnbC8yLjAuMC9jb25mb3JtYW5jZTIvcmVuZGVyYnVmZmVycy9tdWx0
aXNhbXBsZWQtcmVuZGVyYnVmZmVyLWluaXRpYWxpemF0aW9uLmh0bWwgWyBQYXNzIEZhaWx1cmUg
XQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>