214676 2020-07-23 01:09:52 -0700 [JSC] Do not use hardened Array for Intl supportedLocalesOf 2020-07-24 08:50:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 213425 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam ticaiolima tzagallo webkit-bug-importer oldest_to_newest 1674132 0 ysuzuki 2020-07-23 01:09:52 -0700 https://github.com/tc39/ecma402/pull/278 1674134 1 405023 ysuzuki 2020-07-23 01:41:41 -0700 Created attachment 405023 Patch 1674180 2 405023 ticaiolima 2020-07-23 05:36:57 -0700 Comment on attachment 405023 Patch Informal r+. This patch LGTM, but I have one question regarding Test262. Is this making some Test262 cases pass? If so, is it possible to update test expectations? 1674195 3 405023 mark.lam 2020-07-23 06:30:42 -0700 Comment on attachment 405023 Patch r=me 1674547 4 ysuzuki 2020-07-23 22:04:30 -0700 (In reply to Caio Lima from comment #2) > Comment on attachment 405023 [details] > Patch > > Informal r+. This patch LGTM, but I have one question regarding Test262. Is > this making some Test262 cases pass? If so, is it possible to update test > expectations? Because https://trac.webkit.org/changeset/260349/webkit changed observable part, this does not affect on test262. This eliminates non observable but time-consuming + meaningless code. 1674659 5 ews-feeder 2020-07-24 08:49:55 -0700 Committed r264827: <https://trac.webkit.org/changeset/264827> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405023. 1674661 6 webkit-bug-importer 2020-07-24 08:50:46 -0700 <rdar://problem/66055863> 405023 2020-07-23 01:41:41 -0700 2020-07-24 08:49:55 -0700 Patch bug-214676-20200723014140.patch text/plain 4885 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NDZkN2FmNWUwMjg5MmIyOGI5M2U4MzQ3NTQzNDBiOTNiYzMyNzlhLi4wMWQ4YzQyMzhmYTMyZTNm ZWUzMTFiODllNGQ2ZDFhYWM2YjY2ZThhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNy0yMyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIERvIG5vdCB1c2UgaGFyZGVuZWQgQXJyYXkgZm9yIEludGwgc3Vw cG9ydGVkTG9jYWxlc09mCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTQ2NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXZSBkbyBub3QgbmVlZCB0byBjYWxsIGdldE93blByb3BlcnR5TmFtZXMgJiBkZWZp bmVPd25Qcm9wZXJ0eSBiZWNhdXNlIGhhcmRlbmluZyBhcnJheSBvZiBJbnRsLlhYWC5zdXBwb3J0 ZWRMb2NhbGVzT2YgaXMgcmVtb3ZlZCBmcm9tIHRoZSBzcGVjLgorICAgICAgICBXZSBzaG91bGQg anVzdCByZXR1cm4gYW4gYXJyYXkgZnJvbSBiZXN0Rml0U3VwcG9ydGVkTG9jYWxlcyBvciBsb29r dXBTdXBwb3J0ZWRMb2NhbGVzLCB3aGlsZSB0aGlzIGNoYW5nZSBpcyBub3Qgb2JzZXJ2YWJsZSB0 byB1c2VycyAoYnV0IGl0IGlzIGJldHRlcgorICAgICAgICBmb3IgcGVyZm9ybWFuY2UpLiBUaGlz IGZ1bGx5IGZpeGVzIGh0dHBzOi8vZ2l0aHViLmNvbS90YzM5L2VjbWE0MDIvcHVsbC8yNzguCisK KyAgICAgICAgKiBydW50aW1lL0ludGxPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpzdXBwb3J0 ZWRMb2NhbGVzKToKKwogMjAyMC0wNy0yMyAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBn bWFpbC5jb20+CiAKICAgICAgICAgUmVtb3ZlIGVtaXRJc1VuZGVmaW5lZCgpIGZyb20gQ2xhc3NF eHByTm9kZTo6ZW1pdEJ5dGVjb2RlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0ludGxPYmplY3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SW50bE9iamVjdC5jcHAKaW5kZXggYjJkNWNiODRjODMyYzYyZTZjNDVmMGZjZDRmN2ZkODg0ODA2 YWJkYy4uYzVhNjA4OTk4YjY2MDY5NGYyY2E4YzBhMjM3YzZkZjUzMGIwYmY1OCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bE9iamVjdC5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bE9iamVjdC5jcHAKQEAgLTc3MSwyNiArNzcx LDkgQEAgSlNWYWx1ZSBzdXBwb3J0ZWRMb2NhbGVzKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmpl Y3QsIGNvbnN0IEhhc2hTZXQ8U3RyaW5nPiYgYXYKICAgICBMb2NhbGVNYXRjaGVyIGxvY2FsZU1h dGNoZXIgPSBpbnRsT3B0aW9uPExvY2FsZU1hdGNoZXI+KGdsb2JhbE9iamVjdCwgb3B0aW9ucywg dm0ucHJvcGVydHlOYW1lcy0+bG9jYWxlTWF0Y2hlciwgeyB7ICJsb29rdXAiX3MsIExvY2FsZU1h dGNoZXI6Okxvb2t1cCB9LCB7ICJiZXN0IGZpdCJfcywgTG9jYWxlTWF0Y2hlcjo6QmVzdEZpdCB9 IH0sICJsb2NhbGVNYXRjaGVyIG11c3QgYmUgZWl0aGVyIFwibG9va3VwXCIgb3IgXCJiZXN0IGZp dFwiIl9zLCBMb2NhbGVNYXRjaGVyOjpCZXN0Rml0KTsKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9O KHNjb3BlLCBKU1ZhbHVlKCkpOwogCi0gICAgSlNBcnJheSogc3VwcG9ydGVkTG9jYWxlcyA9IGxv Y2FsZU1hdGNoZXIgPT0gTG9jYWxlTWF0Y2hlcjo6QmVzdEZpdAotICAgICAgICA/IGJlc3RGaXRT dXBwb3J0ZWRMb2NhbGVzKGdsb2JhbE9iamVjdCwgYXZhaWxhYmxlTG9jYWxlcywgcmVxdWVzdGVk TG9jYWxlcykKLSAgICAgICAgOiBsb29rdXBTdXBwb3J0ZWRMb2NhbGVzKGdsb2JhbE9iamVjdCwg YXZhaWxhYmxlTG9jYWxlcywgcmVxdWVzdGVkTG9jYWxlcyk7Ci0gICAgUkVUVVJOX0lGX0VYQ0VQ VElPTihzY29wZSwgSlNWYWx1ZSgpKTsKLQotICAgIFByb3BlcnR5TmFtZUFycmF5IGtleXModm0s IFByb3BlcnR5TmFtZU1vZGU6OlN0cmluZ3MsIFByaXZhdGVTeW1ib2xNb2RlOjpFeGNsdWRlKTsK LSAgICBzdXBwb3J0ZWRMb2NhbGVzLT5nZXRPd25Qcm9wZXJ0eU5hbWVzKHN1cHBvcnRlZExvY2Fs ZXMsIGdsb2JhbE9iamVjdCwga2V5cywgRW51bWVyYXRpb25Nb2RlKCkpOwotICAgIFJFVFVSTl9J Rl9FWENFUFRJT04oc2NvcGUsIEpTVmFsdWUoKSk7Ci0KLSAgICBQcm9wZXJ0eURlc2NyaXB0b3Ig ZGVzYzsKLQotICAgIHNpemVfdCBsZW4gPSBrZXlzLnNpemUoKTsKLSAgICBmb3IgKHNpemVfdCBp ID0gMDsgaSA8IGxlbjsgKytpKSB7Ci0gICAgICAgIHN1cHBvcnRlZExvY2FsZXMtPmRlZmluZU93 blByb3BlcnR5KHN1cHBvcnRlZExvY2FsZXMsIGdsb2JhbE9iamVjdCwga2V5c1tpXSwgZGVzYywg dHJ1ZSk7Ci0gICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIEpTVmFsdWUoKSk7Ci0g ICAgfQotICAgIHN1cHBvcnRlZExvY2FsZXMtPmRlZmluZU93blByb3BlcnR5KHN1cHBvcnRlZExv Y2FsZXMsIGdsb2JhbE9iamVjdCwgdm0ucHJvcGVydHlOYW1lcy0+bGVuZ3RoLCBkZXNjLCB0cnVl KTsKLSAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBKU1ZhbHVlKCkpOwotCi0gICAgcmV0 dXJuIHN1cHBvcnRlZExvY2FsZXM7CisgICAgaWYgKGxvY2FsZU1hdGNoZXIgPT0gTG9jYWxlTWF0 Y2hlcjo6QmVzdEZpdCkKKyAgICAgICAgUkVMRUFTRV9BTkRfUkVUVVJOKHNjb3BlLCBiZXN0Rml0 U3VwcG9ydGVkTG9jYWxlcyhnbG9iYWxPYmplY3QsIGF2YWlsYWJsZUxvY2FsZXMsIHJlcXVlc3Rl ZExvY2FsZXMpKTsKKyAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2NvcGUsIGxvb2t1cFN1cHBvcnRl ZExvY2FsZXMoZ2xvYmFsT2JqZWN0LCBhdmFpbGFibGVMb2NhbGVzLCByZXF1ZXN0ZWRMb2NhbGVz KSk7CiB9CiAKIFZlY3RvcjxTdHJpbmc+IG51bWJlcmluZ1N5c3RlbXNGb3JMb2NhbGUoY29uc3Qg U3RyaW5nJiBsb2NhbGUpCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMv Q2hhbmdlTG9nCmluZGV4IDEyMzVlMTY3ZjI5OTNmZmJmYTFlY2MyNGRhOTViMzQ1MGNkYWQxNDYu LjViYmJhODllMDVlNzg3YzQ5MzFmNWU0NDBjYTA2Yjk4YjA0ZjRiN2EgMTAwNjQ0Ci0tLSBhL0pT VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMjAtMDctMjMgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAg ICBbSlNDXSBEbyBub3QgdXNlIGhhcmRlbmVkIEFycmF5IGZvciBJbnRsIHN1cHBvcnRlZExvY2Fs ZXNPZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0 Njc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBz dHJlc3MvaW50bC1zdXBwb3JlZC1sb2NhbGVzLW9mLmpzOiBBZGRlZC4KKyAgICAgICAgKHNob3Vs ZEJlKToKKwogMjAyMC0wNy0yMiAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFuZ2Vsb3NAaWdh bGlhLmNvbT4KIAogICAgICAgICBTa2lwIGZhaWxpbmcgaW50bCB0ZXN0cyBvbiBBUk0KZGlmZiAt LWdpdCBhL0pTVGVzdHMvc3RyZXNzL2ludGwtc3VwcG9yZWQtbG9jYWxlcy1vZi5qcyBiL0pTVGVz dHMvc3RyZXNzL2ludGwtc3VwcG9yZWQtbG9jYWxlcy1vZi5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jMGNlMTky ZTU2NWM5OGVmZDk0YjZkODc0Zjg1Y2MyOGNjMDBiMGE2Ci0tLSAvZGV2L251bGwKKysrIGIvSlNU ZXN0cy9zdHJlc3MvaW50bC1zdXBwb3JlZC1sb2NhbGVzLW9mLmpzCkBAIC0wLDAgKzEsMjYgQEAK Ky8vQCBydW5EZWZhdWx0KCItLXVzZUludGxEaXNwbGF5TmFtZXM9MSIpCitmdW5jdGlvbiBzaG91 bGRCZShhY3R1YWwsIGV4cGVjdGVkKSB7CisgICAgaWYgKGFjdHVhbCAhPT0gZXhwZWN0ZWQpCisg ICAgICAgIHRocm93IG5ldyBFcnJvcignYmFkIHZhbHVlOiAnICsgYWN0dWFsKTsKK30KKworbGV0 IGNvbnN0cnVjdG9ycyA9IFsKKyAgICBJbnRsLkNvbGxhdG9yLAorICAgIEludGwuRGF0ZVRpbWVG b3JtYXQsCisgICAgSW50bC5EaXNwbGF5TmFtZXMsCisgICAgSW50bC5OdW1iZXJGb3JtYXQsCisg ICAgSW50bC5QbHVyYWxSdWxlcywKKyAgICBJbnRsLlJlbGF0aXZlVGltZUZvcm1hdCwKK107CisK K2ZvciAobGV0IGNvbnN0cnVjdG9yIG9mIGNvbnN0cnVjdG9ycykgeworICAgIGxldCBhcnJheSA9 IGNvbnN0cnVjdG9yLnN1cHBvcnRlZExvY2FsZXNPZigiZW4iKTsKKyAgICBmb3IgKGxldCBpbmRl eCA9IDA7IGluZGV4IDwgYXJyYXkubGVuZ3RoOyArK2luZGV4KSB7CisgICAgICAgIGxldCBkZXNj cmlwdG9yID0gUmVmbGVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoYXJyYXksIGluZGV4KTsK KyAgICAgICAgc2hvdWxkQmUoZGVzY3JpcHRvci53cml0YWJsZSwgdHJ1ZSk7CisgICAgICAgIHNo b3VsZEJlKGRlc2NyaXB0b3IuY29uZmlndXJhYmxlLCB0cnVlKTsKKyAgICB9CisgICAgbGV0IGRl c2NyaXB0b3IgPSBSZWZsZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihhcnJheSwgImxlbmd0 aCIpOworICAgIHNob3VsZEJlKGRlc2NyaXB0b3Iud3JpdGFibGUsIHRydWUpOworICAgIHNob3Vs ZEJlKGRlc2NyaXB0b3IuY29uZmlndXJhYmxlLCBmYWxzZSk7Cit9Cg==