214660 2020-07-22 15:07:52 -0700 markContextChangedAndNotifyCanvasObserver and markContextChanged over-notify 2020-07-29 15:08:37 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 126447 126448 212461 1 kbr webkit-unassigned dino jdarpinian webkit-bug-importer oldest_to_newest 1673999 0 kbr 2020-07-22 15:07:52 -0700 WebGLRenderingContextBase::markContextChanged and WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver dispatch too many notifications: - markContextChangedAndNotifyCanvasObserver doesn't take into account whether a user-level framebuffer is bound. If one is, then it shouldn't notify. - markContextChanged calls "htmlCanvas()->clearCopiedImage()" and "renderBox->contentChanged(CanvasPixelsChanged)" for every draw call - this seems expensive. dino@ indicated in discussion on Slack that with the addition of WebGLRenderingContextBase::prepareForDisplay in Bug 212461, at least some of these notifications can be done once per frame, at the end of the frame, rather than on each operation that might touch the WebGL back buffer. 1674000 1 kbr 2020-07-22 15:08:57 -0700 Noticed this while fixing Bug 126447 and Bug 126448. 1676163 2 webkit-bug-importer 2020-07-29 15:08:37 -0700 <rdar://problem/66294753>