<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>214485</bug_id>
          
          <creation_ts>2020-07-17 10:36:13 -0700</creation_ts>
          <short_desc>webkit-patch fails to land big patches</short_desc>
          <delta_ts>2021-03-17 11:17:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=214414</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=213927</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=223269</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ddkilzer</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1672540</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2020-07-17 10:36:13 -0700</bug_when>
    <thetext>Trying to manually land the patch from bug 214414 failed with:

$ Tools/Scripts/webkit-patch land -g HEAD
Logging in as clopez@igalia.com...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=214414&amp;ctype=xml&amp;excludefield=attachmentdata
Guessing &quot;Chris Dumez&quot; as reviewer from attachment 404571 on bug 214414.
Total errors found: 0 in 6 files
COMMIT FAILED: [Errno 7] Argument list too long
Traceback (most recent call last):
  File &quot;Tools/Scripts/webkit-patch&quot;, line 80, in &lt;module&gt;
    main()
  File &quot;Tools/Scripts/webkit-patch&quot;, line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File &quot;/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py&quot;, line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File &quot;/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py&quot;, line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File &quot;/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py&quot;, line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File &quot;/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py&quot;, line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File &quot;/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py&quot;, line 67, in _run
    step(tool, options).run(state)
  File &quot;/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/steps/commit.py&quot;, line 89, in run
    svn_revision = scm.svn_revision_from_commit_text(commit_text)
  File &quot;/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py&quot;, line 106, in svn_revision_from_commit_text
    return match.group(&apos;svn_revision&apos;)
AttributeError: &apos;NoneType&apos; object has no attribute &apos;group&apos;


This is likely caused because we are passing two many arguments to execve and causing an -E2BIG error.

I tried setting &quot;ulimit -s unlimited&quot; but didn&apos;t helped.

Linux has a hard 6MB limit on the arg stack size since https://lore.kernel.org/patchwork/patch/807670/ ... perhaps its related.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674742</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-07-24 10:37:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/66061605&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>