<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>214434</bug_id>
          
          <creation_ts>2020-07-16 17:15:14 -0700</creation_ts>
          <short_desc>should be able to send keyboard events to `&lt;input readonly&gt;` with a software keyboard</short_desc>
          <delta_ts>2020-07-21 10:57:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=199587</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=209380</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Devin Rousso">hi</reporter>
          <assigned_to name="Devin Rousso">hi</assigned_to>
          <cc>ap</cc>
    
    <cc>dbates</cc>
    
    <cc>hi</cc>
    
    <cc>megan_gardner</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1672306</commentid>
    <comment_count>0</comment_count>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-07-16 17:15:14 -0700</bug_when>
    <thetext>`readonly` only means that the `value` is *not* modified when attempting to the edit the `&lt;input&gt;`.  `KeyboardEvent` can still be dispatched from an `&lt;input readonly&gt;`, and it can also be focusable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672307</commentid>
    <comment_count>1</comment_count>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-07-16 17:15:31 -0700</bug_when>
    <thetext>&lt;rdar://problem/65017950&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672309</commentid>
    <comment_count>2</comment_count>
      <attachid>404499</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-07-16 17:17:26 -0700</bug_when>
    <thetext>Created attachment 404499
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672342</commentid>
    <comment_count>3</comment_count>
      <attachid>404507</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-07-16 18:14:45 -0700</bug_when>
    <thetext>Created attachment 404507
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672393</commentid>
    <comment_count>4</comment_count>
      <attachid>404507</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2020-07-16 21:26:12 -0700</bug_when>
    <thetext>Comment on attachment 404507
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404507&amp;action=review

Quick glance...Is it a good user experience on iPhone (but to a lesser extent iPad and whatever else) to show the software keyboard for a readonly, even though typing will 99% of the time do nothing? Could this cause confusion? More bug reports?

&gt; Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-1938
&gt; -    if (_focusedElementInformation.isReadOnly)

This is ok as-is. The optimal solution also:

1. Patches equivalent code in Legacy WebKit for consistency

&gt; Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-5211
&gt; -        completionHandler(isFocused &amp;&amp; isEditable ? strongSelf.get() : nil);

This is ok as-is. The optimal solution does:

1. patches -requesrTextInputContexts **code path** because:
    A. Now it is **asymmetric**: this allows read only, but -request does not.
2. Patches up -focus equivalents in legacy WebKit for consistency
3. Adds a unit test for this change..grep unit tests for existing files</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1673494</commentid>
    <comment_count>5</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2020-07-21 10:34:38 -0700</bug_when>
    <thetext>Hi Devin,

After thinking about this bug some more I think it is best addressed as an evangelism issue because:
    1. shopmini is purposely making the text field readonly and registering a click event handler to make it writable.
    2. Because of (1) the field is **not** tab focusable on Mac and iOS: a click or tap is always required to actually
    type into the field.
        a. Actually this behavior effects every browser and platform though I didn&apos;t check if the same content is served.
    3. Because of (2) the page is less accessible to people with disabilites.
    4. Quick grep for &quot;readonly&quot; and variations found radars of I hope now fixed regressions from people that asked that
    WebKit should **not** show the keyboard for readonly controls.

Second (optional) thing to do is to add a quirk for shopmini. Evangelism and quirk are a better solutions because:
    A. (1) is such a non-standard thing to do
    B. There are years of precedent for adding site-specific quirks to address things like (1).

I talked with Morgan Winer about this bug and to look at things another way, the reasons that showing a keyboard for a readonly field are less optimal are because:
    I. It leads to a broken user experience on 99% of sites that use readonly: people would likely expect that the field is editable and either
        i. Not understand why the keyboard is up without a blinking caret.
        ii. Not understand why none of the keyboard inputs are doing anything.
    II. Because of (I) this can lead to more reported bugs.

What&apos;s the quirk?

Make -focusTextInputContext simulate what happens when a person clicks the field.

I am going to re-purpose all 1, 2, 3, A, B, etc etc below because I ran out of easily typed alphabets...haha.

The optimal solution does this like so:

    1. Add a new setting that is disabled by default (and that will only be enabled in layout tests or API tests) because:
        A. This will allow tests to be written to ensure the quirk works and does not regress.
    2. Add a quirk to Quirks.cpp that returns true if (1) OR if the document&apos;s URL&apos;s host is shopmini or subdomain of it.
        A. My strong opinion, weakly held is that the quirk can be applied to all documents, not just the top document, because doing so will fix this site even if framed.

To see an example of a patch that does ^^^ see the patch on bug #199587.

    3. Page::editableElementsInRect&apos;s rootEditableElement lambda needs to be patched to collect readonly form controls (not just &lt;input&gt;s) when setting is enabled. That&apos;s the optimal solution because:
        A. A tiny bit defensive in case this site uses similar behavior for &lt;textarea&gt;s.
        B. Future proofs this quirk should it turn out it needs to be applied to other web sites that might also apply behavior to &lt;textarea&gt;s.

    4. Patch RenderBlock::paintObject&apos;s EventRegion code to add the text control to the region if readonly and the setting is enabled. This is needed because:
        A. EventRegion is the perf optimization used to allow the UI process to quickly know anything is editable without having to message the web process
        to know nothing is hit.
        A. Because of (A) it avoids -requestTextInputContexts from bailing because it thinks there are no editable fields on the page.

To see an example for how to write a test for (4) see LayoutTests/editing/editable-region

    5. Patch WebPage::focusTextInputContextAndPlaceCaret so that when setting in (1) is enabled it dispatches an event named mousedown BEFORE target is focused and dispatch mouseup and click named events BEFORE computing the editable postion (the latter because A) the event handler could adjust the element bounds and move it and B) it future proofs the code to more gracefully handle if (A) happens, which I am not going to talk about right now because this text is getting long).

To see an example of ^^^ see the patch on bug #209380. ^^^ can be tested using API tests. To see an example of this see the tests in RequestTextInputContext.mm grep for focusText

    6. Patch up -_elementDidFocus: to update focusedElementInformation.isReadOnly if the elementType and interactionRect are idenitical (grep for the FIXME: We should remove this check). Optimal solution calls -elementDidBlur if field BECOMES readonly to clear focused element state in ui process and most importantly hide the keyboard.
        A. Optimal solution adds tests just for ^^^^.
        B. Also can do ^^^ if field BECOMES disabled as well as I don&apos;t think web process sends -elementDidBlur...

    7. Add tests for (1) - (6).
    8. Patch up equivalent code in Legacy WebKit that does (5) and (6).</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>404499</attachid>
            <date>2020-07-16 17:17:26 -0700</date>
            <delta_ts>2020-07-16 18:14:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214434-20200716171725.patch</filename>
            <type>text/plain</type>
            <size>6497</size>
            <attacher name="Devin Rousso">hi</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cKaW5kZXggMmJmYTU5YmJlMjRhNTcwMWUyYzAxZGNkMDZmNDNmYjg1NGY2MmIyOC4uYzRk
NjIxYTkwNTBkOTI3MWNlNTRhZGRlNTlkZDM0MWVkYTUxZGE1YiAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwyMyBAQAorMjAyMC0wNy0xNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK
KyAgICAgICAgc2hvdWxkIGJlIGFibGUgdG8gc2VuZCBrZXlib2FyZCBldmVudHMgdG8gYDxpbnB1
dCByZWFkb25seT5gIHdpdGggYSBzb2Z0d2FyZSBrZXlib2FyZAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0NDM0CisgICAgICAgIDxyZGFyOi8vcHJv
YmxlbS82NTAxNzk1MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAg
ICAgICAoLVtXS0NvbnRlbnRWaWV3IF9zaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSUlnbm9y
aW5nSW5wdXRNb2RlXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2ZvY3VzVGV4dElucHV0
Q29udGV4dDpwbGFjZUNhcmV0QXQ6Y29tcGxldGlvbkhhbmRsZXI6XSk6CisKKyAgICAgICAgKiBT
aGFyZWQvRm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5oOgorICAgICAgICAqIFNoYXJlZC9Gb2N1
c2VkRWxlbWVudEluZm9ybWF0aW9uLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Rm9jdXNlZEVsZW1l
bnRJbmZvcm1hdGlvbjo6ZW5jb2RlIGNvbnN0KToKKyAgICAgICAgKFdlYktpdDo6Rm9jdXNlZEVs
ZW1lbnRJbmZvcm1hdGlvbjo6ZGVjb2RlKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv
aW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmdldEZvY3VzZWRF
bGVtZW50SW5mb3JtYXRpb24pOgorICAgICAgICBSZW1vdmUgYGlzUmVhZE9ubHlgIGFzIGl0J3Mg
bm8gbG9uZ2VyIHVzZWQuCisKIDIwMjAtMDctMTUgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5A
YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydCBwYXJ0IG9mIHIyNjQzODUu
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Gb2N1c2VkRWxlbWVudEluZm9ybWF0
aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24u
Y3BwCmluZGV4IDI0N2VhYWI5NTZmYzkzNWE2YjNjNTBlMTZkNmE1NTBkOWUxYTQ0ZWYuLjA5NDY1
NzA0ZTMxZTI0NmRkYWMyYzY2YTkwMWY4Y2QwNGE2YThiNTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJLaXQvU2hhcmVkL0ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24uY3BwCisrKyBiL1NvdXJjZS9X
ZWJLaXQvU2hhcmVkL0ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24uY3BwCkBAIC04NCw3ICs4NCw2
IEBAIHZvaWQgRm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbjo6ZW5jb2RlKElQQzo6RW5jb2RlciYg
ZW5jb2RlcikgY29uc3QKICAgICBlbmNvZGVyIDw8IHNlbGVjdE9wdGlvbnM7CiAgICAgZW5jb2Rl
ciA8PCBzZWxlY3RlZEluZGV4OwogICAgIGVuY29kZXIgPDwgaXNNdWx0aVNlbGVjdDsKLSAgICBl
bmNvZGVyIDw8IGlzUmVhZE9ubHk7CiAgICAgZW5jb2RlciA8PCBhbGxvd3NVc2VyU2NhbGluZzsK
ICAgICBlbmNvZGVyIDw8IGFsbG93c1VzZXJTY2FsaW5nSWdub3JpbmdBbHdheXNTY2FsYWJsZTsK
ICAgICBlbmNvZGVyIDw8IGluc2lkZUZpeGVkUG9zaXRpb247CkBAIC0xNzgsOSArMTc3LDYgQEAg
Ym9vbCBGb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uOjpkZWNvZGUoSVBDOjpEZWNvZGVyJiBkZWNv
ZGVyLCBGb2N1c2VkRWxlbWVudEluZm8KICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3VsdC5p
c011bHRpU2VsZWN0KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKCFkZWNvZGVy
LmRlY29kZShyZXN1bHQuaXNSZWFkT25seSkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAg
IGlmICghZGVjb2Rlci5kZWNvZGUocmVzdWx0LmFsbG93c1VzZXJTY2FsaW5nKSkKICAgICAgICAg
cmV0dXJuIGZhbHNlOwogICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvRm9j
dXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvRm9jdXNlZEVs
ZW1lbnRJbmZvcm1hdGlvbi5oCmluZGV4IDQzYjNlNzY0ZDNkOWQxZTcxODc2N2NiZDQwN2VhNDQx
MmJjNzU3YmIuLjg3Nzc3MjMyNGU4YjAxOTM3MjhmYWQ2Yjg1NDc4NjllZjEwMWJlN2YgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24uaAor
KysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Gb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmgKQEAg
LTExMiw3ICsxMTIsNiBAQCBzdHJ1Y3QgRm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbiB7CiAgICAg
Ym9vbCBpc0F1dG9jb3JyZWN0IHsgZmFsc2UgfTsKICAgICBib29sIGlzUlRMIHsgZmFsc2UgfTsK
ICAgICBib29sIGlzTXVsdGlTZWxlY3QgeyBmYWxzZSB9OwotICAgIGJvb2wgaXNSZWFkT25seSB7
ZmFsc2UgfTsKICAgICBib29sIGFsbG93c1VzZXJTY2FsaW5nIHsgZmFsc2UgfTsKICAgICBib29s
IGFsbG93c1VzZXJTY2FsaW5nSWdub3JpbmdBbHdheXNTY2FsYWJsZSB7IGZhbHNlIH07CiAgICAg
Ym9vbCBpbnNpZGVGaXhlZFBvc2l0aW9uIHsgZmFsc2UgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2Uv
V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDNk
ZGEyNTc0NjdlNTk3NTE2ZGFlZjY0NjAyMjMxYTAyNDM1YWM1ZjQuLjA5YjA3OTExZDZhNjE5ODAy
MTYwNjU2ZTMwY2FhMDQ5NTI2OWNiZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9V
SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMTkzNSw5ICsxOTM1
LDYgQEAgLSAoQk9PTClzaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSQogCiAtIChCT09MKV9z
aG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSUlnbm9yaW5nSW5wdXRNb2RlCiB7Ci0gICAgaWYg
KF9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmlzUmVhZE9ubHkpCi0gICAgICAgIHJldHVybiBO
TzsKLQogICAgIHN3aXRjaCAoX2ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24uZWxlbWVudFR5cGUp
IHsKICAgICBjYXNlIFdlYktpdDo6SW5wdXRUeXBlOjpOb25lOgogICAgIGNhc2UgV2ViS2l0OjpJ
bnB1dFR5cGU6OkRyYXdpbmc6CkBAIC01MTk0LDcgKzUxOTEsNyBAQCAtICh2b2lkKV9mb2N1c1Rl
eHRJbnB1dENvbnRleHQ6KF9XS1RleHRJbnB1dENvbnRleHQgKiljb250ZXh0IHBsYWNlQ2FyZXRB
dDooQ0dQbwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIGlmIChbc2VsZiBfaXNUZXh0SW5w
dXRDb250ZXh0Rm9jdXNlZDpjb250ZXh0XSkgewotICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihf
Zm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5pc1JlYWRPbmx5ID8gbmlsIDogc2VsZik7CisgICAg
ICAgIGNvbXBsZXRpb25IYW5kbGVyKHNlbGYpOwogICAgICAgICByZXR1cm47CiAgICAgfQogICAg
IF91c2luZ0dlc3R1cmVGb3JTZWxlY3Rpb24gPSBZRVM7CkBAIC01MjA1LDEwICs1MjAyLDkgQEAg
LSAodm9pZClfZm9jdXNUZXh0SW5wdXRDb250ZXh0OihfV0tUZXh0SW5wdXRDb250ZXh0ICopY29u
dGV4dCBwbGFjZUNhcmV0QXQ6KENHUG8KICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQog
ICAgICAgICBib29sIGlzRm9jdXNlZCA9IHN1Y2Nlc3MgJiYgW3N0cm9uZ1NlbGYgX2lzVGV4dElu
cHV0Q29udGV4dEZvY3VzZWQ6Y29udGV4dC5nZXQoKV07Ci0gICAgICAgIGJvb2wgaXNFZGl0YWJs
ZSA9IHN1Y2Nlc3MgJiYgIXN0cm9uZ1NlbGYtPl9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmlz
UmVhZE9ubHk7CiAgICAgICAgIHN0cm9uZ1NlbGYtPl90ZXh0SW50ZXJhY3Rpb25EaWRDaGFuZ2VG
b2N1c2VkRWxlbWVudCB8PSBpc0ZvY3VzZWQ7CiAgICAgICAgIHN0cm9uZ1NlbGYtPl91c2luZ0dl
c3R1cmVGb3JTZWxlY3Rpb24gPSBOTzsKLSAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoaXNGb2N1
c2VkICYmIGlzRWRpdGFibGUgPyBzdHJvbmdTZWxmLmdldCgpIDogbmlsKTsKKyAgICAgICAgY29t
cGxldGlvbkhhbmRsZXIoaXNGb2N1c2VkID8gc3Ryb25nU2VsZi5nZXQoKSA6IG5pbCk7CiAgICAg
fTsKICAgICBfcGFnZS0+Zm9jdXNUZXh0SW5wdXRDb250ZXh0QW5kUGxhY2VDYXJldChjb250ZXh0
Ll90ZXh0SW5wdXRDb250ZXh0LCBXZWJDb3JlOjpJbnRQb2ludCB7IHBvaW50IH0sIFdURk1vdmUo
Y2hlY2tGb2N1c2VkRWxlbWVudCkpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQ
cm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl
c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCAyOTY4ZjdjMGMyNGE1YWQ4ODA2NWRk
ODRkZDhlMGMxYzNiYWVkMjk2Li4zZTQ2OGNmNDY0MjA3OTM5ZGQ0NjdjOGMwYzY1ZDYxNWFjNmEy
ZGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi
UGFnZUlPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi
UGFnZUlPUy5tbQpAQCAtMzE3MSw3ICszMTcxLDYgQEAgdm9pZCBXZWJQYWdlOjpnZXRGb2N1c2Vk
RWxlbWVudEluZm9ybWF0aW9uKEZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24mIGluZm9ybWF0aW8K
ICAgICAgICAgaW5mb3JtYXRpb24uYXV0b2NhcGl0YWxpemVUeXBlID0gZWxlbWVudC5hdXRvY2Fw
aXRhbGl6ZVR5cGUoKTsKICAgICAgICAgaW5mb3JtYXRpb24uaXNBdXRvY29ycmVjdCA9IGVsZW1l
bnQuc2hvdWxkQXV0b2NvcnJlY3QoKTsKICAgICAgICAgaW5mb3JtYXRpb24uZWxlbWVudFR5cGUg
PSBJbnB1dFR5cGU6OlRleHRBcmVhOwotICAgICAgICBpbmZvcm1hdGlvbi5pc1JlYWRPbmx5ID0g
ZWxlbWVudC5pc1JlYWRPbmx5KCk7CiAgICAgICAgIGluZm9ybWF0aW9uLnZhbHVlID0gZWxlbWVu
dC52YWx1ZSgpOwogICAgICAgICBpbmZvcm1hdGlvbi5hdXRvZmlsbEZpZWxkTmFtZSA9IFdlYkNv
cmU6OnRvQXV0b2ZpbGxGaWVsZE5hbWUoZWxlbWVudC5hdXRvZmlsbERhdGEoKS5maWVsZE5hbWUp
OwogICAgICAgICBpbmZvcm1hdGlvbi5wbGFjZWhvbGRlciA9IGVsZW1lbnQuYXR0cmlidXRlV2l0
aG91dFN5bmNocm9uaXphdGlvbihIVE1MTmFtZXM6OnBsYWNlaG9sZGVyQXR0cik7CkBAIC0zMjM3
LDcgKzMyMzYsNiBAQCB2b2lkIFdlYlBhZ2U6OmdldEZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24o
Rm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbiYgaW5mb3JtYXRpbwogI2VuZGlmCiAgICAgICAgIGlu
Zm9ybWF0aW9uLmlucHV0TW9kZSA9IGVsZW1lbnQuY2Fub25pY2FsSW5wdXRNb2RlKCk7CiAgICAg
ICAgIGluZm9ybWF0aW9uLmVudGVyS2V5SGludCA9IGVsZW1lbnQuY2Fub25pY2FsRW50ZXJLZXlI
aW50KCk7Ci0gICAgICAgIGluZm9ybWF0aW9uLmlzUmVhZE9ubHkgPSBlbGVtZW50LmlzUmVhZE9u
bHkoKTsKICAgICAgICAgaW5mb3JtYXRpb24udmFsdWUgPSBlbGVtZW50LnZhbHVlKCk7CiAgICAg
ICAgIGluZm9ybWF0aW9uLnZhbHVlQXNOdW1iZXIgPSBlbGVtZW50LnZhbHVlQXNOdW1iZXIoKTsK
ICAgICAgICAgaW5mb3JtYXRpb24uYXV0b2ZpbGxGaWVsZE5hbWUgPSBXZWJDb3JlOjp0b0F1dG9m
aWxsRmllbGROYW1lKGVsZW1lbnQuYXV0b2ZpbGxEYXRhKCkuZmllbGROYW1lKTsKQEAgLTMyNTcs
NyArMzI1NSw2IEBAIHZvaWQgV2ViUGFnZTo6Z2V0Rm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbihG
b2N1c2VkRWxlbWVudEluZm9ybWF0aW9uJiBpbmZvcm1hdGlvCiAgICAgICAgICAgICBpbmZvcm1h
dGlvbi5pc0F1dG9jb3JyZWN0ID0gdHJ1ZTsKICAgICAgICAgICAgIGluZm9ybWF0aW9uLmF1dG9j
YXBpdGFsaXplVHlwZSA9IFdlYkNvcmU6OkF1dG9jYXBpdGFsaXplVHlwZTo6RGVmYXVsdDsKICAg
ICAgICAgfQotICAgICAgICBpbmZvcm1hdGlvbi5pc1JlYWRPbmx5ID0gZmFsc2U7CiAgICAgfQog
CiAgICAgaWYgKGZvY3VzZWRFbGVtZW50LT5kb2N1bWVudCgpLnF1aXJrcygpLnNob3VsZFN1cHBy
ZXNzQXV0b2NvcnJlY3Rpb25BbmRBdXRvY2FwdGlhbGl6YXRpb25JbkhpZGRlbkVkaXRhYmxlQXJl
YXMoKSAmJiBpc1RyYW5zcGFyZW50T3JGdWxseUNsaXBwZWQoKmZvY3VzZWRFbGVtZW50KSkgewo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>404507</attachid>
            <date>2020-07-16 18:14:45 -0700</date>
            <delta_ts>2020-07-16 18:14:45 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214434-20200716181443.patch</filename>
            <type>text/plain</type>
            <size>10092</size>
            <attacher name="Devin Rousso">hi</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cKaW5kZXggMmJmYTU5YmJlMjRhNTcwMWUyYzAxZGNkMDZmNDNmYjg1NGY2MmIyOC4uM2I4
YzJiZWQ3ZTc2YjRmZDhiNDZiOTAxODZjZTIyMmYwMWM3MTJhOCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwzMiBAQAorMjAyMC0wNy0xNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK
KyAgICAgICAgc2hvdWxkIGJlIGFibGUgdG8gc2VuZCBrZXlib2FyZCBldmVudHMgdG8gYDxpbnB1
dCByZWFkb25seT5gIHdpdGggYSBzb2Z0d2FyZSBrZXlib2FyZAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0NDM0CisgICAgICAgIDxyZGFyOi8vcHJv
YmxlbS82NTAxNzk1MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBQcmV2aW91c2x5LCB0YXBwaW5nIG9uIGFuIGA8aW5wdXQgcmVhZG9ubHk+YCB3b3Vs
ZCBub3Qgc2hvdyB0aGUgc29mdHdhcmUga2V5Ym9hcmQuIFRoaXMgaXMKKyAgICAgICAgbm90IGlk
ZWFsLCBhcyBgcmVhZG9ubHlgIG9ubHkgcHJldmVudHMgdGhlIGA8aW5wdXQ+YCBmcm9tIGJlaW5n
IG1vZGlmaWVkLiBgcmVhZG9ubHlgIHN0aWxsCisgICAgICAgIGFsbG93cyBmb3IgZm9jdXNpbmcg
YW5kIHNlbGVjdGlvbiBhbmQgb3RoZXIgc2ltaWxhciBhY3Rpb25zLCBhbmQgYEtleWJvYXJkRXZl
bnRgIGFyZSBzdGlsbAorICAgICAgICBkaXNwYXRjaGVkIGZvciBgPGlucHV0IHJlYWRvbmx5PmAg
d2hlbiBmb2N1c2VkLCB3aGljaCBKYXZhU2NyaXB0IGNvdWxkIGxpc3RlbiBmb3IgaW4gb3JkZXIK
KyAgICAgICAgdG8gbWFudWFsbHkgbW9kaWZ5IHRoZSBgdmFsdWVgLCB0aGVyZWJ5IGNoYW5naW5n
IHdoYXQgaXMgc2hvd24vc2VsZWN0YWJsZS4gQWxsIG9mIHRoaXMKKyAgICAgICAgcmVxdWlyZXMg
dGhhdCB0aGUgc29mdHdhcmUga2V5Ym9hcmQgaXMgdmlzaWJsZSB0aG91Z2gsIHNvIHdlIG5lZWQg
dG8gc2hvdyBpdCBmb3IgYHJlYWRvbmx5YC4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL2lv
cy9mb2N1cy1pbnB1dC1yZWFkb25seS5odG1sCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dL
Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfc2hv
dWxkU2hvd0F1dG9tYXRpY0tleWJvYXJkVUlJZ25vcmluZ0lucHV0TW9kZV0pOgorICAgICAgICAo
LVtXS0NvbnRlbnRWaWV3IF9mb2N1c1RleHRJbnB1dENvbnRleHQ6cGxhY2VDYXJldEF0OmNvbXBs
ZXRpb25IYW5kbGVyOl0pOgorCisgICAgICAgICogU2hhcmVkL0ZvY3VzZWRFbGVtZW50SW5mb3Jt
YXRpb24uaDoKKyAgICAgICAgKiBTaGFyZWQvRm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5jcHA6
CisgICAgICAgIChXZWJLaXQ6OkZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb246OmVuY29kZSBjb25z
dCk6CisgICAgICAgIChXZWJLaXQ6OkZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb246OmRlY29kZSk6
CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAg
ICAoV2ViS2l0OjpXZWJQYWdlOjpnZXRGb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uKToKKyAgICAg
ICAgUmVtb3ZlIGBpc1JlYWRPbmx5YCBhcyBpdCdzIG5vIGxvbmdlciB1c2VkLgorCiAyMDIwLTA3
LTE1ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJl
dmlld2VkLCByZXZlcnQgcGFydCBvZiByMjY0Mzg1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dC9TaGFyZWQvRm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1No
YXJlZC9Gb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmNwcAppbmRleCAyNDdlYWFiOTU2ZmM5MzVh
NmIzYzUwZTE2ZDZhNTUwZDllMWE0NGVmLi4wOTQ2NTcwNGUzMWUyNDZkZGFjMmM2NmE5MDFmOGNk
MDRhNmE4YjUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Gb2N1c2VkRWxlbWVu
dEluZm9ybWF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Gb2N1c2VkRWxlbWVu
dEluZm9ybWF0aW9uLmNwcApAQCAtODQsNyArODQsNiBAQCB2b2lkIEZvY3VzZWRFbGVtZW50SW5m
b3JtYXRpb246OmVuY29kZShJUEM6OkVuY29kZXImIGVuY29kZXIpIGNvbnN0CiAgICAgZW5jb2Rl
ciA8PCBzZWxlY3RPcHRpb25zOwogICAgIGVuY29kZXIgPDwgc2VsZWN0ZWRJbmRleDsKICAgICBl
bmNvZGVyIDw8IGlzTXVsdGlTZWxlY3Q7Ci0gICAgZW5jb2RlciA8PCBpc1JlYWRPbmx5OwogICAg
IGVuY29kZXIgPDwgYWxsb3dzVXNlclNjYWxpbmc7CiAgICAgZW5jb2RlciA8PCBhbGxvd3NVc2Vy
U2NhbGluZ0lnbm9yaW5nQWx3YXlzU2NhbGFibGU7CiAgICAgZW5jb2RlciA8PCBpbnNpZGVGaXhl
ZFBvc2l0aW9uOwpAQCAtMTc4LDkgKzE3Nyw2IEBAIGJvb2wgRm9jdXNlZEVsZW1lbnRJbmZvcm1h
dGlvbjo6ZGVjb2RlKElQQzo6RGVjb2RlciYgZGVjb2RlciwgRm9jdXNlZEVsZW1lbnRJbmZvCiAg
ICAgaWYgKCFkZWNvZGVyLmRlY29kZShyZXN1bHQuaXNNdWx0aVNlbGVjdCkpCiAgICAgICAgIHJl
dHVybiBmYWxzZTsKIAotICAgIGlmICghZGVjb2Rlci5kZWNvZGUocmVzdWx0LmlzUmVhZE9ubHkp
KQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3Vs
dC5hbGxvd3NVc2VyU2NhbGluZykpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24uaCBi
L1NvdXJjZS9XZWJLaXQvU2hhcmVkL0ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24uaAppbmRleCA0
M2IzZTc2NGQzZDlkMWU3MTg3NjdjYmQ0MDdlYTQ0MTJiYzc1N2JiLi44Nzc3NzIzMjRlOGIwMTkz
NzI4ZmFkNmI4NTQ3ODY5ZWYxMDFiZTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJl
ZC9Gb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQv
Rm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5oCkBAIC0xMTIsNyArMTEyLDYgQEAgc3RydWN0IEZv
Y3VzZWRFbGVtZW50SW5mb3JtYXRpb24gewogICAgIGJvb2wgaXNBdXRvY29ycmVjdCB7IGZhbHNl
IH07CiAgICAgYm9vbCBpc1JUTCB7IGZhbHNlIH07CiAgICAgYm9vbCBpc011bHRpU2VsZWN0IHsg
ZmFsc2UgfTsKLSAgICBib29sIGlzUmVhZE9ubHkge2ZhbHNlIH07CiAgICAgYm9vbCBhbGxvd3NV
c2VyU2NhbGluZyB7IGZhbHNlIH07CiAgICAgYm9vbCBhbGxvd3NVc2VyU2NhbGluZ0lnbm9yaW5n
QWx3YXlzU2NhbGFibGUgeyBmYWxzZSB9OwogICAgIGJvb2wgaW5zaWRlRml4ZWRQb3NpdGlvbiB7
IGZhbHNlIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250
ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u
dGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCAzZGRhMjU3NDY3ZTU5NzUxNmRhZWY2NDYwMjIz
MWEwMjQzNWFjNWY0Li4wOWIwNzkxMWQ2YTYxOTgwMjE2MDY1NmUzMGNhYTA0OTUyNjljYmY0IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVy
YWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3
SW50ZXJhY3Rpb24ubW0KQEAgLTE5MzUsOSArMTkzNSw2IEBAIC0gKEJPT0wpc2hvdWxkU2hvd0F1
dG9tYXRpY0tleWJvYXJkVUkKIAogLSAoQk9PTClfc2hvdWxkU2hvd0F1dG9tYXRpY0tleWJvYXJk
VUlJZ25vcmluZ0lucHV0TW9kZQogewotICAgIGlmIChfZm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlv
bi5pc1JlYWRPbmx5KQotICAgICAgICByZXR1cm4gTk87Ci0KICAgICBzd2l0Y2ggKF9mb2N1c2Vk
RWxlbWVudEluZm9ybWF0aW9uLmVsZW1lbnRUeXBlKSB7CiAgICAgY2FzZSBXZWJLaXQ6OklucHV0
VHlwZTo6Tm9uZToKICAgICBjYXNlIFdlYktpdDo6SW5wdXRUeXBlOjpEcmF3aW5nOgpAQCAtNTE5
NCw3ICs1MTkxLDcgQEAgLSAodm9pZClfZm9jdXNUZXh0SW5wdXRDb250ZXh0OihfV0tUZXh0SW5w
dXRDb250ZXh0ICopY29udGV4dCBwbGFjZUNhcmV0QXQ6KENHUG8KICAgICAgICAgcmV0dXJuOwog
ICAgIH0KICAgICBpZiAoW3NlbGYgX2lzVGV4dElucHV0Q29udGV4dEZvY3VzZWQ6Y29udGV4dF0p
IHsKLSAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoX2ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24u
aXNSZWFkT25seSA/IG5pbCA6IHNlbGYpOworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihzZWxm
KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBfdXNpbmdHZXN0dXJlRm9yU2VsZWN0aW9u
ID0gWUVTOwpAQCAtNTIwNSwxMCArNTIwMiw5IEBAIC0gKHZvaWQpX2ZvY3VzVGV4dElucHV0Q29u
dGV4dDooX1dLVGV4dElucHV0Q29udGV4dCAqKWNvbnRleHQgcGxhY2VDYXJldEF0OihDR1BvCiAg
ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgYm9vbCBpc0ZvY3VzZWQgPSBz
dWNjZXNzICYmIFtzdHJvbmdTZWxmIF9pc1RleHRJbnB1dENvbnRleHRGb2N1c2VkOmNvbnRleHQu
Z2V0KCldOwotICAgICAgICBib29sIGlzRWRpdGFibGUgPSBzdWNjZXNzICYmICFzdHJvbmdTZWxm
LT5fZm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5pc1JlYWRPbmx5OwogICAgICAgICBzdHJvbmdT
ZWxmLT5fdGV4dEludGVyYWN0aW9uRGlkQ2hhbmdlRm9jdXNlZEVsZW1lbnQgfD0gaXNGb2N1c2Vk
OwogICAgICAgICBzdHJvbmdTZWxmLT5fdXNpbmdHZXN0dXJlRm9yU2VsZWN0aW9uID0gTk87Ci0g
ICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKGlzRm9jdXNlZCAmJiBpc0VkaXRhYmxlID8gc3Ryb25n
U2VsZi5nZXQoKSA6IG5pbCk7CisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKGlzRm9jdXNlZCA/
IHN0cm9uZ1NlbGYuZ2V0KCkgOiBuaWwpOwogICAgIH07CiAgICAgX3BhZ2UtPmZvY3VzVGV4dElu
cHV0Q29udGV4dEFuZFBsYWNlQ2FyZXQoY29udGV4dC5fdGV4dElucHV0Q29udGV4dCwgV2ViQ29y
ZTo6SW50UG9pbnQgeyBwb2ludCB9LCBXVEZNb3ZlKGNoZWNrRm9jdXNlZEVsZW1lbnQpKTsKIH0K
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdl
SU9TLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1Mu
bW0KaW5kZXggMjk2OGY3YzBjMjRhNWFkODgwNjVkZDg0ZGQ4ZTBjMWMzYmFlZDI5Ni4uM2U0Njhj
ZjQ2NDIwNzkzOWRkNDY3YzhjMGM2NWQ2MTVhYzZhMmRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dl
YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTMxNzEsNyArMzE3
MSw2IEBAIHZvaWQgV2ViUGFnZTo6Z2V0Rm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbihGb2N1c2Vk
RWxlbWVudEluZm9ybWF0aW9uJiBpbmZvcm1hdGlvCiAgICAgICAgIGluZm9ybWF0aW9uLmF1dG9j
YXBpdGFsaXplVHlwZSA9IGVsZW1lbnQuYXV0b2NhcGl0YWxpemVUeXBlKCk7CiAgICAgICAgIGlu
Zm9ybWF0aW9uLmlzQXV0b2NvcnJlY3QgPSBlbGVtZW50LnNob3VsZEF1dG9jb3JyZWN0KCk7CiAg
ICAgICAgIGluZm9ybWF0aW9uLmVsZW1lbnRUeXBlID0gSW5wdXRUeXBlOjpUZXh0QXJlYTsKLSAg
ICAgICAgaW5mb3JtYXRpb24uaXNSZWFkT25seSA9IGVsZW1lbnQuaXNSZWFkT25seSgpOwogICAg
ICAgICBpbmZvcm1hdGlvbi52YWx1ZSA9IGVsZW1lbnQudmFsdWUoKTsKICAgICAgICAgaW5mb3Jt
YXRpb24uYXV0b2ZpbGxGaWVsZE5hbWUgPSBXZWJDb3JlOjp0b0F1dG9maWxsRmllbGROYW1lKGVs
ZW1lbnQuYXV0b2ZpbGxEYXRhKCkuZmllbGROYW1lKTsKICAgICAgICAgaW5mb3JtYXRpb24ucGxh
Y2Vob2xkZXIgPSBlbGVtZW50LmF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oSFRNTE5h
bWVzOjpwbGFjZWhvbGRlckF0dHIpOwpAQCAtMzIzNyw3ICszMjM2LDYgQEAgdm9pZCBXZWJQYWdl
OjpnZXRGb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uKEZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24m
IGluZm9ybWF0aW8KICNlbmRpZgogICAgICAgICBpbmZvcm1hdGlvbi5pbnB1dE1vZGUgPSBlbGVt
ZW50LmNhbm9uaWNhbElucHV0TW9kZSgpOwogICAgICAgICBpbmZvcm1hdGlvbi5lbnRlcktleUhp
bnQgPSBlbGVtZW50LmNhbm9uaWNhbEVudGVyS2V5SGludCgpOwotICAgICAgICBpbmZvcm1hdGlv
bi5pc1JlYWRPbmx5ID0gZWxlbWVudC5pc1JlYWRPbmx5KCk7CiAgICAgICAgIGluZm9ybWF0aW9u
LnZhbHVlID0gZWxlbWVudC52YWx1ZSgpOwogICAgICAgICBpbmZvcm1hdGlvbi52YWx1ZUFzTnVt
YmVyID0gZWxlbWVudC52YWx1ZUFzTnVtYmVyKCk7CiAgICAgICAgIGluZm9ybWF0aW9uLmF1dG9m
aWxsRmllbGROYW1lID0gV2ViQ29yZTo6dG9BdXRvZmlsbEZpZWxkTmFtZShlbGVtZW50LmF1dG9m
aWxsRGF0YSgpLmZpZWxkTmFtZSk7CkBAIC0zMjU3LDcgKzMyNTUsNiBAQCB2b2lkIFdlYlBhZ2U6
OmdldEZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24oRm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbiYg
aW5mb3JtYXRpbwogICAgICAgICAgICAgaW5mb3JtYXRpb24uaXNBdXRvY29ycmVjdCA9IHRydWU7
CiAgICAgICAgICAgICBpbmZvcm1hdGlvbi5hdXRvY2FwaXRhbGl6ZVR5cGUgPSBXZWJDb3JlOjpB
dXRvY2FwaXRhbGl6ZVR5cGU6OkRlZmF1bHQ7CiAgICAgICAgIH0KLSAgICAgICAgaW5mb3JtYXRp
b24uaXNSZWFkT25seSA9IGZhbHNlOwogICAgIH0KIAogICAgIGlmIChmb2N1c2VkRWxlbWVudC0+
ZG9jdW1lbnQoKS5xdWlya3MoKS5zaG91bGRTdXBwcmVzc0F1dG9jb3JyZWN0aW9uQW5kQXV0b2Nh
cHRpYWxpemF0aW9uSW5IaWRkZW5FZGl0YWJsZUFyZWFzKCkgJiYgaXNUcmFuc3BhcmVudE9yRnVs
bHlDbGlwcGVkKCpmb2N1c2VkRWxlbWVudCkpIHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No
YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkMGQ4OTg3NDJlYTk1MWJkZWY5
YmU1ZDIyNjhjNGUxMTZlYWE3M2RiLi5kNTdhMzIyMDE3MWU4NTFiMmIxNTVkOWJiOWZjNTk0ZTQ5
NmRhODc3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz
dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDctMTYgIERldmluIFJvdXNzbyAg
PGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIHNob3VsZCBiZSBhYmxlIHRvIHNlbmQga2V5
Ym9hcmQgZXZlbnRzIHRvIGA8aW5wdXQgcmVhZG9ubHk+YCB3aXRoIGEgc29mdHdhcmUga2V5Ym9h
cmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDQz
NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjUwMTc5NTA+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2lvcy9mb2N1cy1pbnB1
dC1yZWFkb25seS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL2lvcy9mb2N1cy1p
bnB1dC1yZWFkb25seS1leHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDIwLTA3LTE1ICBSeWFuIEhh
ZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPUyBXSzEgRVdTXSBj
b21wb3NpdGluZy9yZXBhaW50L2lmcmFtZXMvY29tcG9zaXRlZC1pZnJhbWUtd2l0aC1maXhlZC1i
YWNrZ3JvdW5kLWRvYy1yZXBhaW50Lmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCmRpZmYgLS1naXQg
YS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9mb2N1cy1pbnB1dC1yZWFkb25seS1leHBlY3Rl
ZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9mb2N1cy1pbnB1dC1yZWFkb25seS1l
eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDY4YzViYmFkZjJhOGU5ZGQxNDkyMDU5ZjEyYTU3MzQx
NGZjYjQzMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2Zv
Y3VzLWlucHV0LXJlYWRvbmx5LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEzIEBACisKK1RoaXMg
dGVzdCB2ZXJpZmllcyB0aGF0IHRoZSBzeXN0ZW0ga2V5Ym9hcmQgaXMgc2hvd24gd2hlbiB0YXBw
aW5nIG9uIGEgcmVhZG9ubHkgaW5wdXQuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl
cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKwor
ZGlzYWJsZSBoYXJkd2FyZSBrZXlib2FyZAorYWN0aXZhdGUgcmVhZG9ubHkgaW5wdXQKK3Rlc3Qg
c3lzdGVtIGtleWJvYXJkIGJvdW5kcworUEFTUyBzeXN0ZW1LZXlib2FyZFJlY3QuaGVpZ2h0ID4g
MCBpcyB0cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExF
VEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvZm9jdXMtaW5wdXQt
cmVhZG9ubHkuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZvY3VzLWlucHV0LXJl
YWRvbmx5Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYmQyNWVjMDQxYzFhZGZlZGJmY2MwMzNlYjkwOTUwYWM0
OTMwOTdhOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2Zv
Y3VzLWlucHV0LXJlYWRvbmx5Lmh0bWwKQEAgLTAsMCArMSwzNCBAQAorPCFET0NUWVBFIGh0bWw+
IDwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgdXNlRmxleGlibGVWaWV3cG9ydD10cnVlIF0gLS0+
Cis8aHRtbD4KKzxoZWFkPgorPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRl
dmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xLCB1c2VyLXNjYWxhYmxlPW5vIj4KKzxzY3JpcHQg
c3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNy
Yz0iLi4vLi4vLi4vcmVzb3VyY2VzL3VpLWhlbHBlci5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8
Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8ZGl2PjxpbnB1dCBpZD0iaW5wdXQtcmVhZG9ubHki
IHJlYWRvbmx5PjwvZGl2PgorPHByZSBpZD0iZGVzY3JpcHRpb24iPjwvcHJlPgorPHByZSBpZD0i
Y29uc29sZSI+PC9wcmU+Cis8c2NyaXB0PgoranNUZXN0SXNBc3luYyA9IHRydWU7CisKK2FzeW5j
IGZ1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdCB2ZXJpZmll
cyB0aGF0IHRoZSBzeXN0ZW0ga2V5Ym9hcmQgaXMgc2hvd24gd2hlbiB0YXBwaW5nIG9uIGEgcmVh
ZG9ubHkgaW5wdXQuIik7CisKKyAgICBsZXQgaW5wdXRSZWFkT25seSA9IGRvY3VtZW50LmdldEVs
ZW1lbnRCeUlkKCJpbnB1dC1yZWFkb25seSIpOworCisgICAgZGVidWcoImRpc2FibGUgaGFyZHdh
cmUga2V5Ym9hcmQiKTsKKyAgICBhd2FpdCBVSUhlbHBlci5zZXRIYXJkd2FyZUtleWJvYXJkQXR0
YWNoZWQoZmFsc2UpOworCisgICAgZGVidWcoImFjdGl2YXRlIHJlYWRvbmx5IGlucHV0Iik7Cisg
ICAgYXdhaXQgVUlIZWxwZXIuYWN0aXZhdGVFbGVtZW50QW5kV2FpdEZvcklucHV0U2Vzc2lvbihp
bnB1dFJlYWRPbmx5KTsKKworICAgIGRlYnVnKCJ0ZXN0IHN5c3RlbSBrZXlib2FyZCBib3VuZHMi
KTsKKyAgICBzeXN0ZW1LZXlib2FyZFJlY3QgPSBhd2FpdCBVSUhlbHBlci5pbnB1dFZpZXdCb3Vu
ZHMoKTsKKyAgICBzaG91bGRCZSgic3lzdGVtS2V5Ym9hcmRSZWN0LmhlaWdodCA+IDAiLCAidHJ1
ZSIpOworCisgICAgZmluaXNoSlNUZXN0KCk7Cit9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt
bD4K
</data>
<flag name="review"
          id="419893"
          type_id="1"
          status="?"
          setter="hi"
    />
          </attachment>
      

    </bug>

</bugzilla>