213936 2020-07-03 13:23:28 -0700 WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD 2020-07-03 14:56:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 212420 1 darin darin annulen ews-watchlist gyuyoung.kim ryuan.choi sam sergio webkit-bug-importer oldest_to_newest 1668630 0 darin 2020-07-03 13:23:28 -0700 WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD 1668631 1 403475 darin 2020-07-03 13:24:29 -0700 Created attachment 403475 Patch 1668634 2 403475 darin 2020-07-03 13:29:00 -0700 Comment on attachment 403475 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403475&action=review > Source/WebCore/ChangeLog:8 > + * Sources.txt: Remove #if ENABLE_APPLICATION_MANIFEST and sort files in with the others. Oops, this should say ENABLE_GAMEPAD. 1668644 3 darin 2020-07-03 13:45:10 -0700 Looks like I need to modify something so the empty source files get generated, since I am getting this error in the GTK build: Cannot find source file: /app/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp Maybe the perl scripts need to be changed so they generate an empty file rather than no file at all. Or perhaps a file with a comment "/* This file intentionally left empty. */" in it? 1668645 4 darin 2020-07-03 13:47:27 -0700 Hmm, no it seems the real problem is that this same error is repeated in the CMake files, where we conditionalize compilation there instead of in the code. I will make the same change to CMake, I guess. That's going to make this more of a pain, but I think it's the right thing to do. 1668648 5 403482 darin 2020-07-03 13:53:25 -0700 Created attachment 403482 Patch 1668666 6 ews-feeder 2020-07-03 14:44:04 -0700 Committed r263910: <https://trac.webkit.org/changeset/263910> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403482. 1668668 7 webkit-bug-importer 2020-07-03 14:45:16 -0700 <rdar://problem/65083720> 403475 2020-07-03 13:24:29 -0700 2020-07-03 13:53:23 -0700 Patch bug-213936-20200703132429.patch text/plain 1875 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFlYjk3YzFiOWYwYTUz ODIxMjUyNTI0ZGNiN2U5ZGYwMGEzMzAyMC4uOTRkZjg4MGYzODRkMTFhNzQ2MzlkODEwM2E5Mzk2 MzE5NmVjZjU3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA3LTAzICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJDb3JlL1NvdXJjZXMudHh0 OiBSZW1vdmUgI2lmIEVOQUJMRV9HQU1FUEFECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM5MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZXMudHh0OiBSZW1vdmUgI2lmIEVOQUJMRV9BUFBM SUNBVElPTl9NQU5JRkVTVCBhbmQgc29ydCBmaWxlcyBpbiB3aXRoIHRoZSBvdGhlcnMuCisgICAg ICAgIFRoZSBJREwgZmlsZXMgdGhlbXNlbHZlcyBoYXZlIGNvbmRpdGlvbmFscywgd2UgZG9uJ3Qg bmVlZCBjb25kaXRpb25hbHMgaW4gU291cmNlcy50eHQsCisgICAgICAgIGFuZCB3ZSBhcmUgbW92 aW5nIHRvd2FyZHMgcmVtb3ZpbmcgdGhlIGNhcGFiaWxpdHkgZm9yICNpZiBFTkFCTEUgaW4gdGhl IFNvdXJjZXMudHh0IGZpbGUuCisKIDIwMjAtMDctMDMgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtURkNdW1F1aXJrXSBJbmZsb3cgY2hpbGQgYm94IHF1 aXJrIHZlcnRpY2FsIG1hcmdpbnMgc2hvdWxkIGNvbGxhcHNlIHdpdGggdGFibGUgY2VsbC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXMudHh0IGIvU291cmNlL1dlYkNvcmUvU291 cmNlcy50eHQKaW5kZXggZjQ5ZjIwODAzNGQ3MDkyODNlZGJmYzc4YTljY2VmYTMzYjkwMWM5Yy4u ODgxNzdhMDQ0ZmQ0MmYwNDEzYTE0ZmUyMzRiMDk2ODIzMmQzNjc1YiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvU291cmNlcy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvU291cmNlcy50eHQK QEAgLTMwMTQsNiArMzAxNCw5IEBAIEpTR1BVVmVydGV4QXR0cmlidXRlRGVzY3JpcHRvci5jcHAK IEpTR1BVVmVydGV4QnVmZmVyRGVzY3JpcHRvci5jcHAKIEpTR1BVVmVydGV4SW5wdXREZXNjcmlw dG9yLmNwcAogSlNHYWluTm9kZS5jcHAKK0pTR2FtZXBhZC5jcHAKK0pTR2FtZXBhZEJ1dHRvbi5j cHAKK0pTR2FtZXBhZEV2ZW50LmNwcAogSlNHZW9sb2NhdGlvbi5jcHAKIEpTR2VvbG9jYXRpb25D b29yZGluYXRlcy5jcHAKIEpTR2VvbG9jYXRpb25Qb3NpdGlvbi5jcHAKQEAgLTMxOTksNiArMzIw Miw3IEBAIEpTTmF2aWdhdG9yQ2xpcGJvYXJkLmNwcAogSlNOYXZpZ2F0b3JDcmVkZW50aWFscy5j cHAKIEpTTmF2aWdhdG9yR2VvbG9jYXRpb24uY3BwCiBKU05hdmlnYXRvckdQVS5jcHAKK0pTTmF2 aWdhdG9yR2FtZXBhZC5jcHAKIEpTTmF2aWdhdG9ySUQuY3BwCiBKU05hdmlnYXRvckxhbmd1YWdl LmNwcAogSlNOYXZpZ2F0b3JNYXhUb3VjaFBvaW50cy5jcHAKQEAgLTM2NTcsMTUgKzM2NjEsNiBA QCBKU1hSV2ViR0xMYXllckluaXQuY3BwCiAKICNlbmRpZgogCi0jaWYgRU5BQkxFX0dBTUVQQUQK LQotSlNHYW1lcGFkLmNwcAotSlNHYW1lcGFkQnV0dG9uLmNwcAotSlNHYW1lcGFkRXZlbnQuY3Bw Ci1KU05hdmlnYXRvckdhbWVwYWQuY3BwCi0KLSNlbmRpZgotCiAjaWYgRU5BQkxFX0xFR0FDWV9F TkNSWVBURURfTUVESUEKIAogSlNXZWJLaXRNZWRpYUtleU1lc3NhZ2VFdmVudC5jcHAK 403482 2020-07-03 13:53:25 -0700 2020-07-03 14:44:05 -0700 Patch bug-213936-20200703135324.patch text/plain 3446 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODYxMGRlOTBkYzliM2Fm MmU1OGMzZGNiMGUwZjgyZDUwNWYxZWEwMS4uM2ExMWNmNzY3Yzk0NWE2ODJjZjAzYjhhZDEzZmZi MzA3M2Y1NjI5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA3LTAzICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJDb3JlL1NvdXJjZXMudHh0 OiBSZW1vdmUgI2lmIEVOQUJMRV9HQU1FUEFECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM5MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBNb3ZlIElETC1yZWxhdGVkIEVO QUJMRV9HQU1FUEFEIGl0ZW1zIG91dCBvZiAiaWYgKEVOQUJMRV9HQU1FUEFEKSIuCisgICAgICAg IExvbmdlciB0ZXJtLCBJIHRoaW5rIG91ciBkaXJlY3Rpb24gc2hvdWxkIGJlIHRvIHJlbW92ZSBt b3N0IGZlYXR1cmUgY29uZGl0aW9uYWxzIGZyb20KKyAgICAgICAgQ01ha2VMaXN0cy50eHQgdG9v LCBqdXN0IGxpa2UgSSBhbSBkb2luZyBmb3IgU291cmNlcy50eHQuIEJ1dCBmb3Igbm93LCBkb2lu ZyBqdXN0IGVub3VnaAorICAgICAgICBvZiB0aGlzIHRvIGtlZXAgdGhlIGJ1aWxkIHdvcmtpbmcu IFNvbWVvbmUgY2FuIHRpZHkgdGhpcyBsYXRlciBhcyBkZXNpcmVkLgorCisgICAgICAgICogU291 cmNlcy50eHQ6IFJlbW92ZSAjaWYgRU5BQkxFX0dBTUVQQUQgYW5kIHNvcnQgZmlsZXMgaW4gd2l0 aCB0aGUgb3RoZXJzLgorICAgICAgICBUaGUgSURMIGZpbGVzIHRoZW1zZWx2ZXMgaGF2ZSBjb25k aXRpb25hbHMsIHdlIGRvbid0IG5lZWQgY29uZGl0aW9uYWxzIGluIFNvdXJjZXMudHh0LAorICAg ICAgICBhbmQgd2UgYXJlIG1vdmluZyB0b3dhcmRzIHJlbW92aW5nIHRoZSBjYXBhYmlsaXR5IGZv ciAjaWYgRU5BQkxFIGluIHRoZSBTb3VyY2VzLnR4dCBmaWxlLgorCiAyMDIwLTA3LTAzICBTYW0g V2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgIi1XbGl0ZXJhbC1jb252 ZXJzaW9uIiB3YXJuaW5nIHRvIFhjb2RlIGJhc2VkIGJ1aWxkcyBhbmQgZml4IHRoZSBpc3N1ZXMg aXQgZmluZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNjhjZmNmMGUwZjYzNDVjYjdkN2ExODg2 NThjNTdjZTk2NzRmMzk4NC4uMzRiZDQwZmNkODE2Y2JlZTY1MTA1MzQ2NDIzMzUxMzhmYjNlMjVi ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNl L1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTExODAsMjIgKzExODAsMjIgQEAgc2V0KFdlYkNv cmVfU1ZHX0lETF9GSUxFUwogICAgIHN2Zy9TVkdab29tRXZlbnQuaWRsCiApCiAKLWlmIChFTkFC TEVfR0FNRVBBRCkKLSAgICBsaXN0KEFQUEVORCBXZWJDb3JlX1BSSVZBVEVfSU5DTFVERV9ESVJF Q1RPUklFUwotICAgICAgICAiJHtXRUJDT1JFX0RJUn0vTW9kdWxlcy9nYW1lcGFkIgotICAgICkK K2xpc3QoQVBQRU5EIFdlYkNvcmVfUFJJVkFURV9JTkNMVURFX0RJUkVDVE9SSUVTCisgICAgIiR7 V0VCQ09SRV9ESVJ9L01vZHVsZXMvZ2FtZXBhZCIKKykKIAotICAgIGxpc3QoQVBQRU5EIFdlYkNv cmVfSURMX0lOQ0xVREVTCi0gICAgICAgIE1vZHVsZXMvZ2FtZXBhZAotICAgICkKK2xpc3QoQVBQ RU5EIFdlYkNvcmVfSURMX0lOQ0xVREVTCisgICAgTW9kdWxlcy9nYW1lcGFkCispCiAKLSAgICBs aXN0KEFQUEVORCBXZWJDb3JlX05PTl9TVkdfSURMX0ZJTEVTCi0gICAgICAgIE1vZHVsZXMvZ2Ft ZXBhZC9HYW1lcGFkLmlkbAotICAgICAgICBNb2R1bGVzL2dhbWVwYWQvR2FtZXBhZEJ1dHRvbi5p ZGwKLSAgICAgICAgTW9kdWxlcy9nYW1lcGFkL0dhbWVwYWRFdmVudC5pZGwKLSAgICAgICAgTW9k dWxlcy9nYW1lcGFkL05hdmlnYXRvckdhbWVwYWQuaWRsCi0gICAgKQorbGlzdChBUFBFTkQgV2Vi Q29yZV9OT05fU1ZHX0lETF9GSUxFUworICAgIE1vZHVsZXMvZ2FtZXBhZC9HYW1lcGFkLmlkbAor ICAgIE1vZHVsZXMvZ2FtZXBhZC9HYW1lcGFkQnV0dG9uLmlkbAorICAgIE1vZHVsZXMvZ2FtZXBh ZC9HYW1lcGFkRXZlbnQuaWRsCisgICAgTW9kdWxlcy9nYW1lcGFkL05hdmlnYXRvckdhbWVwYWQu aWRsCispCiAKK2lmIChFTkFCTEVfR0FNRVBBRCkKICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX1NP VVJDRVMKICAgICAgICAgTW9kdWxlcy9nYW1lcGFkL0dhbWVwYWQuY3BwCiAgICAgICAgIE1vZHVs ZXMvZ2FtZXBhZC9HYW1lcGFkQnV0dG9uLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv U291cmNlcy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzLnR4dAppbmRleCBmNDlmMjA4MDM0 ZDcwOTI4M2VkYmZjNzhhOWNjZWZhMzNiOTAxYzljLi44ODE3N2EwNDRmZDQyZjA0MTNhMTRmZTIz NGIwOTY4MjMyZDM2NzViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzLnR4dAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzLnR4dApAQCAtMzAxNCw2ICszMDE0LDkgQEAgSlNH UFVWZXJ0ZXhBdHRyaWJ1dGVEZXNjcmlwdG9yLmNwcAogSlNHUFVWZXJ0ZXhCdWZmZXJEZXNjcmlw dG9yLmNwcAogSlNHUFVWZXJ0ZXhJbnB1dERlc2NyaXB0b3IuY3BwCiBKU0dhaW5Ob2RlLmNwcAor SlNHYW1lcGFkLmNwcAorSlNHYW1lcGFkQnV0dG9uLmNwcAorSlNHYW1lcGFkRXZlbnQuY3BwCiBK U0dlb2xvY2F0aW9uLmNwcAogSlNHZW9sb2NhdGlvbkNvb3JkaW5hdGVzLmNwcAogSlNHZW9sb2Nh dGlvblBvc2l0aW9uLmNwcApAQCAtMzE5OSw2ICszMjAyLDcgQEAgSlNOYXZpZ2F0b3JDbGlwYm9h cmQuY3BwCiBKU05hdmlnYXRvckNyZWRlbnRpYWxzLmNwcAogSlNOYXZpZ2F0b3JHZW9sb2NhdGlv bi5jcHAKIEpTTmF2aWdhdG9yR1BVLmNwcAorSlNOYXZpZ2F0b3JHYW1lcGFkLmNwcAogSlNOYXZp Z2F0b3JJRC5jcHAKIEpTTmF2aWdhdG9yTGFuZ3VhZ2UuY3BwCiBKU05hdmlnYXRvck1heFRvdWNo UG9pbnRzLmNwcApAQCAtMzY1NywxNSArMzY2MSw2IEBAIEpTWFJXZWJHTExheWVySW5pdC5jcHAK IAogI2VuZGlmCiAKLSNpZiBFTkFCTEVfR0FNRVBBRAotCi1KU0dhbWVwYWQuY3BwCi1KU0dhbWVw YWRCdXR0b24uY3BwCi1KU0dhbWVwYWRFdmVudC5jcHAKLUpTTmF2aWdhdG9yR2FtZXBhZC5jcHAK LQotI2VuZGlmCi0KICNpZiBFTkFCTEVfTEVHQUNZX0VOQ1JZUFRFRF9NRURJQQogCiBKU1dlYktp dE1lZGlhS2V5TWVzc2FnZUV2ZW50LmNwcAo=