213509 2020-06-23 04:50:25 -0700 [WebXR] Fix PlatformXR initialization/destruction 2020-06-24 01:51:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208988 1 svillar svillar cgarcia dino pnormand svillar webkit-bug-importer youennf zan oldest_to_newest 1665334 0 svillar 2020-06-23 04:50:25 -0700 [WebXR] Fix PlatformXR initialization/destruction 1665338 1 402545 svillar 2020-06-23 05:06:30 -0700 Created attachment 402545 Patch 1665358 2 402545 youennf 2020-06-23 06:18:54 -0700 Comment on attachment 402545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402545&action=review > Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218 > s_instance->m_impl = makeUnique<Impl>(); Can we do this assignment in Instance constructor? And make m_impl a UniqueRef<> maybe? 1665670 3 402545 svillar 2020-06-24 01:42:29 -0700 Comment on attachment 402545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402545&action=review Thanks for the review! >> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218 >> s_instance->m_impl = makeUnique<Impl>(); > > Can we do this assignment in Instance constructor? > And make m_impl a UniqueRef<> maybe? Makes total sense. 1665673 4 svillar 2020-06-24 01:50:13 -0700 Committed r263447: <https://trac.webkit.org/changeset/263447> 1665674 5 webkit-bug-importer 2020-06-24 01:51:15 -0700 <rdar://problem/64690849> 402545 2020-06-23 05:06:30 -0700 2020-06-23 06:18:54 -0700 Patch bug-213509-20200623140628.patch text/plain 3035 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDliNzYwYTg5MWM1ODIx MjM0ZDQ4ZWIxYjRmZGUzOGU2YmUyMGRhZi4uM2I0NWI4MDE4OWUyODUzMzQ4MjYyNWMyNzU4ZjZj NTgzMDMxM2MzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA2LTIzICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXZWJYUl0g Rml4IFBsYXRmb3JtWFIgaW5pdGlhbGl6YXRpb24vZGVzdHJ1Y3Rpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzUwOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIHdlcmUgdHdvIGRpZmZlcmVu dCBpc3N1ZXMsIG9uZSBhdCBjcmVhdGlvbiB0aW1lIGFuZCB0aGUgb3RoZXIgb25lIGF0IGRlc3Ry dWN0aW9uLiBBdCBjcmVhdGlvbgorICAgICAgICB0aW1lIHdlIHdlcmUgbm90IGNhbGxpbmcgY29u c3RydWN0KCkgZm9yIHRoZSBMYXp5TmV2ZXJEZXN0cm95ZWQgb2JqZWN0LiBUaGF0IHdhcyBtYWtp bmcgdGhlIFdlYlByb2Nlc3MKKyAgICAgICAgY3Jhc2ggaW4gRGVidWcgYnVpbGRzLiBBdCBkZXN0 cnVjdGlvbiB0aW1lIHdlIHdlcmUgY2FsbGluZyB4ckRlc3Ryb3lJbnN0YW5jZSgpIHdpdGhvdXQg Y2hlY2tpbmcgdGhhdCB0aGUKKyAgICAgICAgcGFzc2VkIGluc3RhbmNlIHdhcyBhIHZhbGlkIG9u ZSwgYWx0aG91Z2ggT3BlblhSIGltcGxlbWVudGF0aW9ucyBkZWFsIHdpdGggaXQgdGhlIHNwZWMg aXMgcHJldHR5IGNsZWFyLgorCisgICAgICAgICogcGxhdGZvcm0veHIvUGxhdGZvcm1YUi5oOiBN YXJrIExhenlOZXZlckRlc3Ryb3llZCBhcyBmcmllbmQgYW5kIGRlZmF1bHQgY29uc3RydWN0b3Im ZGVzdHJ1Y3Rvci4KKyAgICAgICAgKiBwbGF0Zm9ybS94ci9vcGVueHIvUGxhdGZvcm1YUk9wZW5Y Ui5jcHA6CisgICAgICAgIChQbGF0Zm9ybVhSOjpJbnN0YW5jZTo6SW1wbDo6fkltcGwpOiBDaGVj ayB0aGF0IGluc3RhbmNlIGlzIG5vdCBYUl9OVUxMX0hBTkRMRSBiZWZvcmUgZGVzdHJveWluZy4K KyAgICAgICAgKFBsYXRmb3JtWFI6Okluc3RhbmNlOjpzaW5nbGV0b24pOiBDYWxsIGNvbnN0cnVj dCgpIG9uIHRoZSBMYXp5IGluc3RhbmNlLgorCiAyMDIwLTA2LTE4ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNjIxMjQp OiBUd2l0dGVyIHZpZGVvcyBnbyBibGFuayBhZnRlciBleGl0aW5nIGZ1bGxzY3JlZW4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3hyL1BsYXRmb3JtWFIuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3hyL1BsYXRmb3JtWFIuaAppbmRleCBkNWI1N2RlNTA3OGMzMTVhM2Jk MGM0ZDM1ZmZmYzFiMmE1YmRkMTQ5Li5iNzQ0NDZhODUyNWFjODMxNjJhNjZjY2ZjZGJlNGMxZGZm NmQ1NjAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS94ci9QbGF0Zm9ybVhS LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0veHIvUGxhdGZvcm1YUi5oCkBAIC02OSw4 ICs2OSw5IEBAIHB1YmxpYzoKICAgICB2b2lkIGVudW1lcmF0ZUltbWVyc2l2ZVhSRGV2aWNlcygp OwogICAgIGNvbnN0IFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdHI8RGV2aWNlPj4mIGltbWVyc2l2ZVhS RGV2aWNlcygpIGNvbnN0IHsgcmV0dXJuIG1faW1tZXJzaXZlWFJEZXZpY2VzOyB9CiBwcml2YXRl OgotICAgIEluc3RhbmNlKCk7Ci0gICAgfkluc3RhbmNlKCk7CisgICAgZnJpZW5kIExhenlOZXZl ckRlc3Ryb3llZDxJbnN0YW5jZT47CisgICAgSW5zdGFuY2UoKSA9IGRlZmF1bHQ7CisgICAgfklu c3RhbmNlKCkgPSBkZWZhdWx0OwogCiAgICAgc3RydWN0IEltcGw7CiAgICAgc3RkOjp1bmlxdWVf cHRyPEltcGw+IG1faW1wbDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3hy L29wZW54ci9QbGF0Zm9ybVhST3BlblhSLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3hy L29wZW54ci9QbGF0Zm9ybVhST3BlblhSLmNwcAppbmRleCBkMDNlYWFmYjMwNmI0ZGM2OTgwMDRh Njk5MjU2NzYwMDE0MDYxZDRiLi5lM2Q1MmZjZmZlZWRjNWUwZDI1MDRiNzhmNDFhOTU2NTQyZTc2 MjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS94ci9vcGVueHIvUGxhdGZv cm1YUk9wZW5YUi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0veHIvb3BlbnhyL1Bs YXRmb3JtWFJPcGVuWFIuY3BwCkBAIC0xNjIsNyArMTYyLDggQEAgSW5zdGFuY2U6OkltcGw6Oklt cGwoKQogCiBJbnN0YW5jZTo6SW1wbDo6fkltcGwoKQogewotICAgIHhyRGVzdHJveUluc3RhbmNl KG1faW5zdGFuY2UpOworICAgIGlmIChtX2luc3RhbmNlICE9IFhSX05VTExfSEFORExFKQorICAg ICAgICB4ckRlc3Ryb3lJbnN0YW5jZShtX2luc3RhbmNlKTsKIH0KIAogI2lmIFVTRV9PUEVOWFIK QEAgLTIxMywxNCArMjE0LDEyIEBAIEluc3RhbmNlJiBJbnN0YW5jZTo6c2luZ2xldG9uKCkKICAg ICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgc19vbmNlRmxhZzsKICAgICBzdGQ6OmNhbGxfb25jZShz X29uY2VGbGFnLAogICAgICAgICBbJl0geworICAgICAgICAgICAgc19pbnN0YW5jZS5jb25zdHJ1 Y3QoKTsKICAgICAgICAgICAgIHNfaW5zdGFuY2UtPm1faW1wbCA9IG1ha2VVbmlxdWU8SW1wbD4o KTsKICAgICAgICAgfSk7CiAgICAgcmV0dXJuIHNfaW5zdGFuY2UuZ2V0KCk7CiB9CiAKLUluc3Rh bmNlOjpJbnN0YW5jZSgpID0gZGVmYXVsdDsKLUluc3RhbmNlOjp+SW5zdGFuY2UoKSA9IGRlZmF1 bHQ7Ci0KIHZvaWQgSW5zdGFuY2U6OmVudW1lcmF0ZUltbWVyc2l2ZVhSRGV2aWNlcygpCiB7CiAj aWYgVVNFX09QRU5YUgo=