213360 2020-06-18 15:43:40 -0700 Remove setVelocity() from PannerNode 2020-06-19 17:54:34 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212611 1 clark_wang clark_wang cdumez darin eric.carlson esprehn+autocc ews-watchlist glenn jer.noble kondapallykalyan philipj sergio webkit-bug-importer oldest_to_newest 1664031 0 clark_wang 2020-06-18 15:43:40 -0700 Removed velocity from PannerNode 1664053 1 402253 clark_wang 2020-06-18 17:11:16 -0700 Created attachment 402253 Patch 1664054 2 402253 cdumez 2020-06-18 17:15:22 -0700 Comment on attachment 402253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402253&action=review > Source/WebCore/ChangeLog:8 > + Re-baselined previous test that now passes with velocity removed. Changelog is missing an explanation of the change and a link to the relevant spec section. 1664057 3 402253 darin 2020-06-18 17:24:47 -0700 Comment on attachment 402253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402253&action=review > Source/WebCore/Modules/webaudio/PannerNode.cpp:307 > + const FloatPoint3D& sourceVelocity = FloatPoint3D(0, 0, 0); This seems a peculiar way to write this. Not even sure it has defined behavior. I think the FloatPoint3D object may be destroyed and the end of the full expression? Maybe this should just be: const FloatPoint32 listenerVelocity; But of course, this is also a constant that’s always zero and so we could simplify the code below. 1664382 4 402289 clark_wang 2020-06-19 09:11:51 -0700 Created attachment 402289 Patch 1664661 5 ews-feeder 2020-06-19 17:53:46 -0700 Committed r263304: <https://trac.webkit.org/changeset/263304> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402289. 1664662 6 webkit-bug-importer 2020-06-19 17:54:34 -0700 <rdar://problem/64551041> 402253 2020-06-18 17:11:16 -0700 2020-06-19 09:11:49 -0700 Patch bug-213360-20200618201115.patch text/plain 5623 clark_wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODVmYTU5ZDc3OTRmMDEw MDg1MzNiYzNiNzgzZWU3Y2EzOWM1NzIwMi4uZThkOTEzOWIyOGRkN2EwM2U5YmZmMDAyNzY3NDZm Zjc1ZjM1N2E3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA2LTE4ICBDbGFy ayBXYW5nICA8Y2xhcmtfd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNldFZlbG9j aXR5KCkgZnJvbSBQYW5uZXJOb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTMzNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZS1iYXNlbGluZWQgcHJldmlvdXMgdGVzdCB0aGF0IG5vdyBwYXNzZXMg d2l0aCB2ZWxvY2l0eSByZW1vdmVkLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9QYW5u ZXJOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhbm5lck5vZGU6OlBhbm5lck5vZGUpOgor ICAgICAgICAoV2ViQ29yZTo6UGFubmVyTm9kZTo6ZG9wcGxlclJhdGUpOgorICAgICAgICAqIE1v ZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5oOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8v UGFubmVyTm9kZS5pZGw6CisKIDIwMjAtMDYtMTggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBbTEZDXVtCRkNdIEF2YWlsYWJsZSBzcGFjZSBjb21wdXRhdGlvbiBm b3IgdGhlIGZsb2F0IGF2b2lkZXIgbmVlZHMgY29vcmRpbmF0ZSBtYXBwaW5nCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuY3BwIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmNwcAppbmRleCBmNzk2NWEwOGE4 ODg4MjljOTA2OGE4MGZmOTgwZjYxY2E3MjMzZDI1Li4wN2VhZTMxYTEwNmJkOTI2NWZiYjg0MjM5 OGViZmZhNDhkYjliOTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1 ZGlvL1Bhbm5lck5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8v UGFubmVyTm9kZS5jcHAKQEAgLTgxLDkgKzgxLDYgQEAgUGFubmVyTm9kZTo6UGFubmVyTm9kZShB dWRpb0NvbnRleHQmIGNvbnRleHQsIGZsb2F0IHNhbXBsZVJhdGUpCiAgICAgbV9kaXN0YW5jZUdh aW4gPSBBdWRpb1BhcmFtOjpjcmVhdGUoY29udGV4dCwgImRpc3RhbmNlR2FpbiIsIDEuMCwgMC4w LCAxLjApOwogICAgIG1fY29uZUdhaW4gPSBBdWRpb1BhcmFtOjpjcmVhdGUoY29udGV4dCwgImNv bmVHYWluIiwgMS4wLCAwLjAsIDEuMCk7CiAKLSAgICAvLyBGSVhNRTogUmVtb3ZlIHZlbG9jaXR5 IGZyb20gUGFubmVyTm9kZQotICAgIG1fdmVsb2NpdHkgPSBGbG9hdFBvaW50M0QoMCwgMCwgMCk7 Ci0KICAgICBpbml0aWFsaXplKCk7CiB9CiAKQEAgLTMwNyw4ICszMDQsOCBAQCBmbG9hdCBQYW5u ZXJOb2RlOjpkb3BwbGVyUmF0ZSgpCiAgICAgaWYgKGRvcHBsZXJGYWN0b3IgPiAwLjApIHsKICAg ICAgICAgZG91YmxlIHNwZWVkT2ZTb3VuZCA9IGxpc3RlbmVyKCktPnNwZWVkT2ZTb3VuZCgpOwog Ci0gICAgICAgIGNvbnN0IEZsb2F0UG9pbnQzRCAmc291cmNlVmVsb2NpdHkgPSBtX3ZlbG9jaXR5 OwotICAgICAgICBjb25zdCBGbG9hdFBvaW50M0QgJmxpc3RlbmVyVmVsb2NpdHkgPSBsaXN0ZW5l cigpLT52ZWxvY2l0eSgpOworICAgICAgICBjb25zdCBGbG9hdFBvaW50M0QmIHNvdXJjZVZlbG9j aXR5ID0gRmxvYXRQb2ludDNEKDAsIDAsIDApOworICAgICAgICBjb25zdCBGbG9hdFBvaW50M0Qm IGxpc3RlbmVyVmVsb2NpdHkgPSBsaXN0ZW5lcigpLT52ZWxvY2l0eSgpOwogCiAgICAgICAgIC8v IERvbid0IGJvdGhlciBpZiBib3RoIHNvdXJjZSBhbmQgbGlzdGVuZXIgaGF2ZSBubyB2ZWxvY2l0 eQogICAgICAgICBib29sIHNvdXJjZUhhc1ZlbG9jaXR5ID0gIXNvdXJjZVZlbG9jaXR5LmlzWmVy bygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJO b2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuaAppbmRl eCAzZmEwMzEyYTFjMmJiNzZlY2QxMmQ5NDA5M2EzN2YzZGFmYzlkYWQxLi5mMmZmMmQyMDk2MjQ0 NDQxNTgxZjE1Yzk5ZGY0ZDU0OWFkZjkzZDEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL1Bhbm5lck5vZGUuaApAQCAtMTAwLDEwICsxMDAsNiBAQCBwdWJsaWM6CiAgICAg QXVkaW9QYXJhbSYgb3JpZW50YXRpb25ZKCkgeyByZXR1cm4gbV9vcmllbnRhdGlvblkuZ2V0KCk7 IH0KICAgICBBdWRpb1BhcmFtJiBvcmllbnRhdGlvblooKSB7IHJldHVybiBtX29yaWVudGF0aW9u Wi5nZXQoKTsgfQogCi0gICAgLy8gRklYTUU6IFJlbW92ZSB2ZWxvY2l0eSBmcm9tIFBhbm5lck5v ZGUKLSAgICBGbG9hdFBvaW50M0QgdmVsb2NpdHkoKSBjb25zdCB7IHJldHVybiBtX3ZlbG9jaXR5 OyB9Ci0gICAgdm9pZCBzZXRWZWxvY2l0eShmbG9hdCB4LCBmbG9hdCB5LCBmbG9hdCB6KSB7IG1f dmVsb2NpdHkgPSBGbG9hdFBvaW50M0QoeCwgeSwgeik7IH0KLQogICAgIC8vIERpc3RhbmNlIHBh cmFtZXRlcnMKICAgICBEaXN0YW5jZU1vZGVsVHlwZSBkaXN0YW5jZU1vZGVsKCkgY29uc3Q7CiAg ICAgdm9pZCBzZXREaXN0YW5jZU1vZGVsKERpc3RhbmNlTW9kZWxUeXBlKTsKQEAgLTE1MCw5ICsx NDYsNiBAQCBwcml2YXRlOgogICAgIHN0ZDo6dW5pcXVlX3B0cjxQYW5uZXI+IG1fcGFubmVyOwog ICAgIFBhbm5pbmdNb2RlbFR5cGUgbV9wYW5uaW5nTW9kZWw7CiAKLSAgICAvLyBGSVhNRTogUmVt b3ZlIHZlbG9jaXR5IGZyb20gUGFubmVyTm9kZQotICAgIEZsb2F0UG9pbnQzRCBtX3ZlbG9jaXR5 OwotCiAgICAgLy8gR2FpbgogICAgIFJlZlB0cjxBdWRpb1BhcmFtPiBtX2Rpc3RhbmNlR2FpbjsK ICAgICBSZWZQdHI8QXVkaW9QYXJhbT4gbV9jb25lR2FpbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuaWRsCmluZGV4IDBhZjU5ZDZiNDI4MTcwYTgyOTk4 NDM5ZDBhMTE2N2M5ZGMxMzdjY2UuLjJjZDFhM2YxZDY2ODQyMWRmZDhkMWU5N2NjM2ZjMWE1MjVl ODVhODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVy Tm9kZS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2Rl LmlkbApAQCAtMzQsOSArMzQsNiBAQAogICAgIHZvaWQgc2V0UG9zaXRpb24odW5yZXN0cmljdGVk IGZsb2F0IHgsIHVucmVzdHJpY3RlZCBmbG9hdCB5LCB1bnJlc3RyaWN0ZWQgZmxvYXQgeik7CiAg ICAgdm9pZCBzZXRPcmllbnRhdGlvbih1bnJlc3RyaWN0ZWQgZmxvYXQgeCwgdW5yZXN0cmljdGVk IGZsb2F0IHksIHVucmVzdHJpY3RlZCBmbG9hdCB6KTsKICAgICAKLSAgICAvLyBGSVhNRTogUmVt b3ZlIHZlbG9jaXR5IGZyb20gUGFubmVyTm9kZQotICAgIHZvaWQgc2V0VmVsb2NpdHkodW5yZXN0 cmljdGVkIGZsb2F0IHgsIHVucmVzdHJpY3RlZCBmbG9hdCB5LCB1bnJlc3RyaWN0ZWQgZmxvYXQg eik7Ci0KICAgICAvLyBEZWZhdWx0IGRpc3RhbmNlIG1vZGVsIGlzIGludmVyc2UKICAgICBhdHRy aWJ1dGUgRGlzdGFuY2VNb2RlbFR5cGUgZGlzdGFuY2VNb2RlbDsKIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9DaGFuZ2VMb2cKaW5kZXggZTA1ZDUxMDYwNjY0ZDc1OWI2NGIyNzdhMjM4N2Q5OGYzMGM0ODc4 YS4uYjA3MjIzMWEwN2IyMzBiMzhlZDE5ODllY2Y0Njc0ZjMzNTRhMDQ5YiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDYtMTggIENsYXJrIFdh bmcgIDxjbGFya193YW5nQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc2V0VmVsb2NpdHko KSBmcm9tIFBhbm5lck5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMzM2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlLWJhc2VsaWVuZCBwcmV2aW91cyB0ZXN0IHRoYXQgbm93IHBhc3NlcyB3aXRo IHZlbG9jaXR5IHJlbW92ZWQuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVk aW8vaGlzdG9yaWNhbC1leHBlY3RlZC50eHQ6CisKIDIwMjAtMDYtMTcgIENsYXJrIFdhbmcgIDxj bGFya193YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGRlZCBtaXNzaW5nIG9yaWVudGF0aW9u IGF0dHJpYnV0ZXMgdG8gUGFubmVyTm9kZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJhdWRpby9oaXN0b3JpY2FsLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8v aGlzdG9yaWNhbC1leHBlY3RlZC50eHQKaW5kZXggZTg2ZWNlNDljMTdiYjc3ZGM1NDE1MzhjNDlk NDQ0NzM1NGJlODA5NC4uNGVjMGZjY2E1ZThkZTdjMWQzY2I1ODc3NWUyYmE4OWM2MTJlMTIxNyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93 ZWJhdWRpby9oaXN0b3JpY2FsLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1ZGlvL2hpc3RvcmljYWwtZXhwZWN0ZWQudHh0 CkBAIC01LDUgKzUsNSBAQCBGQUlMIHdlYmtpdE9mZmxpbmVBdWRpb0NvbnRleHQgaW50ZXJmYWNl IHNob3VsZCBub3QgZXhpc3QgYXNzZXJ0X2ZhbHNlOiBleHBlY3RlZAogRkFJTCBkb3BwbGVyRmFj dG9yIG1lbWJlciBzaG91bGQgbm90IGV4aXN0IG9uIHRoZSBBdWRpb0xpc3RlbmVyLiBhc3NlcnRf ZmFsc2U6IGV4cGVjdGVkIGZhbHNlIGdvdCB0cnVlCiBGQUlMIHNwZWVkT2ZTb3VuZCBtZW1iZXIg c2hvdWxkIG5vdCBleGlzdCBvbiB0aGUgQXVkaW9MaXN0ZW5lci4gYXNzZXJ0X2ZhbHNlOiBleHBl Y3RlZCBmYWxzZSBnb3QgdHJ1ZQogRkFJTCBzZXRWZWxvY2l0eSBtZW1iZXIgc2hvdWxkIG5vdCBl eGlzdCBvbiB0aGUgQXVkaW9MaXN0ZW5lci4gYXNzZXJ0X2ZhbHNlOiBleHBlY3RlZCBmYWxzZSBn b3QgdHJ1ZQotRkFJTCBzZXRWZWxvY2l0eSBzaG91bGQgbm90IGV4aXN0IG9uIFBhbm5lck5vZGVz LiBhc3NlcnRfZmFsc2U6IGV4cGVjdGVkIGZhbHNlIGdvdCB0cnVlCitQQVNTIHNldFZlbG9jaXR5 IHNob3VsZCBub3QgZXhpc3Qgb24gUGFubmVyTm9kZXMuIAogCg== 402289 2020-06-19 09:11:51 -0700 2020-06-19 17:53:46 -0700 Patch bug-213360-20200619121150.patch text/plain 7220 clark_wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODVmYTU5ZDc3OTRmMDEw MDg1MzNiYzNiNzgzZWU3Y2EzOWM1NzIwMi4uMDU3NTg5MjMwODNkYmVmNmM1N2E3MmMzNjhkOWVi NTNhMTFhYzU1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA2LTE5ICBDbGFy ayBXYW5nICA8Y2xhcmtfd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNldFZlbG9j aXR5KCkgZnJvbSBQYW5uZXJOb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTMzNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmVkIHNldFZlbG9jaXR5KCkgYW5kIG90aGVyIHZlbG9jaXR5IGRl cGVuZGVuY2llcywgYXMgcGVyIHNwZWM6IGh0dHBzOi8vd3d3LnczLm9yZy9UUi93ZWJhdWRpby8j cGFubmVybm9kZS4KKyAgICAgICAgU2ltcGxpZmllZCBkb3BwbGVyUmF0ZSwgc2luY2Ugc291cmNl VmVsb2NpdHkgaXMgYWx3YXlzIHplcm8uCisKKyAgICAgICAgUmUtYmFzZWxpbmVkIHByZXZpb3Vz IHRlc3QgdGhhdCBub3cgcGFzc2VzIHdpdGggdmVsb2NpdHkgcmVtb3ZlZC4KKworICAgICAgICAq IE1vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYW5u ZXJOb2RlOjpQYW5uZXJOb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OlBhbm5lck5vZGU6OmRvcHBs ZXJSYXRlKToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuaDoKKyAgICAg ICAgKiBNb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuaWRsOgorCiAyMDIwLTA2LTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bQkZDXSBBdmFpbGFi bGUgc3BhY2UgY29tcHV0YXRpb24gZm9yIHRoZSBmbG9hdCBhdm9pZGVyIG5lZWRzIGNvb3JkaW5h dGUgbWFwcGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9Q YW5uZXJOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9k ZS5jcHAKaW5kZXggZjc5NjVhMDhhODg4ODI5YzkwNjhhODBmZjk4MGY2MWNhNzIzM2QyNS4uZjM4 MDBmMWNlYzRjNzAyY2JiODBiOTRiYjJkYTExODMzZThkN2FjMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuY3BwCkBAIC04MSw5ICs4MSw2IEBAIFBh bm5lck5vZGU6OlBhbm5lck5vZGUoQXVkaW9Db250ZXh0JiBjb250ZXh0LCBmbG9hdCBzYW1wbGVS YXRlKQogICAgIG1fZGlzdGFuY2VHYWluID0gQXVkaW9QYXJhbTo6Y3JlYXRlKGNvbnRleHQsICJk aXN0YW5jZUdhaW4iLCAxLjAsIDAuMCwgMS4wKTsKICAgICBtX2NvbmVHYWluID0gQXVkaW9QYXJh bTo6Y3JlYXRlKGNvbnRleHQsICJjb25lR2FpbiIsIDEuMCwgMC4wLCAxLjApOwogCi0gICAgLy8g RklYTUU6IFJlbW92ZSB2ZWxvY2l0eSBmcm9tIFBhbm5lck5vZGUKLSAgICBtX3ZlbG9jaXR5ID0g RmxvYXRQb2ludDNEKDAsIDAsIDApOwotCiAgICAgaW5pdGlhbGl6ZSgpOwogfQogCkBAIC0zMDcs MTQgKzMwNCwxMiBAQCBmbG9hdCBQYW5uZXJOb2RlOjpkb3BwbGVyUmF0ZSgpCiAgICAgaWYgKGRv cHBsZXJGYWN0b3IgPiAwLjApIHsKICAgICAgICAgZG91YmxlIHNwZWVkT2ZTb3VuZCA9IGxpc3Rl bmVyKCktPnNwZWVkT2ZTb3VuZCgpOwogCi0gICAgICAgIGNvbnN0IEZsb2F0UG9pbnQzRCAmc291 cmNlVmVsb2NpdHkgPSBtX3ZlbG9jaXR5OwotICAgICAgICBjb25zdCBGbG9hdFBvaW50M0QgJmxp c3RlbmVyVmVsb2NpdHkgPSBsaXN0ZW5lcigpLT52ZWxvY2l0eSgpOworICAgICAgICBjb25zdCBG bG9hdFBvaW50M0QmIGxpc3RlbmVyVmVsb2NpdHkgPSBsaXN0ZW5lcigpLT52ZWxvY2l0eSgpOwog Ci0gICAgICAgIC8vIERvbid0IGJvdGhlciBpZiBib3RoIHNvdXJjZSBhbmQgbGlzdGVuZXIgaGF2 ZSBubyB2ZWxvY2l0eQotICAgICAgICBib29sIHNvdXJjZUhhc1ZlbG9jaXR5ID0gIXNvdXJjZVZl bG9jaXR5LmlzWmVybygpOworICAgICAgICAvLyBEb24ndCBib3RoZXIgaWYgbGlzdGVuZXIgaGFz IG5vIHZlbG9jaXR5CiAgICAgICAgIGJvb2wgbGlzdGVuZXJIYXNWZWxvY2l0eSA9ICFsaXN0ZW5l clZlbG9jaXR5LmlzWmVybygpOwogCi0gICAgICAgIGlmIChzb3VyY2VIYXNWZWxvY2l0eSB8fCBs aXN0ZW5lckhhc1ZlbG9jaXR5KSB7CisgICAgICAgIGlmIChsaXN0ZW5lckhhc1ZlbG9jaXR5KSB7 CiAgICAgICAgICAgICAvLyBDYWxjdWxhdGUgdGhlIHNvdXJjZSB0byBsaXN0ZW5lciB2ZWN0b3IK ICAgICAgICAgICAgIEZsb2F0UG9pbnQzRCBsaXN0ZW5lclBvc2l0aW9uID0gbGlzdGVuZXIoKS0+ cG9zaXRpb24oKTsKICAgICAgICAgICAgIEZsb2F0UG9pbnQzRCBzb3VyY2VUb0xpc3RlbmVyID0g cG9zaXRpb24oKSAtIGxpc3RlbmVyUG9zaXRpb247CkBAIC0zMjIsMTYgKzMxNywxMyBAQCBmbG9h dCBQYW5uZXJOb2RlOjpkb3BwbGVyUmF0ZSgpCiAgICAgICAgICAgICBkb3VibGUgc291cmNlTGlz dGVuZXJNYWduaXR1ZGUgPSBzb3VyY2VUb0xpc3RlbmVyLmxlbmd0aCgpOwogCiAgICAgICAgICAg ICBkb3VibGUgbGlzdGVuZXJQcm9qZWN0aW9uID0gc291cmNlVG9MaXN0ZW5lci5kb3QobGlzdGVu ZXJWZWxvY2l0eSkgLyBzb3VyY2VMaXN0ZW5lck1hZ25pdHVkZTsKLSAgICAgICAgICAgIGRvdWJs ZSBzb3VyY2VQcm9qZWN0aW9uID0gc291cmNlVG9MaXN0ZW5lci5kb3Qoc291cmNlVmVsb2NpdHkp IC8gc291cmNlTGlzdGVuZXJNYWduaXR1ZGU7CiAKICAgICAgICAgICAgIGxpc3RlbmVyUHJvamVj dGlvbiA9IC1saXN0ZW5lclByb2plY3Rpb247Ci0gICAgICAgICAgICBzb3VyY2VQcm9qZWN0aW9u ID0gLXNvdXJjZVByb2plY3Rpb247CiAKICAgICAgICAgICAgIGRvdWJsZSBzY2FsZWRTcGVlZE9m U291bmQgPSBzcGVlZE9mU291bmQgLyBkb3BwbGVyRmFjdG9yOwogICAgICAgICAgICAgbGlzdGVu ZXJQcm9qZWN0aW9uID0gc3RkOjptaW4obGlzdGVuZXJQcm9qZWN0aW9uLCBzY2FsZWRTcGVlZE9m U291bmQpOwotICAgICAgICAgICAgc291cmNlUHJvamVjdGlvbiA9IHN0ZDo6bWluKHNvdXJjZVBy b2plY3Rpb24sIHNjYWxlZFNwZWVkT2ZTb3VuZCk7CiAKLSAgICAgICAgICAgIGRvcHBsZXJTaGlm dCA9ICgoc3BlZWRPZlNvdW5kIC0gZG9wcGxlckZhY3RvciAqIGxpc3RlbmVyUHJvamVjdGlvbikg LyAoc3BlZWRPZlNvdW5kIC0gZG9wcGxlckZhY3RvciAqIHNvdXJjZVByb2plY3Rpb24pKTsKKyAg ICAgICAgICAgIGRvcHBsZXJTaGlmdCA9ICgoc3BlZWRPZlNvdW5kIC0gZG9wcGxlckZhY3RvciAq IGxpc3RlbmVyUHJvamVjdGlvbikgLyBzcGVlZE9mU291bmQpOwogICAgICAgICAgICAgZml4TkFO cyhkb3BwbGVyU2hpZnQpOyAvLyBhdm9pZCBpbGxlZ2FsIHZhbHVlcwogCiAgICAgICAgICAgICAv LyBMaW1pdCB0aGUgcGl0Y2ggc2hpZnRpbmcgdG8gNCBvY3RhdmVzIHVwIGFuZCAzIG9jdGF2ZXMg ZG93bi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVy Tm9kZS5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmgKaW5k ZXggM2ZhMDMxMmExYzJiYjc2ZWNkMTJkOTQwOTNhMzdmM2RhZmM5ZGFkMS4uZjJmZjJkMjA5NjI0 NDQ0MTU4MWYxNWM5OWRmNGQ1NDlhZGY5M2QxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJhdWRpby9QYW5uZXJOb2RlLmgKQEAgLTEwMCwxMCArMTAwLDYgQEAgcHVibGljOgogICAg IEF1ZGlvUGFyYW0mIG9yaWVudGF0aW9uWSgpIHsgcmV0dXJuIG1fb3JpZW50YXRpb25ZLmdldCgp OyB9CiAgICAgQXVkaW9QYXJhbSYgb3JpZW50YXRpb25aKCkgeyByZXR1cm4gbV9vcmllbnRhdGlv blouZ2V0KCk7IH0KIAotICAgIC8vIEZJWE1FOiBSZW1vdmUgdmVsb2NpdHkgZnJvbSBQYW5uZXJO b2RlCi0gICAgRmxvYXRQb2ludDNEIHZlbG9jaXR5KCkgY29uc3QgeyByZXR1cm4gbV92ZWxvY2l0 eTsgfQotICAgIHZvaWQgc2V0VmVsb2NpdHkoZmxvYXQgeCwgZmxvYXQgeSwgZmxvYXQgeikgeyBt X3ZlbG9jaXR5ID0gRmxvYXRQb2ludDNEKHgsIHksIHopOyB9Ci0KICAgICAvLyBEaXN0YW5jZSBw YXJhbWV0ZXJzCiAgICAgRGlzdGFuY2VNb2RlbFR5cGUgZGlzdGFuY2VNb2RlbCgpIGNvbnN0Owog ICAgIHZvaWQgc2V0RGlzdGFuY2VNb2RlbChEaXN0YW5jZU1vZGVsVHlwZSk7CkBAIC0xNTAsOSAr MTQ2LDYgQEAgcHJpdmF0ZToKICAgICBzdGQ6OnVuaXF1ZV9wdHI8UGFubmVyPiBtX3Bhbm5lcjsK ICAgICBQYW5uaW5nTW9kZWxUeXBlIG1fcGFubmluZ01vZGVsOwogCi0gICAgLy8gRklYTUU6IFJl bW92ZSB2ZWxvY2l0eSBmcm9tIFBhbm5lck5vZGUKLSAgICBGbG9hdFBvaW50M0QgbV92ZWxvY2l0 eTsKLQogICAgIC8vIEdhaW4KICAgICBSZWZQdHI8QXVkaW9QYXJhbT4gbV9kaXN0YW5jZUdhaW47 CiAgICAgUmVmUHRyPEF1ZGlvUGFyYW0+IG1fY29uZUdhaW47CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuaWRsIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmlkbAppbmRleCAwYWY1OWQ2YjQyODE3MGE4Mjk5 ODQzOWQwYTExNjdjOWRjMTM3Y2NlLi4yY2QxYTNmMWQ2Njg0MjFkZmQ4ZDFlOTdjYzNmYzFhNTI1 ZTg1YTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5l ck5vZGUuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9k ZS5pZGwKQEAgLTM0LDkgKzM0LDYgQEAKICAgICB2b2lkIHNldFBvc2l0aW9uKHVucmVzdHJpY3Rl ZCBmbG9hdCB4LCB1bnJlc3RyaWN0ZWQgZmxvYXQgeSwgdW5yZXN0cmljdGVkIGZsb2F0IHopOwog ICAgIHZvaWQgc2V0T3JpZW50YXRpb24odW5yZXN0cmljdGVkIGZsb2F0IHgsIHVucmVzdHJpY3Rl ZCBmbG9hdCB5LCB1bnJlc3RyaWN0ZWQgZmxvYXQgeik7CiAgICAgCi0gICAgLy8gRklYTUU6IFJl bW92ZSB2ZWxvY2l0eSBmcm9tIFBhbm5lck5vZGUKLSAgICB2b2lkIHNldFZlbG9jaXR5KHVucmVz dHJpY3RlZCBmbG9hdCB4LCB1bnJlc3RyaWN0ZWQgZmxvYXQgeSwgdW5yZXN0cmljdGVkIGZsb2F0 IHopOwotCiAgICAgLy8gRGVmYXVsdCBkaXN0YW5jZSBtb2RlbCBpcyBpbnZlcnNlCiAgICAgYXR0 cmlidXRlIERpc3RhbmNlTW9kZWxUeXBlIGRpc3RhbmNlTW9kZWw7CiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2MvQ2hhbmdlTG9nCmluZGV4IGUwNWQ1MTA2MDY2NGQ3NTliNjRiMjc3YTIzODdkOThmMzBjNDg3 OGEuLmQ5ZTgwOWNiYzkwNWZjODcyNzM2ODljNjJlNGE5YmZjYmVmYTFjMTQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA2LTE5ICBDbGFyayBX YW5nICA8Y2xhcmtfd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHNldFZlbG9jaXR5 KCkgZnJvbSBQYW5uZXJOb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTMzNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZS1iYXNlbGluZWQgcHJldmlvdXMgdGVzdCB0aGF0IG5vdyBwYXNzZXMgd2l0 aCB2ZWxvY2l0eSByZW1vdmVkLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1 ZGlvL2hpc3RvcmljYWwtZXhwZWN0ZWQudHh0OgorCiAyMDIwLTA2LTE3ICBDbGFyayBXYW5nICA8 Y2xhcmtfd2FuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkZWQgbWlzc2luZyBvcmllbnRhdGlv biBhdHRyaWJ1dGVzIHRvIFBhbm5lck5vZGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vaGlzdG9yaWNhbC1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1ZGlv L2hpc3RvcmljYWwtZXhwZWN0ZWQudHh0CmluZGV4IGU4NmVjZTQ5YzE3YmI3N2RjNTQxNTM4YzQ5 ZDQ0NDczNTRiZTgwOTQuLjRlYzBmY2NhNWU4ZGU3YzFkM2NiNTg3NzVlMmJhODljNjEyZTEyMTcg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv d2ViYXVkaW8vaGlzdG9yaWNhbC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJhdWRpby9oaXN0b3JpY2FsLWV4cGVjdGVkLnR4 dApAQCAtNSw1ICs1LDUgQEAgRkFJTCB3ZWJraXRPZmZsaW5lQXVkaW9Db250ZXh0IGludGVyZmFj ZSBzaG91bGQgbm90IGV4aXN0IGFzc2VydF9mYWxzZTogZXhwZWN0ZWQKIEZBSUwgZG9wcGxlckZh Y3RvciBtZW1iZXIgc2hvdWxkIG5vdCBleGlzdCBvbiB0aGUgQXVkaW9MaXN0ZW5lci4gYXNzZXJ0 X2ZhbHNlOiBleHBlY3RlZCBmYWxzZSBnb3QgdHJ1ZQogRkFJTCBzcGVlZE9mU291bmQgbWVtYmVy IHNob3VsZCBub3QgZXhpc3Qgb24gdGhlIEF1ZGlvTGlzdGVuZXIuIGFzc2VydF9mYWxzZTogZXhw ZWN0ZWQgZmFsc2UgZ290IHRydWUKIEZBSUwgc2V0VmVsb2NpdHkgbWVtYmVyIHNob3VsZCBub3Qg ZXhpc3Qgb24gdGhlIEF1ZGlvTGlzdGVuZXIuIGFzc2VydF9mYWxzZTogZXhwZWN0ZWQgZmFsc2Ug Z290IHRydWUKLUZBSUwgc2V0VmVsb2NpdHkgc2hvdWxkIG5vdCBleGlzdCBvbiBQYW5uZXJOb2Rl cy4gYXNzZXJ0X2ZhbHNlOiBleHBlY3RlZCBmYWxzZSBnb3QgdHJ1ZQorUEFTUyBzZXRWZWxvY2l0 eSBzaG91bGQgbm90IGV4aXN0IG9uIFBhbm5lck5vZGVzLiAKIAo=