213086 2020-06-11 11:20:50 -0700 DragState::type should be Optional<DragSourceAction> instead of OptionSet<DragSourceAction> 2024-03-01 17:22:17 -0800 1 1 1 Unclassified WebKit DOM Other Unspecified Unspecified NEW P2 Normal --- 212885 1 ddkilzer webkit-unassigned ahmad.saleem792 darin thorton wenson_hsieh oldest_to_newest 1661659 0 ddkilzer 2020-06-11 11:20:50 -0700 Per Darin's feedback in Bug 212885 Comment #12, DragState::type should be Optional<DragSourceAction> instead of OptionSet<DragSourceAction>. ''' Refactoring this to be explicitly "OptionSet" when before it was not explicit is making the confusion worse, so I think we need to straighten this out first. I guess there is some code can set the type to more than one thing. But this seems disorganized and messy. I think it’s not really a general set. It’s just one type plus possibly "selection". Seems really messy. I suppose you aren’t making it worse, but all this "hasExactlyOneBitSet" stuff is just what happens when we make the data structure too confusing. Clearly the "selection" is an independent flag, and need not be included in an option set. ''' 1661671 1 ddkilzer 2020-06-11 11:37:02 -0700 Note that when DragState::type is changed from OptionSet<> to Optional<>, then WTF::Optional<>::hasExactlyOneBitSet() and WTF::Optional<>::toSingleValue() may also be removed. The need for both of these methods are also indicative of the need to change DragState::type to Optional<>. 2018152 2 ahmad.saleem792 2024-03-01 17:22:17 -0800 Still have this - https://searchfox.org/wubkat/rev/c7ee831c38599255e3ae78a2b28b71968615107f/Source/WebCore/page/DragState.h#38