212529 2020-05-29 09:51:07 -0700 [WebXR] Pass an unsigned long to cancelAnimationCallback() as handle 2020-06-11 01:09:41 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 213047 208988 1 svillar svillar cdumez darin dbates esprehn+autocc ews-watchlist kondapallykalyan ross.kirsling svillar webkit-bug-importer youennf ysuzuki zan oldest_to_newest 1657300 0 svillar 2020-05-29 09:51:07 -0700 [WebXR] Pass an unsigned long to cancelAnimationCallback() as handle 1657302 1 400595 svillar 2020-05-29 09:55:23 -0700 Created attachment 400595 Patch 1659604 2 svillar 2020-06-05 08:51:56 -0700 Gentle ping 1660141 3 400595 youennf 2020-06-08 01:07:28 -0700 Comment on attachment 400595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400595&action=review > Source/WebCore/Modules/webxr/WebXRSession.cpp:212 > +void WebXRSession::cancelAnimationFrame(XRFrameRequestCallback::Id callbackId) I would call it XRFrameRequestCallback::Identifier 1660230 4 svillar 2020-06-08 08:59:44 -0700 Committed r262718: <https://trac.webkit.org/changeset/262718> 1660231 5 webkit-bug-importer 2020-06-08 09:00:22 -0700 <rdar://problem/64120637> 1660282 6 400595 darin 2020-06-08 11:39:09 -0700 Comment on attachment 400595 Patch IDL "unsigned long" is the same as C++ "unsigned" in WebKit, so all the "unsigned long" and "long" should be changed to "unsigned" and "int" in the C headers. 1661134 7 svillar 2020-06-10 04:30:54 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 400595 [details] > Patch > > IDL "unsigned long" is the same as C++ "unsigned" in WebKit, so all the > "unsigned long" and "long" should be changed to "unsigned" and "int" in the > C headers. OK, I've seen unsigned long is some other headers in Modules/ so I was not really sure.(In reply to Darin Adler from comment #6) > Comment on attachment 400595 [details] > Patch > > IDL "unsigned long" is the same as C++ "unsigned" in WebKit, so all the > "unsigned long" and "long" should be changed to "unsigned" and "int" in the > C headers. Thanks for this, I've seen "unsigned long" in some other modules so I thought it was also OK. I've just filled bug 213020 to address WebXR changes. 1661194 8 darin 2020-06-10 09:53:40 -0700 (In reply to Sergio Villar Senin from comment #7) > Thanks for this, I've seen "unsigned long" in some other modules so I > thought it was also OK. I've just filled bug 213020 to address WebXR changes. It’s worthwhile to fix those to consistently not use the "long" C types. Should be fairly simple task. Using "long" for 32-bit integers isn't super-actively harmful but can lead to problems where two types are involved where the types should be the same, even possibly leading to template code bloat or need to have two functions where we'd like to have only one. And it’s basically a difference where there should be no difference. The fact that 32-bit is named "long" in IDL is, in effect, unrelated to the "long" in C. 1661336 9 ysuzuki 2020-06-10 13:43:49 -0700 Re-opened since this is blocked by bug 213047 1661534 10 svillar 2020-06-11 01:09:41 -0700 Committed r262898: <https://trac.webkit.org/changeset/262898> 400595 2020-05-29 09:55:23 -0700 2020-06-08 01:07:28 -0700 Patch bug-212529-20200529185521.patch text/plain 3486 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTcwODU3YzU5NmViOWVi NTg5MTRkNDczMzMzOTA3NjIwZDFhNzllMy4uZmRkNmMwM2FmMTZjMjEyNDIzZWIwNGExNDFhMTlj ZWM4Mjc2Njk3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA1LTI5ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXZWJYUl0g UGFzcyBhbiB1bnNpZ25lZCBsb25nIHRvIGNhbmNlbEFuaW1hdGlvbkNhbGxiYWNrKCkgYXMgaGFu ZGxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI1 MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg dHlwZSBvZiB0aGUgaGFuZGxlIHJldHVybmVkIGJ5IFhSU2Vzc2lvbjo6cmVxdWVzdEFuaW1hdGlv bkZyYW1lKCkgd2FzIHJlY2VudGx5IGNoYW5nZWQKKyAgICAgICAgdG8gdW5zaWduZWQgbG9uZyBm cm9tIGxvbmcgYXMgdGhlcmUgd2FzIG5vIHBvaW50IGluIHVzaW5nIHNpZ25lZCBpbnRlZ2VycyBm b3IgdGhhdC4gSG93ZXZlcgorICAgICAgICB3ZSBmb3Jnb3QgdG8gdXBkYXRlIHRoZSBjYW5jZWxB bmltYXRpb25GcmFtZSgpIGluIHRoZSBzcGVjcyBhcyB3ZWxsIGFzIGl0IHJlY2VpdmVzIHRoZSBo YW5kbGUKKyAgICAgICAgcmV0dXJuZWQgYnkgcmVxdWVzdEFuaW1hdGlvbkZyYW1lKCkuCisKKyAg ICAgICAgV2UgbGFuZGVkIGh0dHBzOi8vZ2l0aHViLmNvbS9pbW1lcnNpdmUtd2ViL3dlYnhyL3B1 bGwvMTA2OSBpbiB0aGUgV2ViWFIgc3BlY3Mgc28gd2UgY2FuIG5vdworICAgICAgICBzYWZlbHkg YWxzbyByZXBsYWNlIHNpZ25lZCBieSB1bnNpZ25lZCBpbnRlZ2VycyBpbiBvdXIgaW1wbGVtZW50 YXRpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoZXJlIGlzIG5vIGNoYW5nZSBpbiBm dW5jdGlvbmFsaXR5LgorCisgICAgICAgICogTW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6V2ViWFJTZXNzaW9uOjpjYW5jZWxBbmltYXRpb25GcmFtZSk6 IFVzZSB1bnNpZ25lZCBpZHMuCisgICAgICAgICogTW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24u aDogRGl0dG8uCisgICAgICAgICogTW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24uaWRsOiBEaXR0 by4KKwogMjAyMC0wNS0yNyAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNv bT4KIAogICAgICAgICBbV2ViWFJdIEltcGxlbWVudCBYUlNlc3Npb246OnJlcXVlc3RSZWZlcmVu Y2VTcGFjZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dlYlhS U2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dlYlhSU2Vzc2lvbi5j cHAKaW5kZXggMDMwZDkzMzM5ODc5Y2U2YzRkNjMwNmExYzQyMGYxNDUxOGYxMjA0MC4uNGY3MjA1 ZjBmNTU2MDNkYWRlZjEyZTc0OWI3YzkxNjc1NjBiNWMyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2VieHIvV2ViWFJTZXNzaW9uLmNwcApAQCAtMjA5LDcgKzIwOSw3IEBAIFhSRnJh bWVSZXF1ZXN0Q2FsbGJhY2s6OklkIFdlYlhSU2Vzc2lvbjo6cmVxdWVzdEFuaW1hdGlvbkZyYW1l KFJlZjxYUkZyYW1lUmVxdWVzCiB9CiAKIC8vIGh0dHBzOi8vaW1tZXJzaXZlLXdlYi5naXRodWIu aW8vd2VieHIvI2RvbS14cnNlc3Npb24tY2FuY2VsYW5pbWF0aW9uZnJhbWUKLXZvaWQgV2ViWFJT ZXNzaW9uOjpjYW5jZWxBbmltYXRpb25GcmFtZShpbnQgY2FsbGJhY2tJZCkKK3ZvaWQgV2ViWFJT ZXNzaW9uOjpjYW5jZWxBbmltYXRpb25GcmFtZShYUkZyYW1lUmVxdWVzdENhbGxiYWNrOjpJZCBj YWxsYmFja0lkKQogewogICAgIC8vIDEuIExldCBzZXNzaW9uIGJlIHRoZSB0YXJnZXQgWFJTZXNz aW9uIG9iamVjdC4KICAgICAvLyAyLiBGaW5kIHRoZSBlbnRyeSBpbiBzZXNzaW9uJ3MgbGlzdCBv ZiBhbmltYXRpb24gZnJhbWUgY2FsbGJhY2tzIG9yIHNlc3Npb24ncyBsaXN0IG9mCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dlYlhSU2Vzc2lvbi5oIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24uaAppbmRleCBjMTI4OGZjYWMwYzA2 MDE2MGZjZGY4OTA3ZTQ0MTEzYTNmMzE5ZjU2Li5iN2U3MGZjOTViZmRjNDExMDliNjY1OWM4NmUy OThkYjhhZjdkYTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dl YlhSU2Vzc2lvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIvV2ViWFJTZXNz aW9uLmgKQEAgLTcyLDcgKzcyLDcgQEAgcHVibGljOgogICAgIHZvaWQgcmVxdWVzdFJlZmVyZW5j ZVNwYWNlKFhSUmVmZXJlbmNlU3BhY2VUeXBlLCBSZXF1ZXN0UmVmZXJlbmNlU3BhY2VQcm9taXNl JiYpOwogCiAgICAgWFJGcmFtZVJlcXVlc3RDYWxsYmFjazo6SWQgcmVxdWVzdEFuaW1hdGlvbkZy YW1lKFJlZjxYUkZyYW1lUmVxdWVzdENhbGxiYWNrPiYmKTsKLSAgICB2b2lkIGNhbmNlbEFuaW1h dGlvbkZyYW1lKGludCBoYW5kbGUpOworICAgIHZvaWQgY2FuY2VsQW5pbWF0aW9uRnJhbWUoWFJG cmFtZVJlcXVlc3RDYWxsYmFjazo6SWQgaGFuZGxlKTsKIAogICAgIHZvaWQgZW5kKEVuZFByb21p c2UmJik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIvV2ViWFJT ZXNzaW9uLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIvV2ViWFJTZXNzaW9uLmlk bAppbmRleCA0MDIzMmM2YmE5OWMxZDY5OTI1ODE0MmY0NzRiZDRhNDRjNDRhYmMzLi40NjFmMTEw NjBkNGNhYzU3ZWJhYTQ2OGY2ZTQ1NzJmYzI1ODQ5ZTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYnhyL1dlYlhSU2Vzc2lvbi5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24uaWRsCkBAIC00Miw3ICs0Miw3IEBACiAgICAgW05l d09iamVjdF0gUHJvbWlzZTxXZWJYUlJlZmVyZW5jZVNwYWNlPiByZXF1ZXN0UmVmZXJlbmNlU3Bh Y2UoWFJSZWZlcmVuY2VTcGFjZVR5cGUgdHlwZSk7CiAKICAgICB1bnNpZ25lZCBsb25nIHJlcXVl c3RBbmltYXRpb25GcmFtZShYUkZyYW1lUmVxdWVzdENhbGxiYWNrIGNhbGxiYWNrKTsKLSAgICB2 b2lkIGNhbmNlbEFuaW1hdGlvbkZyYW1lKGxvbmcgaGFuZGxlKTsKKyAgICB2b2lkIGNhbmNlbEFu aW1hdGlvbkZyYW1lKHVuc2lnbmVkIGxvbmcgaGFuZGxlKTsKIAogICAgIFByb21pc2U8dm9pZD4g ZW5kKCk7CiAK