212469 2020-05-28 08:26:43 -0700 'make debug' fails on the repository root if ccache is installed on mac after r262147 2020-10-14 11:03:41 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209890 1 tetsuharu.ohzeki krollin aestes darin ddkilzer jer.noble krollin tetsuharu.ohzeki webkit-bug-importer oldest_to_newest 1656858 0 tetsuharu.ohzeki 2020-05-28 08:26:43 -0700 * After https://trac.webkit.org/changeset/262182/webkit (bug 209890), `make debug` or `make release` fails on the repository root if ccache is installed on the machine. * If the machine did not install ccache, it works well. * This problem is not reproduce with `Tools/Scripts/build-webkit --debug` ## Environment * macOS 10.15.5 * XCode 11.5 * Build for macOS on macOS 1656862 1 tetsuharu.ohzeki 2020-05-28 08:32:34 -0700 the log with `make debug` ``` ../Tools/Scripts/set-webkit-configuration --debug perl ../Tools/Scripts/copy-webkitlibraries-to-product-directory ../../Tools/Scripts/set-webkit-configuration --debug ( if [[ -t 1 ]]; then COLOR_DIAGNOSTICS_ARG="COLOR_DIAGNOSTICS=YES"; fi; xcodebuild `perl -I../../Tools/Scripts -Mwebkitdirs -e 'print XcodeOptionString()' -- ` ${COLOR_DIAGNOSTICS_ARG} WK_USE_CCACHE=YES -UseNewBuildSystem=YES USE_NEW_BUILD_SYSTEM=YES GCC_PREPROCESSOR_DEFINITIONS=' $(inherited)' | ../../Tools/Scripts/filter-build-webkit && exit ${PIPESTATUS[0]} ) Command line invocation: User defaults from command line: ^Cmake[2]: *** [debug] Interrupt: 2 make[1]: *** [debug] Interrupt: 2 make: *** [debug] Interrupt: 2 tetsuharu@macbookpro-15-2017:/Volumes/Source/webkit % rm -rf WebKitBuild (git:master) tetsuharu@macbookpro-15-2017:/Volumes/Source/webkit % rm -rf WebKitBuild (git:master) tetsuharu@macbookpro-15-2017:/Volumes/Source/webkit % make debug (git:master) ../Tools/Scripts/set-webkit-configuration --debug perl ../Tools/Scripts/copy-webkitlibraries-to-product-directory ../../Tools/Scripts/set-webkit-configuration --debug ( if [[ -t 1 ]]; then COLOR_DIAGNOSTICS_ARG="COLOR_DIAGNOSTICS=YES"; fi; xcodebuild `perl -I../../Tools/Scripts -Mwebkitdirs -e 'print XcodeOptionString()' -- ` ${COLOR_DIAGNOSTICS_ARG} WK_USE_CCACHE=YES -UseNewBuildSystem=YES USE_NEW_BUILD_SYSTEM=YES GCC_PREPROCESSOR_DEFINITIONS=' $(inherited)' | ../../Tools/Scripts/filter-build-webkit && exit ${PIPESTATUS[0]} ) Command line invocation: User defaults from command line: note: Using new build system note: Planning build note: Constructing build description CreateBuildDirectory /Volumes/Source/webkit/WebKitBuild (in target 'bmalloc' from project 'bmalloc') WriteAuxiliaryFile /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/bmalloc.hmap (in target 'bmalloc' from project 'bmalloc') WriteAuxiliaryFile /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/bmalloc-own-target-headers.hmap (in target 'bmalloc' from project 'bmalloc') WriteAuxiliaryFile /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/all-product-headers.yaml (in target 'bmalloc' from project 'bmalloc') WriteAuxiliaryFile /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/bmalloc-generated-files.hmap (in target 'bmalloc' from project 'bmalloc') WriteAuxiliaryFile /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/bmalloc-all-non-framework-target-headers.hmap (in target 'bmalloc' from project 'bmalloc') WriteAuxiliaryFile /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/bmalloc-project-headers.hmap (in target 'bmalloc' from project 'bmalloc') WriteAuxiliaryFile /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/bmalloc-all-target-headers.hmap (in target 'bmalloc' from project 'bmalloc') CompileC Scavenger.o /Volumes/Source/webkit/Source/bmalloc/../../Tools/ccache/ccache-wrapper: line 26: ccache: command not found warning: Could not read serialized diagnostics file: Cannot Load File: Failed to open diagnostics file (in target 'bmalloc' from project 'bmalloc') Command CompileC failed with a nonzero exit code CompileC bmalloc.o warning: Could not read serialized diagnostics file: Cannot Load File: Failed to open diagnostics file (in target 'bmalloc' from project 'bmalloc') WriteAuxiliaryFile /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/Objects-normal/x86_64/bmalloc.LinkFileList (in target 'bmalloc' from project 'bmalloc') CompileC Zone.o /Volumes/Source/webkit/Source/bmalloc/../../Tools/ccache/ccache-wrapper: line 26: ccache: command not found warning: Could not read serialized diagnostics file: Cannot Load File: Failed to open diagnostics file (in target 'bmalloc' from project 'bmalloc') CompileC ProcessCheck.o /Volumes/Source/webkit/Source/bmalloc/../../Tools/ccache/ccache-wrapper: line 26: ccache: command not found warning: Could not read serialized diagnostics file: Cannot Load File: Failed to open diagnostics file (in target 'bmalloc' from project 'bmalloc') CompileC PerProcess.o /Volumes/Source/webkit/Source/bmalloc/../../Tools/ccache/ccache-wrapper: line 26: ccache: command not found warning: Could not read serialized diagnostics file: Cannot Load File: Failed to open diagnostics file (in target 'bmalloc' from project 'bmalloc') Command CompileC failed with a nonzero exit code CompileC ObjectType.o /Volumes/Source/webkit/Source/bmalloc/../../Tools/ccache/ccache-wrapper: line 26: ccache: command not found warning: Could not read serialized diagnostics file: Cannot Load File: Failed to open diagnostics file (in target 'bmalloc' from project 'bmalloc') CompileC ObjectTypeTable.o warning: Could not read serialized diagnostics file: Cannot Load File: Failed to open diagnostics file (in target 'bmalloc' from project 'bmalloc') CompileC Mutex.o warning: Could not read serialized diagnostics file: Cannot Load File: Failed to open diagnostics file (in target 'bmalloc' from project 'bmalloc') ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/Objects-normal/x86_64/Scavenger.o /Volumes/Source/webkit/Source/bmalloc/bmalloc/Scavenger.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler CompileC /Volumes/Source/webkit/WebKitBuild/bmalloc.build/Debug/bmalloc.build/Objects-normal/x86_64/PerProcess.o /Volumes/Source/webkit/Source/bmalloc/bmalloc/PerProcess.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (2 failures) make[2]: *** [debug] Error 65 make[1]: *** [debug] Error 2 make: *** [debug] Error 2 ``` 1656882 2 400470 tetsuharu.ohzeki 2020-05-28 09:10:47 -0700 Created attachment 400470 Patch adhoc patch 1656883 3 tetsuharu.ohzeki 2020-05-28 09:15:37 -0700 Originally, bug 197020 introduced that enabling ccache automatically with Makefile. 1656888 4 tetsuharu.ohzeki 2020-05-28 09:40:42 -0700 I'm not sure about XCBuild's cleverness on incremental build. To be honest, I'm not confident whether enabling ccache with XCBuild is nice or not. Thus my patch is just workaround on the environment installed ccache. 1657342 5 krollin 2020-05-29 10:49:55 -0700 I'm reverting the use of XCBuild for now. I'll keep this issue in mind when we try to re-enable it. In that context, I don't think we need this patch right now. 1657357 6 tetsuharu.ohzeki 2020-05-29 11:17:09 -0700 (In reply to Keith Rollin from comment #5) > I'm reverting the use of XCBuild for now. I'll keep this issue in mind when > we try to re-enable it. In that context, I don't think we need this patch > right now. Ah, I see. Thank you for your review. 1679932 7 krollin 2020-08-12 22:40:36 -0700 The problem here is that XCBuild removes /usr/local/bin from the PATH. I'm checking to see if that's intentional. 1697607 8 krollin 2020-10-13 21:35:09 -0700 Rather than taking the approach of Ohzeki-san's original patch (which disables ccache under XCBuild), I'll try to look for it in a few well-known places when under XCBuild (or any time `which ccache` can't find anything). If not found, we'll fall back to compiling regularly. 1697608 9 webkit-bug-importer 2020-10-13 21:35:39 -0700 <rdar://problem/70278783> 1697610 10 411298 krollin 2020-10-13 21:39:42 -0700 Created attachment 411298 Patch 1697723 11 411298 ddkilzer 2020-10-14 08:37:21 -0700 Comment on attachment 411298 Patch r=me 1697788 12 ews-feeder 2020-10-14 11:03:40 -0700 Committed r268475: <https://trac.webkit.org/changeset/268475> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411298. 400470 2020-05-28 09:10:47 -0700 2020-10-13 21:39:40 -0700 Patch bug-212469-20200529011046.patch text/plain 1567 tetsuharu.ohzeki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMjQwCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggMWYyZWFhYmM2NzE3ZWE1MWMwNjIxMWQ3NGFkZDAwM2UzMzgyZmJhMy4uM2I5 NWJlMzU5OTZkNzJhYzUxMGYzYTE1MmU2MDEyOGJlZTNlZjY1MCAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTI4ICBUZXRzdWhh cnUgT2h6ZWtpICA8dGV0c3VoYXJ1Lm9oemVraUBnbWFpbC5jb20+CisKKyAgICAgICAgRml4IHRv IGZhaWwgJ21ha2UgZGVidWcnIGlmIGNjYWNoZSBpcyBpbnN0YWxsZWQgb24gbWFjIGFmdGVyIHIy NjIxNDcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MjQ2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgaXMganVzdCBhbiBhZGhvYyBwYXRjaC4KKworICAgICAgICAqIE1ha2VmaWxlLnNoYXJlZDoK KwogMjAyMC0wNS0yNyAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBVcGRhdGUgTW9iaWxlTWluaUJyb3dzZXIgcHJvamVjdCBzZXR0aW5ncyB0byBjdXJyZW50 IFhjb2RlCmRpZmYgLS1naXQgYS9NYWtlZmlsZS5zaGFyZWQgYi9NYWtlZmlsZS5zaGFyZWQKaW5k ZXggNTNlMWE2NWFiNWVlNDAxNGQwMDI0ZWI4Nzc0NzUwOWQyOGVhNmIzOS4uYmZhNGU2YTcxNTg4 OGZkMzg5MGU5YTRlYjMxY2RjNjBmOWZjNTYyYiAxMDA2NDQKLS0tIGEvTWFrZWZpbGUuc2hhcmVk CisrKyBiL01ha2VmaWxlLnNoYXJlZApAQCAtMzgsMTQgKzM4LDE5IEBAIGlmbmVxICgsJChTREtf VkFSSUFOVCkpCiAJWENPREVfT1BUSU9OUyArPSBTREtfVkFSSUFOVD0iJChTREtfVkFSSUFOVCki CiBlbmRpZgogCitDQU5fVVNFX1hDQlVJTEQgPSAkKHNoZWxsIHBlcmwgLUkkKFNDUklQVFNfUEFU SCkgLU13ZWJraXRkaXJzIC1lICdwcmludCBjYW5Vc2VYQ0J1aWxkKCknKQorCiBpZmVxICgsICQo ZmluZHN0cmluZyBXS19VU0VfQ0NBQ0hFLCAkKEFSR1MpKSkKLQlpZm5lcSAoLCAkKHNoZWxsIHdo aWNoIGNjYWNoZSkpCi0JCVhDT0RFX09QVElPTlMgKz0gV0tfVVNFX0NDQUNIRT1ZRVMKKwlpZmVx ICgkKENBTl9VU0VfWENCVUlMRCksMSkKKwkJWENPREVfT1BUSU9OUyArPSBXS19VU0VfQ0NBQ0hF PU5PCisJZWxzZQorCQlpZm5lcSAoLCAkKHNoZWxsIHdoaWNoIGNjYWNoZSkpCisJCQlYQ09ERV9P UFRJT05TICs9IFdLX1VTRV9DQ0FDSEU9WUVTCisJCWVuZGlmCiAJZW5kaWYKIGVuZGlmCiAKIGlm ZXEgKCQoZmluZHN0cmluZyBVc2VOZXdCdWlsZFN5c3RlbSwkKEFSR1MpKSwpCi0JQ0FOX1VTRV9Y Q0JVSUxEID0gJChzaGVsbCBwZXJsIC1JJChTQ1JJUFRTX1BBVEgpIC1Nd2Via2l0ZGlycyAtZSAn cHJpbnQgY2FuVXNlWENCdWlsZCgpJykKIAlpZmVxICgkKENBTl9VU0VfWENCVUlMRCksMSkKIAkJ WENPREVfT1BUSU9OUyArPSAtVXNlTmV3QnVpbGRTeXN0ZW09WUVTCiAJCVhDT0RFX09QVElPTlMg Kz0gVVNFX05FV19CVUlMRF9TWVNURU09WUVTCg== 411298 2020-10-13 21:39:42 -0700 2020-10-14 11:03:40 -0700 Patch bug-212469-20201013213941.patch text/plain 2093 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MTY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzVjZjI1MmJlN2VjYjE4NDU4NmNlMmUyNjRlYWViMmRi ZmE1ZDFiNS4uMGI0Mjc1ZDcxODA1M2ZmMDUwOWNlNDAwMWY5YTdlMGQ1ODdkNjExZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIwLTEwLTEzICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAg ICAgICAnbWFrZSBkZWJ1ZycgZmFpbHMgb24gdGhlIHJlcG9zaXRvcnkgcm9vdCBpZiBjY2FjaGUg aXMgaW5zdGFsbGVkIG9uIG1hYyBhZnRlciByMjYyMTQ3CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI0NjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzcwMjc4NzgzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGNjYWNoZSBpcyBmcmVxdWVudGx5IGluc3RhbGxlZCBpbiAvdXNyL2xvY2FsL2Jpbi4gSG93 ZXZlciwgd2hlbgorICAgICAgICBydW5uaW5nIHVuZGVyIFhDQnVpbGQsICRQQVRIIGRvZXMgbm90 IGluY2x1ZGUgL3Vzci9sb2NhbC9iaW4uIFRoaXMKKyAgICAgICAgbGVhdmVzIGluIGEgc2l0dWF0 aW9uIHdoZXJlIHRoZSBjaGVjayBmb3IgdGhlIGV4aXN0ZW5jZSBvZiBjY2FjaGUgaW4KKyAgICAg ICAgTWFrZWZpbGUuc2hhcmVkIHN1Y2NlZWRzLCBidXQgdGhlIHVzZSBvZiBjY2FjaGUgaW4gY2Nh Y2hlLXdyYXBwZXIKKyAgICAgICAgZmFpbHMuIFRvIGFkZHJlc3MgdGhpcywgbG9vayBmb3IgY2Nh Y2hlIGluIGEgZmV3IHdlbGwta25vd24gcGxhY2VzCisgICAgICAgIHJhdGhlciB0aGFuIGp1c3Qg cmVseWluZyBvbiAkUEFUSC4gSWYgaXQgc3RpbGwgY2FuJ3QgYmUgZm91bmQsIGZhbGwKKyAgICAg ICAgYmFjayB0byBjb21waWxpbmcgbm9ybWFsbHkgd2l0aG91dCBjY2FjaGUuCisKKyAgICAgICAg KiBjY2FjaGUvY2NhY2hlLXdyYXBwZXI6CisKIDIwMjAtMTAtMDcgIEFha2FzaCBKYWluICA8YWFr YXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtidWlsZC53ZWJraXQub3JnXSBFbnN1cmUg dGhhdCBidWlsZGVyIG5hbWVzIGFyZSB2YWxpZCBCdWlsZGJvdCBpZGVudGlmaWVycwpkaWZmIC0t Z2l0IGEvVG9vbHMvY2NhY2hlL2NjYWNoZS13cmFwcGVyIGIvVG9vbHMvY2NhY2hlL2NjYWNoZS13 cmFwcGVyCmluZGV4IGZmZDJkZTZkM2MzN2UyZmEyMGFlZTRmODczOGM0ZGFmYTczNGRlY2UuLmZk NzllMGY4ZDRlZGYzYWJhOTIyMDJmZjA0NmUyYTY2ZTQ5NjQ2OWUgMTAwNzU1Ci0tLSBhL1Rvb2xz L2NjYWNoZS9jY2FjaGUtd3JhcHBlcgorKysgYi9Ub29scy9jY2FjaGUvY2NhY2hlLXdyYXBwZXIK QEAgLTIzLDQgKzIzLDI4IEBACiAjIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBP RiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YKICMgVEhFIFBPU1NJQklMSVRZIE9G IFNVQ0ggREFNQUdFLgogCi1DQ0FDSEVfU0xPUFBJTkVTUz0icGNoX2RlZmluZXMsdGltZV9tYWNy b3MiIGNjYWNoZSAiJEAiCit0cnlfb25lKCkKK3sKKyAgICBbWyAteCAiJDEiICYmICEgLWQgIiQx IiBdXSAmJiB7IENDQUNIRT0iJDEiOyByZXR1cm4gMDsgfQorICAgIHJldHVybiAxCit9CisKK3Ry eSgpCit7CisgICAgW1sgLW4gIiR7Q0NBQ0hFfSIgXV0gJiYgcmV0dXJuIDAKKyAgICB0cnlfb25l ICIkMSIgfHwgXAorICAgIHRyeV9vbmUgIiQxL2NjYWNoZSIgfHwgXAorICAgIHRyeV9vbmUgIiQx L2Jpbi9jY2FjaGUiCit9CisKK3RyeSAkKHdoaWNoIGNjYWNoZSAmPiAvZGV2L251bGwpCit0cnkg L3Vzci9sb2NhbAordHJ5IC9vcHQvYnJldwordHJ5ICIke0hPTUVCUkVXX1RFTVB9Ly4uL2JyZXci Cit0cnkgIiR7SE9NRUJSRVdfVEVNUH0vLi4vLi4vYnJldyIKKworaWYgW1sgLW4gIiR7Q0NBQ0hF fSIgXV07IHRoZW4KKyAgICBDQ0FDSEVfU0xPUFBJTkVTUz0icGNoX2RlZmluZXMsdGltZV9tYWNy b3MiICIke0NDQUNIRX0iICIkQCIKK2Vsc2UKKyAgICAiJEAiCitmaQo=